From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIFvc-0003v7-L1 for qemu-devel@nongnu.org; Thu, 23 Jul 2015 08:48:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIFvb-0001qE-Oe for qemu-devel@nongnu.org; Thu, 23 Jul 2015 08:48:48 -0400 From: Stefan Hajnoczi Date: Thu, 23 Jul 2015 13:48:35 +0100 Message-Id: <1437655716-11623-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1437655716-11623-1-git-send-email-stefanha@redhat.com> References: <1437655716-11623-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v3 2/3] blockdev: always compile in -drive aio= parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Markus Armbruster , qemu-block@nongnu.org CONFIG_LINUX_AIO is an implementation detail of raw-posix.c. Don't mention CONFIG_LINUX_AIO in blockdev.c. Let block drivers decide what to do with BDRV_O_NATIVE_AIO. They may print an error if it is unsupported. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 62a4586..37b91c8 100644 --- a/blockdev.c +++ b/blockdev.c @@ -405,7 +405,6 @@ static BlockBackend *blockdev_init(const char *file, QDict *bs_opts, bdrv_flags |= BDRV_O_NO_FLUSH; } -#ifdef CONFIG_LINUX_AIO if ((buf = qemu_opt_get(opts, "aio")) != NULL) { if (!strcmp(buf, "native")) { bdrv_flags |= BDRV_O_NATIVE_AIO; @@ -416,7 +415,6 @@ static BlockBackend *blockdev_init(const char *file, QDict *bs_opts, goto early_err; } } -#endif if ((buf = qemu_opt_get(opts, "format")) != NULL) { if (is_help_option(buf)) { -- 2.4.3