From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj6Io-0004up-Q6 for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:46:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tj6In-0003EW-Pj for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:46:06 -0500 Received: from mx3-phx2.redhat.com ([209.132.183.24]:58582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tj6In-0003EO-GT for qemu-devel@nongnu.org; Thu, 13 Dec 2012 05:46:05 -0500 Date: Thu, 13 Dec 2012 05:46:04 -0500 (EST) From: Alon Levy Message-ID: <1437710917.47097439.1355395564564.JavaMail.root@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] virtio-serial: Rework, fix post_load code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu list All looks good. Reviewed-by: Alon Levy ----- Original Message ----- > This series reworks the post_load code recently introduced to > allocate > the structures only when required (i.e. only at load time). This > helps keep the VirtIOSerial struct clean, and use less RAM. > > Also rearrange the code in virtio_serial_load() for easier > readability. > > Patch 4 fixes a race with the timer going off after a device got > hot-unplugged, and patch 1 uses unsigned int (uint32_t) type to count > ports, as in the rest of the code. > > Please review. > > Amit Shah (4): > virtio-serial: use uint32_t to count ports > virtio-serial: move active ports loading to separate function > virtio-serial: allocate post_load only at load-time > virtio-serial: delete timer if active during exit > > hw/virtio-serial-bus.c | 150 > +++++++++++++++++++++++++++++-------------------- > 1 file changed, 89 insertions(+), 61 deletions(-) > > -- > 1.8.0.2 > >