From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 01/13] exec.c: Use atomic_rcu_read() to access dispatch in memory_region_section_get_iotlb()
Date: Fri, 24 Jul 2015 12:16:22 +0200 [thread overview]
Message-ID: <1437732994-20478-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1437732994-20478-1-git-send-email-pbonzini@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
When accessing the dispatch pointer in an AddressSpace within an RCU
critical section we should always use atomic_rcu_read(). Fix an
access within memory_region_section_get_iotlb() which was incorrectly
doing a direct pointer access.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <1437391637-31576-1-git-send-email-peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
exec.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 7d60e15..0a4a0c5 100644
--- a/exec.c
+++ b/exec.c
@@ -954,7 +954,10 @@ hwaddr memory_region_section_get_iotlb(CPUState *cpu,
iotlb |= PHYS_SECTION_ROM;
}
} else {
- iotlb = section - section->address_space->dispatch->map.sections;
+ AddressSpaceDispatch *d;
+
+ d = atomic_rcu_read(§ion->address_space->dispatch);
+ iotlb = section - d->map.sections;
iotlb += xlat;
}
--
2.4.3
next prev parent reply other threads:[~2015-07-24 10:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 10:16 [Qemu-devel] [PULL 00/13] Miscellaneous bugfixes for 2.4.0-rc3 Paolo Bonzini
2015-07-24 10:16 ` Paolo Bonzini [this message]
2015-07-24 10:16 ` [Qemu-devel] [PULL 02/13] qemu-char: handle EINTR for TCP character devices Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 03/13] qemu-char: Fix missed data on unix socket Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 04/13] crypto: extend unit tests to cover decryption too Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 05/13] vnc: fix memory leak Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 06/13] scsi: fix buffer overflow in scsi_req_parse_cdb (CVE-2015-5158) Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 07/13] rcu: actually register threads that have RCU read-side critical sections Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 08/13] scsi: Handle no media case for scsi_get_configuration Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 09/13] vl: Fix compiler warning for builds without VNC Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 10/13] memory: count number of active VGA logging clients Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 11/13] framebuffer: set DIRTY_MEMORY_VGA on RAM that is used for the framebuffer Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 12/13] qemu-doc: fix typos Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 13/13] target-i386/FPU: a misprint in helper_fistll_ST0 Paolo Bonzini
2015-07-24 11:56 ` [Qemu-devel] [PULL 00/13] Miscellaneous bugfixes for 2.4.0-rc3 Peter Maydell
2015-07-24 12:02 ` Paolo Bonzini
2015-07-24 12:07 ` Daniel P. Berrange
2015-07-24 12:24 ` Daniel P. Berrange
2015-07-24 12:30 ` Paolo Bonzini
2015-07-24 12:35 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437732994-20478-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).