From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 02/13] qemu-char: handle EINTR for TCP character devices
Date: Fri, 24 Jul 2015 12:16:23 +0200 [thread overview]
Message-ID: <1437732994-20478-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1437732994-20478-1-git-send-email-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
qemu-char.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 617e034..3200200 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2797,7 +2797,10 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char *buf, size_t len)
#ifdef MSG_CMSG_CLOEXEC
flags |= MSG_CMSG_CLOEXEC;
#endif
- ret = recvmsg(s->fd, &msg, flags);
+ do {
+ ret = recvmsg(s->fd, &msg, flags);
+ } while (ret == -1 && errno == EINTR);
+
if (ret > 0 && s->is_unix) {
unix_process_msgfd(chr, &msg);
}
@@ -2808,7 +2811,13 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char *buf, size_t len)
static ssize_t tcp_chr_recv(CharDriverState *chr, char *buf, size_t len)
{
TCPCharDriver *s = chr->opaque;
- return qemu_recv(s->fd, buf, len, 0);
+ ssize_t ret;
+
+ do {
+ ret = qemu_recv(s->fd, buf, len, 0);
+ } while (ret == -1 && socket_error() == EINTR);
+
+ return ret;
}
#endif
--
2.4.3
next prev parent reply other threads:[~2015-07-24 10:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 10:16 [Qemu-devel] [PULL 00/13] Miscellaneous bugfixes for 2.4.0-rc3 Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 01/13] exec.c: Use atomic_rcu_read() to access dispatch in memory_region_section_get_iotlb() Paolo Bonzini
2015-07-24 10:16 ` Paolo Bonzini [this message]
2015-07-24 10:16 ` [Qemu-devel] [PULL 03/13] qemu-char: Fix missed data on unix socket Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 04/13] crypto: extend unit tests to cover decryption too Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 05/13] vnc: fix memory leak Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 06/13] scsi: fix buffer overflow in scsi_req_parse_cdb (CVE-2015-5158) Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 07/13] rcu: actually register threads that have RCU read-side critical sections Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 08/13] scsi: Handle no media case for scsi_get_configuration Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 09/13] vl: Fix compiler warning for builds without VNC Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 10/13] memory: count number of active VGA logging clients Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 11/13] framebuffer: set DIRTY_MEMORY_VGA on RAM that is used for the framebuffer Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 12/13] qemu-doc: fix typos Paolo Bonzini
2015-07-24 10:16 ` [Qemu-devel] [PULL 13/13] target-i386/FPU: a misprint in helper_fistll_ST0 Paolo Bonzini
2015-07-24 11:56 ` [Qemu-devel] [PULL 00/13] Miscellaneous bugfixes for 2.4.0-rc3 Peter Maydell
2015-07-24 12:02 ` Paolo Bonzini
2015-07-24 12:07 ` Daniel P. Berrange
2015-07-24 12:24 ` Daniel P. Berrange
2015-07-24 12:30 ` Paolo Bonzini
2015-07-24 12:35 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437732994-20478-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).