From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIhzb-000708-JY for qemu-devel@nongnu.org; Fri, 24 Jul 2015 14:46:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIhzW-000860-N9 for qemu-devel@nongnu.org; Fri, 24 Jul 2015 14:46:47 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:14766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIhzW-00085X-GV for qemu-devel@nongnu.org; Fri, 24 Jul 2015 14:46:42 -0400 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Fri, 24 Jul 2015 20:42:21 +0200 Message-Id: <1437763343-7980-2-git-send-email-hpoussin@reactos.org> In-Reply-To: <1437763343-7980-1-git-send-email-hpoussin@reactos.org> References: <1437763343-7980-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for 2.4 1/3] net/dp8393x: disable user creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Leon Alrae , Aurelien Jarno Netcard needs an address space to write data to, which can't be specified= on command line. This fixes a crash when user starts QEMU with "-device dp8393x" Signed-off-by: Herv=C3=A9 Poussineau --- hw/net/dp8393x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index cd889bc..8fafdb0 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -881,6 +881,8 @@ static void dp8393x_class_init(ObjectClass *klass, vo= id *data) dc->reset =3D dp8393x_reset; dc->vmsd =3D &vmstate_dp8393x; dc->props =3D dp8393x_properties; + /* Reason: dma_mr property can't be set */ + dc->cannot_instantiate_with_device_add_yet =3D true; } =20 static const TypeInfo dp8393x_info =3D { --=20 2.1.4