From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJe8a-0007vc-9v for qemu-devel@nongnu.org; Mon, 27 Jul 2015 04:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJe8V-00061c-Ae for qemu-devel@nongnu.org; Mon, 27 Jul 2015 04:51:56 -0400 From: =?UTF-8?q?Salva=20Peir=C3=B3?= Date: Mon, 27 Jul 2015 10:51:52 +0200 Message-Id: <1437987112-24744-1-git-send-email-speirofr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH] megasas: Add write function to handle write access to PCI BAR 3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Hannes Reinecke , qemu-block@nongnu.org, =?UTF-8?q?Salva=20Peir=C3=B3?= This patch fixes a QEMU SEGFAULT when a write operation is performed on the memory region of the PCI BAR 3 (base address space). When a writeb(0xe0000000) is performed the .write function is invoked to handle the write access, however, since the .write is not initialised, the call to 0, causes QEMU to SEGFAULT. Signed-off-by: Salva Peiró --- hw/scsi/megasas.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 51ba9e0..a04369c 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -2202,8 +2202,15 @@ static uint64_t megasas_queue_read(void *opaque, hwaddr addr, return 0; } +static void megasas_queue_write(void *opaque, hwaddr addr, + uint64_t val, unsigned size) +{ + return; +} + static const MemoryRegionOps megasas_queue_ops = { .read = megasas_queue_read, + .write = megasas_queue_write, .endianness = DEVICE_LITTLE_ENDIAN, .impl = { .min_access_size = 8, -- 2.1.4