From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJf2K-00007M-Oo for qemu-devel@nongnu.org; Mon, 27 Jul 2015 05:49:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJf2H-0004n1-Hp for qemu-devel@nongnu.org; Mon, 27 Jul 2015 05:49:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJf2H-0004mx-Bh for qemu-devel@nongnu.org; Mon, 27 Jul 2015 05:49:29 -0400 From: Jason Wang Date: Mon, 27 Jul 2015 17:49:18 +0800 Message-Id: <1437990561-22134-1-git-send-email-jasowang@redhat.com> Subject: [Qemu-devel] [PATCH V4 0/3] Set correct blk feature for virtio 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, pbonzini@redhat.com, Jason Wang , mst@redhat.com Hi all: This series tries to set feature correctly for virtio-blk when virtio 1.0 is supported. Two isssues were addressed according to the spec: - scsi passthrough was not support in 1.0. This is done through: 1) let get_features() can fail 2) fail the get_features() when both scsi and virtio 1.0 is enabled. - any layout must be set for transitional device. This is done by set any layout when 1.0 is supported. Changes from V3: - rebase on top of Michael's any_layout fixes Changes from V2: - Keep scsi=on by default since virtio 1.0 is disabled by default - Advertise VIRTIO_BLK_F_SCSI unconditionally if virtio 1.0 is disabled Changes from V1: - Split virtio-net changes out of the series - Enable VIRTIO_BLK_F_SCSI only when scsi is set - Disable scsi by default and compat it for legacy machine types - Let get_features() can fail and fail the initialization of virito-blk when both 1.0 and scsi were supported. Jason Wang (3): virtio: get_features() can fail virtio-blk: fail get_features when both scsi and 1.0 were set virtio-blk: only clear VIRTIO_F_ANY_LAYOUT for legacy device hw/9pfs/virtio-9p-device.c | 3 ++- hw/block/virtio-blk.c | 15 ++++++++++++--- hw/char/virtio-serial-bus.c | 3 ++- hw/display/virtio-gpu.c | 3 ++- hw/input/virtio-input.c | 3 ++- hw/net/virtio-net.c | 3 ++- hw/scsi/vhost-scsi.c | 3 ++- hw/scsi/virtio-scsi.c | 3 ++- hw/virtio/virtio-balloon.c | 3 ++- hw/virtio/virtio-bus.c | 3 ++- hw/virtio/virtio-rng.c | 2 +- include/hw/virtio/virtio.h | 4 +++- 12 files changed, 34 insertions(+), 14 deletions(-) -- 2.1.4