From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
peter.maydell@linaro.org, jsnow@redhat.com,
qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 2/3] ide/atapi: Fix START STOP UNIT command completion
Date: Mon, 27 Jul 2015 08:01:42 -0400 [thread overview]
Message-ID: <1437998503-1865-3-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1437998503-1865-1-git-send-email-jsnow@redhat.com>
From: Kevin Wolf <kwolf@redhat.com>
The command must be completed on all code paths. START STOP UNIT with
pwrcnd set should succeed without doing anything.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
hw/ide/atapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 950e311..79dd167 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -983,6 +983,7 @@ static void cmd_start_stop_unit(IDEState *s, uint8_t* buf)
if (pwrcnd) {
/* eject/load only happens for power condition == 0 */
+ ide_atapi_cmd_ok(s);
return;
}
--
2.1.0
next prev parent reply other threads:[~2015-07-27 12:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 12:01 [Qemu-devel] [PULL 0/3] Cve 2015 5154 patches John Snow
2015-07-27 12:01 ` [Qemu-devel] [PULL 1/3] ide: Check array bounds before writing to io_buffer (CVE-2015-5154) John Snow
2015-07-27 12:01 ` John Snow [this message]
2015-07-27 12:01 ` [Qemu-devel] [PULL 3/3] ide: Clear DRQ after handling all expected accesses John Snow
2015-07-27 12:10 ` [Qemu-devel] [Qemu-stable] [PULL 0/3] Cve 2015 5154 patches Stefan Priebe - Profihost AG
2015-07-27 12:28 ` John Snow
2015-07-27 13:25 ` Stefan Priebe - Profihost AG
2015-07-27 13:38 ` Kevin Wolf
2015-07-27 13:46 ` Peter Lieven
2015-07-27 13:54 ` Kevin Wolf
2015-07-27 14:05 ` Peter Lieven
2015-07-27 12:34 ` John Snow
2015-07-27 13:44 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437998503-1865-3-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).