From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJh6L-0002Fj-PA for qemu-devel@nongnu.org; Mon, 27 Jul 2015 08:01:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJh6J-00054C-Iv for qemu-devel@nongnu.org; Mon, 27 Jul 2015 08:01:49 -0400 From: John Snow Date: Mon, 27 Jul 2015 08:01:42 -0400 Message-Id: <1437998503-1865-3-git-send-email-jsnow@redhat.com> In-Reply-To: <1437998503-1865-1-git-send-email-jsnow@redhat.com> References: <1437998503-1865-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PULL 2/3] ide/atapi: Fix START STOP UNIT command completion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , peter.maydell@linaro.org, jsnow@redhat.com, qemu-stable@nongnu.org From: Kevin Wolf The command must be completed on all code paths. START STOP UNIT with pwrcnd set should succeed without doing anything. Signed-off-by: Kevin Wolf Reviewed-by: John Snow --- hw/ide/atapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 950e311..79dd167 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -983,6 +983,7 @@ static void cmd_start_stop_unit(IDEState *s, uint8_t* buf) if (pwrcnd) { /* eject/load only happens for power condition == 0 */ + ide_atapi_cmd_ok(s); return; } -- 2.1.0