qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v5 13/17] qcow2/overlaps: Add "memory limit reached" event
Date: Mon, 27 Jul 2015 21:02:22 +0200	[thread overview]
Message-ID: <1438023746-10132-14-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1438023746-10132-1-git-send-email-mreitz@redhat.com>

Later, a mechanism to set a limit on how much memory may be used for the
overlap prevention structures will be introduced. If that limit is about
to be exceeded, a QMP event should be emitted. This very event is
specified by this patch.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 docs/qmp/qmp-events.txt | 27 +++++++++++++++++++++++++++
 qapi/event.json         | 27 +++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)

diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
index d92cc48..00c70d1 100644
--- a/docs/qmp/qmp-events.txt
+++ b/docs/qmp/qmp-events.txt
@@ -279,6 +279,33 @@ Example:
 { "event": "POWERDOWN",
     "timestamp": { "seconds": 1267040730, "microseconds": 682951 } }
 
+QCOW2_OVERLAP_CHECK_MEMORY_LIMIT_REACHED
+----------------------------------------
+
+Emitted by the qcow2 block driver if the preset size limit for the in-memory
+structures for metadata overlap prevention has been reached and an allocation
+of further resources has been denied. This means that it cannot be guaranteed
+that overlap checks will be performed for the specified range; if no range is
+given, no checks can be expected to be performed whatsoever.
+
+Note that this event does not guarantee that no check will be performed in the
+given range (or on the whole image, if no range is given), but only signals the
+possibility that this might be the case. The ability to check the full range or
+a part of it may be restored at any point in time.
+
+Data:
+- "reference": Device name if set; node name otherwise. (json-string)
+- "start":     Offset of the range of clusters (possibly) no longer being
+               checked for writes overlapping with existing metadata.
+               (json-int, optional)
+- "length":    Length of that range in bytes. (json-int, optional)
+
+Example:
+
+{ "event": "QCOW2_OVERLAP_CHECK_MEMORY_LIMIT_REACHED",
+    "data": { "reference": "virtio0", "start": 805306368, "length": 268435456 },
+    "timestamp": { "seconds": 1429331400, "microseconds": 519454 } }
+
 QUORUM_FAILURE
 --------------
 
diff --git a/qapi/event.json b/qapi/event.json
index f0cef01..996cd3d 100644
--- a/qapi/event.json
+++ b/qapi/event.json
@@ -356,3 +356,30 @@
 ##
 { 'event': 'MEM_UNPLUG_ERROR',
   'data': { 'device': 'str', 'msg': 'str' } }
+
+##
+# @QCOW2_OVERLAP_CHECK_MEMORY_LIMIT_REACHED
+#
+# Emitted by the qcow2 block driver if the preset size limit for the in-memory
+# structures for metadata overlap prevention has been reached and an allocation
+# of further resources has been denied. This means that no overlap checks will
+# be performed for the specified range.
+#
+# Note that this event does not guarantee that no check will be performed in the
+# given range (or on the whole image, if no range is given), but only signals
+# the possibility that this might be the case. The ability to check the full
+# range or a part of it may be restored at any point in time.
+#
+# @reference: device name if set; node name otherwise
+#
+# @start:     #optional offset of the range of clusters (possibly) no longer
+#             being checked for writes overlapping with existing metadata
+#
+# @length:    #optional length of that range in bytes
+#
+# Since: 2.5
+##
+{ 'event': 'QCOW2_OVERLAP_CHECK_MEMORY_LIMIT_REACHED',
+  'data': { 'reference': 'str',
+            '*start':    'int',
+            '*length':   'int' } }
-- 
2.4.6

  parent reply	other threads:[~2015-07-27 19:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 19:02 [Qemu-devel] [PATCH v5 00/17] qcow2: Add new overlap check functions Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 01/17] " Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 02/17] qcow2: Pull up overlap check option evaluation Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 03/17] qcow2: Create metadata list Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 04/17] qcow2/overlaps: Protect image header Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 05/17] qcow2/overlaps: Protect refcount table Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 06/17] qcow2/overlaps: Protect refcount blocks Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 07/17] qcow2/overlaps: Protect active L1 table Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 08/17] qcow2/overlaps: Protect active L2 tables Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 09/17] qcow2/overlaps: Protect snapshot table Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 10/17] qcow2/overlaps: Protect inactive L1 tables Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 11/17] qcow2/overlaps: Protect inactive L2 tables Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 12/17] qcow2: Use new metadata overlap check function Max Reitz
2015-07-27 19:02 ` Max Reitz [this message]
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 14/17] qcow2/overlaps: Add memory usage limit Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 15/17] qcow2: Add overlap structure memory size options Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 16/17] qapi: Expose new qcow2 overlap check options Max Reitz
2015-07-27 19:02 ` [Qemu-devel] [PATCH v5 17/17] iotests: Test qcow2's overlap check memory limit Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438023746-10132-14-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).