From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJnfx-0002Fw-Ex for qemu-devel@nongnu.org; Mon, 27 Jul 2015 15:03:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJnft-00028e-Mg for qemu-devel@nongnu.org; Mon, 27 Jul 2015 15:03:01 -0400 From: Max Reitz Date: Mon, 27 Jul 2015 21:02:16 +0200 Message-Id: <1438023746-10132-8-git-send-email-mreitz@redhat.com> In-Reply-To: <1438023746-10132-1-git-send-email-mreitz@redhat.com> References: <1438023746-10132-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v5 07/17] qcow2/overlaps: Protect active L1 table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Keep track of the active L1 table in the metadata list to protect it against accidental modifications. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-cluster.c | 11 +++++++++++ block/qcow2-snapshot.c | 10 ++++++++++ block/qcow2.c | 4 ++++ 3 files changed, 25 insertions(+) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index b43f186..b95f6fe 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -125,6 +125,17 @@ int qcow2_grow_l1_table(BlockDriverState *bs, uint64_t min_size, s->l1_table = new_l1_table; old_l1_size = s->l1_size; s->l1_size = new_l1_size; + + qcow2_metadata_list_remove(bs, old_l1_table_offset, + size_to_clusters(s, old_l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); + + qcow2_metadata_list_enter(bs, s->l1_table_offset, + size_to_clusters(s, s->l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); + qcow2_free_clusters(bs, old_l1_table_offset, old_l1_size * sizeof(uint64_t), QCOW2_DISCARD_OTHER); return 0; diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index b6f58c1..05e814d 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -719,6 +719,11 @@ int qcow2_snapshot_load_tmp(BlockDriverState *bs, return ret; } + qcow2_metadata_list_remove(bs, s->l1_table_offset, + size_to_clusters(s, s->l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); + /* Switch the L1 table */ qemu_vfree(s->l1_table); @@ -730,5 +735,10 @@ int qcow2_snapshot_load_tmp(BlockDriverState *bs, be64_to_cpus(&s->l1_table[i]); } + qcow2_metadata_list_enter(bs, s->l1_table_offset, + size_to_clusters(s, s->l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); + return 0; } diff --git a/block/qcow2.c b/block/qcow2.c index e34cd7c..c186452 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -844,6 +844,10 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags, } s->l1_table_offset = header.l1_table_offset; + qcow2_metadata_list_enter(bs, s->l1_table_offset, + size_to_clusters(s, s->l1_size * + sizeof(uint64_t)), + QCOW2_OL_ACTIVE_L1); if (s->l1_size > 0) { s->l1_table = qemu_try_blockalign(bs->file, -- 2.4.6