From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PULL 3/5] net/dp8393x: disable user creation
Date: Tue, 28 Jul 2015 11:04:46 +0100 [thread overview]
Message-ID: <1438077888-10384-4-git-send-email-leon.alrae@imgtec.com> (raw)
In-Reply-To: <1438077888-10384-1-git-send-email-leon.alrae@imgtec.com>
From: Hervé Poussineau <hpoussin@reactos.org>
Netcard needs an address space to write data to, which can't be specified
on command line.
This fixes a crash when user starts QEMU with "-device dp8393x"
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
hw/net/dp8393x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 451ff72..93d6a47 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -889,6 +889,8 @@ static void dp8393x_class_init(ObjectClass *klass, void *data)
dc->reset = dp8393x_reset;
dc->vmsd = &vmstate_dp8393x;
dc->props = dp8393x_properties;
+ /* Reason: dma_mr property can't be set */
+ dc->cannot_instantiate_with_device_add_yet = true;
}
static const TypeInfo dp8393x_info = {
--
2.1.0
next prev parent reply other threads:[~2015-07-28 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 10:04 [Qemu-devel] [PULL 0/5] target-mips queue for 2.4 Leon Alrae
2015-07-28 10:04 ` [Qemu-devel] [PULL 1/5] target-mips: fix passing incompatible pointer type in machine.c Leon Alrae
2015-07-28 10:04 ` [Qemu-devel] [PULL 2/5] target-mips: fix offset calculation for Interrupts Leon Alrae
2015-07-28 10:04 ` Leon Alrae [this message]
2015-07-28 10:04 ` [Qemu-devel] [PULL 4/5] net/dp8393x: remove check of runt packets Leon Alrae
2015-07-28 10:04 ` [Qemu-devel] [PULL 5/5] net/dp8393x: do not use memory_region_init_rom_device with NULL Leon Alrae
2015-07-28 16:09 ` [Qemu-devel] [PULL 0/5] target-mips queue for 2.4 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438077888-10384-4-git-send-email-leon.alrae@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).