From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK1l2-0006yu-6W for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:05:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK1kv-0008AV-7E for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:05:12 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:41964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK1kv-00088f-0g for qemu-devel@nongnu.org; Tue, 28 Jul 2015 06:05:05 -0400 From: Leon Alrae Date: Tue, 28 Jul 2015 11:04:46 +0100 Message-ID: <1438077888-10384-4-git-send-email-leon.alrae@imgtec.com> In-Reply-To: <1438077888-10384-1-git-send-email-leon.alrae@imgtec.com> References: <1438077888-10384-1-git-send-email-leon.alrae@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 3/5] net/dp8393x: disable user creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= From: Herv=C3=A9 Poussineau Netcard needs an address space to write data to, which can't be specified on command line. This fixes a crash when user starts QEMU with "-device dp8393x" Signed-off-by: Herv=C3=A9 Poussineau Reviewed-by: Aurelien Jarno Signed-off-by: Leon Alrae --- hw/net/dp8393x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 451ff72..93d6a47 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -889,6 +889,8 @@ static void dp8393x_class_init(ObjectClass *klass, vo= id *data) dc->reset =3D dp8393x_reset; dc->vmsd =3D &vmstate_dp8393x; dc->props =3D dp8393x_properties; + /* Reason: dma_mr property can't be set */ + dc->cannot_instantiate_with_device_add_yet =3D true; } =20 static const TypeInfo dp8393x_info =3D { --=20 2.1.0