From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PULL 4/5] net/dp8393x: remove check of runt packets
Date: Tue, 28 Jul 2015 11:04:47 +0100 [thread overview]
Message-ID: <1438077888-10384-5-git-send-email-leon.alrae@imgtec.com> (raw)
In-Reply-To: <1438077888-10384-1-git-send-email-leon.alrae@imgtec.com>
From: Hervé Poussineau <hpoussin@reactos.org>
Ethernet requires that messages are at least 64 bytes on the wire. This
limitation does not exist on emulation (no wire message), so remove the
check. Netcard is now able to receive small network packets.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
hw/net/dp8393x.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 93d6a47..0f45146 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -643,11 +643,6 @@ static int dp8393x_receive_filter(dp8393xState *s, const uint8_t * buf,
static const uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
int i;
- /* Check for runt packet (remember that checksum is not there) */
- if (size < 64 - 4) {
- return (s->regs[SONIC_RCR] & SONIC_RCR_RNT) ? 0 : -1;
- }
-
/* Check promiscuous mode */
if ((s->regs[SONIC_RCR] & SONIC_RCR_PRO) && (buf[0] & 1) == 0) {
return 0;
--
2.1.0
next prev parent reply other threads:[~2015-07-28 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 10:04 [Qemu-devel] [PULL 0/5] target-mips queue for 2.4 Leon Alrae
2015-07-28 10:04 ` [Qemu-devel] [PULL 1/5] target-mips: fix passing incompatible pointer type in machine.c Leon Alrae
2015-07-28 10:04 ` [Qemu-devel] [PULL 2/5] target-mips: fix offset calculation for Interrupts Leon Alrae
2015-07-28 10:04 ` [Qemu-devel] [PULL 3/5] net/dp8393x: disable user creation Leon Alrae
2015-07-28 10:04 ` Leon Alrae [this message]
2015-07-28 10:04 ` [Qemu-devel] [PULL 5/5] net/dp8393x: do not use memory_region_init_rom_device with NULL Leon Alrae
2015-07-28 16:09 ` [Qemu-devel] [PULL 0/5] target-mips queue for 2.4 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438077888-10384-5-git-send-email-leon.alrae@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).