* [Qemu-devel] [PATCH] migration: yet more possible state transitions
@ 2015-07-28 13:30 Juan Quintela
2015-07-28 15:19 ` Juan Quintela
0 siblings, 1 reply; 4+ messages in thread
From: Juan Quintela @ 2015-07-28 13:30 UTC (permalink / raw)
To: qemu-devel; +Cc: amit.shah, dgilbert
On destination, we move from INMIGRATE to FINISH_MIGRATE. Add that to
the list of allowed states.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 0adbbd6..45eb9ea 100644
--- a/vl.c
+++ b/vl.c
@@ -582,6 +582,7 @@ static const RunStateTransition runstate_transitions_def[] = {
{ RUN_STATE_INMIGRATE, RUN_STATE_SUSPENDED },
{ RUN_STATE_INMIGRATE, RUN_STATE_WATCHDOG },
{ RUN_STATE_INMIGRATE, RUN_STATE_GUEST_PANICKED },
+ { RUN_STATE_INMIGRATE, RUN_STATE_FINISH_MIGRATE },
{ RUN_STATE_INTERNAL_ERROR, RUN_STATE_PAUSED },
{ RUN_STATE_INTERNAL_ERROR, RUN_STATE_FINISH_MIGRATE },
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: yet more possible state transitions
2015-07-28 13:30 [Qemu-devel] [PATCH] migration: yet more possible state transitions Juan Quintela
@ 2015-07-28 15:19 ` Juan Quintela
2015-07-28 16:16 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Juan Quintela @ 2015-07-28 15:19 UTC (permalink / raw)
To: qemu-devel; +Cc: amit.shah, dgilbert
Juan Quintela <quintela@redhat.com> wrote:
> On destination, we move from INMIGRATE to FINISH_MIGRATE. Add that to
> the list of allowed states.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Self-NAK.
Somewhere I was able to test old + new qemu given this weird behaviour.
behaviour makes no sense, and I am not able to reproduce anymore.
Sorry for the noise.
> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vl.c b/vl.c
> index 0adbbd6..45eb9ea 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -582,6 +582,7 @@ static const RunStateTransition runstate_transitions_def[] = {
> { RUN_STATE_INMIGRATE, RUN_STATE_SUSPENDED },
> { RUN_STATE_INMIGRATE, RUN_STATE_WATCHDOG },
> { RUN_STATE_INMIGRATE, RUN_STATE_GUEST_PANICKED },
> + { RUN_STATE_INMIGRATE, RUN_STATE_FINISH_MIGRATE },
>
> { RUN_STATE_INTERNAL_ERROR, RUN_STATE_PAUSED },
> { RUN_STATE_INTERNAL_ERROR, RUN_STATE_FINISH_MIGRATE },
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration: yet more possible state transitions
2015-07-28 15:19 ` Juan Quintela
@ 2015-07-28 16:16 ` Paolo Bonzini
2015-07-28 16:47 ` Juan Quintela
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2015-07-28 16:16 UTC (permalink / raw)
To: quintela, Amit Shah, Dr. David Alan Gilbert, qemu-devel
On 28/07/2015 17:19, Juan Quintela wrote:
>> > On destination, we move from INMIGRATE to FINISH_MIGRATE. Add that to
>> > the list of allowed states.
>> >
>> > Signed-off-by: Juan Quintela <quintela@redhat.com>
> Self-NAK.
>
> Somewhere I was able to test old + new qemu given this weird behaviour.
> behaviour makes no sense, and I am not able to reproduce anymore.
I think it makes sense. Did you migrate twice on the source? Then the
state was FINISH_MIGRATE at the beginning of the second migration.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: yet more possible state transitions
2015-07-28 16:16 ` Paolo Bonzini
@ 2015-07-28 16:47 ` Juan Quintela
0 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2015-07-28 16:47 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Amit Shah, Dr. David Alan Gilbert, qemu-devel
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 28/07/2015 17:19, Juan Quintela wrote:
>>> > On destination, we move from INMIGRATE to FINISH_MIGRATE. Add that to
>>> > the list of allowed states.
>>> >
>>> > Signed-off-by: Juan Quintela <quintela@redhat.com>
>> Self-NAK.
>>
>> Somewhere I was able to test old + new qemu given this weird behaviour.
>> behaviour makes no sense, and I am not able to reproduce anymore.
>
> I think it makes sense. Did you migrate twice on the source? Then the
> state was FINISH_MIGRATE at the beginning of the second migration.
It could be, I would try again with normal trees (I was using and old
compiled binary in one of the sides when errors happened).
Later, Juan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-28 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-28 13:30 [Qemu-devel] [PATCH] migration: yet more possible state transitions Juan Quintela
2015-07-28 15:19 ` Juan Quintela
2015-07-28 16:16 ` Paolo Bonzini
2015-07-28 16:47 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).