* [Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec
@ 2015-07-29 18:40 Richard Henderson
2015-07-29 21:22 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2015-07-29 18:40 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
This buglet, from whenever we re-orged the parameters, means
that all x86-bsd-user invocations die instantly.
r~
---
bsd-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index f46728b..ee68daa 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -173,7 +173,7 @@ void cpu_loop(CPUX86State *env)
//target_siginfo_t info;
for(;;) {
- trapnr = cpu_x86_exec(env);
+ trapnr = cpu_x86_exec(cs);
switch(trapnr) {
case 0x80:
/* syscall from int $0x80 */
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec
2015-07-29 18:40 [Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec Richard Henderson
@ 2015-07-29 21:22 ` Peter Maydell
2015-07-30 13:00 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2015-07-29 21:22 UTC (permalink / raw)
To: Richard Henderson; +Cc: QEMU Developers
On 29 July 2015 at 19:40, Richard Henderson <rth@twiddle.net> wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> This buglet, from whenever we re-orged the parameters, means
> that all x86-bsd-user invocations die instantly.
>
>
> r~
> ---
> bsd-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index f46728b..ee68daa 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -173,7 +173,7 @@ void cpu_loop(CPUX86State *env)
> //target_siginfo_t info;
>
> for(;;) {
> - trapnr = cpu_x86_exec(env);
> + trapnr = cpu_x86_exec(cs);
> switch(trapnr) {
> case 0x80:
> /* syscall from int $0x80 */
Whoops. This sounds like it's worth putting into 2.4...
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec
2015-07-29 21:22 ` Peter Maydell
@ 2015-07-30 13:00 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2015-07-30 13:00 UTC (permalink / raw)
To: Richard Henderson; +Cc: QEMU Developers
On 29 July 2015 at 22:22, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 29 July 2015 at 19:40, Richard Henderson <rth@twiddle.net> wrote:
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>> This buglet, from whenever we re-orged the parameters, means
>> that all x86-bsd-user invocations die instantly.
>>
>>
>> r~
>> ---
>> bsd-user/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bsd-user/main.c b/bsd-user/main.c
>> index f46728b..ee68daa 100644
>> --- a/bsd-user/main.c
>> +++ b/bsd-user/main.c
>> @@ -173,7 +173,7 @@ void cpu_loop(CPUX86State *env)
>> //target_siginfo_t info;
>>
>> for(;;) {
>> - trapnr = cpu_x86_exec(env);
>> + trapnr = cpu_x86_exec(cs);
>> switch(trapnr) {
>> case 0x80:
>> /* syscall from int $0x80 */
>
> Whoops. This sounds like it's worth putting into 2.4...
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-30 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-29 18:40 [Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec Richard Henderson
2015-07-29 21:22 ` Peter Maydell
2015-07-30 13:00 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).