qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	famz@redhat.com, John Snow <jsnow@redhat.com>,
	Jeff Cody <jcody@redhat.com>, Max Reitz <mreitz@redhat.com>,
	vsementsov@parallels.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v4 07/14] blockjob: Add "completed" and "ret" in BlockJob
Date: Thu, 30 Jul 2015 14:39:23 +0800	[thread overview]
Message-ID: <1438238370-16212-8-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1438238370-16212-1-git-send-email-famz@redhat.com>

They are set when block_job_completed is called.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
 blockjob.c               | 3 +++
 include/block/blockjob.h | 9 +++++++++
 2 files changed, 12 insertions(+)

diff --git a/blockjob.c b/blockjob.c
index ec12887..293b62a 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -95,6 +95,9 @@ void block_job_completed(BlockJob *job, int ret)
     BlockDriverState *bs = job->bs;
 
     assert(bs->job == job);
+    assert(!job->completed);
+    job->completed = true;
+    job->ret = ret;
     job->cb(job->opaque, ret);
     block_job_unref(job);
 }
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index a7b497c..f6e4c86 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -143,6 +143,15 @@ struct BlockJob {
 
     /** Reference count of the block job */
     int refcnt;
+
+    /* True if this job has reported completion by calling block_job_completed.
+     */
+    bool completed;
+
+    /* ret code passed to block_job_completed.
+     */
+    int ret;
+
 };
 
 /**
-- 
2.4.3

  parent reply	other threads:[~2015-07-30  6:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  6:39 [Qemu-devel] [PATCH v4 00/14] block: incremental backup transactions using BlockJobTxn Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 01/14] qapi: Add transaction support to block-dirty-bitmap operations Fam Zheng
2015-08-03 16:49   ` Max Reitz
2015-09-07  6:32     ` Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 02/14] iotests: add transactional incremental backup test Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 03/14] block: rename BlkTransactionState and BdrvActionOps Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 04/14] backup: Extract dirty bitmap handling as a separate function Fam Zheng
2015-08-03 17:06   ` Max Reitz
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 05/14] blockjob: Introduce reference count Fam Zheng
2015-08-03 17:16   ` Max Reitz
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 06/14] blockjob: Add .commit and .abort block job actions Fam Zheng
2015-08-03 17:27   ` Max Reitz
2015-07-30  6:39 ` Fam Zheng [this message]
2015-08-03 17:32   ` [Qemu-devel] [PATCH v4 07/14] blockjob: Add "completed" and "ret" in BlockJob Max Reitz
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 08/14] blockjob: Simplify block_job_finish_sync Fam Zheng
2015-08-03 17:37   ` Max Reitz
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 09/14] block: add block job transactions Fam Zheng
2015-08-03 18:06   ` Max Reitz
2015-09-07  6:36     ` Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 10/14] blockdev: make BlockJobTxn available to qmp 'transaction' Fam Zheng
2015-08-03 18:13   ` Max Reitz
2015-09-07  6:52     ` Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 11/14] block/backup: support block job transactions Fam Zheng
2015-08-03 18:26   ` Max Reitz
2015-09-07  6:57     ` Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 12/14] iotests: 124 - transactional failure test Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 13/14] qmp-commands.hx: Update the supported 'transaction' operations Fam Zheng
2015-07-30  6:39 ` [Qemu-devel] [PATCH v4 14/14] tests: add BlockJobTxn unit test Fam Zheng
2015-08-03 18:45   ` Max Reitz
2015-09-07  7:11     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438238370-16212-8-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).