qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.4 0/3] scsi: fixes for failed requests
Date: Thu, 30 Jul 2015 14:16:10 +0100	[thread overview]
Message-ID: <1438262173-11546-1-git-send-email-stefanha@redhat.com> (raw)

When requests fail the error policy (-drive rerror=,werror=) determines what
happens.  The 'stop' policy pauses the guest and waits for the administrator to
resolve the storage problem.  It is possible to live migrate during this time
and the failed requests can be restarted on the destination host.

Two bugs:
1. Segfault due to missing sgs mapping when loading migrated failed requests.
2. Incorrect error action due to broken is_read logic.

I also noticed that the unaligned WRITE SAME test case in
tests/virtio-scsi-test.c is broken.  I've included a fix for that too.

Stefan Hajnoczi (3):
  virtio-scsi: use virtqueue_map_sg() when loading requests
  scsi-disk: fix cmd.mode field typo
  tests: virtio-scsi: clear unit attention after reset

 hw/scsi/scsi-disk.c      |  2 +-
 hw/scsi/virtio-scsi.c    |  5 +++
 tests/virtio-scsi-test.c | 90 +++++++++++++++++++++++++++++-------------------
 3 files changed, 60 insertions(+), 37 deletions(-)

-- 
2.4.3

             reply	other threads:[~2015-07-30 13:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 13:16 Stefan Hajnoczi [this message]
2015-07-30 13:16 ` [Qemu-devel] [PATCH for-2.4 1/3] virtio-scsi: use virtqueue_map_sg() when loading requests Stefan Hajnoczi
2015-07-30 13:16 ` [Qemu-devel] [PATCH for-2.4 2/3] scsi-disk: fix cmd.mode field typo Stefan Hajnoczi
2015-07-30 13:16 ` [Qemu-devel] [PATCH for-2.4 3/3] tests: virtio-scsi: clear unit attention after reset Stefan Hajnoczi
2015-07-30 13:19 ` [Qemu-devel] [PATCH for-2.4 0/3] scsi: fixes for failed requests Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438262173-11546-1-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).