From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKnuT-0004Y5-Bv for qemu-devel@nongnu.org; Thu, 30 Jul 2015 09:30:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKnuN-0003LY-F5 for qemu-devel@nongnu.org; Thu, 30 Jul 2015 09:30:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKnuN-0003Kw-9m for qemu-devel@nongnu.org; Thu, 30 Jul 2015 09:30:03 -0400 From: Igor Mammedov Date: Thu, 30 Jul 2015 15:29:59 +0200 Message-Id: <1438262999-287627-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH] vhost/scsi: call vhost_dev_cleanup() at unrealize() time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lina.lulina@huawei.com, pbonzini@redhat.com, arei.gonglei@huawei.com, mst@redhat.com vhost-scsi calls vhost_dev_init() at realize() time but forgets to call it's counterpart vhost_dev_cleanup() at unrealize() time. Calling it should fix leaking of memory table and mem_sections table in vhost device. And also unregister vhost's memory listerner to prevent access from memory core to freed memory. Signed-off-by: Igor Mammedov --- hw/scsi/vhost-scsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index a69918b..0dd57ff 100644 --- a/hw/scsi/vhost-scsi.c +++ b/hw/scsi/vhost-scsi.c @@ -277,6 +277,7 @@ static void vhost_scsi_unrealize(DeviceState *dev, Error **errp) /* This will stop vhost backend. */ vhost_scsi_set_status(vdev, 0); + vhost_dev_cleanup(&s->dev); g_free(s->dev.vqs); virtio_scsi_common_unrealize(dev, errp); -- 1.8.3.1