From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLDDe-0004OR-Gf for qemu-devel@nongnu.org; Fri, 31 Jul 2015 12:31:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZLDDa-00085z-9V for qemu-devel@nongnu.org; Fri, 31 Jul 2015 12:31:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLDDa-00085t-5V for qemu-devel@nongnu.org; Fri, 31 Jul 2015 12:31:34 -0400 From: "Daniel P. Berrange" Date: Fri, 31 Jul 2015 17:31:03 +0100 Message-Id: <1438360263-25445-11-git-send-email-berrange@redhat.com> In-Reply-To: <1438360263-25445-1-git-send-email-berrange@redhat.com> References: <1438360263-25445-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PATCH RFC 10/10] maint: enable checking for qemu/osdep.h header usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell Uncomment rules which mandate that qemu/osdep.h is included in all .c file, and that it appears in the file before any other includes. NB, this change isn't intended to be applied as it obviously fails. It is just an illustration of how we'd enforce such a header usage rule. Signed-off-by: Daniel P. Berrange --- cfg.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index 2f98c1a..da420c0 100644 --- a/cfg.mk +++ b/cfg.mk @@ -63,8 +63,6 @@ local-checks-to-skip = \ sc_prohibit_test_double_equal \ sc_prohibit_test_minus_ao \ sc_prohibit_undesirable_word_seq \ - sc_require_config_h \ - sc_require_config_h_first \ sc_require_test_exit_idiom \ sc_root_tests \ sc_space_tab \ @@ -80,6 +78,8 @@ local-checks-to-skip = \ sc_Wundef_boolean \ $(NULL) +config_h_header ?= "qemu/osdep\.h" + # Files that should never cause syntax check failures. VC_LIST_ALWAYS_EXCLUDE_REGEX = \ (^HACKING|\.po|^maint\.mk|^cfg\.mk|^pc-bios/.*)$$ -- 2.4.3