qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH RFC 07/10] maint: remove unused include for strings.h
Date: Fri, 31 Jul 2015 17:31:00 +0100	[thread overview]
Message-ID: <1438360263-25445-8-git-send-email-berrange@redhat.com> (raw)
In-Reply-To: <1438360263-25445-1-git-send-email-berrange@redhat.com>

A number of files were including strings.h but not using any
of the functions it provides

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 cfg.mk              | 1 -
 disas/microblaze.c  | 1 -
 hw/pci/shpc.c       | 1 -
 page_cache.c        | 1 -
 tests/test-xbzrle.c | 1 -
 5 files changed, 5 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index dddc544..a429980 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -60,7 +60,6 @@ local-checks-to-skip =			\
   sc_prohibit_S_IS_definition		\
   sc_prohibit_stat_st_blocks		\
   sc_prohibit_strcmp			\
-  sc_prohibit_strings_without_use	\
   sc_prohibit_strncpy			\
   sc_prohibit_test_double_equal		\
   sc_prohibit_test_minus_ao		\
diff --git a/disas/microblaze.c b/disas/microblaze.c
index c14ab89..92cd4b1 100644
--- a/disas/microblaze.c
+++ b/disas/microblaze.c
@@ -582,7 +582,6 @@ static const char pvr_register_prefix[] = "rpvr";
 #endif /* MICROBLAZE_OPC */
 
 #include "disas/bfd.h"
-#include <strings.h>
 
 #define get_field_rd(instr) get_field(instr, RD_MASK, RD_LOW)
 #define get_field_r1(instr) get_field(instr, RA_MASK, RA_LOW)
diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c
index bfb4d31..d34fdf3 100644
--- a/hw/pci/shpc.c
+++ b/hw/pci/shpc.c
@@ -1,5 +1,4 @@
 #include "qemu-common.h"
-#include <strings.h>
 #include <stdint.h>
 #include "qemu/range.h"
 #include "qemu/error-report.h"
diff --git a/page_cache.c b/page_cache.c
index cf8878d..a9eb076 100644
--- a/page_cache.c
+++ b/page_cache.c
@@ -15,7 +15,6 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <strings.h>
 #include <string.h>
 #include <sys/time.h>
 #include <sys/types.h>
diff --git a/tests/test-xbzrle.c b/tests/test-xbzrle.c
index b5ee8bb..1cd8cb7 100644
--- a/tests/test-xbzrle.c
+++ b/tests/test-xbzrle.c
@@ -13,7 +13,6 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <strings.h>
 #include <string.h>
 #include <sys/time.h>
 #include "qemu-common.h"
-- 
2.4.3

  parent reply	other threads:[~2015-07-31 16:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 16:30 [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 01/10] tests: import GNULIB's syntax-check infrastructure Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 02/10] maint: remove double semicolons in many files Daniel P. Berrange
2015-08-13 17:57   ` Peter Maydell
2015-08-14  8:32     ` Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 03/10] maint: remove / fix many doubled words Daniel P. Berrange
2015-08-03 16:10   ` Max Reitz
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 04/10] maint: remove unused include for assert.h Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 05/10] maint: remove unused include for dirent.h Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 06/10] maint: remove unused include for signal.h Daniel P. Berrange
2015-07-31 16:31 ` Daniel P. Berrange [this message]
2015-07-31 16:31 ` [Qemu-devel] [PATCH RFC 08/10] maint: avoid useless "if (foo) free(foo)" pattern Daniel P. Berrange
2015-07-31 16:31 ` [Qemu-devel] [PATCH RFC 09/10] maint: add check for use of POSIX functions which are not reentrant safe Daniel P. Berrange
2015-07-31 16:31 ` [Qemu-devel] [PATCH RFC 10/10] maint: enable checking for qemu/osdep.h header usage Daniel P. Berrange
2015-08-13 17:53 ` [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking Peter Maydell
2015-08-13 18:27   ` Eric Blake
2015-08-13 20:39     ` Peter Maydell
2015-08-14  9:57       ` Daniel P. Berrange
2015-08-14 10:30       ` Paul Eggert
2015-08-14 10:35         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438360263-25445-8-git-send-email-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).