qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, jasowang@redhat.com, famz@redhat.com,
	n.nikolaev@virtualopensystems.com, mst@redhat.com
Subject: [Qemu-devel]  [PATCH V3 0/3] vhost-user: sync backend
Date: Fri, 31 Jul 2015 19:38:17 +0300	[thread overview]
Message-ID: <1438360700-18289-1-git-send-email-marcel@redhat.com> (raw)

To be used on top of:
 [PATCH 0/4] vhost-user: protocol updates
 https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg03842.html 

v2 -> v3:
 - Addressed Michael S. Tsirkin's comments:
   - Fixed a typo in patch 2/3  message
   - MQ - I left it there for completeness,
     it will be moved once the "protocol" bits
     will be 'active'
   - unit-test - The bits were added to GET_FEATURES,
     not GET_PROTOCOL_FEATURES, no need to make any changes
 - Added a new patch (1/3) that removes the unnecessary
   virtio bits related to vhost-user backend.

v1 -> v2:
 - Addressed Michael S. Tsirkin's comments:
   - Prefer a white-list of supported features
   - Add a unit-test to show the problem we are trying to solve
     (run the unit-test before the patch and it will fail)

Currently the vhost-user supported features are not evaluated.
 The way I see it, and please correct me, the best way to do
 this is to:
  1. Get the backend features on vhost init.
  2. Check them one by one (white-list) against all 
     the currently supported virtio features.
  3. All other code should remain the same.


Marcel Apfelbaum (3):
  hw/vhost-user: remove unnecessary virtio control bits
  hw/vhost-user: sync backend features
  tests/vhost-user: check vhost-user feature negotiation

 hw/net/vhost_net.c      | 22 ----------------------
 hw/virtio/vhost-user.c  | 17 +++++++++++++++++
 tests/vhost-user-test.c | 19 ++++++++++++++++---
 3 files changed, 33 insertions(+), 25 deletions(-)

-- 
2.1.0

             reply	other threads:[~2015-07-31 16:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 16:38 Marcel Apfelbaum [this message]
2015-07-31 16:38 ` [Qemu-devel] [PATCH V3 1/3] hw/vhost-user: remove unnecessary virtio control bits Marcel Apfelbaum
2015-08-05 11:37   ` Marcel Apfelbaum
2015-07-31 16:38 ` [Qemu-devel] [PATCH V3 2/3] hw/vhost-user: sync backend features Marcel Apfelbaum
2015-07-31 16:38 ` [Qemu-devel] [PATCH V3 3/3] tests/vhost-user: check vhost-user feature negotiation Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438360700-18289-1-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=famz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=n.nikolaev@virtualopensystems.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).