From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLDKI-0005iA-3g for qemu-devel@nongnu.org; Fri, 31 Jul 2015 12:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZLDKC-0003B0-GN for qemu-devel@nongnu.org; Fri, 31 Jul 2015 12:38:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLDKC-0003Aw-C1 for qemu-devel@nongnu.org; Fri, 31 Jul 2015 12:38:24 -0400 From: Marcel Apfelbaum Date: Fri, 31 Jul 2015 19:38:17 +0300 Message-Id: <1438360700-18289-1-git-send-email-marcel@redhat.com> Subject: [Qemu-devel] [PATCH V3 0/3] vhost-user: sync backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcel@redhat.com, jasowang@redhat.com, famz@redhat.com, n.nikolaev@virtualopensystems.com, mst@redhat.com To be used on top of: [PATCH 0/4] vhost-user: protocol updates https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg03842.html v2 -> v3: - Addressed Michael S. Tsirkin's comments: - Fixed a typo in patch 2/3 message - MQ - I left it there for completeness, it will be moved once the "protocol" bits will be 'active' - unit-test - The bits were added to GET_FEATURES, not GET_PROTOCOL_FEATURES, no need to make any changes - Added a new patch (1/3) that removes the unnecessary virtio bits related to vhost-user backend. v1 -> v2: - Addressed Michael S. Tsirkin's comments: - Prefer a white-list of supported features - Add a unit-test to show the problem we are trying to solve (run the unit-test before the patch and it will fail) Currently the vhost-user supported features are not evaluated. The way I see it, and please correct me, the best way to do this is to: 1. Get the backend features on vhost init. 2. Check them one by one (white-list) against all the currently supported virtio features. 3. All other code should remain the same. Marcel Apfelbaum (3): hw/vhost-user: remove unnecessary virtio control bits hw/vhost-user: sync backend features tests/vhost-user: check vhost-user feature negotiation hw/net/vhost_net.c | 22 ---------------------- hw/virtio/vhost-user.c | 17 +++++++++++++++++ tests/vhost-user-test.c | 19 ++++++++++++++++--- 3 files changed, 33 insertions(+), 25 deletions(-) -- 2.1.0