From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLIlw-0002bc-BO for qemu-devel@nongnu.org; Fri, 31 Jul 2015 18:27:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZLIls-00048T-5X for qemu-devel@nongnu.org; Fri, 31 Jul 2015 18:27:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLIls-00048P-0c for qemu-devel@nongnu.org; Fri, 31 Jul 2015 18:27:20 -0400 From: John Snow Date: Fri, 31 Jul 2015 18:27:15 -0400 Message-Id: <1438381635-11949-3-git-send-email-jsnow@redhat.com> In-Reply-To: <1438381635-11949-1-git-send-email-jsnow@redhat.com> References: <1438381635-11949-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PULL for-2.4 2/2] ahci: fix ICC mask definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, jsnow@redhat.com There are likely others that could be updated, but we'll go with a light touch for 2.4 for now. Without the Unsigned specifier, this shifts bits into the signed bit, which makes clang unhappy and could cause unwanted behavior. Reported-by: Peter Maydell Signed-off-by: John Snow Message-id: 1437501721-24495-1-git-send-email-jsnow@redhat.com --- hw/ide/ahci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h index 68d5074..79a463d 100644 --- a/hw/ide/ahci.h +++ b/hw/ide/ahci.h @@ -127,7 +127,7 @@ #define PORT_CMD_SPIN_UP (1 << 1) /* Spin up device */ #define PORT_CMD_START (1 << 0) /* Enable port DMA engine */ -#define PORT_CMD_ICC_MASK (0xf << 28) /* i/f ICC state mask */ +#define PORT_CMD_ICC_MASK (0xfU << 28) /* i/f ICC state mask */ #define PORT_CMD_ICC_ACTIVE (0x1 << 28) /* Put i/f in active state */ #define PORT_CMD_ICC_PARTIAL (0x2 << 28) /* Put i/f in partial state */ #define PORT_CMD_ICC_SLUMBER (0x6 << 28) /* Put i/f in slumber state */ -- 2.1.0