From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMJwv-0003G4-OP for qemu-devel@nongnu.org; Mon, 03 Aug 2015 13:54:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMJwt-0003i3-0v for qemu-devel@nongnu.org; Mon, 03 Aug 2015 13:54:57 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMJws-0003hc-Ow for qemu-devel@nongnu.org; Mon, 03 Aug 2015 13:54:54 -0400 Received: by wicgj17 with SMTP id gj17so116258329wic.1 for ; Mon, 03 Aug 2015 10:54:54 -0700 (PDT) From: Leonid Bloch Date: Mon, 3 Aug 2015 20:54:24 +0300 Message-Id: <1438624464-22770-5-git-send-email-leonid@daynix.com> In-Reply-To: <1438624464-22770-1-git-send-email-leonid@daynix.com> References: <1438624464-22770-1-git-send-email-leonid@daynix.com> Subject: [Qemu-devel] [PATCH v3 4/4] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on MSI reinstall List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Leonid Bloch , marcandre.lureau@gmail.com Previously, running the .msi would unregister the QEMU GA VSS service if QEMU GA was already installed on the machine, and then register it only if QEMU GA was NOT previously installed. This behavior caused the service to be registered only after the INITIAL installation, and any subsequent run of the .msi (to redo, repair, or upgrade the installation) ended in the service being unregistered. Now, the VSS service is still unregistered if QEMU GA is already installed (so that a fix or an update could be performed) but then it is registered again (if the GA is not being uninstalled) thus finishing the repair/upgrade correctly. Additionally, downgrading is now prevented. If a user would like to downgrade a version, he/she must uninstall the newer version first. Signed-off-by: Leonid Bloch --- qga/installer/qemu-ga.wxs | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index 2302745..41b11cf 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -58,13 +58,9 @@ /> - - - - + @@ -125,6 +121,7 @@ + - - NOT Installed Installed + NOT REMOVE -- 2.4.3