qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 03/26] qapi: Simplify guardname()
Date: Tue,  4 Aug 2015 11:17:53 +0200	[thread overview]
Message-ID: <1438679896-5077-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1438679896-5077-1-git-send-email-armbru@redhat.com>

The guards around built-in declarations lose their _H.  It never made
much sense anyway.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 scripts/qapi.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/scripts/qapi.py b/scripts/qapi.py
index 20383ef..2bbc8ff 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -958,14 +958,9 @@ def mcgen(code, **kwds):
         code = code[1:]
     return cgen(code, **kwds)
 
-def basename(filename):
-    return filename.split("/")[-1]
 
 def guardname(filename):
-    guard = basename(filename).rsplit(".", 1)[0]
-    for substr in [".", " ", "-"]:
-        guard = guard.replace(substr, "_")
-    return guard.upper() + '_H'
+    return c_name(filename, protect=False).upper()
 
 def guardstart(name):
     return mcgen('''
@@ -1035,6 +1030,7 @@ def parse_command_line(extra_options = "", extra_long_options = []):
 
 def open_output(output_dir, do_c, do_h, prefix, c_file, h_file,
                 c_comment, h_comment):
+    guard = guardname(prefix + h_file)
     c_file = output_dir + prefix + c_file
     h_file = output_dir + prefix + h_file
 
@@ -1067,7 +1063,7 @@ def open_output(output_dir, do_c, do_h, prefix, c_file, h_file,
 #define %(guard)s
 
 ''',
-                      comment = h_comment, guard = guardname(h_file)))
+                      comment = h_comment, guard = guard))
 
     return (fdef, fdecl)
 
-- 
2.4.3

  parent reply	other threads:[~2015-08-04  9:18 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04  9:17 [Qemu-devel] [PATCH 00/26] qapi: Another round of fixes and cleanups Markus Armbruster
2015-08-04  9:17 ` [Qemu-devel] [PATCH 01/26] qapi: Clarify docs on including the same file multiple times Markus Armbruster
2015-08-04  9:17 ` [Qemu-devel] [PATCH 02/26] qapi: Clean up cgen() and mcgen() Markus Armbruster
2015-08-04 15:44   ` Markus Armbruster
2015-08-04 16:33     ` Eric Blake
2015-08-04  9:17 ` Markus Armbruster [this message]
2015-08-04  9:17 ` [Qemu-devel] [PATCH 04/26] qapi-event: Clean up how name of enum QAPIEvent is made Markus Armbruster
2015-08-04  9:17 ` [Qemu-devel] [PATCH 05/26] qapi: Reject -p arguments that break qapi-event.py Markus Armbruster
2015-08-04  9:17 ` [Qemu-devel] [PATCH 06/26] qapi: Drop unused and useless parameters and variables Markus Armbruster
2015-08-04  9:17 ` [Qemu-devel] [PATCH 07/26] qapi: Fix generated code when flat union has member 'kind' Markus Armbruster
2015-08-04 16:17   ` Eric Blake
2015-08-05  5:24     ` Markus Armbruster
2015-08-04  9:17 ` [Qemu-devel] [PATCH 08/26] qapi: Generate a nicer struct for flat unions Markus Armbruster
2015-08-04 17:00   ` Eric Blake
2015-08-04  9:17 ` [Qemu-devel] [PATCH 09/26] qapi-visit: Fix generated code when schema has forward refs Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 10/26] qapi-visit: Replace list implicit_structs by set Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 11/26] qapi-visit: Fix two name arguments passed to visitors Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 12/26] tests/qapi-schema: Document alternate's enum lacks visit function Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 13/26] tests/qapi-schema: Document events with base don't work Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 14/26] qapi: Document that input visitor semantics are prone to leaks Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 15/26] qapi: Document shortcoming with union 'data' branch Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 16/26] qapi: Document flaws in checking of names Markus Armbruster
2015-08-04 17:29   ` Eric Blake
2015-08-04  9:18 ` [Qemu-devel] [PATCH 17/26] tests/qapi-schema: Restore test case for flat union base bug Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args- Markus Armbruster
2015-08-04 17:37   ` Eric Blake
2015-08-04  9:18 ` [Qemu-devel] [PATCH 19/26] qapi-tests: New tests for union, alternate command arguments Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 20/26] qapi: Fix to reject union command and event arguments Markus Armbruster
2015-08-04 17:44   ` Eric Blake
2015-08-17 19:14   ` Eric Blake
2015-08-24 11:17     ` Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type doesn't work, outlaw Markus Armbruster
2015-08-04 18:03   ` Eric Blake
2015-08-05  5:29     ` Markus Armbruster
2015-08-05 14:22       ` Eric Blake
2015-08-06  5:43         ` Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 22/26] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err' Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 23/26] qapi-commands: Inline gen_marshal_output_call() Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again Markus Armbruster
2015-08-04  9:18 ` [Qemu-devel] [PATCH 25/26] qapi-commands: Drop useless initialization Markus Armbruster
2015-08-04 18:46   ` Eric Blake
2015-08-04  9:18 ` [Qemu-devel] [PATCH 26/26] qapi: Generated code cleanup Markus Armbruster
2015-08-04 18:59   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438679896-5077-4-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).