From: Victor Kaplansky <victork@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefan Weil <sw@weilnetz.de>, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v2 0/2] make: Cleanup and fix of loading of dependency info
Date: Wed, 5 Aug 2015 20:27:04 +0300 [thread overview]
Message-ID: <1438795570-3930-1-git-send-email-victork@redhat.com> (raw)
Hi,
sometimes the make fails when one switches between commits without running
"make clean".
This is caused by loading old *.d dependency info files and is harmful for
autogenerated sources with their own includes. This situation may
significantly slow down the process of git bisect.
These two patches clean things up and fix the issue both for further versions,
and between old and new commits.
This also replaces my previous patch "[PATCH] make: explicit dependencies for
ACPI gen sources".
I've tested the fix by validating that lists included by previous "*.d"
approach and new "patsubst" approach are identical.
Victor Kaplansky (2):
make: fix where dependency *.d are stored.
make: load only required dependency files.
hw/i386/Makefile.objs | 2 ++
hw/i386/acpi-dsdt.dsl | 1 -
hw/i386/q35-acpi-dsdt.dsl | 1 +
rules.mak | 4 ++--
4 files changed, 5 insertions(+), 3 deletions(-)
--
--Victor
next reply other threads:[~2015-08-05 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 17:27 Victor Kaplansky [this message]
2015-08-05 17:28 ` [Qemu-devel] [PATCH v2 1/2] make: fix where dependency *.d are stored Victor Kaplansky
2015-08-06 8:57 ` Alex Bennée
2015-08-06 9:02 ` Michael S. Tsirkin
2015-08-06 15:55 ` Alex Bennée
2015-08-05 17:29 ` [Qemu-devel] [PATCH v2 2/2] make: load only required dependency files Victor Kaplansky
2015-08-05 17:40 ` Paolo Bonzini
2015-08-05 18:22 ` Victor kaplansky
2015-08-06 7:05 ` Markus Armbruster
2015-08-05 18:32 ` Michael S. Tsirkin
2015-08-05 18:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438795570-3930-1-git-send-email-victork@redhat.com \
--to=victork@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).