From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOozs-00079x-Ul for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:28:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOozq-00009t-VT for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:28:20 -0400 Received: from greensocs.com ([193.104.36.180]:59390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOozq-00009j-LK for qemu-devel@nongnu.org; Mon, 10 Aug 2015 11:28:18 -0400 From: fred.konrad@greensocs.com Date: Mon, 10 Aug 2015 17:27:16 +0200 Message-Id: <1439220437-23957-19-git-send-email-fred.konrad@greensocs.com> In-Reply-To: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> References: <1439220437-23957-1-git-send-email-fred.konrad@greensocs.com> Subject: [Qemu-devel] [RFC PATCH V7 18/19] mttcg: signal the associated cpu anyway. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mttcg@listserver.greensocs.com Cc: mark.burton@greensocs.com, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, alex.bennee@linaro.org, fred.konrad@greensocs.com From: KONRAD Frederic We might have a race here. If current_cpu is about to be set then cpu_exit won't be called and we don't exit TCG. This was probably an issue with old implementation as well. Signed-off-by: KONRAD Frederic --- cpus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 2c5ca72..f61530c 100644 --- a/cpus.c +++ b/cpus.c @@ -674,8 +674,7 @@ static void cpu_signal(int sig) cpu_exit(current_cpu); } - /* FIXME: We might want to check if the cpu is running? */ - tcg_thread_cpu->exit_request = true; + cpu_exit(tcg_thread_cpu); } #ifdef CONFIG_LINUX -- 1.9.0