* [Qemu-devel] [PATCH] sh4: Fix initramfs initialization for endiannes-mismatched targets
@ 2015-08-12 14:20 Guenter Roeck
2015-08-17 20:46 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2015-08-12 14:20 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Guenter Roeck, Aurelien Jarno
If host and target endianness does not match, loding an initramfs does not work.
Fix by writing boot parameters with appropriate endianness conversion.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
hw/sh4/r2d.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
index 5e22ed7..3b0b2ec 100644
--- a/hw/sh4/r2d.c
+++ b/hw/sh4/r2d.c
@@ -338,9 +338,9 @@ static void r2d_init(MachineState *machine)
}
/* initialization which should be done by firmware */
- boot_params.loader_type = 1;
- boot_params.initrd_start = INITRD_LOAD_OFFSET;
- boot_params.initrd_size = initrd_size;
+ boot_params.loader_type = tswap32(1);
+ boot_params.initrd_start = tswap32(INITRD_LOAD_OFFSET);
+ boot_params.initrd_size = tswap32(initrd_size);
}
if (kernel_cmdline) {
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] sh4: Fix initramfs initialization for endiannes-mismatched targets
2015-08-12 14:20 [Qemu-devel] [PATCH] sh4: Fix initramfs initialization for endiannes-mismatched targets Guenter Roeck
@ 2015-08-17 20:46 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2015-08-17 20:46 UTC (permalink / raw)
To: Guenter Roeck; +Cc: qemu-trivial, qemu-devel
On 2015-08-12 07:20, Guenter Roeck wrote:
> If host and target endianness does not match, loding an initramfs does not work.
> Fix by writing boot parameters with appropriate endianness conversion.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> hw/sh4/r2d.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
> index 5e22ed7..3b0b2ec 100644
> --- a/hw/sh4/r2d.c
> +++ b/hw/sh4/r2d.c
> @@ -338,9 +338,9 @@ static void r2d_init(MachineState *machine)
> }
>
> /* initialization which should be done by firmware */
> - boot_params.loader_type = 1;
> - boot_params.initrd_start = INITRD_LOAD_OFFSET;
> - boot_params.initrd_size = initrd_size;
> + boot_params.loader_type = tswap32(1);
> + boot_params.initrd_start = tswap32(INITRD_LOAD_OFFSET);
> + boot_params.initrd_size = tswap32(initrd_size);
> }
>
> if (kernel_cmdline) {
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Good catch. I have added it to my sh4-next queue:
http://git.aurel32.net/?p=qemu.git;a=shortlog;h=refs/heads/sh4-next
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-17 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-12 14:20 [Qemu-devel] [PATCH] sh4: Fix initramfs initialization for endiannes-mismatched targets Guenter Roeck
2015-08-17 20:46 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).