qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 12/27] i.MX: Fix Coding style for AVIC emulator.
Date: Thu, 13 Aug 2015 11:44:32 +0100	[thread overview]
Message-ID: <1439462687-26903-13-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1439462687-26903-1-git-send-email-peter.maydell@linaro.org>

From: Jean-Christophe Dubois <jcd@tribudubois.net>

Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Message-id: 01e1d9026220992405819f25640ebd5bb843fc93.1437080501.git.jcd@tribudubois.net
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/intc/imx_avic.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c
index c5eecb5..96c376b 100644
--- a/hw/intc/imx_avic.c
+++ b/hw/intc/imx_avic.c
@@ -22,7 +22,7 @@
 
 #ifdef DEBUG_INT
 #define DPRINTF(fmt, args...) \
-do { printf("imx_avic: " fmt , ##args); } while (0)
+do { printf("%s: " fmt , TYPE_IMX_AVIC, ##args); } while (0)
 #else
 #define DPRINTF(fmt, args...) do {} while (0)
 #endif
@@ -34,13 +34,13 @@ do { printf("imx_avic: " fmt , ##args); } while (0)
 #define DEBUG_IMPLEMENTATION 1
 #if DEBUG_IMPLEMENTATION
 #  define IPRINTF(fmt, args...) \
-    do  { fprintf(stderr, "imx_avic: " fmt, ##args); } while (0)
+    do  { fprintf(stderr, "%s: " fmt, TYPE_IMX_AVIC, ##args); } while (0)
 #else
 #  define IPRINTF(fmt, args...) do {} while (0)
 #endif
 
 static const VMStateDescription vmstate_imx_avic = {
-    .name = "imx-avic",
+    .name = TYPE_IMX_AVIC,
     .version_id = 1,
     .minimum_version_id = 1,
     .fields = (VMStateField[]) {
@@ -54,8 +54,6 @@ static const VMStateDescription vmstate_imx_avic = {
     },
 };
 
-
-
 static inline int imx_avic_prio(IMXAVICState *s, int irq)
 {
     uint32_t word = irq / PRIO_PER_WORD;
@@ -215,7 +213,7 @@ static uint64_t imx_avic_read(void *opaque,
         return 0x4;
 
     default:
-        IPRINTF("imx_avic_read: Bad offset 0x%x\n", (int)offset);
+        IPRINTF("%s: Bad offset 0x%x\n", __func__, (int)offset);
         return 0;
     }
 }
@@ -227,12 +225,12 @@ static void imx_avic_write(void *opaque, hwaddr offset,
 
     /* Vector Registers not yet supported */
     if (offset >= 0x100 && offset <= 0x2fc) {
-        IPRINTF("imx_avic_write to vector register %d ignored\n",
+        IPRINTF("%s to vector register %d ignored\n", __func__,
                 (unsigned int)((offset - 0x100) >> 2));
         return;
     }
 
-    DPRINTF("imx_avic_write(0x%x) = %x\n",
+    DPRINTF("%s(0x%x) = %x\n", __func__,
             (unsigned int)offset>>2, (unsigned int)val);
     switch (offset >> 2) {
     case 0: /* Interrupt Control Register, INTCNTL */
@@ -307,7 +305,7 @@ static void imx_avic_write(void *opaque, hwaddr offset,
         return;
 
     default:
-        IPRINTF("imx_avic_write: Bad offset %x\n", (int)offset);
+        IPRINTF("%s: Bad offset %x\n", __func__, (int)offset);
     }
     imx_avic_update(s);
 }
-- 
1.9.1

  parent reply	other threads:[~2015-08-13 10:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 10:44 [Qemu-devel] [PULL 00/27] target-arm queue Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 01/27] target-arm: Add CNTVOFF_EL2 Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 02/27] target-arm: Add CNTHCTL_EL2 Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 03/27] target-arm: Rename and move gt_cnt_reset Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 04/27] target-arm: Pass timeridx as argument to various timer functions Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 05/27] target-arm: Add the Hypervisor timer Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 06/27] hw/arm/virt: Replace magic IRQ constants with macros Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 07/27] hw/arm/virt: Connect the Hypervisor timer Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 08/27] i.MX: Split UART emulator in a header file and a source file Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 09/27] i.MX: Move serial initialization to init/realize of DeviceClass Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 10/27] i.MX:Fix Coding style for UART emulator Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 11/27] i.MX: Split AVIC emulator in a header file and a source file Peter Maydell
2015-08-13 10:44 ` Peter Maydell [this message]
2015-08-13 10:44 ` [Qemu-devel] [PULL 13/27] i.MX: Split CCM " Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 14/27] i.MX: Fix Coding style for CCM emulator Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 15/27] i.MX: Split EPIT emulator in a header file and a source file Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 16/27] i.MX: Fix Coding style for EPIT emulator Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 17/27] i.MX: Split GPT emulator in a header file and a source file Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 18/27] i.MX: Fix Coding style for GPT emulator Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 19/27] Merge memory_region_init_reservation() into memory_region_init_io() Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 20/27] hw/arm/gic: Kill code duplication Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 21/27] Introduce gic_class_name() instead of repeating condition Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 22/27] target-arm: Add debug check for mismatched cpreg resets Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 23/27] target-arm: Add the AArch64 view of the Secure physical timer Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 24/27] target-arm: Add AArch32 banked register access to secure " Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 25/27] hw/arm/virt: Wire up secure timer interrupt Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 26/27] hw/cpu/a15mpcore: Wire up hyp and secure physical timer interrupts Peter Maydell
2015-08-13 10:44 ` [Qemu-devel] [PULL 27/27] i.MX: Fix UART driver to work with unitialized "chardev" device Peter Maydell
2015-08-13 14:06 ` [Qemu-devel] [PULL 00/27] target-arm queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439462687-26903-13-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).