qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, schwab@linux-m68k.org,
	laurent@vivier.eu, gerg@uclinux.org
Subject: [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of cc_x
Date: Fri, 14 Aug 2015 07:59:18 -0700	[thread overview]
Message-ID: <1439564366-11633-4-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1439564366-11633-1-git-send-email-rth@twiddle.net>

The CF docs certainly doesnt suggest this is true.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-m68k/helper.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/target-m68k/helper.c b/target-m68k/helper.c
index c7b0fbe..6feb4bf 100644
--- a/target-m68k/helper.c
+++ b/target-m68k/helper.c
@@ -205,19 +205,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
         break;
     case CC_OP_LOGICB:
         SET_NZ(dest, int8_t);
-        goto set_x;
         break;
     case CC_OP_LOGICW:
         SET_NZ(dest, int16_t);
-        goto set_x;
         break;
     case CC_OP_LOGIC:
         SET_NZ(dest, int32_t);
-set_x:
-        if (!m68k_feature(env, M68K_FEATURE_M68000)) {
-            /* Unlike m68k, coldfire always clears the overflow bit.  */
-            env->cc_x = 0;
-        }
         break;
     case CC_OP_ADDB:
         SET_FLAGS_ADD(int8_t, uint8_t);
-- 
2.4.3

  parent reply	other threads:[~2015-08-14 15:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 14:59 [Qemu-devel] [PATCH 00/11] Proposed format for m68k flags Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 01/11] target-m68k: Print flags properly Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 02/11] target-m68k: Some fixes to SR and flags management Richard Henderson
2015-08-14 14:59 ` Richard Henderson [this message]
2015-08-14 17:04   ` [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of cc_x Andreas Schwab
2015-08-14 23:10     ` Richard Henderson
2015-08-15  6:25       ` Andreas Schwab
2015-08-14 14:59 ` [Qemu-devel] [PATCH 04/11] target-m68k: Replace helper_xflag_lt with setcond Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 05/11] target-m68k: Reorg flags handling Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 06/11] target-m68k: Introduce DisasCompare Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 07/11] target-m68k: Use setcond for scc Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 08/11] target-m68k: Optimize some comparisons Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 09/11] target-m68k: Optimize gen_flush_flags Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 10/11] target-m68k: Inline shifts Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 11/11] target-m68k: Inline addx, subx, negx Richard Henderson
2015-08-14 15:37 ` [Qemu-devel] [PATCH 00/11] Proposed format for m68k flags Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439564366-11633-4-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=gerg@uclinux.org \
    --cc=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).