From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQGSl-0007ZT-P9 for qemu-devel@nongnu.org; Fri, 14 Aug 2015 11:00:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQGSk-0006UA-Rl for qemu-devel@nongnu.org; Fri, 14 Aug 2015 11:00:07 -0400 Received: from mail-qg0-x236.google.com ([2607:f8b0:400d:c04::236]:33117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQGSk-0006Tf-Oi for qemu-devel@nongnu.org; Fri, 14 Aug 2015 11:00:06 -0400 Received: by qged69 with SMTP id d69so52837745qge.0 for ; Fri, 14 Aug 2015 08:00:06 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Fri, 14 Aug 2015 07:59:18 -0700 Message-Id: <1439564366-11633-4-git-send-email-rth@twiddle.net> In-Reply-To: <1439564366-11633-1-git-send-email-rth@twiddle.net> References: <1439564366-11633-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of cc_x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, schwab@linux-m68k.org, laurent@vivier.eu, gerg@uclinux.org The CF docs certainly doesnt suggest this is true. Signed-off-by: Richard Henderson --- target-m68k/helper.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/target-m68k/helper.c b/target-m68k/helper.c index c7b0fbe..6feb4bf 100644 --- a/target-m68k/helper.c +++ b/target-m68k/helper.c @@ -205,19 +205,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op) break; case CC_OP_LOGICB: SET_NZ(dest, int8_t); - goto set_x; break; case CC_OP_LOGICW: SET_NZ(dest, int16_t); - goto set_x; break; case CC_OP_LOGIC: SET_NZ(dest, int32_t); -set_x: - if (!m68k_feature(env, M68K_FEATURE_M68000)) { - /* Unlike m68k, coldfire always clears the overflow bit. */ - env->cc_x = 0; - } break; case CC_OP_ADDB: SET_FLAGS_ADD(int8_t, uint8_t); -- 2.4.3