From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, schwab@linux-m68k.org,
laurent@vivier.eu, gerg@uclinux.org
Subject: [Qemu-devel] [PATCH 04/11] target-m68k: Replace helper_xflag_lt with setcond
Date: Fri, 14 Aug 2015 07:59:19 -0700 [thread overview]
Message-ID: <1439564366-11633-5-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1439564366-11633-1-git-send-email-rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
target-m68k/helper.c | 5 -----
target-m68k/helper.h | 1 -
target-m68k/translate.c | 14 +++++++-------
3 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/target-m68k/helper.c b/target-m68k/helper.c
index 6feb4bf..a032947 100644
--- a/target-m68k/helper.c
+++ b/target-m68k/helper.c
@@ -465,11 +465,6 @@ uint32_t HELPER(addx_cc)(CPUM68KState *env, uint32_t op1, uint32_t op2)
return res;
}
-uint32_t HELPER(xflag_lt)(uint32_t a, uint32_t b)
-{
- return a < b;
-}
-
void HELPER(set_sr)(CPUM68KState *env, uint32_t val)
{
env->sr = val & 0xffe0;
diff --git a/target-m68k/helper.h b/target-m68k/helper.h
index 81c8e79..0f5a7cf 100644
--- a/target-m68k/helper.h
+++ b/target-m68k/helper.h
@@ -8,7 +8,6 @@ DEF_HELPER_3(subx_cc, i32, env, i32, i32)
DEF_HELPER_3(shl_cc, i32, env, i32, i32)
DEF_HELPER_3(shr_cc, i32, env, i32, i32)
DEF_HELPER_3(sar_cc, i32, env, i32, i32)
-DEF_HELPER_2(xflag_lt, i32, i32, i32)
DEF_HELPER_2(set_sr, void, env, i32)
DEF_HELPER_3(movec, void, env, i32, i32)
diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index 2c720a2..cf6a54c 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -1102,10 +1102,10 @@ DISAS_INSN(addsub)
}
if (add) {
tcg_gen_add_i32(dest, tmp, src);
- gen_helper_xflag_lt(QREG_CC_X, dest, src);
+ tcg_gen_setcond_i32(TCG_COND_LTU, QREG_CC_X, dest, src);
set_cc_op(s, CC_OP_ADD);
} else {
- gen_helper_xflag_lt(QREG_CC_X, tmp, src);
+ tcg_gen_setcond_i32(TCG_COND_LTU, QREG_CC_X, tmp, src);
tcg_gen_sub_i32(dest, tmp, src);
set_cc_op(s, CC_OP_SUB);
}
@@ -1317,7 +1317,7 @@ DISAS_INSN(arith_im)
break;
case 2: /* subi */
tcg_gen_mov_i32(dest, src1);
- gen_helper_xflag_lt(QREG_CC_X, dest, tcg_const_i32(im));
+ tcg_gen_setcond_i32(TCG_COND_LTU, QREG_CC_X, dest, tcg_const_i32(im));
tcg_gen_subi_i32(dest, dest, im);
gen_update_cc_add(dest, tcg_const_i32(im));
set_cc_op(s, CC_OP_SUB);
@@ -1326,7 +1326,7 @@ DISAS_INSN(arith_im)
tcg_gen_mov_i32(dest, src1);
tcg_gen_addi_i32(dest, dest, im);
gen_update_cc_add(dest, tcg_const_i32(im));
- gen_helper_xflag_lt(QREG_CC_X, dest, tcg_const_i32(im));
+ tcg_gen_setcond_i32(TCG_COND_LTU, QREG_CC_X, dest, tcg_const_i32(im));
set_cc_op(s, CC_OP_ADD);
break;
case 5: /* eori */
@@ -1456,7 +1456,7 @@ DISAS_INSN(neg)
tcg_gen_neg_i32(reg, src1);
set_cc_op(s, CC_OP_SUB);
gen_update_cc_add(reg, src1);
- gen_helper_xflag_lt(QREG_CC_X, tcg_const_i32(0), src1);
+ tcg_gen_setcond_i32(TCG_COND_LTU, QREG_CC_X, tcg_const_i32(0), src1);
set_cc_op(s, CC_OP_SUB);
}
@@ -1696,12 +1696,12 @@ DISAS_INSN(addsubq)
} else {
src2 = tcg_const_i32(val);
if (insn & 0x0100) {
- gen_helper_xflag_lt(QREG_CC_X, dest, src2);
+ tcg_gen_setcond_i32(TCG_COND_LTU, QREG_CC_X, dest, src2);
tcg_gen_subi_i32(dest, dest, val);
set_cc_op(s, CC_OP_SUB);
} else {
tcg_gen_addi_i32(dest, dest, val);
- gen_helper_xflag_lt(QREG_CC_X, dest, src2);
+ tcg_gen_setcond_i32(TCG_COND_LTU, QREG_CC_X, dest, src2);
set_cc_op(s, CC_OP_ADD);
}
gen_update_cc_add(dest, src2);
--
2.4.3
next prev parent reply other threads:[~2015-08-14 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 14:59 [Qemu-devel] [PATCH 00/11] Proposed format for m68k flags Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 01/11] target-m68k: Print flags properly Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 02/11] target-m68k: Some fixes to SR and flags management Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of cc_x Richard Henderson
2015-08-14 17:04 ` Andreas Schwab
2015-08-14 23:10 ` Richard Henderson
2015-08-15 6:25 ` Andreas Schwab
2015-08-14 14:59 ` Richard Henderson [this message]
2015-08-14 14:59 ` [Qemu-devel] [PATCH 05/11] target-m68k: Reorg flags handling Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 06/11] target-m68k: Introduce DisasCompare Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 07/11] target-m68k: Use setcond for scc Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 08/11] target-m68k: Optimize some comparisons Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 09/11] target-m68k: Optimize gen_flush_flags Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 10/11] target-m68k: Inline shifts Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 11/11] target-m68k: Inline addx, subx, negx Richard Henderson
2015-08-14 15:37 ` [Qemu-devel] [PATCH 00/11] Proposed format for m68k flags Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439564366-11633-5-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=gerg@uclinux.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).