qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, schwab@linux-m68k.org,
	laurent@vivier.eu, gerg@uclinux.org
Subject: [Qemu-devel] [PATCH 07/11] target-m68k: Use setcond for scc
Date: Fri, 14 Aug 2015 07:59:22 -0700	[thread overview]
Message-ID: <1439564366-11633-8-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1439564366-11633-1-git-send-email-rth@twiddle.net>

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-m68k/translate.c | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/target-m68k/translate.c b/target-m68k/translate.c
index ce48e2a..28c3e1e 100644
--- a/target-m68k/translate.c
+++ b/target-m68k/translate.c
@@ -886,19 +886,21 @@ static void gen_jmpcc(DisasContext *s, int cond, TCGLabel *l1)
 
 DISAS_INSN(scc)
 {
-    TCGLabel *l1;
+    DisasCompare c;
     int cond;
-    TCGv reg;
+    TCGv reg, tmp;
 
-    l1 = gen_new_label();
     cond = (insn >> 8) & 0xf;
+    gen_cc_cond(&c, s, cond);
+
+    tmp = tcg_temp_new();
+    tcg_gen_setcond_i32(c.tcond, tmp, c.v1, c.v2);
+    free_cond(&c);
+
     reg = DREG(insn, 0);
-    tcg_gen_andi_i32(reg, reg, 0xffffff00);
-    /* This is safe because we modify the reg directly, with no other values
-       live.  */
-    gen_jmpcc(s, cond ^ 1, l1);
-    tcg_gen_ori_i32(reg, reg, 0xff);
-    gen_set_label(l1);
+    tcg_gen_neg_i32(tmp, tmp);
+    tcg_gen_deposit_i32(reg, reg, tmp, 0, 8);
+    tcg_temp_free(tmp);
 }
 
 /* Force a TB lookup after an instruction that changes the CPU state.  */
-- 
2.4.3

  parent reply	other threads:[~2015-08-14 15:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 14:59 [Qemu-devel] [PATCH 00/11] Proposed format for m68k flags Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 01/11] target-m68k: Print flags properly Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 02/11] target-m68k: Some fixes to SR and flags management Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of cc_x Richard Henderson
2015-08-14 17:04   ` Andreas Schwab
2015-08-14 23:10     ` Richard Henderson
2015-08-15  6:25       ` Andreas Schwab
2015-08-14 14:59 ` [Qemu-devel] [PATCH 04/11] target-m68k: Replace helper_xflag_lt with setcond Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 05/11] target-m68k: Reorg flags handling Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 06/11] target-m68k: Introduce DisasCompare Richard Henderson
2015-08-14 14:59 ` Richard Henderson [this message]
2015-08-14 14:59 ` [Qemu-devel] [PATCH 08/11] target-m68k: Optimize some comparisons Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 09/11] target-m68k: Optimize gen_flush_flags Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 10/11] target-m68k: Inline shifts Richard Henderson
2015-08-14 14:59 ` [Qemu-devel] [PATCH 11/11] target-m68k: Inline addx, subx, negx Richard Henderson
2015-08-14 15:37 ` [Qemu-devel] [PATCH 00/11] Proposed format for m68k flags Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439564366-11633-8-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=gerg@uclinux.org \
    --cc=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).