From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 07/17] tcg: don't abuse TCG type in tcg_gen_trunc_shr_i64_i32
Date: Mon, 17 Aug 2015 12:38:30 -0700 [thread overview]
Message-ID: <1439840320-20897-8-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1439840320-20897-1-git-send-email-rth@twiddle.net>
From: Aurelien Jarno <aurelien@aurel32.net>
The tcg_gen_trunc_shr_i64_i32 function takes a 64-bit argument and
returns a 32-bit value. Directly call tcg_gen_op3 with the correct
types instead of calling tcg_gen_op3i_i32 and abusing the TCG types.
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
tcg/tcg-op.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
index 61b64db..0e79fd1 100644
--- a/tcg/tcg-op.c
+++ b/tcg/tcg-op.c
@@ -1752,8 +1752,8 @@ void tcg_gen_trunc_shr_i64_i32(TCGv_i32 ret, TCGv_i64 arg, unsigned count)
tcg_temp_free_i64(t);
}
} else if (TCG_TARGET_HAS_trunc_shr_i64_i32) {
- tcg_gen_op3i_i32(INDEX_op_trunc_shr_i64_i32, ret,
- MAKE_TCGV_I32(GET_TCGV_I64(arg)), count);
+ tcg_gen_op3(&tcg_ctx, INDEX_op_trunc_shr_i64_i32,
+ GET_TCGV_I32(ret), GET_TCGV_I64(arg), count);
} else if (count == 0) {
tcg_gen_mov_i32(ret, MAKE_TCGV_I32(GET_TCGV_I64(arg)));
} else {
--
2.4.3
next prev parent reply other threads:[~2015-08-17 19:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 19:38 [Qemu-devel] [PATCH 00/17] queued tcg improvements Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 01/17] tcg/optimize: fix constant signedness Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 02/17] tcg/optimize: optimize temps tracking Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 03/17] tcg/optimize: add temp_is_const and temp_is_copy functions Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 04/17] tcg/optimize: track const/copy status separately Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 05/17] tcg/optimize: allow constant to have copies Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 06/17] tcg: rename trunc_shr_i32 into trunc_shr_i64_i32 Richard Henderson
2015-08-17 19:38 ` Richard Henderson [this message]
2015-08-17 19:38 ` [Qemu-devel] [PATCH 08/17] tcg: implement real ext_i32_i64 and extu_i32_i64 ops Richard Henderson
2015-08-17 19:51 ` Claudio Fontana
2015-08-17 19:38 ` [Qemu-devel] [PATCH 09/17] tcg/optimize: add optimizations for " Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 10/17] tcg/optimize: do not remember garbage high bits for 32-bit ops Richard Henderson
2015-08-18 8:35 ` Aurelien Jarno
2015-08-17 19:38 ` [Qemu-devel] [PATCH 11/17] tcg: update README about size changing ops Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 12/17] tcg: Split trunc_shr_i32 opcode into extr[lh]_i64_i32 Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 14/17] tcg/i386: use softmmu fast path for unaligned accesses Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 15/17] tcg/ppc: Improve unaligned load/store handling on 64-bit backend Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 16/17] tcg/s390: Use softmmu fast path for unaligned accesses Richard Henderson
2015-08-17 19:38 ` [Qemu-devel] [PATCH 17/17] tcg/aarch64: " Richard Henderson
2015-08-17 20:06 ` [Qemu-devel] [PATCH 00/17] queued tcg improvements Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439840320-20897-8-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).