From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, sw@weilnetz.de,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
rth@twiddle.net
Subject: [Qemu-devel] [PATCH] exec-all: Translate TCI return addresses backwards too
Date: Mon, 17 Aug 2015 20:28:18 -0700 [thread overview]
Message-ID: <1439868498-2740-1-git-send-email-crosthwaite.peter@gmail.com> (raw)
This subtraction of return addresses applies directly to TCI as well as
host-TCG. This fixes Linux boots for at least Microblaze, CRIS, ARM and
SH4 when using TCI.
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---
Changed since v1:
Wrote commit message.
---
include/exec/exec-all.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index a6fce04..31c2405 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -308,11 +308,7 @@ extern uintptr_t tci_tb_ptr;
to indicate the compressed mode; subtracting two works around that. It
is also the case that there are no host isas that contain a call insn
smaller than 4 bytes, so we don't worry about special-casing this. */
-#if defined(CONFIG_TCG_INTERPRETER)
-# define GETPC_ADJ 0
-#else
# define GETPC_ADJ 2
-#endif
#define GETPC() (GETRA() - GETPC_ADJ)
--
1.9.1
next reply other threads:[~2015-08-18 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 3:28 Peter Crosthwaite [this message]
2015-08-18 15:08 ` [Qemu-devel] [PATCH] exec-all: Translate TCI return addresses backwards too Paolo Bonzini
2015-08-18 20:05 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439868498-2740-1-git-send-email-crosthwaite.peter@gmail.com \
--to=crosthwaitepeter@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).