From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRfQE-0003If-9v for qemu-devel@nongnu.org; Tue, 18 Aug 2015 07:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRfQA-0001Qp-8A for qemu-devel@nongnu.org; Tue, 18 Aug 2015 07:51:18 -0400 Received: from stormwind.0x539.de ([188.40.127.183]:53918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRfQA-0001IJ-1S for qemu-devel@nongnu.org; Tue, 18 Aug 2015 07:51:14 -0400 Received: from hub.kern.lc ([91.143.80.43]) by stormwind.0x539.de with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1ZRfQ0-00069j-RQ for qemu-devel@nongnu.org; Tue, 18 Aug 2015 13:51:04 +0200 From: Philipp Kern Date: Tue, 18 Aug 2015 13:50:55 +0200 Message-Id: <1439898655-6275-1-git-send-email-phil@philkern.de> In-Reply-To: <1439897731-3645-1-git-send-email-phil@philkern.de> References: <1439897731-3645-1-git-send-email-phil@philkern.de> Subject: [Qemu-devel] [PATCH] target-s390x: Mask the SIGP order_code to 8bit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Philipp Kern According to "CPU Signaling and Response", "Signal-Processor Orders", the order field is bit position 56-63. Without this, the Linux guest kernel is sometimes unable to stop emulation and enters an infinite loop of "XXX unknown sigp: 0xffffffff00000005". Signed-off-by: Philipp Kern --- target-s390x/misc_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c index 8eac0e1..0f0907c 100644 --- a/target-s390x/misc_helper.c +++ b/target-s390x/misc_helper.c @@ -500,7 +500,7 @@ uint32_t HELPER(sigp)(CPUS390XState *env, uint64_t order_code, uint32_t r1, /* Remember: Use "R1 or R1 + 1, whichever is the odd-numbered register" as parameter (input). Status (output) is always R1. */ - switch (order_code) { + switch (order_code & 0xff) { case SIGP_SET_ARCH: /* switch arch */ break; -- 2.1.4