From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRlNw-00039A-PJ for qemu-devel@nongnu.org; Tue, 18 Aug 2015 14:13:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRlNv-0000TD-RV for qemu-devel@nongnu.org; Tue, 18 Aug 2015 14:13:20 -0400 Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]:35902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRlNv-0000Su-Nx for qemu-devel@nongnu.org; Tue, 18 Aug 2015 14:13:19 -0400 Received: by qgeb6 with SMTP id b6so5186925qge.3 for ; Tue, 18 Aug 2015 11:13:19 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Tue, 18 Aug 2015 11:12:44 -0700 Message-Id: <1439921564-25597-4-git-send-email-rth@twiddle.net> In-Reply-To: <1439921564-25597-1-git-send-email-rth@twiddle.net> References: <1439921564-25597-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL 3/3] target-alpha: Inline hw_ret List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target-alpha/helper.h | 2 -- target-alpha/sys_helper.c | 8 -------- target-alpha/translate.c | 15 ++++++++++----- 3 files changed, 10 insertions(+), 15 deletions(-) diff --git a/target-alpha/helper.h b/target-alpha/helper.h index e7f0450..42bb247 100644 --- a/target-alpha/helper.h +++ b/target-alpha/helper.h @@ -91,8 +91,6 @@ DEF_HELPER_FLAGS_2(ieee_input_cmp, TCG_CALL_NO_WG, void, env, i64) DEF_HELPER_FLAGS_2(ieee_input_s, TCG_CALL_NO_WG, void, env, i64) #if !defined (CONFIG_USER_ONLY) -DEF_HELPER_2(hw_ret, void, env, i64) - DEF_HELPER_2(ldl_phys, i64, env, i64) DEF_HELPER_2(ldq_phys, i64, env, i64) DEF_HELPER_2(ldl_l_phys, i64, env, i64) diff --git a/target-alpha/sys_helper.c b/target-alpha/sys_helper.c index 380d6e4..1f0e1a9 100644 --- a/target-alpha/sys_helper.c +++ b/target-alpha/sys_helper.c @@ -40,14 +40,6 @@ uint64_t helper_load_pcc(CPUAlphaState *env) /* PALcode support special instructions */ #ifndef CONFIG_USER_ONLY -void helper_hw_ret(CPUAlphaState *env, uint64_t a) -{ - env->pc = a & ~3; - env->intr_flag = 0; - env->lock_addr = -1; - env->pal_mode = a & 1; -} - void helper_tbia(CPUAlphaState *env) { tlb_flush(CPU(alpha_env_get_cpu(env)), 1); diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 01e7f35..2849ede 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -2635,13 +2635,18 @@ static ExitStatus translate_one(DisasContext *ctx, uint32_t insn) /* Pre-EV6 CPUs interpreted this as HW_REI, loading the return address from EXC_ADDR. This turns out to be useful for our emulation PALcode, so continue to accept it. */ - tmp = tcg_temp_new(); - tcg_gen_ld_i64(tmp, cpu_env, offsetof(CPUAlphaState, exc_addr)); - gen_helper_hw_ret(cpu_env, tmp); - tcg_temp_free(tmp); + ctx->lit = vb = tcg_temp_new(); + tcg_gen_ld_i64(vb, cpu_env, offsetof(CPUAlphaState, exc_addr)); } else { - gen_helper_hw_ret(cpu_env, load_gpr(ctx, rb)); + vb = load_gpr(ctx, rb); } + tmp = tcg_temp_new(); + tcg_gen_movi_i64(tmp, 0); + tcg_gen_st8_i64(tmp, cpu_env, offsetof(CPUAlphaState, intr_flag)); + tcg_gen_movi_i64(cpu_lock_addr, -1); + tcg_gen_andi_i64(tmp, vb, 1); + tcg_gen_st8_i64(tmp, cpu_env, offsetof(CPUAlphaState, pal_mode)); + tcg_gen_andi_i64(cpu_pc, vb, ~3); ret = EXIT_PC_UPDATED; break; #else -- 2.4.3