qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.a@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 5/7] pc: Use DEFINE_MACHINE to implement DEFINE_PC_MACHINE
Date: Tue, 18 Aug 2015 12:08:52 -0700	[thread overview]
Message-ID: <1439924934-30491-6-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1439924934-30491-1-git-send-email-ehabkost@redhat.com>

DEFINE_PC_MACHINE should be eventually replaced by DEFINE_MACHINE, we
just need to eliminate the pc_compat_*() functions first.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/hw/i386/pc.h | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index d0cad87..dc22608 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -694,23 +694,12 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
         },
 
 #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \
-    static void pc_machine_##suffix##_class_init(ObjectClass *oc, void *data) \
+    static void pc_machine_##suffix##_class_init(MachineClass *mc) \
     { \
-        MachineClass *mc = MACHINE_CLASS(oc); \
         optsfn(mc); \
-        mc->name = namestr; \
         mc->init = initfn; \
     } \
-    static const TypeInfo pc_machine_type_##suffix = { \
-        .name       = namestr TYPE_MACHINE_SUFFIX, \
-        .parent     = TYPE_PC_MACHINE, \
-        .class_init = pc_machine_##suffix##_class_init, \
-    }; \
-    static void pc_machine_init_##suffix(void) \
-    { \
-        type_register(&pc_machine_type_##suffix); \
-    } \
-    machine_init(pc_machine_init_##suffix)
+    DEFINE_MACHINE(namestr, pc_machine_##suffix##_class_init)
 
 #define SET_MACHINE_COMPAT(m, COMPAT) do { \
     static GlobalProperty props[] = { \
-- 
2.1.0

  parent reply	other threads:[~2015-08-18 19:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 19:08 [Qemu-devel] [PATCH 0/7] machine registration: Use QOM, eliminate QEMUMachine Eduardo Habkost
2015-08-18 19:08 ` [Qemu-devel] [PATCH 1/7] exynos4: Use EXYNOS4210_NCPUS instead of max_cpus on error message Eduardo Habkost
2015-08-18 19:08 ` [Qemu-devel] [PATCH 2/7] exynos4: Use MachineClass instead of exynos4_machines array Eduardo Habkost
2015-08-18 19:08 ` [Qemu-devel] [PATCH 3/7] exynos4: Declare each QEMUMachine as a separate variable Eduardo Habkost
2015-08-18 19:08 ` [Qemu-devel] [PATCH 4/7] machine: DEFINE_MACHINE macro Eduardo Habkost
2015-08-20 21:14   ` Eduardo Habkost
2015-08-18 19:08 ` Eduardo Habkost [this message]
2015-08-19 23:28   ` [Qemu-devel] [PATCH 5/7] pc: Use DEFINE_MACHINE to implement DEFINE_PC_MACHINE Eduardo Habkost
2015-08-18 19:08 ` [Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines Eduardo Habkost
2015-08-18 19:54   ` Eduardo Habkost
2015-08-18 20:06   ` Eduardo Habkost
2015-08-18 21:43     ` [Qemu-devel] [PATCH v2 " Eduardo Habkost
2015-08-19  8:25       ` Michael Walle
2015-08-21 22:43         ` Eduardo Habkost
2015-08-18 19:08 ` [Qemu-devel] [PATCH 7/7] machine: Eliminate QEMUMachine and qemu_register_machine() Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439924934-30491-6-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).