From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRxJU-0001m0-G2 for qemu-devel@nongnu.org; Wed, 19 Aug 2015 02:57:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRxJQ-0002Qx-Ar for qemu-devel@nongnu.org; Wed, 19 Aug 2015 02:57:32 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:43624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRxJP-0002Qh-Mw for qemu-devel@nongnu.org; Wed, 19 Aug 2015 02:57:28 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Aug 2015 16:57:25 +1000 From: Bharata B Rao Date: Wed, 19 Aug 2015 12:26:10 +0530 Message-Id: <1439967371-15870-3-git-send-email-bharata@linux.vnet.ibm.com> In-Reply-To: <1439967371-15870-1-git-send-email-bharata@linux.vnet.ibm.com> References: <1439967371-15870-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: [Qemu-devel] [RFC PATCH v0 2/3] spapr-rtas: Enable rtas_set_indicator() to return correct error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Bharata B Rao , mdroth@linux.vnet.ibm.com, agraf@suse.de, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, imammedo@redhat.com, david@gibson.dropbear.id.au drck->set_isolation_state() can return error. For such a case ensure correct error is returned by rtas_set_indicator() instead of always returning success. TODO: rtas_st(, , uint32 val) => the return value uint32, but drck->set_[allocation/indicator/isolation]_state() is returning int. Should we change this return value to uint32_t to match with rtas_st() argument ? Signed-off-by: Bharata B Rao --- hw/ppc/spapr_rtas.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index e99e25f..96729b4 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -374,6 +374,7 @@ static void rtas_set_indicator(PowerPCCPU *cpu, sPAPRMachineState *spapr, uint32_t sensor_state; sPAPRDRConnector *drc; sPAPRDRConnectorClass *drck; + int ret; if (nargs != 3 || nret != 1) { rtas_st(rets, 0, RTAS_OUT_PARAM_ERROR); @@ -413,19 +414,19 @@ static void rtas_set_indicator(PowerPCCPU *cpu, sPAPRMachineState *spapr, spapr_ccs_remove(spapr, ccs); } } - drck->set_isolation_state(drc, sensor_state); + ret = drck->set_isolation_state(drc, sensor_state); break; case RTAS_SENSOR_TYPE_DR: - drck->set_indicator_state(drc, sensor_state); + ret = drck->set_indicator_state(drc, sensor_state); break; case RTAS_SENSOR_TYPE_ALLOCATION_STATE: - drck->set_allocation_state(drc, sensor_state); + ret = drck->set_allocation_state(drc, sensor_state); break; default: goto out_unimplemented; } - rtas_st(rets, 0, RTAS_OUT_SUCCESS); + rtas_st(rets, 0, ret); return; out_unimplemented: -- 2.1.0