From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, stefanha@gmail.com, Peter Lieven <pl@kamp.de>,
jsnow@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] ide/atapi: partially avoid deadlock if the storage backend is dead
Date: Thu, 20 Aug 2015 10:14:06 +0200 [thread overview]
Message-ID: <1440058448-27847-1-git-send-email-pl@kamp.de> (raw)
the blk_drain_all() that is executed if the guest issues a DMA cancel
leads to a stuck main loop if the storage backend (e.g. a NFS share)
is unresponsive.
This scenario is a common case for CDROM images mounted from an
NFS share. In this case a broken NFS server can take down the
whole VM even if the mounted CDROM is not used and was just not
unmounted after usage.
This approach avoids the blk_drain_all for read-only media and
cancelles the AIO locally and makes the callback a NOP if the
original request is completed after the NFS share is responsive
again.
Peter Lieven (2):
block/io: allow AIOCB without callback
ide/atapi: partially avoid deadlock if the storage backend is dead
block/io.c | 8 ++++++--
hw/ide/pci.c | 32 ++++++++++++++++++--------------
2 files changed, 24 insertions(+), 16 deletions(-)
--
1.9.1
next reply other threads:[~2015-08-20 8:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 8:14 Peter Lieven [this message]
2015-08-20 8:14 ` [Qemu-devel] [PATCH 1/2] block/io: allow AIOCB without callback Peter Lieven
2015-08-21 6:12 ` Eric Blake
2015-08-31 8:38 ` Peter Lieven
2015-08-20 8:14 ` [Qemu-devel] [PATCH 2/2] ide/atapi: partially avoid deadlock if the storage backend is dead Peter Lieven
2015-08-21 6:13 ` Eric Blake
2015-09-03 16:59 ` Stefan Hajnoczi
2015-09-06 9:24 ` Peter Lieven
2015-09-07 13:43 ` Stefan Hajnoczi
2015-09-07 14:05 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440058448-27847-1-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).