qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cormac O'Brien <cormac@c-obrien.org>
To: agraf@suse.de, mark.cave-ayland@ilande.co.uk,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: [Qemu-devel] [PATCH 1/4] PPC: Allow Rc bit to be set on mtspr
Date: Sat, 22 Aug 2015 10:32:10 -0500	[thread overview]
Message-ID: <1440257533-1504-2-git-send-email-cormac@c-obrien.org> (raw)
In-Reply-To: <1440257533-1504-1-git-send-email-cormac@c-obrien.org>

From: Alexander Graf <agraf@suse.de>

According to the ISA setting the Rc bit on mtspr is undefined behavior.
Real 750 hardware simply ignores the bit and doesn't touch cr0 though.

Unfortunately, Mac OS 9 relies on this fact and executes a few mtspr
instructions (to set XER for example) with Rc set.

So let's handle the bit the same way hardware does and ignore it.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 target-ppc/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 84c5cea..fc3251e 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -9884,7 +9884,7 @@ GEN_HANDLER(mtcrf, 0x1F, 0x10, 0x04, 0x00000801, PPC_MISC),
 GEN_HANDLER(mtmsrd, 0x1F, 0x12, 0x05, 0x001EF801, PPC_64B),
 #endif
 GEN_HANDLER(mtmsr, 0x1F, 0x12, 0x04, 0x001FF801, PPC_MISC),
-GEN_HANDLER(mtspr, 0x1F, 0x13, 0x0E, 0x00000001, PPC_MISC),
+GEN_HANDLER(mtspr, 0x1F, 0x13, 0x0E, 0x00000000, PPC_MISC),
 GEN_HANDLER(dcbf, 0x1F, 0x16, 0x02, 0x03C00001, PPC_CACHE),
 GEN_HANDLER(dcbi, 0x1F, 0x16, 0x0E, 0x03E00001, PPC_CACHE),
 GEN_HANDLER(dcbst, 0x1F, 0x16, 0x01, 0x03E00001, PPC_CACHE),
-- 
2.5.0

  reply	other threads:[~2015-08-22 15:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22 15:32 [Qemu-devel] [PATCH RFC 0/4] Mac OS 9 compatibility improvements Cormac O'Brien
2015-08-22 15:32 ` Cormac O'Brien [this message]
2015-08-22 15:32 ` [Qemu-devel] [PATCH 2/4] PPC: Fix lsxw bounds checks Cormac O'Brien
2015-08-22 15:32 ` [Qemu-devel] [PATCH 3/4] PPC: mac99: Always add USB controller Cormac O'Brien
2015-08-22 15:32 ` [Qemu-devel] [PATCH RFC 4/4] PPC: fix CUDA packet header size Cormac O'Brien
2015-08-23 13:03   ` Mark Cave-Ayland
2015-08-23 12:31 ` [Qemu-devel] [PATCH RFC 0/4] Mac OS 9 compatibility improvements Mark Cave-Ayland
2015-09-11  5:27   ` [Qemu-devel] [Qemu-ppc] " Stewart Smith
2015-08-24  5:05 ` [Qemu-devel] " Alexander Graf
2015-08-24  5:20 ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440257533-1504-2-git-send-email-cormac@c-obrien.org \
    --to=cormac@c-obrien.org \
    --cc=agraf@suse.de \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).