From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTfZ2-0006uQ-QV for qemu-devel@nongnu.org; Sun, 23 Aug 2015 20:24:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTfZ0-0000fL-2K for qemu-devel@nongnu.org; Sun, 23 Aug 2015 20:24:40 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:58176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTfYz-0000fB-Vj for qemu-devel@nongnu.org; Sun, 23 Aug 2015 20:24:38 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D9E1D20869 for ; Sun, 23 Aug 2015 20:24:37 -0400 (EDT) From: "Emilio G. Cota" Date: Sun, 23 Aug 2015 20:23:37 -0400 Message-Id: <1440375847-17603-9-git-send-email-cota@braap.org> In-Reply-To: <1440375847-17603-1-git-send-email-cota@braap.org> References: <1440375847-17603-1-git-send-email-cota@braap.org> Subject: [Qemu-devel] [RFC 08/38] rcu: init rcu_registry_lock after fork List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mttcg@listserver.greensocs.com Cc: mark.burton@greensocs.com, a.rigo@virtualopensystems.com, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, alex.bennee@linaro.org, Frederic Konrad We were unlocking this lock after fork, which is wrong since only the thread that holds a mutex is allowed to unlock it. Signed-off-by: Emilio G. Cota --- util/rcu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/rcu.c b/util/rcu.c index 8ba304d..47c2bce 100644 --- a/util/rcu.c +++ b/util/rcu.c @@ -335,6 +335,11 @@ static void rcu_init_unlock(void) qemu_mutex_unlock(&rcu_registry_lock); qemu_mutex_unlock(&rcu_sync_lock); } + +static void rcu_init_child(void) +{ + qemu_mutex_init(&rcu_registry_lock); +} #endif void rcu_after_fork(void) @@ -346,7 +351,7 @@ void rcu_after_fork(void) static void __attribute__((__constructor__)) rcu_init(void) { #ifdef CONFIG_POSIX - pthread_atfork(rcu_init_lock, rcu_init_unlock, rcu_init_unlock); + pthread_atfork(rcu_init_lock, rcu_init_unlock, rcu_init_child); #endif rcu_init_complete(); } -- 1.9.1