* [Qemu-devel] [RFC 0/4] AMD IOMMU
@ 2015-08-24 23:19 David Kiarie
2015-08-24 23:19 ` [Qemu-devel] [RFC 1/4] hw/core: Prepare for introducing " David Kiarie
` (3 more replies)
0 siblings, 4 replies; 22+ messages in thread
From: David Kiarie @ 2015-08-24 23:19 UTC (permalink / raw)
To: qemu-devel; +Cc: valentine.sinitsyn, jan.kiszka, David Kiarie, mst
This series implements basic AMD IOMMU emulation to Qemu
AMD IOMMU emulation.
-This series emulates AMD IOMMU on qemu. It implements the following features
-Translation - 4K pages
-Event logging - particulary fault logging.
-AMD IOMMU, being a convectional PCI device doesn't rely on any other technology from AMD and hence you can test this patch on l2 guest emulated on an Intel PC.
-These patches have been tested using the 'ac97' sound device with QEMU_AUDIO_DRV=alsa and proven to work.
Testing - pretty basic stuff...
On host
#kvm_amd is loaded with nested support by default by anyways :)
-$modprobe -r kvm_amd
$modprobe kvm_amd nested=1
$command to start guest with 'iommu=1' kernel arguments
On the guest
$dmesg | AMD-Vi
AMD-Vi: Enabling IOMMU at 0000:00:00.2 cap 0x40
AMD-Vi: Lazy IO/TLB flushing enabled
$modprobe kvm_amd
$modprobe pci_stub
$lspci -n
01:00.0 0200: 8086:10b9 (rev 06)
$echo "8086 10b9" > /sys/bus/pci/drivers/pci-stub/new_id
$echo 0000:01:00.0 > /sys/bus/pci/devices/0000:01:00.0/driver/unbind
$echo 0000:01:00.0 > /sys/bus/pci/drivers/pci-stub/bind
Assign the device
$/usr/local/bin/qemu-system-x86_64 -m 512 -boot c -net none -hda /root/ia32e_rhel5u1.img -device pci-assign,host=01:00.0
I guess that's all there is to say. Please test!
asla.
David (4):
hw/core: Prepare for introducing AMD IOMMU
hw/i386: Introduce AMD IOMMU
hw/i386: Introduce IVRS for AMD IOMMU
hw/pci-host: Add AMD IOMMU emulation to q35 and PIIX
hw/core/machine.c | 25 ++
hw/i386/Makefile.objs | 1 +
hw/i386/acpi-build.c | 85 ++++
hw/i386/amd_iommu.c | 993 ++++++++++++++++++++++++++++++++++++++++++++
hw/i386/amd_iommu.h | 298 +++++++++++++
hw/pci-host/piix.c | 11 +
hw/pci-host/q35.c | 11 +
include/hw/acpi/acpi-defs.h | 55 +++
include/hw/boards.h | 2 +
9 files changed, 1481 insertions(+)
create mode 100644 hw/i386/amd_iommu.c
create mode 100644 hw/i386/amd_iommu.h
--
2.1.4
^ permalink raw reply [flat|nested] 22+ messages in thread* [Qemu-devel] [RFC 1/4] hw/core: Prepare for introducing AMD IOMMU 2015-08-24 23:19 [Qemu-devel] [RFC 0/4] AMD IOMMU David Kiarie @ 2015-08-24 23:19 ` David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 2/4] hw/i386: Introduce " David Kiarie ` (2 subsequent siblings) 3 siblings, 0 replies; 22+ messages in thread From: David Kiarie @ 2015-08-24 23:19 UTC (permalink / raw) To: qemu-devel; +Cc: valentine.sinitsyn, jan.kiszka, David, mst From: David <davidkiarie4@gmail.com> Add AMD IOMMU as one of the devices that can possibly be emulated by Qemu. Also, add some helper functions for manipulating presence/absence of IOMMU Signed-off-by: David Kiarie <davidkiarie4@gmail.com> --- hw/core/machine.c | 25 +++++++++++++++++++++++++ include/hw/boards.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index ac4654e..b326a80 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -255,6 +255,20 @@ static void machine_set_iommu(Object *obj, bool value, Error **errp) ms->iommu = value; } +static bool machine_get_amd_iommu(Object *obj, Error **errp) +{ + MachineState *ms = MACHINE(obj); + + return ms->amd_iommu; +} + +static void machine_set_amd_iommu(Object *obj, bool value, Error **errp) +{ + MachineState *ms = MACHINE(obj); + + ms->amd_iommu = value; +} + static void machine_set_suppress_vmdesc(Object *obj, bool value, Error **errp) { MachineState *ms = MACHINE(obj); @@ -400,6 +414,12 @@ static void machine_initfn(Object *obj) object_property_set_description(obj, "iommu", "Set on/off to enable/disable Intel IOMMU (VT-d)", NULL); + object_property_add_bool(obj, "amd-iommu", + machine_get_amd_iommu, + machine_set_amd_iommu, NULL); + object_property_set_description(obj, "amd-iommu", + "Set on/off to enable/disable AMD-Vi", + NULL); object_property_add_bool(obj, "suppress-vmdesc", machine_get_suppress_vmdesc, machine_set_suppress_vmdesc, NULL); @@ -436,6 +456,11 @@ bool machine_iommu(MachineState *machine) return machine->iommu; } +bool machine_amd_iommu(MachineState *machine) +{ + return machine->amd_iommu; +} + bool machine_kernel_irqchip_allowed(MachineState *machine) { return machine->kernel_irqchip_allowed; diff --git a/include/hw/boards.h b/include/hw/boards.h index 3f84afd..88324b2 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -54,6 +54,7 @@ extern MachineState *current_machine; bool machine_usb(MachineState *machine); bool machine_iommu(MachineState *machine); +bool machine_amd_iommu(MachineState *machine); bool machine_kernel_irqchip_allowed(MachineState *machine); bool machine_kernel_irqchip_required(MachineState *machine); int machine_kvm_shadow_mem(MachineState *machine); @@ -139,6 +140,7 @@ struct MachineState { bool usb_disabled; char *firmware; bool iommu; + bool amd_iommu; bool suppress_vmdesc; ram_addr_t ram_size; -- 2.1.4 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-08-24 23:19 [Qemu-devel] [RFC 0/4] AMD IOMMU David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 1/4] hw/core: Prepare for introducing " David Kiarie @ 2015-08-24 23:19 ` David Kiarie 2015-08-25 6:39 ` Valentine Sinitsyn 2015-09-07 12:46 ` Valentine Sinitsyn 2015-08-24 23:19 ` [Qemu-devel] [RFC 3/4] hw/i386: Introduce IVRS for " David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 4/4] hw/pci-host: Add AMD IOMMU emulation to q35 and PIIX David Kiarie 3 siblings, 2 replies; 22+ messages in thread From: David Kiarie @ 2015-08-24 23:19 UTC (permalink / raw) To: qemu-devel; +Cc: valentine.sinitsyn, jan.kiszka, David, mst From: David <davidkiarie4@gmail.com> Add AMD IOMMU emulation to Qemu. This is a very basic AMD IOMMU emulation that only does translation and some basic Event logging. Guest translation enables nested PCI passthrough Signed-off-by: David Kiarie <davidkiarie4@gmail.com> --- hw/i386/Makefile.objs | 1 + hw/i386/amd_iommu.c | 993 ++++++++++++++++++++++++++++++++++++++++++++++++++ hw/i386/amd_iommu.h | 298 +++++++++++++++ 3 files changed, 1292 insertions(+) create mode 100644 hw/i386/amd_iommu.c create mode 100644 hw/i386/amd_iommu.h diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs index ebd1015..2bae11c 100644 --- a/hw/i386/Makefile.objs +++ b/hw/i386/Makefile.objs @@ -3,6 +3,7 @@ obj-y += multiboot.o obj-y += pc.o pc_piix.o pc_q35.o obj-y += pc_sysfw.o obj-y += intel_iommu.o +obj-y += amd_iommu.o obj-$(CONFIG_XEN) += ../xenpv/ xen/ obj-y += kvmvapic.o diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c new file mode 100644 index 0000000..a3a0b20 --- /dev/null +++ b/hw/i386/amd_iommu.c @@ -0,0 +1,993 @@ +/* + * QEMU emulation of an AMD IOMMU (AMD-Vi) + * + * Copyright (C) 2011 Eduard - Gabriel Munteanu + * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + + * You should have received a copy of the GNU General Public License along + * with this program; if not, see <http://www.gnu.org/licenses/>. + * + */ +#include "hw/i386/amd_iommu.h" + +#define PCI_EXT_CAP_ID_PASID 0x1B +#define PCI_EXT_CAP_ID_PRI 0x13 + +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) +#define PCI_FUNC(devfn) ((devfn) & 0x07) + +#define MAX_VA_ADDR (64UL << 5) +#define MAX_PH_ADDR (48UL << 8) +#define MAX_GVA_ADDR (64UL << 15) + +//#define DEBUG_AMD_IOMMU +#ifdef DEBUG_AMD_IOMMU +enum { + DEBUG_GENERAL, DEBUG_CAPAB, DEBUG_MMIO, DEBUG_ELOG, + DEBUG_CACHE, DEBUG_COMMAND, DEBUG_MMU +}; + +#define IOMMU_DBGBIT(x) (1 << DEBUG_##x) +static int iommu_dbgflags = IOMMU_DBGBIT(GENERAL) | IOMMU_DBGBIT(MMU) | IOMMU_DBGBIT(MMIO); +//| IOMMU_DBGBIT(CAPAB) | IOMMU_DBGBIT(ELOG) | IOMMU_DBGBIT(CACHE) | IOMMU_DBGBIT(COMMAND); + +#define IOMMU_DPRINTF(what, fmt, ...) do { \ + if (iommu_dbgflags & IOMMU_DBGBIT(what)) { \ + fprintf(stderr, "(amd-iommu)%s: " fmt "\n", __func__, \ + ## __VA_ARGS__); } \ + } while (0) +#else +#define IOMMU_DPRINTF(what, fmt, ...) do {} while (0) +#endif + +/* helper functions - FIXME - provide for reading one byte */ +static uint16_t amd_iommu_readw(AMDIOMMUState *s, hwaddr addr) +{ + return lduw_le_p(&s->mmior[addr]); +} + +static uint32_t amd_iommu_readl(AMDIOMMUState *s, hwaddr addr) +{ + return ldl_le_p(&s->mmior[addr]); +} + +static uint64_t amd_iommu_readq(AMDIOMMUState *s, hwaddr addr) +{ + return ldq_le_p(&s->mmior[addr]); +} + +static void amd_iommu_writew(AMDIOMMUState *s, hwaddr addr, uint16_t val) +{ + stw_le_p(&s->mmior[addr], val); +} + +static void amd_iommu_writel(AMDIOMMUState *s, hwaddr addr, uint32_t val) +{ + stl_le_p(&s->mmior[addr], val); +} + +static void amd_iommu_writeq(AMDIOMMUState *s, hwaddr addr, uint64_t val) +{ + stq_le_p(&s->mmior[addr], val); +} + +/* execute a completion wait command */ +static void amd_iommu_completion_wait(AMDIOMMUState *s, uint8_t *cmd) +{ + unsigned int addr; + + /* completion store */ + if(cmd[0] & COM_COMPLETION_STORE_MASK){ + addr = le64_to_cpu(*(uint64_t*)cmd) & COM_STORE_ADDRESS_MASK; + if(dma_memory_write(&address_space_memory, addr, cmd + 8, 8)){ + IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIx64, addr); + } + + } + + /* set completion interrupt */ + if (cmd[0] & COM_COMPLETION_INTR){ + s->mmior[MMIO_STATUS] |= MMIO_STATUS_COMWAIT_INTR; + } +} + +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) +{ + unsigned type; + uint8_t cmd[IOMMU_COMMAND_SIZE]; + + IOMMU_DPRINTF(COMMAND, ""); + memset(cmd, 0, IOMMU_COMMAND_SIZE); + + if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, cmd, IOMMU_COMMAND_SIZE)){ + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at 0x%"PRIx64 + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); + } + + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; + + switch(type){ + case CMD_COMPLETION_WAIT: + /* pretend to wait for command execution to complete */ + IOMMU_DPRINTF(COMMAND, "completion wait requested"); + amd_iommu_completion_wait(s, cmd); + break; + case CMD_INVAL_DEVTAB_ENTRY: + /* Not implemented yet - should just clear device table contents */ + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); + break; + case CMD_INVAL_IOMMU_PAGES: + /* invalidate IOMMU cache for a particular domain */ + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); + break; + case CMD_INVAL_IOTLB_PAGES: + /* Only present if remote IOTLB present */ + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); + break; + case CMD_INVAL_INTR_TABLE: + /* no support for interrupt remapping yet */ + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); + break; + default: + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); + break; + } + +} + +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) +{ + IOMMU_DPRINTF(COMMAND, ""); + + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; + + if(!s->cmdbuf_enabled){ + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); + return; + } + + while(s->cmdbuf_head != s->cmdbuf_tail) { + /* check if there is work to do. */ + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER tail at %x", + s->cmdbuf_head, s->cmdbuf_tail); + amd_iommu_cmdbuf_exec(s); + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; + + /* wrap head pointer */ + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { + s->cmdbuf_head = 0; + } + } + + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); +} + +/* System Software might never read from some of this fields but anyways */ +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned size) +{ + AMDIOMMUState *s = opaque; + + uint64_t val = -1; + if(addr + size > MMIO_SIZE) { + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 + ", got 0x%"PRIx64 " %d", + (uint64_t)MMIO_SIZE, addr, size); + return (uint64_t) - 1; + } + + switch(addr & ~0x07){ + case MMIO_DEVICE_TABLE: + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_COMMAND_BASE: + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_EVENT_BASE: + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_CONTROL: + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_EXCL_BASE: + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_EXCL_LIMIT: + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_COMMAND_HEAD: + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_COMMAND_TAIL: + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_EVENT_HEAD: + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_EVENT_TAIL: + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_STATUS: + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + case MMIO_EXT_FEATURES: + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + if(size == 2){ + val = amd_iommu_readw(s, addr); + } else if(size == 4){ + val = amd_iommu_readl(s, addr); + } + else if(size == 8){ + val = amd_iommu_readq(s, addr); + } + break; + + default: + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 + ", size %d offset 0x%"PRIx64, addr, size, offset); + } + + return val; +} + +static void iommu_handle_control_write(AMDIOMMUState *s) +{ + /* read whatever is already written incase software is writing in chucks less than 8 bytes */ + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); + + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); + s->evtlog_enabled = s->enabled && !!(control & MMIO_CONTROL_EVENTLOGEN); + + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); + s->cmdbuf_enabled = s->enabled && !!(control & MMIO_CONTROL_CMDBUFLEN); + + /* update the flags depending on the control register */ + if(s->cmdbuf_enabled) { + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; + } else { + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; + } + if (s->evtlog_enabled) { + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; + } else { + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; + } + + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); + + amd_iommu_cmdbuf_run(s); +} + +/* FIXME: something might go wrong if System Software writes in chunks + * of one byte but linux writes in chunks of 4 bytes so currently it + * works correctly with linux but will definitely be busted if software + * reads/writes 8 bytes + */ +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) +{ + + AMDIOMMUState *s = opaque; + unsigned long offset = addr & 0x07; + + if(addr + size > MMIO_SIZE) { + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 + ", got 0x%"PRIx64 " %d", + (uint64_t)MMIO_SIZE, addr, size); + return; + } + + switch(addr & ~0x07){ + case MMIO_CONTROL: + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 , addr, size, val, offset); + iommu_handle_control_write(s); + break; + + case MMIO_DEVICE_TABLE: + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + + /* set device table address + * This also suffers from inability to tell whether software is done writing + */ + if(offset || (size == 8)){ + unsigned long device_base = amd_iommu_readq(s, MMIO_DEVICE_TABLE); + s->devtab = (dma_addr_t)(device_base & MMIO_CMDBUF_BASE_MASK); + /* set device table length */ + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + 1) * (MMIO_DEVTAB_SIZE_UNIT / + MMIO_DEVTAB_ENTRY_SIZE); + } + break; + + case MMIO_COMMAND_HEAD: + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; + amd_iommu_cmdbuf_run(s); + break; + + case MMIO_COMMAND_BASE: + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + + /* FIXME - make sure System Software has finished writing incase it writes + * in chucks less than 8 bytes in a robust way.As for now, this hacks works + * for the linux driver + */ + if(offset || (size == 8)){ + unsigned long command_base = amd_iommu_readq(s, MMIO_COMMAND_BASE); + s->cmdbuf = (dma_addr_t)(command_base & MMIO_CMDBUF_BASE_MASK); + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & MMIO_CMDBUF_SIZE_MASK); + s->cmdbuf_head = s->cmdbuf_tail = 0; + } + break; + + case MMIO_COMMAND_TAIL: + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; + amd_iommu_cmdbuf_run(s); + break; + + case MMIO_EVENT_BASE: + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); + s->evtlog_len = 1UL << (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); + break; + + case MMIO_EXCL_LIMIT: + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | MMIO_EXCL_LIMIT_LOW; + break; + //TODO : Event handling fixes + + case MMIO_EVENT_HEAD: + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + break; + + case MMIO_EVENT_TAIL: + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + break; + /* PPR log base - unused for now */ + case MMIO_PPR_BASE: + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + break; + /* PPR log head - also unused for now */ + case MMIO_PPR_HEAD: + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + break; + /* PPR log tail - unused for now */ + case MMIO_PPR_TAIL: + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + if(size == 2){ + amd_iommu_writew(s, addr, val); + } else if(size == 4){ + amd_iommu_writel(s, addr, val); + } else if(size == 8){ + amd_iommu_writeq(s, addr, val); + } + break; + + default: + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); + ; + } + +} + +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) +{ + /* event logging not enabled */ + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | MMIO_STATUS_EVTLOG_OF){ + return; + } + + /* event log buffer full */ + if(s->evtlog_tail >= s->evtlog_len) { + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; + } + + if(dma_memory_write(&address_space_memory, s->evtlog_len + s->evtlog_tail, &evt, EVENT_LEN)){ + //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, s->evtlog + s->evtlog_tail); + } + + s->evtlog_tail += EVENT_LEN; + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; + /* Disable logging if Overflow ? */ +} + +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned domid, dma_addr_t addr, int present, + int is_write) +{ + IOMMU_DPRINTF(ELOG, ""); + + AMDIOMMUEvent evt; + unsigned info; + uint16_t status; + + evt.devfn = cpu_to_le16(devfn); + evt.reserved = 0; + evt.domid = cpu_to_le16(domid); + evt.addr = cpu_to_le16(addr); + + info = EVENT_IOPF; + + if(present) { + info |= EVENT_IOPF_PR; + } + + if (is_write) { + info |= EVENT_IOPF_RW; + } + + /* log a page fault */ + amd_iommu_log_event(s, &evt); + + /* Abort the translation */ + status = pci_get_word(s->dev.config + PCI_STATUS); + pci_set_word(s->dev.config + PCI_STATUS, status | PCI_STATUS_SIG_TARGET_ABORT); +} + +static inline uint64_t amd_iommu_get_perms(uint64_t entry) +{ + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; +} + +/* FIXME deduplication */ +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) +{ + AMDIOMMUState *s = opaque; + AMDIOMMUAddressSpace **iommu_as; + int bus_num = pci_bus_num(bus); + + /* just in case */ + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); + + iommu_as = s->address_spaces[bus_num]; + + /* allocate memory during the first run */ + if(!iommu_as) { + iommu_as = g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); + s->address_spaces[bus_num] = iommu_as; + } + + /* set up IOMMU region */ + if(!iommu_as[devfn]){ + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); + iommu_as[devfn]->bus_num = (uint8_t)bus_num; + iommu_as[devfn]->devfn = (uint8_t)devfn; + iommu_as[devfn]->iommu_state = s; + + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), &s->iommu_ops, "amd-iommu", UINT64_MAX); + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, "amd-iommu"); + } + return &iommu_as[devfn]->as; +} + +/* validate a page table entry */ +static bool amd_iommu_validate_pte(uint64_t pte) +{ + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; +} + +/* get a device table entry given the device function */ +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t *entry) +{ + /* Could lead to out of range accesses */ + assert(0 < devfn && devfn < PCI_DEVFN_MAX); + + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; + if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, 32)){ + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab 0x%"PRIx64 + "offset 0x%"PRIx32, s->devtab, offset); + return false; + } + + if(!amd_iommu_validate_pte(entry[0])){ + IOMMU_DPRINTF(MMU, + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); + return false; + } + + return true; +} + +static uint64_t get_pte_translation_mode(uint64_t pte) +{ + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; + + if(level == 7){ + /* reserved level - abort ? */ + IOMMU_DPRINTF(MMU, + "Reserved translation level (7) detected"); + return 0; + } + + return level; +} + +/* TODO : Mark addresses as Accessed and Dirty */ +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, bool is_write, IOMMUTLBEntry *ret) +{ + AMDIOMMUState *s = as->iommu_state; + + int present; + dma_addr_t pte_addr; + uint64_t entry[4], pte, pte_perms; + unsigned level; + unsigned perms; + + if(!amd_iommu_get_dte(s, as->devfn, entry)){ + goto no_translation; + } + + pte = entry[0]; + + /* + * It's okay to check for either read or write permissions + * even for memory maps, since we don't support R/W maps. + */ + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; + + if(!(level = get_pte_translation_mode(pte))){ + goto no_translation; + } + + while(level > 0){ + /* + * check permissions: the bitwise + * implication perms -> entry_perms must be true. Pages must be present + * and permissions on all levels must be similar + */ + pte_perms = amd_iommu_get_perms(pte); + present = pte & 1; + if(!present || perms != (perms & pte_perms)){ + amd_iommu_page_fault(s, as->devfn, entry[1] & DEV_DOMID_ID_MASK, addr, present, + !!(perms & IOMMU_PERM_WRITE)); + return; + } + + /* go to the next lower level */ + pte_addr = pte & DEV_PT_ROOT_MASK; + pte_addr += ((addr >> ( 9 * level)) & 0xff8); + pte = ldq_phys(&address_space_memory, pte_addr); + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; + } + + ret->iova = addr & IOMMU_PAGE_MASK_4K; + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; + ret->perm = IOMMU_RW; + return; + +no_translation: + ret->iova = addr; + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; + ret->perm = IOMMU_RW; + return; +} + +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr addr, bool is_write) +{ + + IOMMU_DPRINTF(GENERAL, ""); + + AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, iommu); + AMDIOMMUState *s = as->iommu_state; + + IOMMUTLBEntry ret = { + .target_as = &address_space_memory, + .iova = addr, + .translated_addr = 0, + .addr_mask = ~(hwaddr)0, + .perm = IOMMU_NONE, + }; + + if(!s->enabled){ + /* IOMMU disabled - corresponds to iommu=off not failure to provide any parameter */ + ret.iova = addr & IOMMU_PAGE_MASK_4K; + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; + ret.perm = IOMMU_RW; + return ret; + } + + amd_iommu_do_translate(as, addr, is_write, &ret); + + IOMMU_DPRINTF(MMU, + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, as->bus_num, + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, ret.translated_addr); + + return ret; +} + +static const MemoryRegionOps mmio_mem_ops = { + .read = amd_iommu_mmio_read, + .write = amd_iommu_mmio_write, + .endianness = DEVICE_LITTLE_ENDIAN, + .valid = { + .min_access_size = 1, + .max_access_size = 8, + .unaligned = false, + }, + + .valid = { + .min_access_size = 8, + .max_access_size = 8, + }, +}; + +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, uint32_t guest_va, uint32_t *reg) +{ + *reg = 0; + + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; +} + +/* FIXME: The similar code in reset and init could be combined into a function */ +static void amd_iommu_reset(DeviceState *dev) +{ + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); + + uint32_t capab_header = CAPAB_FEATURES; + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; + uint32_t capab_range = 0xff000000; + uint32_t capab_misc = 0x0; + + /* reset MMIO */ + memset(s->mmior, 0, MMIO_SIZE); + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); + /* TODO :Disable event logging and reset all buffers */ + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, &capab_misc); + + /* reset IOMMU specific capabilities */ + pci_set_long(s->dev.config + s->capab_offset, capab_header); + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, capab_base_addr_low); + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, capab_base_addr_high); + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, capab_range); + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, capab_misc); + + /* reset device ident */ + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); + pci_config_set_class(s->dev.config, 0x0806); + pci_config_set_prog_interface(s->dev.config, 00); +} + +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t val, int len) +{ + pci_default_write_config(dev, addr, val, len); +} + +/* I honestly don't know how to reserve MMIO */ +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) +{ + if(s->mmio.addr == addr){ + return; + } + +// if(s->mmio.addr != (hwaddr)-1) { +// memory_region_del_subregion(get_system_memory(), &s->mmio); +// } + + s->mmio.addr = addr; + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); + +} + +static int amd_iommu_pci_initfn(PCIDevice *dev) +{ + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); + uint32_t capab_header = CAPAB_FEATURES; + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); + uint32_t capab_range = 0xff000000; + uint32_t capab_misc = 0x0; + + memset(s->mmior, 0, MMIO_SIZE); + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, &capab_misc); + + s->iommu_ops.translate = amd_iommu_translate; + s->enabled = false; + s->ats_enabled = false; + s->cmdbuf_enabled = false; + s->devtab_len = 0; + s->cmdbuf_len = 0; + s->cmdbuf_head = 0; + s->cmdbuf_tail = 0; + s->evtlog_head = 0; + s->evtlog_tail = 0; + s->excl_enabled = false; + s->excl_allow = false; + s->mmio_enabled = false; + dev->config_write = amd_iommu_write_capab; + + size_t offset; + /* Save offset for IVRS */ + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, CAPAB_SIZE); + pci_set_long(s->dev.config + offset, capab_header); + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, capab_base_addr_low); + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, capab_base_addr_high); + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); + + /* add msi and hypertransport capabilities */ + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); + + /* set up MMIO */ + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, "amd-iommu", MMIO_SIZE); + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); + + /* reset device ident */ + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); + + /* may not be necessary */ + pci_config_set_interrupt_pin(dev->config, 0x1a); + + return 0; +} + +static void amd_iommu_realize(PCIDevice *dev, Error **error) +{ + amd_iommu_pci_initfn(dev); +} + +static const VMStateDescription vmstate_amd_iommu = { + .name = "amd-iommu", + .fields = (VMStateField[]) { + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), + VMSTATE_END_OF_LIST() + } +}; + +static Property amd_iommu_properties[] = { + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), + DEFINE_PROP_END_OF_LIST(), +}; + +/* not used for now but will be when cache is added */ +static void amd_iommu_uninit(PCIDevice *dev) +{ + return; +} + +static void amd_iommu_class_init(ObjectClass *klass, void* data) +{ + DeviceClass *dc = DEVICE_CLASS(klass); + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); + + pci->realize = amd_iommu_realize; + pci->exit = amd_iommu_uninit; + + dc->reset = amd_iommu_reset; + dc->vmsd = &vmstate_amd_iommu; + dc->props = amd_iommu_properties; +} + +static const TypeInfo amd_iommu = { + .name = TYPE_AMD_IOMMU_DEVICE, + .parent = TYPE_PCI_DEVICE, + .instance_size = sizeof(AMDIOMMUState), + .class_init = amd_iommu_class_init +}; + +static void amd_iommu_register_types(void) +{ + type_register_static(&amd_iommu); +} + +type_init(amd_iommu_register_types); diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h new file mode 100644 index 0000000..90309eb --- /dev/null +++ b/hw/i386/amd_iommu.h @@ -0,0 +1,298 @@ +/* + * QEMU emulation of an AMD IOMMU (AMD-Vi) + * + * Copyright (C) 2011 Eduard-Gabriel Mateanu + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + + * You should have received a copy of the GNU General Public License along + * with this program; if not, see <http://www.gnu.org/licenses/>. + */ + +#ifndef AMD_IOMMU_H_ +#define AMD_IOMMU_H_ + +#include "hw/hw.h" +#include "hw/pci/pci.h" +#include "hw/sysbus.h" +#include "sysemu/dma.h" +#include "qemu/osdep.h" +#include "qemu/event_notifier.h" + +/* Capability registers */ +#define CAPAB_HEADER 0x00 +#define CAPAB_REV_TYPE 0x02 +#define CAPAB_FLAGS 0x03 +#define CAPAB_BAR_LOW 0x04 +#define CAPAB_BAR_HIGH 0x08 +#define CAPAB_RANGE 0x0C +#define CAPAB_MISC 0x10 +#define CAPAB_MISC1 0x14 + +#define CAPAB_SIZE 0x18 +#define CAPAB_REG_SIZE 0x04 + +/* Capability header data */ +#define CAPAB_FLAT_EXT (1 << 28) +#define CAPAB_EFR_SUP (1 << 27) +#define CAPAB_FLAG_NPCACHE (1 << 26) +#define CAPAB_FLAG_HTTUNNEL (1 << 25) +#define CAPAB_FLAG_IOTLBSUP (1 << 24) +#define CAPAB_INIT_REV (1 << 19) +#define CAPAB_INIT_TYPE (3 << 16) +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | CAPAB_FLAG_HTTUNNEL) +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) + +/* MMIO registers */ +#define MMIO_DEVICE_TABLE 0x0000 +#define MMIO_COMMAND_BASE 0x0008 +#define MMIO_EVENT_BASE 0x0010 +#define MMIO_CONTROL 0x0018 +#define MMIO_EXCL_BASE 0x0020 +#define MMIO_EXCL_LIMIT 0x0028 +#define MMIO_EXT_FEATURES 0x0030 +#define MMIO_COMMAND_HEAD 0x2000 +#define MMIO_COMMAND_TAIL 0x2008 +#define MMIO_EVENT_HEAD 0x2010 +#define MMIO_EVENT_TAIL 0x2018 +#define MMIO_STATUS 0x2020 +#define MMIO_PPR_BASE 0x0038 +#define MMIO_PPR_HEAD 0x2030 +#define MMIO_PPR_TAIL 0x2038 + +#define MMIO_SIZE 0x4000 + +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & ~MMIO_DEVTAB_SIZE_MASK) +#define MMIO_DEVTAB_ENTRY_SIZE 32 +#define MMIO_DEVTAB_SIZE_UNIT 4096 + +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) +#define MMIO_CMDBUF_SIZE_MASK 0x0F +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK +#define MMIO_CMDBUF_DEFAULT_SIZE 8 +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK + +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK + +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK +#define MMIO_EXCL_LIMIT_LOW 0xFFF + +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) + +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) + +#define CMDBUF_ID_BYTE 0x07 +#define CMDBUF_ID_RSHIFT 4 +#define CMDBUF_ENTRY_SIZE 0x10 + +#define CMD_COMPLETION_WAIT 0x01 +#define CMD_INVAL_DEVTAB_ENTRY 0x02 +#define CMD_INVAL_IOMMU_PAGES 0x03 +#define CMD_INVAL_IOTLB_PAGES 0x04 +#define CMD_INVAL_INTR_TABLE 0x05 + +#define DEVTAB_ENTRY_SIZE 32 + +/* Device table entry bits 0:63 */ +#define DEV_VALID (1ULL << 0) +#define DEV_TRANSLATION_VALID (1ULL << 1) +#define DEV_MODE_MASK 0x7 +#define DEV_MODE_RSHIFT 9 +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 +#define DEV_PT_ROOT_RSHIFT 12 +#define DEV_PERM_SHIFT 61 +#define DEV_PERM_READ (1ULL << 61) +#define DEV_PERM_WRITE (1ULL << 62) + +/* Device table entry bits 64:127 */ +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) +#define DEV_IOTLB_SUPPORT (1ULL << 17) +#define DEV_SUPPRESS_PF (1ULL << 18) +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) +#define DEV_IOCTL_MASK (~3) +#define DEV_IOCTL_RSHIFT 20 +#define DEV_IOCTL_DENY 0 +#define DEV_IOCTL_PASSTHROUGH 1 +#define DEV_IOCTL_TRANSLATE 2 +#define DEV_CACHE (1ULL << 37) +#define DEV_SNOOP_DISABLE (1ULL << 38) +#define DEV_EXCL (1ULL << 39) + +/* Event codes and flags, as stored in the info field */ +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) +#define EVENT_IOPF (0x2U << 24) +#define EVENT_IOPF_I (1U << 3) +#define EVENT_IOPF_PR (1U << 4) +#define EVENT_IOPF_RW (1U << 5) +#define EVENT_IOPF_PE (1U << 6) +#define EVENT_IOPF_RZ (1U << 7) +#define EVENT_IOPF_TR (1U << 8) +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) + +#define EVENT_LEN 16 + +#define IOMMU_PERM_READ (1 << 0) +#define IOMMU_PERM_WRITE (1 << 1) +#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) + +/* AMD RD890 Chipset */ +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 + +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header register */ +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low register */ +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high register */ +#define PCI_CAP_ID_RANGE 0x0 /* Device range register */ +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information register 0 */ +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information register 1 */ + +#define FEATURE_PREFETCH (1ULL<<0) +#define FEATURE_PPR (1ULL<<1) +#define FEATURE_NX (1ULL<<3) +#define FEATURE_GT (1ULL<<4) +#define FEATURE_IA (1ULL<<6) +#define FEATURE_GA (1ULL<<7) +#define FEATURE_HE (1ULL<<8) +#define FEATURE_PC (1ULL<<9) + +/* IOMMU paging mode */ +#define GATS_MODE (6ULL << 12) +#define HATS_MODE (6ULL << 10) +/* PCI SIG constants */ +#define PCI_BUS_MAX 256 +#define PCI_SLOT_MAX 32 +#define PCI_FUNC_MAX 8 +#define PCI_DEVFN_MAX 256 + +/* extended feature support */ +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) + +/* capabilities header */ +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL | CAPAB_EFR_SUP) + +/* command constants */ +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 +#define COM_COMPLETION_STORE_MASK 0x1 +#define COM_COMPLETION_INTR 0x2 +#define COM_COMPLETION_DATA_OFF 0x8 +#define IOMMU_COMMAND_SIZE 0x10 + +/* IOMMU default address */ +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 + +/* page management constants */ +#define IOMMU_PAGE_SHIFT 12 +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) + +#define IOMMU_PAGE_SHIFT_4K 12 +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) +#define IOMMU_PAGE_SHIFT_2M 21 +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) +#define IOMMU_PAGE_SHIFT_1G 30 +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) + +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" +#define AMD_IOMMU_DEVICE(obj)\ + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) + +typedef struct AMDIOMMUState AMDIOMMUState; + +typedef struct AMDIOMMUAddressSpace{ + uint8_t bus_num; /* bus number */ + uint8_t devfn; /* device function */ + AMDIOMMUState *iommu_state; /* IOMMU - one per machine */ + MemoryRegion iommu; /* Device's iommu region */ + AddressSpace as; /* device's corresponding address space */ +}AMDIOMMUAddressSpace; + +struct AMDIOMMUState { + PCIDevice dev; /* The PCI device itself */ + + uint32_t version; + + int capab_offset; /* capability offset pointer */ + unsigned char *capab; /* capabilities registers */ + + bool enabled; /* IOMMU enabled */ + bool ats_enabled; /* address translation enabled */ + bool cmdbuf_enabled; /* command buffer enabled */ + bool evtlog_enabled; /* event log enabled */ + bool excl_enabled; + + dma_addr_t devtab; /* base address device table */ + size_t devtab_len; /* device table length */ + + dma_addr_t cmdbuf; /* command buffer base address */ + uint64_t cmdbuf_len; /* command buffer length */ + unsigned cmdbuf_head; /* current IOMMU read position */ + unsigned cmdbuf_tail; /* next Software write position */ + int completion_wait_intr; + + dma_addr_t evtlog; /* base address event log */ + size_t evtlog_intr; + size_t evtlog_len; /* event log length */ + size_t evtlog_head; /* event log head */ + size_t evtlog_tail; /* event log tail */ + + /* unused for now */ + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ + bool excl_allow; /* translate accesses to the exclusion range */ + bool excl_enable; /* exclusion range enabled */ + + MemoryRegion mmio; /* MMIO region */ + unsigned char mmior[MMIO_SIZE]; + bool mmio_enabled; + + /* IOMMU function */ + MemoryRegionIOMMUOps iommu_ops; + + /* for each served device */ + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; +}; + +typedef struct AMDIOMMUEvent { + uint16_t devfn; + uint16_t reserved; + uint16_t domid; + uint16_t info; + uint16_t addr; +} __attribute__((packed)) AMDIOMMUEvent; + +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn); + +#endif -- 2.1.4 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-08-24 23:19 ` [Qemu-devel] [RFC 2/4] hw/i386: Introduce " David Kiarie @ 2015-08-25 6:39 ` Valentine Sinitsyn 2015-08-25 7:25 ` David kiarie 2015-09-07 12:46 ` Valentine Sinitsyn 1 sibling, 1 reply; 22+ messages in thread From: Valentine Sinitsyn @ 2015-08-25 6:39 UTC (permalink / raw) To: David Kiarie, qemu-devel; +Cc: jan.kiszka, mst Hi, On 25.08.2015 04:19, David Kiarie wrote: > From: David <davidkiarie4@gmail.com> > > Add AMD IOMMU emulation to Qemu. This is a very basic AMD IOMMU > emulation that only does translation and some basic Event logging. > Guest translation enables nested PCI passthrough > > Signed-off-by: David Kiarie <davidkiarie4@gmail.com> > --- > hw/i386/Makefile.objs | 1 + > hw/i386/amd_iommu.c | 993 ++++++++++++++++++++++++++++++++++++++++++++++++++ > hw/i386/amd_iommu.h | 298 +++++++++++++++ > 3 files changed, 1292 insertions(+) > create mode 100644 hw/i386/amd_iommu.c > create mode 100644 hw/i386/amd_iommu.h > > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs > index ebd1015..2bae11c 100644 > --- a/hw/i386/Makefile.objs > +++ b/hw/i386/Makefile.objs > @@ -3,6 +3,7 @@ obj-y += multiboot.o > obj-y += pc.o pc_piix.o pc_q35.o > obj-y += pc_sysfw.o > obj-y += intel_iommu.o > +obj-y += amd_iommu.o > obj-$(CONFIG_XEN) += ../xenpv/ xen/ > > obj-y += kvmvapic.o > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > new file mode 100644 > index 0000000..a3a0b20 > --- /dev/null > +++ b/hw/i386/amd_iommu.c > @@ -0,0 +1,993 @@ > +/* > + * QEMU emulation of an AMD IOMMU (AMD-Vi) > + * > + * Copyright (C) 2011 Eduard - Gabriel Munteanu > + * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see <http://www.gnu.org/licenses/>. > + * > + */ > +#include "hw/i386/amd_iommu.h" > + > +#define PCI_EXT_CAP_ID_PASID 0x1B > +#define PCI_EXT_CAP_ID_PRI 0x13 > + > +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) > +#define PCI_FUNC(devfn) ((devfn) & 0x07) > + > +#define MAX_VA_ADDR (64UL << 5) > +#define MAX_PH_ADDR (48UL << 8) > +#define MAX_GVA_ADDR (64UL << 15) > + > +//#define DEBUG_AMD_IOMMU > +#ifdef DEBUG_AMD_IOMMU > +enum { > + DEBUG_GENERAL, DEBUG_CAPAB, DEBUG_MMIO, DEBUG_ELOG, > + DEBUG_CACHE, DEBUG_COMMAND, DEBUG_MMU > +}; > + > +#define IOMMU_DBGBIT(x) (1 << DEBUG_##x) > +static int iommu_dbgflags = IOMMU_DBGBIT(GENERAL) | IOMMU_DBGBIT(MMU) | IOMMU_DBGBIT(MMIO); > +//| IOMMU_DBGBIT(CAPAB) | IOMMU_DBGBIT(ELOG) | IOMMU_DBGBIT(CACHE) | IOMMU_DBGBIT(COMMAND); > + > +#define IOMMU_DPRINTF(what, fmt, ...) do { \ > + if (iommu_dbgflags & IOMMU_DBGBIT(what)) { \ > + fprintf(stderr, "(amd-iommu)%s: " fmt "\n", __func__, \ > + ## __VA_ARGS__); } \ > + } while (0) > +#else > +#define IOMMU_DPRINTF(what, fmt, ...) do {} while (0) > +#endif > + > +/* helper functions - FIXME - provide for reading one byte */ > +static uint16_t amd_iommu_readw(AMDIOMMUState *s, hwaddr addr) > +{ > + return lduw_le_p(&s->mmior[addr]); > +} > + > +static uint32_t amd_iommu_readl(AMDIOMMUState *s, hwaddr addr) > +{ > + return ldl_le_p(&s->mmior[addr]); > +} > + > +static uint64_t amd_iommu_readq(AMDIOMMUState *s, hwaddr addr) > +{ > + return ldq_le_p(&s->mmior[addr]); > +} > + > +static void amd_iommu_writew(AMDIOMMUState *s, hwaddr addr, uint16_t val) > +{ > + stw_le_p(&s->mmior[addr], val); > +} > + > +static void amd_iommu_writel(AMDIOMMUState *s, hwaddr addr, uint32_t val) > +{ > + stl_le_p(&s->mmior[addr], val); > +} > + > +static void amd_iommu_writeq(AMDIOMMUState *s, hwaddr addr, uint64_t val) > +{ > + stq_le_p(&s->mmior[addr], val); > +} > + > +/* execute a completion wait command */ > +static void amd_iommu_completion_wait(AMDIOMMUState *s, uint8_t *cmd) > +{ > + unsigned int addr; > + > + /* completion store */ > + if(cmd[0] & COM_COMPLETION_STORE_MASK){ > + addr = le64_to_cpu(*(uint64_t*)cmd) & COM_STORE_ADDRESS_MASK; > + if(dma_memory_write(&address_space_memory, addr, cmd + 8, 8)){ > + IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIx64, addr); > + } > + > + } > + > + /* set completion interrupt */ When I was experimenting with a real IOMMU, it all looked like if both COM_COMPLETION_STORE_MASK and COM_COMPLETION_BIT are set in the command, only an interrupt is generated. Could someone comment on this? > + if (cmd[0] & COM_COMPLETION_INTR){ > + s->mmior[MMIO_STATUS] |= MMIO_STATUS_COMWAIT_INTR; > + } > +} > + > +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) > +{ > + unsigned type; > + uint8_t cmd[IOMMU_COMMAND_SIZE]; > + > + IOMMU_DPRINTF(COMMAND, ""); > + memset(cmd, 0, IOMMU_COMMAND_SIZE); > + > + if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, cmd, IOMMU_COMMAND_SIZE)){ > + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at 0x%"PRIx64 > + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); > + } > + > + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; > + > + switch(type){ > + case CMD_COMPLETION_WAIT: > + /* pretend to wait for command execution to complete */ > + IOMMU_DPRINTF(COMMAND, "completion wait requested"); > + amd_iommu_completion_wait(s, cmd); > + break; > + case CMD_INVAL_DEVTAB_ENTRY: > + /* Not implemented yet - should just clear device table contents */ > + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); > + break; > + case CMD_INVAL_IOMMU_PAGES: > + /* invalidate IOMMU cache for a particular domain */ > + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); > + break; > + case CMD_INVAL_IOTLB_PAGES: > + /* Only present if remote IOTLB present */ > + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); > + break; > + case CMD_INVAL_INTR_TABLE: > + /* no support for interrupt remapping yet */ > + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); > + break; > + default: > + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); > + break; > + } > + > +} > + > +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) > +{ > + IOMMU_DPRINTF(COMMAND, ""); > + > + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; > + > + if(!s->cmdbuf_enabled){ > + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); > + return; > + } > + > + while(s->cmdbuf_head != s->cmdbuf_tail) { > + /* check if there is work to do. */ > + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER tail at %x", > + s->cmdbuf_head, s->cmdbuf_tail); > + amd_iommu_cmdbuf_exec(s); > + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; > + > + /* wrap head pointer */ > + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { > + s->cmdbuf_head = 0; > + } > + } > + > + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); > +} > + > +/* System Software might never read from some of this fields but anyways */ > +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned size) > +{ > + AMDIOMMUState *s = opaque; > + > + uint64_t val = -1; > + if(addr + size > MMIO_SIZE) { > + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 > + ", got 0x%"PRIx64 " %d", > + (uint64_t)MMIO_SIZE, addr, size); > + return (uint64_t) - 1; > + } > + > + switch(addr & ~0x07){ > + case MMIO_DEVICE_TABLE: > + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_COMMAND_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EVENT_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_CONTROL: > + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EXCL_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EXCL_LIMIT: > + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_COMMAND_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_COMMAND_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EVENT_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EVENT_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_STATUS: > + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EXT_FEATURES: > + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + default: > + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + } > + > + return val; > +} > + > +static void iommu_handle_control_write(AMDIOMMUState *s) > +{ > + /* read whatever is already written incase software is writing in chucks less than 8 bytes */ > + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); > + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); > + > + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); > + s->evtlog_enabled = s->enabled && !!(control & MMIO_CONTROL_EVENTLOGEN); > + > + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); > + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); > + s->cmdbuf_enabled = s->enabled && !!(control & MMIO_CONTROL_CMDBUFLEN); > + > + /* update the flags depending on the control register */ > + if(s->cmdbuf_enabled) { > + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; > + } else { > + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; > + } > + if (s->evtlog_enabled) { > + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; > + } else { > + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; > + } > + > + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); > + > + amd_iommu_cmdbuf_run(s); > +} > + > +/* FIXME: something might go wrong if System Software writes in chunks > + * of one byte but linux writes in chunks of 4 bytes so currently it > + * works correctly with linux but will definitely be busted if software > + * reads/writes 8 bytes > + */ > +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) > +{ > + > + AMDIOMMUState *s = opaque; > + unsigned long offset = addr & 0x07; > + > + if(addr + size > MMIO_SIZE) { > + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 > + ", got 0x%"PRIx64 " %d", > + (uint64_t)MMIO_SIZE, addr, size); > + return; > + } > + > + switch(addr & ~0x07){ > + case MMIO_CONTROL: > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + > + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 , addr, size, val, offset); > + iommu_handle_control_write(s); > + break; > + > + case MMIO_DEVICE_TABLE: > + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + > + /* set device table address > + * This also suffers from inability to tell whether software is done writing > + */ > + if(offset || (size == 8)){ > + unsigned long device_base = amd_iommu_readq(s, MMIO_DEVICE_TABLE); > + s->devtab = (dma_addr_t)(device_base & MMIO_CMDBUF_BASE_MASK); > + /* set device table length */ > + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + 1) * (MMIO_DEVTAB_SIZE_UNIT / > + MMIO_DEVTAB_ENTRY_SIZE); > + } > + break; > + > + case MMIO_COMMAND_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; > + amd_iommu_cmdbuf_run(s); > + break; > + > + case MMIO_COMMAND_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + > + /* FIXME - make sure System Software has finished writing incase it writes > + * in chucks less than 8 bytes in a robust way.As for now, this hacks works > + * for the linux driver > + */ > + if(offset || (size == 8)){ > + unsigned long command_base = amd_iommu_readq(s, MMIO_COMMAND_BASE); > + s->cmdbuf = (dma_addr_t)(command_base & MMIO_CMDBUF_BASE_MASK); > + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & MMIO_CMDBUF_SIZE_MASK); > + s->cmdbuf_head = s->cmdbuf_tail = 0; > + } > + break; > + > + case MMIO_COMMAND_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + > + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; > + amd_iommu_cmdbuf_run(s); > + break; > + > + case MMIO_EVENT_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); > + s->evtlog_len = 1UL << (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); > + break; > + > + case MMIO_EXCL_LIMIT: > + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | MMIO_EXCL_LIMIT_LOW; > + break; > + //TODO : Event handling fixes > + > + case MMIO_EVENT_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + > + case MMIO_EVENT_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + /* PPR log base - unused for now */ > + case MMIO_PPR_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + /* PPR log head - also unused for now */ > + case MMIO_PPR_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + /* PPR log tail - unused for now */ > + case MMIO_PPR_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + > + default: > + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + ; > + } > + > +} > + > +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) > +{ > + /* event logging not enabled */ > + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | MMIO_STATUS_EVTLOG_OF){ > + return; > + } > + > + /* event log buffer full */ > + if(s->evtlog_tail >= s->evtlog_len) { > + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; > + } > + > + if(dma_memory_write(&address_space_memory, s->evtlog_len + s->evtlog_tail, &evt, EVENT_LEN)){ > + //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, s->evtlog + s->evtlog_tail); > + } > + > + s->evtlog_tail += EVENT_LEN; > + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; > + /* Disable logging if Overflow ? */ > +} > + > +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned domid, dma_addr_t addr, int present, > + int is_write) > +{ > + IOMMU_DPRINTF(ELOG, ""); > + > + AMDIOMMUEvent evt; > + unsigned info; > + uint16_t status; > + > + evt.devfn = cpu_to_le16(devfn); > + evt.reserved = 0; > + evt.domid = cpu_to_le16(domid); > + evt.addr = cpu_to_le16(addr); > + > + info = EVENT_IOPF; > + > + if(present) { > + info |= EVENT_IOPF_PR; > + } > + > + if (is_write) { > + info |= EVENT_IOPF_RW; > + } > + > + /* log a page fault */ > + amd_iommu_log_event(s, &evt); > + > + /* Abort the translation */ > + status = pci_get_word(s->dev.config + PCI_STATUS); > + pci_set_word(s->dev.config + PCI_STATUS, status | PCI_STATUS_SIG_TARGET_ABORT); > +} > + > +static inline uint64_t amd_iommu_get_perms(uint64_t entry) > +{ > + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; > +} > + > +/* FIXME deduplication */ > +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) > +{ > + AMDIOMMUState *s = opaque; > + AMDIOMMUAddressSpace **iommu_as; > + int bus_num = pci_bus_num(bus); > + > + /* just in case */ > + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); > + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); > + > + iommu_as = s->address_spaces[bus_num]; > + > + /* allocate memory during the first run */ > + if(!iommu_as) { > + iommu_as = g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); > + s->address_spaces[bus_num] = iommu_as; > + } > + > + /* set up IOMMU region */ > + if(!iommu_as[devfn]){ > + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); > + iommu_as[devfn]->bus_num = (uint8_t)bus_num; > + iommu_as[devfn]->devfn = (uint8_t)devfn; > + iommu_as[devfn]->iommu_state = s; > + > + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), &s->iommu_ops, "amd-iommu", UINT64_MAX); > + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, "amd-iommu"); > + } > + return &iommu_as[devfn]->as; > +} > + > +/* validate a page table entry */ > +static bool amd_iommu_validate_pte(uint64_t pte) > +{ > + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; > +} > + > +/* get a device table entry given the device function */ > +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t *entry) > +{ > + /* Could lead to out of range accesses */ > + assert(0 < devfn && devfn < PCI_DEVFN_MAX); > + > + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; > + if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, 32)){ > + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab 0x%"PRIx64 > + "offset 0x%"PRIx32, s->devtab, offset); > + return false; > + } > + > + if(!amd_iommu_validate_pte(entry[0])){ > + IOMMU_DPRINTF(MMU, > + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); > + return false; > + } > + > + return true; > +} > + > +static uint64_t get_pte_translation_mode(uint64_t pte) > +{ > + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; > + > + if(level == 7){ > + /* reserved level - abort ? */ > + IOMMU_DPRINTF(MMU, > + "Reserved translation level (7) detected"); > + return 0; > + } > + > + return level; > +} > + > +/* TODO : Mark addresses as Accessed and Dirty */ > +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, bool is_write, IOMMUTLBEntry *ret) > +{ > + AMDIOMMUState *s = as->iommu_state; > + > + int present; > + dma_addr_t pte_addr; > + uint64_t entry[4], pte, pte_perms; > + unsigned level; > + unsigned perms; > + > + if(!amd_iommu_get_dte(s, as->devfn, entry)){ > + goto no_translation; > + } > + > + pte = entry[0]; > + > + /* > + * It's okay to check for either read or write permissions > + * even for memory maps, since we don't support R/W maps. > + */ > + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; > + > + if(!(level = get_pte_translation_mode(pte))){ > + goto no_translation; > + } > + > + while(level > 0){ > + /* > + * check permissions: the bitwise > + * implication perms -> entry_perms must be true. Pages must be present > + * and permissions on all levels must be similar > + */ > + pte_perms = amd_iommu_get_perms(pte); > + present = pte & 1; > + if(!present || perms != (perms & pte_perms)){ > + amd_iommu_page_fault(s, as->devfn, entry[1] & DEV_DOMID_ID_MASK, addr, present, > + !!(perms & IOMMU_PERM_WRITE)); > + return; > + } > + > + /* go to the next lower level */ > + pte_addr = pte & DEV_PT_ROOT_MASK; > + pte_addr += ((addr >> ( 9 * level)) & 0xff8); > + pte = ldq_phys(&address_space_memory, pte_addr); > + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; > + } > + > + ret->iova = addr & IOMMU_PAGE_MASK_4K; > + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; > + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; > + ret->perm = IOMMU_RW; > + return; > + > +no_translation: > + ret->iova = addr; > + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; > + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; > + ret->perm = IOMMU_RW; > + return; > +} > + > +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr addr, bool is_write) > +{ > + > + IOMMU_DPRINTF(GENERAL, ""); > + > + AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, iommu); > + AMDIOMMUState *s = as->iommu_state; > + > + IOMMUTLBEntry ret = { > + .target_as = &address_space_memory, > + .iova = addr, > + .translated_addr = 0, > + .addr_mask = ~(hwaddr)0, > + .perm = IOMMU_NONE, > + }; > + > + if(!s->enabled){ > + /* IOMMU disabled - corresponds to iommu=off not failure to provide any parameter */ > + ret.iova = addr & IOMMU_PAGE_MASK_4K; > + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; > + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; > + ret.perm = IOMMU_RW; > + return ret; > + } > + > + amd_iommu_do_translate(as, addr, is_write, &ret); > + > + IOMMU_DPRINTF(MMU, > + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, as->bus_num, > + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, ret.translated_addr); > + > + return ret; > +} > + > +static const MemoryRegionOps mmio_mem_ops = { > + .read = amd_iommu_mmio_read, > + .write = amd_iommu_mmio_write, > + .endianness = DEVICE_LITTLE_ENDIAN, > + .valid = { > + .min_access_size = 1, > + .max_access_size = 8, > + .unaligned = false, > + }, > + > + .valid = { > + .min_access_size = 8, > + .max_access_size = 8, > + }, > +}; > + > +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, uint32_t guest_va, uint32_t *reg) > +{ > + *reg = 0; > + > + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; > +} > + > +/* FIXME: The similar code in reset and init could be combined into a function */ > +static void amd_iommu_reset(DeviceState *dev) > +{ > + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); > + > + uint32_t capab_header = CAPAB_FEATURES; > + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); > + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; > + uint32_t capab_range = 0xff000000; > + uint32_t capab_misc = 0x0; > + > + /* reset MMIO */ > + memset(s->mmior, 0, MMIO_SIZE); > + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); > + /* TODO :Disable event logging and reset all buffers */ > + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, &capab_misc); > + > + /* reset IOMMU specific capabilities */ > + pci_set_long(s->dev.config + s->capab_offset, capab_header); > + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, capab_base_addr_low); > + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, capab_base_addr_high); > + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, capab_range); > + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, capab_misc); > + > + /* reset device ident */ > + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); > + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); > + pci_config_set_class(s->dev.config, 0x0806); > + pci_config_set_prog_interface(s->dev.config, 00); > +} > + > +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t val, int len) > +{ > + pci_default_write_config(dev, addr, val, len); > +} > + > +/* I honestly don't know how to reserve MMIO */ > +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) > +{ > + if(s->mmio.addr == addr){ > + return; > + } > + > +// if(s->mmio.addr != (hwaddr)-1) { > +// memory_region_del_subregion(get_system_memory(), &s->mmio); > +// } > + > + s->mmio.addr = addr; > + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); > + > +} > + > +static int amd_iommu_pci_initfn(PCIDevice *dev) > +{ > + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); > + uint32_t capab_header = CAPAB_FEATURES; > + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); > + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); > + uint32_t capab_range = 0xff000000; > + uint32_t capab_misc = 0x0; > + > + memset(s->mmior, 0, MMIO_SIZE); > + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, &capab_misc); > + > + s->iommu_ops.translate = amd_iommu_translate; > + s->enabled = false; > + s->ats_enabled = false; > + s->cmdbuf_enabled = false; > + s->devtab_len = 0; > + s->cmdbuf_len = 0; > + s->cmdbuf_head = 0; > + s->cmdbuf_tail = 0; > + s->evtlog_head = 0; > + s->evtlog_tail = 0; > + s->excl_enabled = false; > + s->excl_allow = false; > + s->mmio_enabled = false; > + dev->config_write = amd_iommu_write_capab; > + > + size_t offset; > + /* Save offset for IVRS */ > + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, CAPAB_SIZE); > + pci_set_long(s->dev.config + offset, capab_header); > + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, capab_base_addr_low); > + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, capab_base_addr_high); > + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); > + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); > + > + /* add msi and hypertransport capabilities */ > + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); > + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); > + > + /* set up MMIO */ > + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, "amd-iommu", MMIO_SIZE); > + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); > + > + /* reset device ident */ > + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); > + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); > + > + /* may not be necessary */ > + pci_config_set_interrupt_pin(dev->config, 0x1a); > + > + return 0; > +} > + > +static void amd_iommu_realize(PCIDevice *dev, Error **error) > +{ > + amd_iommu_pci_initfn(dev); > +} > + > +static const VMStateDescription vmstate_amd_iommu = { > + .name = "amd-iommu", > + .fields = (VMStateField[]) { > + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), > + VMSTATE_END_OF_LIST() > + } > +}; > + > +static Property amd_iommu_properties[] = { > + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), > + DEFINE_PROP_END_OF_LIST(), > +}; > + > +/* not used for now but will be when cache is added */ > +static void amd_iommu_uninit(PCIDevice *dev) > +{ > + return; > +} > + > +static void amd_iommu_class_init(ObjectClass *klass, void* data) > +{ > + DeviceClass *dc = DEVICE_CLASS(klass); > + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); > + > + pci->realize = amd_iommu_realize; > + pci->exit = amd_iommu_uninit; > + > + dc->reset = amd_iommu_reset; > + dc->vmsd = &vmstate_amd_iommu; > + dc->props = amd_iommu_properties; > +} > + > +static const TypeInfo amd_iommu = { > + .name = TYPE_AMD_IOMMU_DEVICE, > + .parent = TYPE_PCI_DEVICE, > + .instance_size = sizeof(AMDIOMMUState), > + .class_init = amd_iommu_class_init > +}; > + > +static void amd_iommu_register_types(void) > +{ > + type_register_static(&amd_iommu); > +} > + > +type_init(amd_iommu_register_types); > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > new file mode 100644 > index 0000000..90309eb > --- /dev/null > +++ b/hw/i386/amd_iommu.h > @@ -0,0 +1,298 @@ > +/* > + * QEMU emulation of an AMD IOMMU (AMD-Vi) > + * > + * Copyright (C) 2011 Eduard-Gabriel Mateanu > + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see <http://www.gnu.org/licenses/>. > + */ > + > +#ifndef AMD_IOMMU_H_ > +#define AMD_IOMMU_H_ > + > +#include "hw/hw.h" > +#include "hw/pci/pci.h" > +#include "hw/sysbus.h" > +#include "sysemu/dma.h" > +#include "qemu/osdep.h" > +#include "qemu/event_notifier.h" > + > +/* Capability registers */ > +#define CAPAB_HEADER 0x00 > +#define CAPAB_REV_TYPE 0x02 > +#define CAPAB_FLAGS 0x03 > +#define CAPAB_BAR_LOW 0x04 > +#define CAPAB_BAR_HIGH 0x08 > +#define CAPAB_RANGE 0x0C > +#define CAPAB_MISC 0x10 > +#define CAPAB_MISC1 0x14 > + > +#define CAPAB_SIZE 0x18 > +#define CAPAB_REG_SIZE 0x04 > + > +/* Capability header data */ > +#define CAPAB_FLAT_EXT (1 << 28) > +#define CAPAB_EFR_SUP (1 << 27) > +#define CAPAB_FLAG_NPCACHE (1 << 26) > +#define CAPAB_FLAG_HTTUNNEL (1 << 25) > +#define CAPAB_FLAG_IOTLBSUP (1 << 24) > +#define CAPAB_INIT_REV (1 << 19) > +#define CAPAB_INIT_TYPE (3 << 16) > +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) > +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | CAPAB_FLAG_HTTUNNEL) > +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) > +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) > + > +/* MMIO registers */ > +#define MMIO_DEVICE_TABLE 0x0000 > +#define MMIO_COMMAND_BASE 0x0008 > +#define MMIO_EVENT_BASE 0x0010 > +#define MMIO_CONTROL 0x0018 > +#define MMIO_EXCL_BASE 0x0020 > +#define MMIO_EXCL_LIMIT 0x0028 > +#define MMIO_EXT_FEATURES 0x0030 > +#define MMIO_COMMAND_HEAD 0x2000 > +#define MMIO_COMMAND_TAIL 0x2008 > +#define MMIO_EVENT_HEAD 0x2010 > +#define MMIO_EVENT_TAIL 0x2018 > +#define MMIO_STATUS 0x2020 > +#define MMIO_PPR_BASE 0x0038 > +#define MMIO_PPR_HEAD 0x2030 > +#define MMIO_PPR_TAIL 0x2038 > + > +#define MMIO_SIZE 0x4000 > + > +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) > +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & ~MMIO_DEVTAB_SIZE_MASK) > +#define MMIO_DEVTAB_ENTRY_SIZE 32 > +#define MMIO_DEVTAB_SIZE_UNIT 4096 > + > +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) > +#define MMIO_CMDBUF_SIZE_MASK 0x0F > +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK > +#define MMIO_CMDBUF_DEFAULT_SIZE 8 > +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) > +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK > + > +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) > +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK > +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK > +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE > +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) > +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK > + > +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK > +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) > +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) > +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK > +#define MMIO_EXCL_LIMIT_LOW 0xFFF > + > +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) > +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) > +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) > +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) > +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) > +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) > + > +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) > +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) > +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) > +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) > +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) > + > +#define CMDBUF_ID_BYTE 0x07 > +#define CMDBUF_ID_RSHIFT 4 > +#define CMDBUF_ENTRY_SIZE 0x10 > + > +#define CMD_COMPLETION_WAIT 0x01 > +#define CMD_INVAL_DEVTAB_ENTRY 0x02 > +#define CMD_INVAL_IOMMU_PAGES 0x03 > +#define CMD_INVAL_IOTLB_PAGES 0x04 > +#define CMD_INVAL_INTR_TABLE 0x05 > + > +#define DEVTAB_ENTRY_SIZE 32 > + > +/* Device table entry bits 0:63 */ > +#define DEV_VALID (1ULL << 0) > +#define DEV_TRANSLATION_VALID (1ULL << 1) > +#define DEV_MODE_MASK 0x7 > +#define DEV_MODE_RSHIFT 9 > +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 > +#define DEV_PT_ROOT_RSHIFT 12 > +#define DEV_PERM_SHIFT 61 > +#define DEV_PERM_READ (1ULL << 61) > +#define DEV_PERM_WRITE (1ULL << 62) > + > +/* Device table entry bits 64:127 */ > +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) > +#define DEV_IOTLB_SUPPORT (1ULL << 17) > +#define DEV_SUPPRESS_PF (1ULL << 18) > +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) > +#define DEV_IOCTL_MASK (~3) > +#define DEV_IOCTL_RSHIFT 20 > +#define DEV_IOCTL_DENY 0 > +#define DEV_IOCTL_PASSTHROUGH 1 > +#define DEV_IOCTL_TRANSLATE 2 > +#define DEV_CACHE (1ULL << 37) > +#define DEV_SNOOP_DISABLE (1ULL << 38) > +#define DEV_EXCL (1ULL << 39) > + > +/* Event codes and flags, as stored in the info field */ > +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) > +#define EVENT_IOPF (0x2U << 24) > +#define EVENT_IOPF_I (1U << 3) > +#define EVENT_IOPF_PR (1U << 4) > +#define EVENT_IOPF_RW (1U << 5) > +#define EVENT_IOPF_PE (1U << 6) > +#define EVENT_IOPF_RZ (1U << 7) > +#define EVENT_IOPF_TR (1U << 8) > +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) > +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) > +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) > +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) > +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) > +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) > + > +#define EVENT_LEN 16 > + > +#define IOMMU_PERM_READ (1 << 0) > +#define IOMMU_PERM_WRITE (1 << 1) > +#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) > + > +/* AMD RD890 Chipset */ > +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 > + > +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header register */ > +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low register */ > +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high register */ > +#define PCI_CAP_ID_RANGE 0x0 /* Device range register */ > +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information register 0 */ > +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information register 1 */ > + > +#define FEATURE_PREFETCH (1ULL<<0) > +#define FEATURE_PPR (1ULL<<1) > +#define FEATURE_NX (1ULL<<3) > +#define FEATURE_GT (1ULL<<4) > +#define FEATURE_IA (1ULL<<6) > +#define FEATURE_GA (1ULL<<7) > +#define FEATURE_HE (1ULL<<8) > +#define FEATURE_PC (1ULL<<9) > + > +/* IOMMU paging mode */ > +#define GATS_MODE (6ULL << 12) > +#define HATS_MODE (6ULL << 10) > +/* PCI SIG constants */ > +#define PCI_BUS_MAX 256 > +#define PCI_SLOT_MAX 32 > +#define PCI_FUNC_MAX 8 > +#define PCI_DEVFN_MAX 256 > + > +/* extended feature support */ > +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) > + > +/* capabilities header */ > +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL | CAPAB_EFR_SUP) > + > +/* command constants */ > +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 > +#define COM_COMPLETION_STORE_MASK 0x1 > +#define COM_COMPLETION_INTR 0x2 > +#define COM_COMPLETION_DATA_OFF 0x8 > +#define IOMMU_COMMAND_SIZE 0x10 > + > +/* IOMMU default address */ > +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 > + > +/* page management constants */ > +#define IOMMU_PAGE_SHIFT 12 > +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) > + > +#define IOMMU_PAGE_SHIFT_4K 12 > +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) > +#define IOMMU_PAGE_SHIFT_2M 21 > +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) > +#define IOMMU_PAGE_SHIFT_1G 30 > +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) > + > +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" > +#define AMD_IOMMU_DEVICE(obj)\ > + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) > + > +typedef struct AMDIOMMUState AMDIOMMUState; > + > +typedef struct AMDIOMMUAddressSpace{ > + uint8_t bus_num; /* bus number */ > + uint8_t devfn; /* device function */ > + AMDIOMMUState *iommu_state; /* IOMMU - one per machine */ > + MemoryRegion iommu; /* Device's iommu region */ > + AddressSpace as; /* device's corresponding address space */ > +}AMDIOMMUAddressSpace; > + > +struct AMDIOMMUState { > + PCIDevice dev; /* The PCI device itself */ > + > + uint32_t version; > + > + int capab_offset; /* capability offset pointer */ > + unsigned char *capab; /* capabilities registers */ > + > + bool enabled; /* IOMMU enabled */ > + bool ats_enabled; /* address translation enabled */ > + bool cmdbuf_enabled; /* command buffer enabled */ > + bool evtlog_enabled; /* event log enabled */ > + bool excl_enabled; > + > + dma_addr_t devtab; /* base address device table */ > + size_t devtab_len; /* device table length */ > + > + dma_addr_t cmdbuf; /* command buffer base address */ > + uint64_t cmdbuf_len; /* command buffer length */ > + unsigned cmdbuf_head; /* current IOMMU read position */ > + unsigned cmdbuf_tail; /* next Software write position */ > + int completion_wait_intr; > + > + dma_addr_t evtlog; /* base address event log */ > + size_t evtlog_intr; > + size_t evtlog_len; /* event log length */ > + size_t evtlog_head; /* event log head */ > + size_t evtlog_tail; /* event log tail */ > + > + /* unused for now */ > + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ > + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ > + bool excl_allow; /* translate accesses to the exclusion range */ > + bool excl_enable; /* exclusion range enabled */ > + > + MemoryRegion mmio; /* MMIO region */ > + unsigned char mmior[MMIO_SIZE]; > + bool mmio_enabled; > + > + /* IOMMU function */ > + MemoryRegionIOMMUOps iommu_ops; > + > + /* for each served device */ > + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; > +}; > + > +typedef struct AMDIOMMUEvent { > + uint16_t devfn; > + uint16_t reserved; > + uint16_t domid; > + uint16_t info; > + uint16_t addr; > +} __attribute__((packed)) AMDIOMMUEvent; > + > +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn); > + > +#endif > Thanks, Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-08-25 6:39 ` Valentine Sinitsyn @ 2015-08-25 7:25 ` David kiarie 2015-08-25 7:31 ` Valentine Sinitsyn 0 siblings, 1 reply; 22+ messages in thread From: David kiarie @ 2015-08-25 7:25 UTC (permalink / raw) To: Valentine Sinitsyn; +Cc: Jan Kiszka, qemu-devel, mst On Tue, Aug 25, 2015 at 9:39 AM, Valentine Sinitsyn <valentine.sinitsyn@gmail.com> wrote: > Hi, > > > On 25.08.2015 04:19, David Kiarie wrote: >> >> From: David <davidkiarie4@gmail.com> >> >> Add AMD IOMMU emulation to Qemu. This is a very basic AMD IOMMU >> emulation that only does translation and some basic Event logging. >> Guest translation enables nested PCI passthrough >> >> Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >> --- >> hw/i386/Makefile.objs | 1 + >> hw/i386/amd_iommu.c | 993 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> hw/i386/amd_iommu.h | 298 +++++++++++++++ >> 3 files changed, 1292 insertions(+) >> create mode 100644 hw/i386/amd_iommu.c >> create mode 100644 hw/i386/amd_iommu.h >> >> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs >> index ebd1015..2bae11c 100644 >> --- a/hw/i386/Makefile.objs >> +++ b/hw/i386/Makefile.objs >> @@ -3,6 +3,7 @@ obj-y += multiboot.o >> obj-y += pc.o pc_piix.o pc_q35.o >> obj-y += pc_sysfw.o >> obj-y += intel_iommu.o >> +obj-y += amd_iommu.o >> obj-$(CONFIG_XEN) += ../xenpv/ xen/ >> >> obj-y += kvmvapic.o >> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c >> new file mode 100644 >> index 0000000..a3a0b20 >> --- /dev/null >> +++ b/hw/i386/amd_iommu.c >> @@ -0,0 +1,993 @@ >> +/* >> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >> + * >> + * Copyright (C) 2011 Eduard - Gabriel Munteanu >> + * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + >> + * You should have received a copy of the GNU General Public License >> along >> + * with this program; if not, see <http://www.gnu.org/licenses/>. >> + * >> + */ >> +#include "hw/i386/amd_iommu.h" >> + >> +#define PCI_EXT_CAP_ID_PASID 0x1B >> +#define PCI_EXT_CAP_ID_PRI 0x13 >> + >> +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) >> +#define PCI_FUNC(devfn) ((devfn) & 0x07) >> + >> +#define MAX_VA_ADDR (64UL << 5) >> +#define MAX_PH_ADDR (48UL << 8) >> +#define MAX_GVA_ADDR (64UL << 15) >> + >> +//#define DEBUG_AMD_IOMMU >> +#ifdef DEBUG_AMD_IOMMU >> +enum { >> + DEBUG_GENERAL, DEBUG_CAPAB, DEBUG_MMIO, DEBUG_ELOG, >> + DEBUG_CACHE, DEBUG_COMMAND, DEBUG_MMU >> +}; >> + >> +#define IOMMU_DBGBIT(x) (1 << DEBUG_##x) >> +static int iommu_dbgflags = IOMMU_DBGBIT(GENERAL) | IOMMU_DBGBIT(MMU) | >> IOMMU_DBGBIT(MMIO); >> +//| IOMMU_DBGBIT(CAPAB) | IOMMU_DBGBIT(ELOG) | IOMMU_DBGBIT(CACHE) | >> IOMMU_DBGBIT(COMMAND); >> + >> +#define IOMMU_DPRINTF(what, fmt, ...) do { \ >> + if (iommu_dbgflags & IOMMU_DBGBIT(what)) { \ >> + fprintf(stderr, "(amd-iommu)%s: " fmt "\n", __func__, \ >> + ## __VA_ARGS__); } \ >> + } while (0) >> +#else >> +#define IOMMU_DPRINTF(what, fmt, ...) do {} while (0) >> +#endif >> + >> +/* helper functions - FIXME - provide for reading one byte */ >> +static uint16_t amd_iommu_readw(AMDIOMMUState *s, hwaddr addr) >> +{ >> + return lduw_le_p(&s->mmior[addr]); >> +} >> + >> +static uint32_t amd_iommu_readl(AMDIOMMUState *s, hwaddr addr) >> +{ >> + return ldl_le_p(&s->mmior[addr]); >> +} >> + >> +static uint64_t amd_iommu_readq(AMDIOMMUState *s, hwaddr addr) >> +{ >> + return ldq_le_p(&s->mmior[addr]); >> +} >> + >> +static void amd_iommu_writew(AMDIOMMUState *s, hwaddr addr, uint16_t val) >> +{ >> + stw_le_p(&s->mmior[addr], val); >> +} >> + >> +static void amd_iommu_writel(AMDIOMMUState *s, hwaddr addr, uint32_t val) >> +{ >> + stl_le_p(&s->mmior[addr], val); >> +} >> + >> +static void amd_iommu_writeq(AMDIOMMUState *s, hwaddr addr, uint64_t val) >> +{ >> + stq_le_p(&s->mmior[addr], val); >> +} >> + >> +/* execute a completion wait command */ >> +static void amd_iommu_completion_wait(AMDIOMMUState *s, uint8_t *cmd) >> +{ >> + unsigned int addr; >> + >> + /* completion store */ >> + if(cmd[0] & COM_COMPLETION_STORE_MASK){ >> + addr = le64_to_cpu(*(uint64_t*)cmd) & COM_STORE_ADDRESS_MASK; >> + if(dma_memory_write(&address_space_memory, addr, cmd + 8, 8)){ >> + IOMMU_DPRINTF(ELOG, "error: fail to write at address >> 0%x"PRIx64, addr); >> + } >> + >> + } >> + >> + /* set completion interrupt */ > > When I was experimenting with a real IOMMU, it all looked like if both > COM_COMPLETION_STORE_MASK and COM_COMPLETION_BIT are set in the command, > only an interrupt is generated. Could someone comment on this? Which bit do you mean by COM_COMPLETION_BIT ?Do you mean 'COM_COMPLETION_INTR ? If yes, when would such a scenario occur ? I have checked on from the spec, I can't find anything worthwhile and I don't any of us is running an IOMMU - except you, so I guess you should tell us what to do... > > >> + if (cmd[0] & COM_COMPLETION_INTR){ >> + s->mmior[MMIO_STATUS] |= MMIO_STATUS_COMWAIT_INTR; >> + } >> +} >> + >> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >> +{ >> + unsigned type; >> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >> + >> + IOMMU_DPRINTF(COMMAND, ""); >> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >> + >> + if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, >> cmd, IOMMU_COMMAND_SIZE)){ >> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >> 0x%"PRIx64 >> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >> + } >> + >> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >> + >> + switch(type){ >> + case CMD_COMPLETION_WAIT: >> + /* pretend to wait for command execution to complete */ >> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >> + amd_iommu_completion_wait(s, cmd); >> + break; >> + case CMD_INVAL_DEVTAB_ENTRY: >> + /* Not implemented yet - should just clear device table >> contents */ >> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); >> + break; >> + case CMD_INVAL_IOMMU_PAGES: >> + /* invalidate IOMMU cache for a particular domain */ >> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >> + break; >> + case CMD_INVAL_IOTLB_PAGES: >> + /* Only present if remote IOTLB present */ >> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >> + break; >> + case CMD_INVAL_INTR_TABLE: >> + /* no support for interrupt remapping yet */ >> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >> + break; >> + default: >> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >> + break; >> + } >> + >> +} >> + >> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >> +{ >> + IOMMU_DPRINTF(COMMAND, ""); >> + >> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; >> + >> + if(!s->cmdbuf_enabled){ >> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >> + return; >> + } >> + >> + while(s->cmdbuf_head != s->cmdbuf_tail) { >> + /* check if there is work to do. */ >> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER >> tail at %x", >> + s->cmdbuf_head, s->cmdbuf_tail); >> + amd_iommu_cmdbuf_exec(s); >> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >> + >> + /* wrap head pointer */ >> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >> + s->cmdbuf_head = 0; >> + } >> + } >> + >> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >> +} >> + >> +/* System Software might never read from some of this fields but anyways >> */ >> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >> size) >> +{ >> + AMDIOMMUState *s = opaque; >> + >> + uint64_t val = -1; >> + if(addr + size > MMIO_SIZE) { >> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >> + ", got 0x%"PRIx64 " %d", >> + (uint64_t)MMIO_SIZE, addr, size); >> + return (uint64_t) - 1; >> + } >> + >> + switch(addr & ~0x07){ >> + case MMIO_DEVICE_TABLE: >> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_COMMAND_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EVENT_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_CONTROL: >> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EXCL_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EXCL_LIMIT: >> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_COMMAND_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_COMMAND_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EVENT_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EVENT_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_STATUS: >> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EXT_FEATURES: >> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + default: >> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + } >> + >> + return val; >> +} >> + >> +static void iommu_handle_control_write(AMDIOMMUState *s) >> +{ >> + /* read whatever is already written incase software is writing in >> chucks less than 8 bytes */ >> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >> + >> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >> + s->evtlog_enabled = s->enabled && !!(control & >> MMIO_CONTROL_EVENTLOGEN); >> + >> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >> + s->cmdbuf_enabled = s->enabled && !!(control & >> MMIO_CONTROL_CMDBUFLEN); >> + >> + /* update the flags depending on the control register */ >> + if(s->cmdbuf_enabled) { >> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >> + } else { >> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; >> + } >> + if (s->evtlog_enabled) { >> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >> + } else { >> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; >> + } >> + >> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >> + >> + amd_iommu_cmdbuf_run(s); >> +} >> + >> +/* FIXME: something might go wrong if System Software writes in chunks >> + * of one byte but linux writes in chunks of 4 bytes so currently it >> + * works correctly with linux but will definitely be busted if software >> + * reads/writes 8 bytes >> + */ >> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, >> unsigned size) >> +{ >> + >> + AMDIOMMUState *s = opaque; >> + unsigned long offset = addr & 0x07; >> + >> + if(addr + size > MMIO_SIZE) { >> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >> + ", got 0x%"PRIx64 " %d", >> + (uint64_t)MMIO_SIZE, addr, size); >> + return; >> + } >> + >> + switch(addr & ~0x07){ >> + case MMIO_CONTROL: >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + >> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 >> , addr, size, val, offset); >> + iommu_handle_control_write(s); >> + break; >> + >> + case MMIO_DEVICE_TABLE: >> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + >> + /* set device table address >> + * This also suffers from inability to tell whether software >> is done writing >> + */ >> + if(offset || (size == 8)){ >> + unsigned long device_base = amd_iommu_readq(s, >> MMIO_DEVICE_TABLE); >> + s->devtab = (dma_addr_t)(device_base & >> MMIO_CMDBUF_BASE_MASK); >> + /* set device table length */ >> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + >> 1) * (MMIO_DEVTAB_SIZE_UNIT / >> + MMIO_DEVTAB_ENTRY_SIZE); >> + } >> + break; >> + >> + case MMIO_COMMAND_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >> + amd_iommu_cmdbuf_run(s); >> + break; >> + >> + case MMIO_COMMAND_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + >> + /* FIXME - make sure System Software has finished writing >> incase it writes >> + * in chucks less than 8 bytes in a robust way.As for now, >> this hacks works >> + * for the linux driver >> + */ >> + if(offset || (size == 8)){ >> + unsigned long command_base = amd_iommu_readq(s, >> MMIO_COMMAND_BASE); >> + s->cmdbuf = (dma_addr_t)(command_base & >> MMIO_CMDBUF_BASE_MASK); >> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & >> MMIO_CMDBUF_SIZE_MASK); >> + s->cmdbuf_head = s->cmdbuf_tail = 0; >> + } >> + break; >> + >> + case MMIO_COMMAND_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + >> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >> + amd_iommu_cmdbuf_run(s); >> + break; >> + >> + case MMIO_EVENT_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >> + s->evtlog_len = 1UL << >> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >> + break; >> + >> + case MMIO_EXCL_LIMIT: >> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >> MMIO_EXCL_LIMIT_LOW; >> + break; >> + //TODO : Event handling fixes >> + >> + case MMIO_EVENT_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + >> + case MMIO_EVENT_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + /* PPR log base - unused for now */ >> + case MMIO_PPR_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + /* PPR log head - also unused for now */ >> + case MMIO_PPR_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + /* PPR log tail - unused for now */ >> + case MMIO_PPR_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + >> + default: >> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + ; >> + } >> + >> +} >> + >> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >> +{ >> + /* event logging not enabled */ >> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >> MMIO_STATUS_EVTLOG_OF){ >> + return; >> + } >> + >> + /* event log buffer full */ >> + if(s->evtlog_tail >= s->evtlog_len) { >> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >> + } >> + >> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >> s->evtlog_tail, &evt, EVENT_LEN)){ >> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, >> s->evtlog + s->evtlog_tail); >> + } >> + >> + s->evtlog_tail += EVENT_LEN; >> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >> + /* Disable logging if Overflow ? */ >> +} >> + >> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >> domid, dma_addr_t addr, int present, >> + int is_write) >> +{ >> + IOMMU_DPRINTF(ELOG, ""); >> + >> + AMDIOMMUEvent evt; >> + unsigned info; >> + uint16_t status; >> + >> + evt.devfn = cpu_to_le16(devfn); >> + evt.reserved = 0; >> + evt.domid = cpu_to_le16(domid); >> + evt.addr = cpu_to_le16(addr); >> + >> + info = EVENT_IOPF; >> + >> + if(present) { >> + info |= EVENT_IOPF_PR; >> + } >> + >> + if (is_write) { >> + info |= EVENT_IOPF_RW; >> + } >> + >> + /* log a page fault */ >> + amd_iommu_log_event(s, &evt); >> + >> + /* Abort the translation */ >> + status = pci_get_word(s->dev.config + PCI_STATUS); >> + pci_set_word(s->dev.config + PCI_STATUS, status | >> PCI_STATUS_SIG_TARGET_ABORT); >> +} >> + >> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >> +{ >> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >> +} >> + >> +/* FIXME deduplication */ >> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) >> +{ >> + AMDIOMMUState *s = opaque; >> + AMDIOMMUAddressSpace **iommu_as; >> + int bus_num = pci_bus_num(bus); >> + >> + /* just in case */ >> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >> + >> + iommu_as = s->address_spaces[bus_num]; >> + >> + /* allocate memory during the first run */ >> + if(!iommu_as) { >> + iommu_as = >> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >> + s->address_spaces[bus_num] = iommu_as; >> + } >> + >> + /* set up IOMMU region */ >> + if(!iommu_as[devfn]){ >> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >> + iommu_as[devfn]->devfn = (uint8_t)devfn; >> + iommu_as[devfn]->iommu_state = s; >> + >> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >> &s->iommu_ops, "amd-iommu", UINT64_MAX); >> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >> "amd-iommu"); >> + } >> + return &iommu_as[devfn]->as; >> +} >> + >> +/* validate a page table entry */ >> +static bool amd_iommu_validate_pte(uint64_t pte) >> +{ >> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >> +} >> + >> +/* get a device table entry given the device function */ >> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >> *entry) >> +{ >> + /* Could lead to out of range accesses */ >> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >> + >> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >> + if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, >> 32)){ >> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >> 0x%"PRIx64 >> + "offset 0x%"PRIx32, s->devtab, offset); >> + return false; >> + } >> + >> + if(!amd_iommu_validate_pte(entry[0])){ >> + IOMMU_DPRINTF(MMU, >> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >> + return false; >> + } >> + >> + return true; >> +} >> + >> +static uint64_t get_pte_translation_mode(uint64_t pte) >> +{ >> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >> + >> + if(level == 7){ >> + /* reserved level - abort ? */ >> + IOMMU_DPRINTF(MMU, >> + "Reserved translation level (7) detected"); >> + return 0; >> + } >> + >> + return level; >> +} >> + >> +/* TODO : Mark addresses as Accessed and Dirty */ >> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, >> bool is_write, IOMMUTLBEntry *ret) >> +{ >> + AMDIOMMUState *s = as->iommu_state; >> + >> + int present; >> + dma_addr_t pte_addr; >> + uint64_t entry[4], pte, pte_perms; >> + unsigned level; >> + unsigned perms; >> + >> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >> + goto no_translation; >> + } >> + >> + pte = entry[0]; >> + >> + /* >> + * It's okay to check for either read or write permissions >> + * even for memory maps, since we don't support R/W maps. >> + */ >> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >> + >> + if(!(level = get_pte_translation_mode(pte))){ >> + goto no_translation; >> + } >> + >> + while(level > 0){ >> + /* >> + * check permissions: the bitwise >> + * implication perms -> entry_perms must be true. Pages must be >> present >> + * and permissions on all levels must be similar >> + */ >> + pte_perms = amd_iommu_get_perms(pte); >> + present = pte & 1; >> + if(!present || perms != (perms & pte_perms)){ >> + amd_iommu_page_fault(s, as->devfn, entry[1] & >> DEV_DOMID_ID_MASK, addr, present, >> + !!(perms & IOMMU_PERM_WRITE)); >> + return; >> + } >> + >> + /* go to the next lower level */ >> + pte_addr = pte & DEV_PT_ROOT_MASK; >> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >> + pte = ldq_phys(&address_space_memory, pte_addr); >> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >> + } >> + >> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; >> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >> + ret->perm = IOMMU_RW; >> + return; >> + >> +no_translation: >> + ret->iova = addr; >> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >> + ret->perm = IOMMU_RW; >> + return; >> +} >> + >> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >> addr, bool is_write) >> +{ >> + >> + IOMMU_DPRINTF(GENERAL, ""); >> + >> + AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, >> iommu); >> + AMDIOMMUState *s = as->iommu_state; >> + >> + IOMMUTLBEntry ret = { >> + .target_as = &address_space_memory, >> + .iova = addr, >> + .translated_addr = 0, >> + .addr_mask = ~(hwaddr)0, >> + .perm = IOMMU_NONE, >> + }; >> + >> + if(!s->enabled){ >> + /* IOMMU disabled - corresponds to iommu=off not failure to >> provide any parameter */ >> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >> + ret.perm = IOMMU_RW; >> + return ret; >> + } >> + >> + amd_iommu_do_translate(as, addr, is_write, &ret); >> + >> + IOMMU_DPRINTF(MMU, >> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >> as->bus_num, >> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >> ret.translated_addr); >> + >> + return ret; >> +} >> + >> +static const MemoryRegionOps mmio_mem_ops = { >> + .read = amd_iommu_mmio_read, >> + .write = amd_iommu_mmio_write, >> + .endianness = DEVICE_LITTLE_ENDIAN, >> + .valid = { >> + .min_access_size = 1, >> + .max_access_size = 8, >> + .unaligned = false, >> + }, >> + >> + .valid = { >> + .min_access_size = 8, >> + .max_access_size = 8, >> + }, >> +}; >> + >> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, >> uint32_t guest_va, uint32_t *reg) >> +{ >> + *reg = 0; >> + >> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >> +} >> + >> +/* FIXME: The similar code in reset and init could be combined into a >> function */ >> +static void amd_iommu_reset(DeviceState *dev) >> +{ >> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >> + >> + uint32_t capab_header = CAPAB_FEATURES; >> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >> + uint32_t capab_range = 0xff000000; >> + uint32_t capab_misc = 0x0; >> + >> + /* reset MMIO */ >> + memset(s->mmior, 0, MMIO_SIZE); >> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >> + /* TODO :Disable event logging and reset all buffers */ >> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >> &capab_misc); >> + >> + /* reset IOMMU specific capabilities */ >> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >> capab_base_addr_low); >> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >> capab_base_addr_high); >> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >> capab_range); >> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >> capab_misc); >> + >> + /* reset device ident */ >> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >> + pci_config_set_class(s->dev.config, 0x0806); >> + pci_config_set_prog_interface(s->dev.config, 00); >> +} >> + >> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t >> val, int len) >> +{ >> + pci_default_write_config(dev, addr, val, len); >> +} >> + >> +/* I honestly don't know how to reserve MMIO */ >> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >> +{ >> + if(s->mmio.addr == addr){ >> + return; >> + } >> + >> +// if(s->mmio.addr != (hwaddr)-1) { >> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >> +// } >> + >> + s->mmio.addr = addr; >> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >> + >> +} >> + >> +static int amd_iommu_pci_initfn(PCIDevice *dev) >> +{ >> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >> + uint32_t capab_header = CAPAB_FEATURES; >> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); >> + uint32_t capab_range = 0xff000000; >> + uint32_t capab_misc = 0x0; >> + >> + memset(s->mmior, 0, MMIO_SIZE); >> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >> &capab_misc); >> + >> + s->iommu_ops.translate = amd_iommu_translate; >> + s->enabled = false; >> + s->ats_enabled = false; >> + s->cmdbuf_enabled = false; >> + s->devtab_len = 0; >> + s->cmdbuf_len = 0; >> + s->cmdbuf_head = 0; >> + s->cmdbuf_tail = 0; >> + s->evtlog_head = 0; >> + s->evtlog_tail = 0; >> + s->excl_enabled = false; >> + s->excl_allow = false; >> + s->mmio_enabled = false; >> + dev->config_write = amd_iommu_write_capab; >> + >> + size_t offset; >> + /* Save offset for IVRS */ >> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, >> CAPAB_SIZE); >> + pci_set_long(s->dev.config + offset, capab_header); >> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >> capab_base_addr_low); >> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >> capab_base_addr_high); >> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >> + >> + /* add msi and hypertransport capabilities */ >> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >> + >> + /* set up MMIO */ >> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >> "amd-iommu", MMIO_SIZE); >> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >> + >> + /* reset device ident */ >> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >> + >> + /* may not be necessary */ >> + pci_config_set_interrupt_pin(dev->config, 0x1a); >> + >> + return 0; >> +} >> + >> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >> +{ >> + amd_iommu_pci_initfn(dev); >> +} >> + >> +static const VMStateDescription vmstate_amd_iommu = { >> + .name = "amd-iommu", >> + .fields = (VMStateField[]) { >> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >> + VMSTATE_END_OF_LIST() >> + } >> +}; >> + >> +static Property amd_iommu_properties[] = { >> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >> + DEFINE_PROP_END_OF_LIST(), >> +}; >> + >> +/* not used for now but will be when cache is added */ >> +static void amd_iommu_uninit(PCIDevice *dev) >> +{ >> + return; >> +} >> + >> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >> +{ >> + DeviceClass *dc = DEVICE_CLASS(klass); >> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >> + >> + pci->realize = amd_iommu_realize; >> + pci->exit = amd_iommu_uninit; >> + >> + dc->reset = amd_iommu_reset; >> + dc->vmsd = &vmstate_amd_iommu; >> + dc->props = amd_iommu_properties; >> +} >> + >> +static const TypeInfo amd_iommu = { >> + .name = TYPE_AMD_IOMMU_DEVICE, >> + .parent = TYPE_PCI_DEVICE, >> + .instance_size = sizeof(AMDIOMMUState), >> + .class_init = amd_iommu_class_init >> +}; >> + >> +static void amd_iommu_register_types(void) >> +{ >> + type_register_static(&amd_iommu); >> +} >> + >> +type_init(amd_iommu_register_types); >> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >> new file mode 100644 >> index 0000000..90309eb >> --- /dev/null >> +++ b/hw/i386/amd_iommu.h >> @@ -0,0 +1,298 @@ >> +/* >> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >> + * >> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + >> + * You should have received a copy of the GNU General Public License >> along >> + * with this program; if not, see <http://www.gnu.org/licenses/>. >> + */ >> + >> +#ifndef AMD_IOMMU_H_ >> +#define AMD_IOMMU_H_ >> + >> +#include "hw/hw.h" >> +#include "hw/pci/pci.h" >> +#include "hw/sysbus.h" >> +#include "sysemu/dma.h" >> +#include "qemu/osdep.h" >> +#include "qemu/event_notifier.h" >> + >> +/* Capability registers */ >> +#define CAPAB_HEADER 0x00 >> +#define CAPAB_REV_TYPE 0x02 >> +#define CAPAB_FLAGS 0x03 >> +#define CAPAB_BAR_LOW 0x04 >> +#define CAPAB_BAR_HIGH 0x08 >> +#define CAPAB_RANGE 0x0C >> +#define CAPAB_MISC 0x10 >> +#define CAPAB_MISC1 0x14 >> + >> +#define CAPAB_SIZE 0x18 >> +#define CAPAB_REG_SIZE 0x04 >> + >> +/* Capability header data */ >> +#define CAPAB_FLAT_EXT (1 << 28) >> +#define CAPAB_EFR_SUP (1 << 27) >> +#define CAPAB_FLAG_NPCACHE (1 << 26) >> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >> +#define CAPAB_INIT_REV (1 << 19) >> +#define CAPAB_INIT_TYPE (3 << 16) >> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >> CAPAB_FLAG_HTTUNNEL) >> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >> + >> +/* MMIO registers */ >> +#define MMIO_DEVICE_TABLE 0x0000 >> +#define MMIO_COMMAND_BASE 0x0008 >> +#define MMIO_EVENT_BASE 0x0010 >> +#define MMIO_CONTROL 0x0018 >> +#define MMIO_EXCL_BASE 0x0020 >> +#define MMIO_EXCL_LIMIT 0x0028 >> +#define MMIO_EXT_FEATURES 0x0030 >> +#define MMIO_COMMAND_HEAD 0x2000 >> +#define MMIO_COMMAND_TAIL 0x2008 >> +#define MMIO_EVENT_HEAD 0x2010 >> +#define MMIO_EVENT_TAIL 0x2018 >> +#define MMIO_STATUS 0x2020 >> +#define MMIO_PPR_BASE 0x0038 >> +#define MMIO_PPR_HEAD 0x2030 >> +#define MMIO_PPR_TAIL 0x2038 >> + >> +#define MMIO_SIZE 0x4000 >> + >> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >> ~MMIO_DEVTAB_SIZE_MASK) >> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >> + >> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >> + >> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >> + >> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >> + >> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >> + >> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >> + >> +#define CMDBUF_ID_BYTE 0x07 >> +#define CMDBUF_ID_RSHIFT 4 >> +#define CMDBUF_ENTRY_SIZE 0x10 >> + >> +#define CMD_COMPLETION_WAIT 0x01 >> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >> +#define CMD_INVAL_IOMMU_PAGES 0x03 >> +#define CMD_INVAL_IOTLB_PAGES 0x04 >> +#define CMD_INVAL_INTR_TABLE 0x05 >> + >> +#define DEVTAB_ENTRY_SIZE 32 >> + >> +/* Device table entry bits 0:63 */ >> +#define DEV_VALID (1ULL << 0) >> +#define DEV_TRANSLATION_VALID (1ULL << 1) >> +#define DEV_MODE_MASK 0x7 >> +#define DEV_MODE_RSHIFT 9 >> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >> +#define DEV_PT_ROOT_RSHIFT 12 >> +#define DEV_PERM_SHIFT 61 >> +#define DEV_PERM_READ (1ULL << 61) >> +#define DEV_PERM_WRITE (1ULL << 62) >> + >> +/* Device table entry bits 64:127 */ >> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >> +#define DEV_SUPPRESS_PF (1ULL << 18) >> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >> +#define DEV_IOCTL_MASK (~3) >> +#define DEV_IOCTL_RSHIFT 20 >> +#define DEV_IOCTL_DENY 0 >> +#define DEV_IOCTL_PASSTHROUGH 1 >> +#define DEV_IOCTL_TRANSLATE 2 >> +#define DEV_CACHE (1ULL << 37) >> +#define DEV_SNOOP_DISABLE (1ULL << 38) >> +#define DEV_EXCL (1ULL << 39) >> + >> +/* Event codes and flags, as stored in the info field */ >> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >> +#define EVENT_IOPF (0x2U << 24) >> +#define EVENT_IOPF_I (1U << 3) >> +#define EVENT_IOPF_PR (1U << 4) >> +#define EVENT_IOPF_RW (1U << 5) >> +#define EVENT_IOPF_PE (1U << 6) >> +#define EVENT_IOPF_RZ (1U << 7) >> +#define EVENT_IOPF_TR (1U << 8) >> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >> + >> +#define EVENT_LEN 16 >> + >> +#define IOMMU_PERM_READ (1 << 0) >> +#define IOMMU_PERM_WRITE (1 << 1) >> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) >> + >> +/* AMD RD890 Chipset */ >> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >> + >> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >> register */ >> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >> register */ >> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >> register */ >> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >> */ >> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >> register 0 */ >> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >> register 1 */ >> + >> +#define FEATURE_PREFETCH (1ULL<<0) >> +#define FEATURE_PPR (1ULL<<1) >> +#define FEATURE_NX (1ULL<<3) >> +#define FEATURE_GT (1ULL<<4) >> +#define FEATURE_IA (1ULL<<6) >> +#define FEATURE_GA (1ULL<<7) >> +#define FEATURE_HE (1ULL<<8) >> +#define FEATURE_PC (1ULL<<9) >> + >> +/* IOMMU paging mode */ >> +#define GATS_MODE (6ULL << 12) >> +#define HATS_MODE (6ULL << 10) >> +/* PCI SIG constants */ >> +#define PCI_BUS_MAX 256 >> +#define PCI_SLOT_MAX 32 >> +#define PCI_FUNC_MAX 8 >> +#define PCI_DEVFN_MAX 256 >> + >> +/* extended feature support */ >> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) >> + >> +/* capabilities header */ >> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL >> | CAPAB_EFR_SUP) >> + >> +/* command constants */ >> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >> +#define COM_COMPLETION_STORE_MASK 0x1 >> +#define COM_COMPLETION_INTR 0x2 >> +#define COM_COMPLETION_DATA_OFF 0x8 >> +#define IOMMU_COMMAND_SIZE 0x10 >> + >> +/* IOMMU default address */ >> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >> + >> +/* page management constants */ >> +#define IOMMU_PAGE_SHIFT 12 >> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >> + >> +#define IOMMU_PAGE_SHIFT_4K 12 >> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >> +#define IOMMU_PAGE_SHIFT_2M 21 >> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >> +#define IOMMU_PAGE_SHIFT_1G 30 >> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >> + >> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >> +#define AMD_IOMMU_DEVICE(obj)\ >> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >> + >> +typedef struct AMDIOMMUState AMDIOMMUState; >> + >> +typedef struct AMDIOMMUAddressSpace{ >> + uint8_t bus_num; /* bus number >> */ >> + uint8_t devfn; /* device function >> */ >> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >> */ >> + MemoryRegion iommu; /* Device's iommu region >> */ >> + AddressSpace as; /* device's corresponding address space >> */ >> +}AMDIOMMUAddressSpace; >> + >> +struct AMDIOMMUState { >> + PCIDevice dev; /* The PCI device itself */ >> + >> + uint32_t version; >> + >> + int capab_offset; /* capability offset pointer */ >> + unsigned char *capab; /* capabilities registers */ >> + >> + bool enabled; /* IOMMU enabled */ >> + bool ats_enabled; /* address translation enabled */ >> + bool cmdbuf_enabled; /* command buffer enabled */ >> + bool evtlog_enabled; /* event log enabled */ >> + bool excl_enabled; >> + >> + dma_addr_t devtab; /* base address device table */ >> + size_t devtab_len; /* device table length */ >> + >> + dma_addr_t cmdbuf; /* command buffer base address */ >> + uint64_t cmdbuf_len; /* command buffer length */ >> + unsigned cmdbuf_head; /* current IOMMU read position */ >> + unsigned cmdbuf_tail; /* next Software write position */ >> + int completion_wait_intr; >> + >> + dma_addr_t evtlog; /* base address event log */ >> + size_t evtlog_intr; >> + size_t evtlog_len; /* event log length */ >> + size_t evtlog_head; /* event log head */ >> + size_t evtlog_tail; /* event log tail */ >> + >> + /* unused for now */ >> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >> + bool excl_allow; /* translate accesses to the exclusion >> range */ >> + bool excl_enable; /* exclusion range enabled */ >> + >> + MemoryRegion mmio; /* MMIO region */ >> + unsigned char mmior[MMIO_SIZE]; >> + bool mmio_enabled; >> + >> + /* IOMMU function */ >> + MemoryRegionIOMMUOps iommu_ops; >> + >> + /* for each served device */ >> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >> +}; >> + >> +typedef struct AMDIOMMUEvent { >> + uint16_t devfn; >> + uint16_t reserved; >> + uint16_t domid; >> + uint16_t info; >> + uint16_t addr; >> +} __attribute__((packed)) AMDIOMMUEvent; >> + >> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >> devfn); >> + >> +#endif >> > > Thanks, > Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-08-25 7:25 ` David kiarie @ 2015-08-25 7:31 ` Valentine Sinitsyn 2015-08-25 7:41 ` David kiarie 0 siblings, 1 reply; 22+ messages in thread From: Valentine Sinitsyn @ 2015-08-25 7:31 UTC (permalink / raw) To: David kiarie; +Cc: Jan Kiszka, qemu-devel, mst On 25.08.2015 12:25, David kiarie wrote: > On Tue, Aug 25, 2015 at 9:39 AM, Valentine Sinitsyn > <valentine.sinitsyn@gmail.com> wrote: >> Hi, >> >> >> On 25.08.2015 04:19, David Kiarie wrote: >>> >>> From: David <davidkiarie4@gmail.com> >>> >>> Add AMD IOMMU emulation to Qemu. This is a very basic AMD IOMMU >>> emulation that only does translation and some basic Event logging. >>> Guest translation enables nested PCI passthrough >>> >>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >>> --- >>> hw/i386/Makefile.objs | 1 + >>> hw/i386/amd_iommu.c | 993 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++ >>> hw/i386/amd_iommu.h | 298 +++++++++++++++ >>> 3 files changed, 1292 insertions(+) >>> create mode 100644 hw/i386/amd_iommu.c >>> create mode 100644 hw/i386/amd_iommu.h >>> >>> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs >>> index ebd1015..2bae11c 100644 >>> --- a/hw/i386/Makefile.objs >>> +++ b/hw/i386/Makefile.objs >>> @@ -3,6 +3,7 @@ obj-y += multiboot.o >>> obj-y += pc.o pc_piix.o pc_q35.o >>> obj-y += pc_sysfw.o >>> obj-y += intel_iommu.o >>> +obj-y += amd_iommu.o >>> obj-$(CONFIG_XEN) += ../xenpv/ xen/ >>> >>> obj-y += kvmvapic.o >>> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c >>> new file mode 100644 >>> index 0000000..a3a0b20 >>> --- /dev/null >>> +++ b/hw/i386/amd_iommu.c >>> @@ -0,0 +1,993 @@ >>> +/* >>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>> + * >>> + * Copyright (C) 2011 Eduard - Gabriel Munteanu >>> + * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + >>> + * You should have received a copy of the GNU General Public License >>> along >>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>> + * >>> + */ >>> +#include "hw/i386/amd_iommu.h" >>> + >>> +#define PCI_EXT_CAP_ID_PASID 0x1B >>> +#define PCI_EXT_CAP_ID_PRI 0x13 >>> + >>> +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) >>> +#define PCI_FUNC(devfn) ((devfn) & 0x07) >>> + >>> +#define MAX_VA_ADDR (64UL << 5) >>> +#define MAX_PH_ADDR (48UL << 8) >>> +#define MAX_GVA_ADDR (64UL << 15) >>> + >>> +//#define DEBUG_AMD_IOMMU >>> +#ifdef DEBUG_AMD_IOMMU >>> +enum { >>> + DEBUG_GENERAL, DEBUG_CAPAB, DEBUG_MMIO, DEBUG_ELOG, >>> + DEBUG_CACHE, DEBUG_COMMAND, DEBUG_MMU >>> +}; >>> + >>> +#define IOMMU_DBGBIT(x) (1 << DEBUG_##x) >>> +static int iommu_dbgflags = IOMMU_DBGBIT(GENERAL) | IOMMU_DBGBIT(MMU) | >>> IOMMU_DBGBIT(MMIO); >>> +//| IOMMU_DBGBIT(CAPAB) | IOMMU_DBGBIT(ELOG) | IOMMU_DBGBIT(CACHE) | >>> IOMMU_DBGBIT(COMMAND); >>> + >>> +#define IOMMU_DPRINTF(what, fmt, ...) do { \ >>> + if (iommu_dbgflags & IOMMU_DBGBIT(what)) { \ >>> + fprintf(stderr, "(amd-iommu)%s: " fmt "\n", __func__, \ >>> + ## __VA_ARGS__); } \ >>> + } while (0) >>> +#else >>> +#define IOMMU_DPRINTF(what, fmt, ...) do {} while (0) >>> +#endif >>> + >>> +/* helper functions - FIXME - provide for reading one byte */ >>> +static uint16_t amd_iommu_readw(AMDIOMMUState *s, hwaddr addr) >>> +{ >>> + return lduw_le_p(&s->mmior[addr]); >>> +} >>> + >>> +static uint32_t amd_iommu_readl(AMDIOMMUState *s, hwaddr addr) >>> +{ >>> + return ldl_le_p(&s->mmior[addr]); >>> +} >>> + >>> +static uint64_t amd_iommu_readq(AMDIOMMUState *s, hwaddr addr) >>> +{ >>> + return ldq_le_p(&s->mmior[addr]); >>> +} >>> + >>> +static void amd_iommu_writew(AMDIOMMUState *s, hwaddr addr, uint16_t val) >>> +{ >>> + stw_le_p(&s->mmior[addr], val); >>> +} >>> + >>> +static void amd_iommu_writel(AMDIOMMUState *s, hwaddr addr, uint32_t val) >>> +{ >>> + stl_le_p(&s->mmior[addr], val); >>> +} >>> + >>> +static void amd_iommu_writeq(AMDIOMMUState *s, hwaddr addr, uint64_t val) >>> +{ >>> + stq_le_p(&s->mmior[addr], val); >>> +} >>> + >>> +/* execute a completion wait command */ >>> +static void amd_iommu_completion_wait(AMDIOMMUState *s, uint8_t *cmd) >>> +{ >>> + unsigned int addr; >>> + >>> + /* completion store */ >>> + if(cmd[0] & COM_COMPLETION_STORE_MASK){ >>> + addr = le64_to_cpu(*(uint64_t*)cmd) & COM_STORE_ADDRESS_MASK; >>> + if(dma_memory_write(&address_space_memory, addr, cmd + 8, 8)){ >>> + IOMMU_DPRINTF(ELOG, "error: fail to write at address >>> 0%x"PRIx64, addr); >>> + } >>> + >>> + } >>> + >>> + /* set completion interrupt */ >> >> When I was experimenting with a real IOMMU, it all looked like if both >> COM_COMPLETION_STORE_MASK and COM_COMPLETION_BIT are set in the command, >> only an interrupt is generated. Could someone comment on this? > > Which bit do you mean by COM_COMPLETION_BIT ?Do you mean > 'COM_COMPLETION_INTR ? If yes, when would such a scenario occur ? I was referring to COM_COMPLETION_INTR, sorry for the typo. > I have checked on from the spec, I can't find anything worthwhile and > I don't any of us is running an IOMMU - except you, so I guess you > should tell us what to do... The spec doesn't say anything about this, I checked it. IIRC, I came across this behavior when submitted COMPLETION_WAIT command with interrupts off and spin in a while() loop waiting for the mask to be written. The loop never finished, but everything worked as intended if I removed COM_COMPLETION_INTR for the command. > >> >> >>> + if (cmd[0] & COM_COMPLETION_INTR){ >>> + s->mmior[MMIO_STATUS] |= MMIO_STATUS_COMWAIT_INTR; >>> + } >>> +} >>> + >>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>> +{ >>> + unsigned type; >>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>> + >>> + IOMMU_DPRINTF(COMMAND, ""); >>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>> + >>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, >>> cmd, IOMMU_COMMAND_SIZE)){ >>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>> 0x%"PRIx64 >>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>> + } >>> + >>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>> + >>> + switch(type){ >>> + case CMD_COMPLETION_WAIT: >>> + /* pretend to wait for command execution to complete */ >>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>> + amd_iommu_completion_wait(s, cmd); >>> + break; >>> + case CMD_INVAL_DEVTAB_ENTRY: >>> + /* Not implemented yet - should just clear device table >>> contents */ >>> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); >>> + break; >>> + case CMD_INVAL_IOMMU_PAGES: >>> + /* invalidate IOMMU cache for a particular domain */ >>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>> + break; >>> + case CMD_INVAL_IOTLB_PAGES: >>> + /* Only present if remote IOTLB present */ >>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>> + break; >>> + case CMD_INVAL_INTR_TABLE: >>> + /* no support for interrupt remapping yet */ >>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>> + break; >>> + default: >>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>> + break; >>> + } >>> + >>> +} >>> + >>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>> +{ >>> + IOMMU_DPRINTF(COMMAND, ""); >>> + >>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; >>> + >>> + if(!s->cmdbuf_enabled){ >>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>> + return; >>> + } >>> + >>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>> + /* check if there is work to do. */ >>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER >>> tail at %x", >>> + s->cmdbuf_head, s->cmdbuf_tail); >>> + amd_iommu_cmdbuf_exec(s); >>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>> + >>> + /* wrap head pointer */ >>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>> + s->cmdbuf_head = 0; >>> + } >>> + } >>> + >>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>> +} >>> + >>> +/* System Software might never read from some of this fields but anyways >>> */ >>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >>> size) >>> +{ >>> + AMDIOMMUState *s = opaque; >>> + >>> + uint64_t val = -1; >>> + if(addr + size > MMIO_SIZE) { >>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >>> + ", got 0x%"PRIx64 " %d", >>> + (uint64_t)MMIO_SIZE, addr, size); >>> + return (uint64_t) - 1; >>> + } >>> + >>> + switch(addr & ~0x07){ >>> + case MMIO_DEVICE_TABLE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EVENT_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_CONTROL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EXCL_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EXCL_LIMIT: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EVENT_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EVENT_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_STATUS: >>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EXT_FEATURES: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + default: >>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + } >>> + >>> + return val; >>> +} >>> + >>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>> +{ >>> + /* read whatever is already written incase software is writing in >>> chucks less than 8 bytes */ >>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>> + >>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>> + s->evtlog_enabled = s->enabled && !!(control & >>> MMIO_CONTROL_EVENTLOGEN); >>> + >>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >>> + s->cmdbuf_enabled = s->enabled && !!(control & >>> MMIO_CONTROL_CMDBUFLEN); >>> + >>> + /* update the flags depending on the control register */ >>> + if(s->cmdbuf_enabled) { >>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >>> + } else { >>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; >>> + } >>> + if (s->evtlog_enabled) { >>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >>> + } else { >>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; >>> + } >>> + >>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>> + >>> + amd_iommu_cmdbuf_run(s); >>> +} >>> + >>> +/* FIXME: something might go wrong if System Software writes in chunks >>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>> + * works correctly with linux but will definitely be busted if software >>> + * reads/writes 8 bytes >>> + */ >>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, >>> unsigned size) >>> +{ >>> + >>> + AMDIOMMUState *s = opaque; >>> + unsigned long offset = addr & 0x07; >>> + >>> + if(addr + size > MMIO_SIZE) { >>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >>> + ", got 0x%"PRIx64 " %d", >>> + (uint64_t)MMIO_SIZE, addr, size); >>> + return; >>> + } >>> + >>> + switch(addr & ~0x07){ >>> + case MMIO_CONTROL: >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + >>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 >>> , addr, size, val, offset); >>> + iommu_handle_control_write(s); >>> + break; >>> + >>> + case MMIO_DEVICE_TABLE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + >>> + /* set device table address >>> + * This also suffers from inability to tell whether software >>> is done writing >>> + */ >>> + if(offset || (size == 8)){ >>> + unsigned long device_base = amd_iommu_readq(s, >>> MMIO_DEVICE_TABLE); >>> + s->devtab = (dma_addr_t)(device_base & >>> MMIO_CMDBUF_BASE_MASK); >>> + /* set device table length */ >>> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + >>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>> + MMIO_DEVTAB_ENTRY_SIZE); >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>> + amd_iommu_cmdbuf_run(s); >>> + break; >>> + >>> + case MMIO_COMMAND_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + >>> + /* FIXME - make sure System Software has finished writing >>> incase it writes >>> + * in chucks less than 8 bytes in a robust way.As for now, >>> this hacks works >>> + * for the linux driver >>> + */ >>> + if(offset || (size == 8)){ >>> + unsigned long command_base = amd_iommu_readq(s, >>> MMIO_COMMAND_BASE); >>> + s->cmdbuf = (dma_addr_t)(command_base & >>> MMIO_CMDBUF_BASE_MASK); >>> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & >>> MMIO_CMDBUF_SIZE_MASK); >>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + >>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>> + amd_iommu_cmdbuf_run(s); >>> + break; >>> + >>> + case MMIO_EVENT_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>> + s->evtlog_len = 1UL << >>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >>> + break; >>> + >>> + case MMIO_EXCL_LIMIT: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>> MMIO_EXCL_LIMIT_LOW; >>> + break; >>> + //TODO : Event handling fixes >>> + >>> + case MMIO_EVENT_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + >>> + case MMIO_EVENT_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + /* PPR log base - unused for now */ >>> + case MMIO_PPR_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + /* PPR log head - also unused for now */ >>> + case MMIO_PPR_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + /* PPR log tail - unused for now */ >>> + case MMIO_PPR_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + >>> + default: >>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + ; >>> + } >>> + >>> +} >>> + >>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>> +{ >>> + /* event logging not enabled */ >>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>> MMIO_STATUS_EVTLOG_OF){ >>> + return; >>> + } >>> + >>> + /* event log buffer full */ >>> + if(s->evtlog_tail >= s->evtlog_len) { >>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>> + } >>> + >>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>> s->evtlog_tail, &evt, EVENT_LEN)){ >>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, >>> s->evtlog + s->evtlog_tail); >>> + } >>> + >>> + s->evtlog_tail += EVENT_LEN; >>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>> + /* Disable logging if Overflow ? */ >>> +} >>> + >>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >>> domid, dma_addr_t addr, int present, >>> + int is_write) >>> +{ >>> + IOMMU_DPRINTF(ELOG, ""); >>> + >>> + AMDIOMMUEvent evt; >>> + unsigned info; >>> + uint16_t status; >>> + >>> + evt.devfn = cpu_to_le16(devfn); >>> + evt.reserved = 0; >>> + evt.domid = cpu_to_le16(domid); >>> + evt.addr = cpu_to_le16(addr); >>> + >>> + info = EVENT_IOPF; >>> + >>> + if(present) { >>> + info |= EVENT_IOPF_PR; >>> + } >>> + >>> + if (is_write) { >>> + info |= EVENT_IOPF_RW; >>> + } >>> + >>> + /* log a page fault */ >>> + amd_iommu_log_event(s, &evt); >>> + >>> + /* Abort the translation */ >>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>> PCI_STATUS_SIG_TARGET_ABORT); >>> +} >>> + >>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>> +{ >>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >>> +} >>> + >>> +/* FIXME deduplication */ >>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) >>> +{ >>> + AMDIOMMUState *s = opaque; >>> + AMDIOMMUAddressSpace **iommu_as; >>> + int bus_num = pci_bus_num(bus); >>> + >>> + /* just in case */ >>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>> + >>> + iommu_as = s->address_spaces[bus_num]; >>> + >>> + /* allocate memory during the first run */ >>> + if(!iommu_as) { >>> + iommu_as = >>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>> + s->address_spaces[bus_num] = iommu_as; >>> + } >>> + >>> + /* set up IOMMU region */ >>> + if(!iommu_as[devfn]){ >>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>> + iommu_as[devfn]->iommu_state = s; >>> + >>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>> "amd-iommu"); >>> + } >>> + return &iommu_as[devfn]->as; >>> +} >>> + >>> +/* validate a page table entry */ >>> +static bool amd_iommu_validate_pte(uint64_t pte) >>> +{ >>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>> +} >>> + >>> +/* get a device table entry given the device function */ >>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>> *entry) >>> +{ >>> + /* Could lead to out of range accesses */ >>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>> + >>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, >>> 32)){ >>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>> 0x%"PRIx64 >>> + "offset 0x%"PRIx32, s->devtab, offset); >>> + return false; >>> + } >>> + >>> + if(!amd_iommu_validate_pte(entry[0])){ >>> + IOMMU_DPRINTF(MMU, >>> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >>> + return false; >>> + } >>> + >>> + return true; >>> +} >>> + >>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>> +{ >>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>> + >>> + if(level == 7){ >>> + /* reserved level - abort ? */ >>> + IOMMU_DPRINTF(MMU, >>> + "Reserved translation level (7) detected"); >>> + return 0; >>> + } >>> + >>> + return level; >>> +} >>> + >>> +/* TODO : Mark addresses as Accessed and Dirty */ >>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, >>> bool is_write, IOMMUTLBEntry *ret) >>> +{ >>> + AMDIOMMUState *s = as->iommu_state; >>> + >>> + int present; >>> + dma_addr_t pte_addr; >>> + uint64_t entry[4], pte, pte_perms; >>> + unsigned level; >>> + unsigned perms; >>> + >>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>> + goto no_translation; >>> + } >>> + >>> + pte = entry[0]; >>> + >>> + /* >>> + * It's okay to check for either read or write permissions >>> + * even for memory maps, since we don't support R/W maps. >>> + */ >>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>> + >>> + if(!(level = get_pte_translation_mode(pte))){ >>> + goto no_translation; >>> + } >>> + >>> + while(level > 0){ >>> + /* >>> + * check permissions: the bitwise >>> + * implication perms -> entry_perms must be true. Pages must be >>> present >>> + * and permissions on all levels must be similar >>> + */ >>> + pte_perms = amd_iommu_get_perms(pte); >>> + present = pte & 1; >>> + if(!present || perms != (perms & pte_perms)){ >>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>> DEV_DOMID_ID_MASK, addr, present, >>> + !!(perms & IOMMU_PERM_WRITE)); >>> + return; >>> + } >>> + >>> + /* go to the next lower level */ >>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>> + pte = ldq_phys(&address_space_memory, pte_addr); >>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>> + } >>> + >>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; >>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>> + ret->perm = IOMMU_RW; >>> + return; >>> + >>> +no_translation: >>> + ret->iova = addr; >>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>> + ret->perm = IOMMU_RW; >>> + return; >>> +} >>> + >>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>> addr, bool is_write) >>> +{ >>> + >>> + IOMMU_DPRINTF(GENERAL, ""); >>> + >>> + AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, >>> iommu); >>> + AMDIOMMUState *s = as->iommu_state; >>> + >>> + IOMMUTLBEntry ret = { >>> + .target_as = &address_space_memory, >>> + .iova = addr, >>> + .translated_addr = 0, >>> + .addr_mask = ~(hwaddr)0, >>> + .perm = IOMMU_NONE, >>> + }; >>> + >>> + if(!s->enabled){ >>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>> provide any parameter */ >>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>> + ret.perm = IOMMU_RW; >>> + return ret; >>> + } >>> + >>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>> + >>> + IOMMU_DPRINTF(MMU, >>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >>> as->bus_num, >>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>> ret.translated_addr); >>> + >>> + return ret; >>> +} >>> + >>> +static const MemoryRegionOps mmio_mem_ops = { >>> + .read = amd_iommu_mmio_read, >>> + .write = amd_iommu_mmio_write, >>> + .endianness = DEVICE_LITTLE_ENDIAN, >>> + .valid = { >>> + .min_access_size = 1, >>> + .max_access_size = 8, >>> + .unaligned = false, >>> + }, >>> + >>> + .valid = { >>> + .min_access_size = 8, >>> + .max_access_size = 8, >>> + }, >>> +}; >>> + >>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, >>> uint32_t guest_va, uint32_t *reg) >>> +{ >>> + *reg = 0; >>> + >>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>> +} >>> + >>> +/* FIXME: The similar code in reset and init could be combined into a >>> function */ >>> +static void amd_iommu_reset(DeviceState *dev) >>> +{ >>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>> + >>> + uint32_t capab_header = CAPAB_FEATURES; >>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>> + uint32_t capab_range = 0xff000000; >>> + uint32_t capab_misc = 0x0; >>> + >>> + /* reset MMIO */ >>> + memset(s->mmior, 0, MMIO_SIZE); >>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>> + /* TODO :Disable event logging and reset all buffers */ >>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>> &capab_misc); >>> + >>> + /* reset IOMMU specific capabilities */ >>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>> capab_base_addr_low); >>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>> capab_base_addr_high); >>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>> capab_range); >>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>> capab_misc); >>> + >>> + /* reset device ident */ >>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >>> + pci_config_set_class(s->dev.config, 0x0806); >>> + pci_config_set_prog_interface(s->dev.config, 00); >>> +} >>> + >>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t >>> val, int len) >>> +{ >>> + pci_default_write_config(dev, addr, val, len); >>> +} >>> + >>> +/* I honestly don't know how to reserve MMIO */ >>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>> +{ >>> + if(s->mmio.addr == addr){ >>> + return; >>> + } >>> + >>> +// if(s->mmio.addr != (hwaddr)-1) { >>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>> +// } >>> + >>> + s->mmio.addr = addr; >>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>> + >>> +} >>> + >>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>> +{ >>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>> + uint32_t capab_header = CAPAB_FEATURES; >>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); >>> + uint32_t capab_range = 0xff000000; >>> + uint32_t capab_misc = 0x0; >>> + >>> + memset(s->mmior, 0, MMIO_SIZE); >>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>> &capab_misc); >>> + >>> + s->iommu_ops.translate = amd_iommu_translate; >>> + s->enabled = false; >>> + s->ats_enabled = false; >>> + s->cmdbuf_enabled = false; >>> + s->devtab_len = 0; >>> + s->cmdbuf_len = 0; >>> + s->cmdbuf_head = 0; >>> + s->cmdbuf_tail = 0; >>> + s->evtlog_head = 0; >>> + s->evtlog_tail = 0; >>> + s->excl_enabled = false; >>> + s->excl_allow = false; >>> + s->mmio_enabled = false; >>> + dev->config_write = amd_iommu_write_capab; >>> + >>> + size_t offset; >>> + /* Save offset for IVRS */ >>> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, >>> CAPAB_SIZE); >>> + pci_set_long(s->dev.config + offset, capab_header); >>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>> capab_base_addr_low); >>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>> capab_base_addr_high); >>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>> + >>> + /* add msi and hypertransport capabilities */ >>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>> + >>> + /* set up MMIO */ >>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>> "amd-iommu", MMIO_SIZE); >>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>> + >>> + /* reset device ident */ >>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>> + >>> + /* may not be necessary */ >>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>> + >>> + return 0; >>> +} >>> + >>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>> +{ >>> + amd_iommu_pci_initfn(dev); >>> +} >>> + >>> +static const VMStateDescription vmstate_amd_iommu = { >>> + .name = "amd-iommu", >>> + .fields = (VMStateField[]) { >>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>> + VMSTATE_END_OF_LIST() >>> + } >>> +}; >>> + >>> +static Property amd_iommu_properties[] = { >>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>> + DEFINE_PROP_END_OF_LIST(), >>> +}; >>> + >>> +/* not used for now but will be when cache is added */ >>> +static void amd_iommu_uninit(PCIDevice *dev) >>> +{ >>> + return; >>> +} >>> + >>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>> +{ >>> + DeviceClass *dc = DEVICE_CLASS(klass); >>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>> + >>> + pci->realize = amd_iommu_realize; >>> + pci->exit = amd_iommu_uninit; >>> + >>> + dc->reset = amd_iommu_reset; >>> + dc->vmsd = &vmstate_amd_iommu; >>> + dc->props = amd_iommu_properties; >>> +} >>> + >>> +static const TypeInfo amd_iommu = { >>> + .name = TYPE_AMD_IOMMU_DEVICE, >>> + .parent = TYPE_PCI_DEVICE, >>> + .instance_size = sizeof(AMDIOMMUState), >>> + .class_init = amd_iommu_class_init >>> +}; >>> + >>> +static void amd_iommu_register_types(void) >>> +{ >>> + type_register_static(&amd_iommu); >>> +} >>> + >>> +type_init(amd_iommu_register_types); >>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>> new file mode 100644 >>> index 0000000..90309eb >>> --- /dev/null >>> +++ b/hw/i386/amd_iommu.h >>> @@ -0,0 +1,298 @@ >>> +/* >>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>> + * >>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + >>> + * You should have received a copy of the GNU General Public License >>> along >>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>> + */ >>> + >>> +#ifndef AMD_IOMMU_H_ >>> +#define AMD_IOMMU_H_ >>> + >>> +#include "hw/hw.h" >>> +#include "hw/pci/pci.h" >>> +#include "hw/sysbus.h" >>> +#include "sysemu/dma.h" >>> +#include "qemu/osdep.h" >>> +#include "qemu/event_notifier.h" >>> + >>> +/* Capability registers */ >>> +#define CAPAB_HEADER 0x00 >>> +#define CAPAB_REV_TYPE 0x02 >>> +#define CAPAB_FLAGS 0x03 >>> +#define CAPAB_BAR_LOW 0x04 >>> +#define CAPAB_BAR_HIGH 0x08 >>> +#define CAPAB_RANGE 0x0C >>> +#define CAPAB_MISC 0x10 >>> +#define CAPAB_MISC1 0x14 >>> + >>> +#define CAPAB_SIZE 0x18 >>> +#define CAPAB_REG_SIZE 0x04 >>> + >>> +/* Capability header data */ >>> +#define CAPAB_FLAT_EXT (1 << 28) >>> +#define CAPAB_EFR_SUP (1 << 27) >>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>> +#define CAPAB_INIT_REV (1 << 19) >>> +#define CAPAB_INIT_TYPE (3 << 16) >>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>> CAPAB_FLAG_HTTUNNEL) >>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>> + >>> +/* MMIO registers */ >>> +#define MMIO_DEVICE_TABLE 0x0000 >>> +#define MMIO_COMMAND_BASE 0x0008 >>> +#define MMIO_EVENT_BASE 0x0010 >>> +#define MMIO_CONTROL 0x0018 >>> +#define MMIO_EXCL_BASE 0x0020 >>> +#define MMIO_EXCL_LIMIT 0x0028 >>> +#define MMIO_EXT_FEATURES 0x0030 >>> +#define MMIO_COMMAND_HEAD 0x2000 >>> +#define MMIO_COMMAND_TAIL 0x2008 >>> +#define MMIO_EVENT_HEAD 0x2010 >>> +#define MMIO_EVENT_TAIL 0x2018 >>> +#define MMIO_STATUS 0x2020 >>> +#define MMIO_PPR_BASE 0x0038 >>> +#define MMIO_PPR_HEAD 0x2030 >>> +#define MMIO_PPR_TAIL 0x2038 >>> + >>> +#define MMIO_SIZE 0x4000 >>> + >>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>> ~MMIO_DEVTAB_SIZE_MASK) >>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>> + >>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>> + >>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>> + >>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>> + >>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>> + >>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>> + >>> +#define CMDBUF_ID_BYTE 0x07 >>> +#define CMDBUF_ID_RSHIFT 4 >>> +#define CMDBUF_ENTRY_SIZE 0x10 >>> + >>> +#define CMD_COMPLETION_WAIT 0x01 >>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>> +#define CMD_INVAL_INTR_TABLE 0x05 >>> + >>> +#define DEVTAB_ENTRY_SIZE 32 >>> + >>> +/* Device table entry bits 0:63 */ >>> +#define DEV_VALID (1ULL << 0) >>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>> +#define DEV_MODE_MASK 0x7 >>> +#define DEV_MODE_RSHIFT 9 >>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>> +#define DEV_PT_ROOT_RSHIFT 12 >>> +#define DEV_PERM_SHIFT 61 >>> +#define DEV_PERM_READ (1ULL << 61) >>> +#define DEV_PERM_WRITE (1ULL << 62) >>> + >>> +/* Device table entry bits 64:127 */ >>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>> +#define DEV_IOCTL_MASK (~3) >>> +#define DEV_IOCTL_RSHIFT 20 >>> +#define DEV_IOCTL_DENY 0 >>> +#define DEV_IOCTL_PASSTHROUGH 1 >>> +#define DEV_IOCTL_TRANSLATE 2 >>> +#define DEV_CACHE (1ULL << 37) >>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>> +#define DEV_EXCL (1ULL << 39) >>> + >>> +/* Event codes and flags, as stored in the info field */ >>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>> +#define EVENT_IOPF (0x2U << 24) >>> +#define EVENT_IOPF_I (1U << 3) >>> +#define EVENT_IOPF_PR (1U << 4) >>> +#define EVENT_IOPF_RW (1U << 5) >>> +#define EVENT_IOPF_PE (1U << 6) >>> +#define EVENT_IOPF_RZ (1U << 7) >>> +#define EVENT_IOPF_TR (1U << 8) >>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>> + >>> +#define EVENT_LEN 16 >>> + >>> +#define IOMMU_PERM_READ (1 << 0) >>> +#define IOMMU_PERM_WRITE (1 << 1) >>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) >>> + >>> +/* AMD RD890 Chipset */ >>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>> + >>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>> register */ >>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>> register */ >>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>> register */ >>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>> */ >>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >>> register 0 */ >>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >>> register 1 */ >>> + >>> +#define FEATURE_PREFETCH (1ULL<<0) >>> +#define FEATURE_PPR (1ULL<<1) >>> +#define FEATURE_NX (1ULL<<3) >>> +#define FEATURE_GT (1ULL<<4) >>> +#define FEATURE_IA (1ULL<<6) >>> +#define FEATURE_GA (1ULL<<7) >>> +#define FEATURE_HE (1ULL<<8) >>> +#define FEATURE_PC (1ULL<<9) >>> + >>> +/* IOMMU paging mode */ >>> +#define GATS_MODE (6ULL << 12) >>> +#define HATS_MODE (6ULL << 10) >>> +/* PCI SIG constants */ >>> +#define PCI_BUS_MAX 256 >>> +#define PCI_SLOT_MAX 32 >>> +#define PCI_FUNC_MAX 8 >>> +#define PCI_DEVFN_MAX 256 >>> + >>> +/* extended feature support */ >>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) >>> + >>> +/* capabilities header */ >>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL >>> | CAPAB_EFR_SUP) >>> + >>> +/* command constants */ >>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>> +#define COM_COMPLETION_STORE_MASK 0x1 >>> +#define COM_COMPLETION_INTR 0x2 >>> +#define COM_COMPLETION_DATA_OFF 0x8 >>> +#define IOMMU_COMMAND_SIZE 0x10 >>> + >>> +/* IOMMU default address */ >>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>> + >>> +/* page management constants */ >>> +#define IOMMU_PAGE_SHIFT 12 >>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>> + >>> +#define IOMMU_PAGE_SHIFT_4K 12 >>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>> +#define IOMMU_PAGE_SHIFT_2M 21 >>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>> +#define IOMMU_PAGE_SHIFT_1G 30 >>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>> + >>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>> +#define AMD_IOMMU_DEVICE(obj)\ >>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>> + >>> +typedef struct AMDIOMMUState AMDIOMMUState; >>> + >>> +typedef struct AMDIOMMUAddressSpace{ >>> + uint8_t bus_num; /* bus number >>> */ >>> + uint8_t devfn; /* device function >>> */ >>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>> */ >>> + MemoryRegion iommu; /* Device's iommu region >>> */ >>> + AddressSpace as; /* device's corresponding address space >>> */ >>> +}AMDIOMMUAddressSpace; >>> + >>> +struct AMDIOMMUState { >>> + PCIDevice dev; /* The PCI device itself */ >>> + >>> + uint32_t version; >>> + >>> + int capab_offset; /* capability offset pointer */ >>> + unsigned char *capab; /* capabilities registers */ >>> + >>> + bool enabled; /* IOMMU enabled */ >>> + bool ats_enabled; /* address translation enabled */ >>> + bool cmdbuf_enabled; /* command buffer enabled */ >>> + bool evtlog_enabled; /* event log enabled */ >>> + bool excl_enabled; >>> + >>> + dma_addr_t devtab; /* base address device table */ >>> + size_t devtab_len; /* device table length */ >>> + >>> + dma_addr_t cmdbuf; /* command buffer base address */ >>> + uint64_t cmdbuf_len; /* command buffer length */ >>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>> + unsigned cmdbuf_tail; /* next Software write position */ >>> + int completion_wait_intr; >>> + >>> + dma_addr_t evtlog; /* base address event log */ >>> + size_t evtlog_intr; >>> + size_t evtlog_len; /* event log length */ >>> + size_t evtlog_head; /* event log head */ >>> + size_t evtlog_tail; /* event log tail */ >>> + >>> + /* unused for now */ >>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >>> + bool excl_allow; /* translate accesses to the exclusion >>> range */ >>> + bool excl_enable; /* exclusion range enabled */ >>> + >>> + MemoryRegion mmio; /* MMIO region */ >>> + unsigned char mmior[MMIO_SIZE]; >>> + bool mmio_enabled; >>> + >>> + /* IOMMU function */ >>> + MemoryRegionIOMMUOps iommu_ops; >>> + >>> + /* for each served device */ >>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>> +}; >>> + >>> +typedef struct AMDIOMMUEvent { >>> + uint16_t devfn; >>> + uint16_t reserved; >>> + uint16_t domid; >>> + uint16_t info; >>> + uint16_t addr; >>> +} __attribute__((packed)) AMDIOMMUEvent; >>> + >>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>> devfn); >>> + >>> +#endif >>> >> >> Thanks, >> Valentine Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-08-25 7:31 ` Valentine Sinitsyn @ 2015-08-25 7:41 ` David kiarie 2015-08-25 7:43 ` Valentine Sinitsyn 2015-08-25 7:44 ` David kiarie 0 siblings, 2 replies; 22+ messages in thread From: David kiarie @ 2015-08-25 7:41 UTC (permalink / raw) To: Valentine Sinitsyn; +Cc: Jan Kiszka, qemu-devel, mst On Tue, Aug 25, 2015 at 10:31 AM, Valentine Sinitsyn <valentine.sinitsyn@gmail.com> wrote: > > > On 25.08.2015 12:25, David kiarie wrote: >> >> On Tue, Aug 25, 2015 at 9:39 AM, Valentine Sinitsyn >> <valentine.sinitsyn@gmail.com> wrote: >>> >>> Hi, >>> >>> >>> On 25.08.2015 04:19, David Kiarie wrote: >>>> >>>> >>>> From: David <davidkiarie4@gmail.com> >>>> >>>> Add AMD IOMMU emulation to Qemu. This is a very basic AMD IOMMU >>>> emulation that only does translation and some basic Event logging. >>>> Guest translation enables nested PCI passthrough >>>> >>>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >>>> --- >>>> hw/i386/Makefile.objs | 1 + >>>> hw/i386/amd_iommu.c | 993 >>>> ++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> hw/i386/amd_iommu.h | 298 +++++++++++++++ >>>> 3 files changed, 1292 insertions(+) >>>> create mode 100644 hw/i386/amd_iommu.c >>>> create mode 100644 hw/i386/amd_iommu.h >>>> >>>> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs >>>> index ebd1015..2bae11c 100644 >>>> --- a/hw/i386/Makefile.objs >>>> +++ b/hw/i386/Makefile.objs >>>> @@ -3,6 +3,7 @@ obj-y += multiboot.o >>>> obj-y += pc.o pc_piix.o pc_q35.o >>>> obj-y += pc_sysfw.o >>>> obj-y += intel_iommu.o >>>> +obj-y += amd_iommu.o >>>> obj-$(CONFIG_XEN) += ../xenpv/ xen/ >>>> >>>> obj-y += kvmvapic.o >>>> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c >>>> new file mode 100644 >>>> index 0000000..a3a0b20 >>>> --- /dev/null >>>> +++ b/hw/i386/amd_iommu.c >>>> @@ -0,0 +1,993 @@ >>>> +/* >>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>> + * >>>> + * Copyright (C) 2011 Eduard - Gabriel Munteanu >>>> + * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License as published by >>>> + * the Free Software Foundation; either version 2 of the License, or >>>> + * (at your option) any later version. >>>> + >>>> + * This program is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + >>>> + * You should have received a copy of the GNU General Public License >>>> along >>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>> + * >>>> + */ >>>> +#include "hw/i386/amd_iommu.h" >>>> + >>>> +#define PCI_EXT_CAP_ID_PASID 0x1B >>>> +#define PCI_EXT_CAP_ID_PRI 0x13 >>>> + >>>> +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) >>>> +#define PCI_FUNC(devfn) ((devfn) & 0x07) >>>> + >>>> +#define MAX_VA_ADDR (64UL << 5) >>>> +#define MAX_PH_ADDR (48UL << 8) >>>> +#define MAX_GVA_ADDR (64UL << 15) >>>> + >>>> +//#define DEBUG_AMD_IOMMU >>>> +#ifdef DEBUG_AMD_IOMMU >>>> +enum { >>>> + DEBUG_GENERAL, DEBUG_CAPAB, DEBUG_MMIO, DEBUG_ELOG, >>>> + DEBUG_CACHE, DEBUG_COMMAND, DEBUG_MMU >>>> +}; >>>> + >>>> +#define IOMMU_DBGBIT(x) (1 << DEBUG_##x) >>>> +static int iommu_dbgflags = IOMMU_DBGBIT(GENERAL) | IOMMU_DBGBIT(MMU) | >>>> IOMMU_DBGBIT(MMIO); >>>> +//| IOMMU_DBGBIT(CAPAB) | IOMMU_DBGBIT(ELOG) | IOMMU_DBGBIT(CACHE) | >>>> IOMMU_DBGBIT(COMMAND); >>>> + >>>> +#define IOMMU_DPRINTF(what, fmt, ...) do { \ >>>> + if (iommu_dbgflags & IOMMU_DBGBIT(what)) { \ >>>> + fprintf(stderr, "(amd-iommu)%s: " fmt "\n", __func__, \ >>>> + ## __VA_ARGS__); } \ >>>> + } while (0) >>>> +#else >>>> +#define IOMMU_DPRINTF(what, fmt, ...) do {} while (0) >>>> +#endif >>>> + >>>> +/* helper functions - FIXME - provide for reading one byte */ >>>> +static uint16_t amd_iommu_readw(AMDIOMMUState *s, hwaddr addr) >>>> +{ >>>> + return lduw_le_p(&s->mmior[addr]); >>>> +} >>>> + >>>> +static uint32_t amd_iommu_readl(AMDIOMMUState *s, hwaddr addr) >>>> +{ >>>> + return ldl_le_p(&s->mmior[addr]); >>>> +} >>>> + >>>> +static uint64_t amd_iommu_readq(AMDIOMMUState *s, hwaddr addr) >>>> +{ >>>> + return ldq_le_p(&s->mmior[addr]); >>>> +} >>>> + >>>> +static void amd_iommu_writew(AMDIOMMUState *s, hwaddr addr, uint16_t >>>> val) >>>> +{ >>>> + stw_le_p(&s->mmior[addr], val); >>>> +} >>>> + >>>> +static void amd_iommu_writel(AMDIOMMUState *s, hwaddr addr, uint32_t >>>> val) >>>> +{ >>>> + stl_le_p(&s->mmior[addr], val); >>>> +} >>>> + >>>> +static void amd_iommu_writeq(AMDIOMMUState *s, hwaddr addr, uint64_t >>>> val) >>>> +{ >>>> + stq_le_p(&s->mmior[addr], val); >>>> +} >>>> + >>>> +/* execute a completion wait command */ >>>> +static void amd_iommu_completion_wait(AMDIOMMUState *s, uint8_t *cmd) >>>> +{ >>>> + unsigned int addr; >>>> + >>>> + /* completion store */ >>>> + if(cmd[0] & COM_COMPLETION_STORE_MASK){ >>>> + addr = le64_to_cpu(*(uint64_t*)cmd) & COM_STORE_ADDRESS_MASK; >>>> + if(dma_memory_write(&address_space_memory, addr, cmd + 8, 8)){ >>>> + IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>> 0%x"PRIx64, addr); >>>> + } >>>> + >>>> + } >>>> + >>>> + /* set completion interrupt */ >>> >>> >>> When I was experimenting with a real IOMMU, it all looked like if both >>> COM_COMPLETION_STORE_MASK and COM_COMPLETION_BIT are set in the command, >>> only an interrupt is generated. Could someone comment on this? >> >> >> Which bit do you mean by COM_COMPLETION_BIT ?Do you mean >> 'COM_COMPLETION_INTR ? If yes, when would such a scenario occur ? > > I was referring to COM_COMPLETION_INTR, sorry for the typo. > >> I have checked on from the spec, I can't find anything worthwhile and >> I don't any of us is running an IOMMU - except you, so I guess you >> should tell us what to do... > > The spec doesn't say anything about this, I checked it. IIRC, I came across > this behavior when submitted COMPLETION_WAIT command with interrupts off and > spin in a while() loop waiting for the mask to be written. The loop never > finished, but everything worked as intended if I removed COM_COMPLETION_INTR > for the command. Is this behaviour useful in any way ?I'll try to fix this in the next version. > > >> >>> >>> >>>> + if (cmd[0] & COM_COMPLETION_INTR){ >>>> + s->mmior[MMIO_STATUS] |= MMIO_STATUS_COMWAIT_INTR; >>>> + } >>>> +} >>>> + >>>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>>> +{ >>>> + unsigned type; >>>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>>> + >>>> + IOMMU_DPRINTF(COMMAND, ""); >>>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>>> + >>>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + >>>> s->cmdbuf_head, >>>> cmd, IOMMU_COMMAND_SIZE)){ >>>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>>> 0x%"PRIx64 >>>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>>> + } >>>> + >>>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>>> + >>>> + switch(type){ >>>> + case CMD_COMPLETION_WAIT: >>>> + /* pretend to wait for command execution to complete */ >>>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>>> + amd_iommu_completion_wait(s, cmd); >>>> + break; >>>> + case CMD_INVAL_DEVTAB_ENTRY: >>>> + /* Not implemented yet - should just clear device table >>>> contents */ >>>> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); >>>> + break; >>>> + case CMD_INVAL_IOMMU_PAGES: >>>> + /* invalidate IOMMU cache for a particular domain */ >>>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>>> + break; >>>> + case CMD_INVAL_IOTLB_PAGES: >>>> + /* Only present if remote IOTLB present */ >>>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>>> + break; >>>> + case CMD_INVAL_INTR_TABLE: >>>> + /* no support for interrupt remapping yet */ >>>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>>> + break; >>>> + default: >>>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>>> + break; >>>> + } >>>> + >>>> +} >>>> + >>>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>>> +{ >>>> + IOMMU_DPRINTF(COMMAND, ""); >>>> + >>>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + >>>> MMIO_COMMAND_HEAD; >>>> + >>>> + if(!s->cmdbuf_enabled){ >>>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>>> + return; >>>> + } >>>> + >>>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>>> + /* check if there is work to do. */ >>>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND >>>> BUFFER >>>> tail at %x", >>>> + s->cmdbuf_head, s->cmdbuf_tail); >>>> + amd_iommu_cmdbuf_exec(s); >>>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>>> + >>>> + /* wrap head pointer */ >>>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>>> + s->cmdbuf_head = 0; >>>> + } >>>> + } >>>> + >>>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>>> +} >>>> + >>>> +/* System Software might never read from some of this fields but >>>> anyways >>>> */ >>>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >>>> size) >>>> +{ >>>> + AMDIOMMUState *s = opaque; >>>> + >>>> + uint64_t val = -1; >>>> + if(addr + size > MMIO_SIZE) { >>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >>>> + ", got 0x%"PRIx64 " %d", >>>> + (uint64_t)MMIO_SIZE, addr, size); >>>> + return (uint64_t) - 1; >>>> + } >>>> + >>>> + switch(addr & ~0x07){ >>>> + case MMIO_DEVICE_TABLE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EVENT_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_CONTROL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EXCL_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EXCL_LIMIT: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EVENT_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EVENT_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_STATUS: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EXT_FEATURES: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + default: >>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + } >>>> + >>>> + return val; >>>> +} >>>> + >>>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>>> +{ >>>> + /* read whatever is already written incase software is writing in >>>> chucks less than 8 bytes */ >>>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>>> + >>>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>>> + s->evtlog_enabled = s->enabled && !!(control & >>>> MMIO_CONTROL_EVENTLOGEN); >>>> + >>>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>>> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >>>> + s->cmdbuf_enabled = s->enabled && !!(control & >>>> MMIO_CONTROL_CMDBUFLEN); >>>> + >>>> + /* update the flags depending on the control register */ >>>> + if(s->cmdbuf_enabled) { >>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >>>> + } else { >>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>> ~MMIO_STATUS_CMDBUF_RUN; >>>> + } >>>> + if (s->evtlog_enabled) { >>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >>>> + } else { >>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>> ~MMIO_STATUS_EVTLOG_RUN; >>>> + } >>>> + >>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>>> + >>>> + amd_iommu_cmdbuf_run(s); >>>> +} >>>> + >>>> +/* FIXME: something might go wrong if System Software writes in chunks >>>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>>> + * works correctly with linux but will definitely be busted if software >>>> + * reads/writes 8 bytes >>>> + */ >>>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t >>>> val, >>>> unsigned size) >>>> +{ >>>> + >>>> + AMDIOMMUState *s = opaque; >>>> + unsigned long offset = addr & 0x07; >>>> + >>>> + if(addr + size > MMIO_SIZE) { >>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >>>> + ", got 0x%"PRIx64 " %d", >>>> + (uint64_t)MMIO_SIZE, addr, size); >>>> + return; >>>> + } >>>> + >>>> + switch(addr & ~0x07){ >>>> + case MMIO_CONTROL: >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + >>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64 >>>> , addr, size, val, offset); >>>> + iommu_handle_control_write(s); >>>> + break; >>>> + >>>> + case MMIO_DEVICE_TABLE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr >>>> 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + >>>> + /* set device table address >>>> + * This also suffers from inability to tell whether >>>> software >>>> is done writing >>>> + */ >>>> + if(offset || (size == 8)){ >>>> + unsigned long device_base = amd_iommu_readq(s, >>>> MMIO_DEVICE_TABLE); >>>> + s->devtab = (dma_addr_t)(device_base & >>>> MMIO_CMDBUF_BASE_MASK); >>>> + /* set device table length */ >>>> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) >>>> + >>>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>>> + MMIO_DEVTAB_ENTRY_SIZE); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr >>>> 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>>> + amd_iommu_cmdbuf_run(s); >>>> + break; >>>> + >>>> + case MMIO_COMMAND_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr >>>> 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + >>>> + /* FIXME - make sure System Software has finished writing >>>> incase it writes >>>> + * in chucks less than 8 bytes in a robust way.As for now, >>>> this hacks works >>>> + * for the linux driver >>>> + */ >>>> + if(offset || (size == 8)){ >>>> + unsigned long command_base = amd_iommu_readq(s, >>>> MMIO_COMMAND_BASE); >>>> + s->cmdbuf = (dma_addr_t)(command_base & >>>> MMIO_CMDBUF_BASE_MASK); >>>> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] >>>> & >>>> MMIO_CMDBUF_SIZE_MASK); >>>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr >>>> 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + >>>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>>> + amd_iommu_cmdbuf_run(s); >>>> + break; >>>> + >>>> + case MMIO_EVENT_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>>> + s->evtlog_len = 1UL << >>>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >>>> + break; >>>> + >>>> + case MMIO_EXCL_LIMIT: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>>> MMIO_EXCL_LIMIT_LOW; >>>> + break; >>>> + //TODO : Event handling fixes >>>> + >>>> + case MMIO_EVENT_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EVENT_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + /* PPR log base - unused for now */ >>>> + case MMIO_PPR_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + /* PPR log head - also unused for now */ >>>> + case MMIO_PPR_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + /* PPR log tail - unused for now */ >>>> + case MMIO_PPR_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + >>>> + default: >>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + ; >>>> + } >>>> + >>>> +} >>>> + >>>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>>> +{ >>>> + /* event logging not enabled */ >>>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>>> MMIO_STATUS_EVTLOG_OF){ >>>> + return; >>>> + } >>>> + >>>> + /* event log buffer full */ >>>> + if(s->evtlog_tail >= s->evtlog_len) { >>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>>> + } >>>> + >>>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>>> s->evtlog_tail, &evt, EVENT_LEN)){ >>>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>> 0%x"PRIu8, >>>> s->evtlog + s->evtlog_tail); >>>> + } >>>> + >>>> + s->evtlog_tail += EVENT_LEN; >>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>>> + /* Disable logging if Overflow ? */ >>>> +} >>>> + >>>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >>>> domid, dma_addr_t addr, int present, >>>> + int is_write) >>>> +{ >>>> + IOMMU_DPRINTF(ELOG, ""); >>>> + >>>> + AMDIOMMUEvent evt; >>>> + unsigned info; >>>> + uint16_t status; >>>> + >>>> + evt.devfn = cpu_to_le16(devfn); >>>> + evt.reserved = 0; >>>> + evt.domid = cpu_to_le16(domid); >>>> + evt.addr = cpu_to_le16(addr); >>>> + >>>> + info = EVENT_IOPF; >>>> + >>>> + if(present) { >>>> + info |= EVENT_IOPF_PR; >>>> + } >>>> + >>>> + if (is_write) { >>>> + info |= EVENT_IOPF_RW; >>>> + } >>>> + >>>> + /* log a page fault */ >>>> + amd_iommu_log_event(s, &evt); >>>> + >>>> + /* Abort the translation */ >>>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>>> PCI_STATUS_SIG_TARGET_ABORT); >>>> +} >>>> + >>>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>>> +{ >>>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >>>> +} >>>> + >>>> +/* FIXME deduplication */ >>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>> devfn) >>>> +{ >>>> + AMDIOMMUState *s = opaque; >>>> + AMDIOMMUAddressSpace **iommu_as; >>>> + int bus_num = pci_bus_num(bus); >>>> + >>>> + /* just in case */ >>>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>>> + >>>> + iommu_as = s->address_spaces[bus_num]; >>>> + >>>> + /* allocate memory during the first run */ >>>> + if(!iommu_as) { >>>> + iommu_as = >>>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>>> + s->address_spaces[bus_num] = iommu_as; >>>> + } >>>> + >>>> + /* set up IOMMU region */ >>>> + if(!iommu_as[devfn]){ >>>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>>> + iommu_as[devfn]->iommu_state = s; >>>> + >>>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>>> "amd-iommu"); >>>> + } >>>> + return &iommu_as[devfn]->as; >>>> +} >>>> + >>>> +/* validate a page table entry */ >>>> +static bool amd_iommu_validate_pte(uint64_t pte) >>>> +{ >>>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>>> +} >>>> + >>>> +/* get a device table entry given the device function */ >>>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>>> *entry) >>>> +{ >>>> + /* Could lead to out of range accesses */ >>>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>>> + >>>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, >>>> entry, >>>> 32)){ >>>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>>> 0x%"PRIx64 >>>> + "offset 0x%"PRIx32, s->devtab, offset); >>>> + return false; >>>> + } >>>> + >>>> + if(!amd_iommu_validate_pte(entry[0])){ >>>> + IOMMU_DPRINTF(MMU, >>>> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >>>> + return false; >>>> + } >>>> + >>>> + return true; >>>> +} >>>> + >>>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>>> +{ >>>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>> + >>>> + if(level == 7){ >>>> + /* reserved level - abort ? */ >>>> + IOMMU_DPRINTF(MMU, >>>> + "Reserved translation level (7) detected"); >>>> + return 0; >>>> + } >>>> + >>>> + return level; >>>> +} >>>> + >>>> +/* TODO : Mark addresses as Accessed and Dirty */ >>>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr >>>> addr, >>>> bool is_write, IOMMUTLBEntry *ret) >>>> +{ >>>> + AMDIOMMUState *s = as->iommu_state; >>>> + >>>> + int present; >>>> + dma_addr_t pte_addr; >>>> + uint64_t entry[4], pte, pte_perms; >>>> + unsigned level; >>>> + unsigned perms; >>>> + >>>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>>> + goto no_translation; >>>> + } >>>> + >>>> + pte = entry[0]; >>>> + >>>> + /* >>>> + * It's okay to check for either read or write permissions >>>> + * even for memory maps, since we don't support R/W maps. >>>> + */ >>>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>>> + >>>> + if(!(level = get_pte_translation_mode(pte))){ >>>> + goto no_translation; >>>> + } >>>> + >>>> + while(level > 0){ >>>> + /* >>>> + * check permissions: the bitwise >>>> + * implication perms -> entry_perms must be true. Pages must be >>>> present >>>> + * and permissions on all levels must be similar >>>> + */ >>>> + pte_perms = amd_iommu_get_perms(pte); >>>> + present = pte & 1; >>>> + if(!present || perms != (perms & pte_perms)){ >>>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>>> DEV_DOMID_ID_MASK, addr, present, >>>> + !!(perms & IOMMU_PERM_WRITE)); >>>> + return; >>>> + } >>>> + >>>> + /* go to the next lower level */ >>>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>>> + pte = ldq_phys(&address_space_memory, pte_addr); >>>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>> + } >>>> + >>>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & >>>> IOMMU_PAGE_MASK_4K; >>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>> + ret->perm = IOMMU_RW; >>>> + return; >>>> + >>>> +no_translation: >>>> + ret->iova = addr; >>>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>> + ret->perm = IOMMU_RW; >>>> + return; >>>> +} >>>> + >>>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>>> addr, bool is_write) >>>> +{ >>>> + >>>> + IOMMU_DPRINTF(GENERAL, ""); >>>> + >>>> + AMDIOMMUAddressSpace *as = container_of(iommu, >>>> AMDIOMMUAddressSpace, >>>> iommu); >>>> + AMDIOMMUState *s = as->iommu_state; >>>> + >>>> + IOMMUTLBEntry ret = { >>>> + .target_as = &address_space_memory, >>>> + .iova = addr, >>>> + .translated_addr = 0, >>>> + .addr_mask = ~(hwaddr)0, >>>> + .perm = IOMMU_NONE, >>>> + }; >>>> + >>>> + if(!s->enabled){ >>>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>>> provide any parameter */ >>>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>>> + ret.perm = IOMMU_RW; >>>> + return ret; >>>> + } >>>> + >>>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>>> + >>>> + IOMMU_DPRINTF(MMU, >>>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >>>> as->bus_num, >>>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>>> ret.translated_addr); >>>> + >>>> + return ret; >>>> +} >>>> + >>>> +static const MemoryRegionOps mmio_mem_ops = { >>>> + .read = amd_iommu_mmio_read, >>>> + .write = amd_iommu_mmio_write, >>>> + .endianness = DEVICE_LITTLE_ENDIAN, >>>> + .valid = { >>>> + .min_access_size = 1, >>>> + .max_access_size = 8, >>>> + .unaligned = false, >>>> + }, >>>> + >>>> + .valid = { >>>> + .min_access_size = 8, >>>> + .max_access_size = 8, >>>> + }, >>>> +}; >>>> + >>>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t >>>> host_pa, >>>> uint32_t guest_va, uint32_t *reg) >>>> +{ >>>> + *reg = 0; >>>> + >>>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>>> +} >>>> + >>>> +/* FIXME: The similar code in reset and init could be combined into a >>>> function */ >>>> +static void amd_iommu_reset(DeviceState *dev) >>>> +{ >>>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>>> + >>>> + uint32_t capab_header = CAPAB_FEATURES; >>>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>>> + uint32_t capab_range = 0xff000000; >>>> + uint32_t capab_misc = 0x0; >>>> + >>>> + /* reset MMIO */ >>>> + memset(s->mmior, 0, MMIO_SIZE); >>>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>>> + /* TODO :Disable event logging and reset all buffers */ >>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>> &capab_misc); >>>> + >>>> + /* reset IOMMU specific capabilities */ >>>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>>> capab_base_addr_low); >>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>>> capab_base_addr_high); >>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>>> capab_range); >>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>>> capab_misc); >>>> + >>>> + /* reset device ident */ >>>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>>> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >>>> + pci_config_set_class(s->dev.config, 0x0806); >>>> + pci_config_set_prog_interface(s->dev.config, 00); >>>> +} >>>> + >>>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, >>>> uint32_t >>>> val, int len) >>>> +{ >>>> + pci_default_write_config(dev, addr, val, len); >>>> +} >>>> + >>>> +/* I honestly don't know how to reserve MMIO */ >>>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>>> +{ >>>> + if(s->mmio.addr == addr){ >>>> + return; >>>> + } >>>> + >>>> +// if(s->mmio.addr != (hwaddr)-1) { >>>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>>> +// } >>>> + >>>> + s->mmio.addr = addr; >>>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>>> + >>>> +} >>>> + >>>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>>> +{ >>>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>>> + uint32_t capab_header = CAPAB_FEATURES; >>>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> >>>> 16); >>>> + uint32_t capab_range = 0xff000000; >>>> + uint32_t capab_misc = 0x0; >>>> + >>>> + memset(s->mmior, 0, MMIO_SIZE); >>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>> &capab_misc); >>>> + >>>> + s->iommu_ops.translate = amd_iommu_translate; >>>> + s->enabled = false; >>>> + s->ats_enabled = false; >>>> + s->cmdbuf_enabled = false; >>>> + s->devtab_len = 0; >>>> + s->cmdbuf_len = 0; >>>> + s->cmdbuf_head = 0; >>>> + s->cmdbuf_tail = 0; >>>> + s->evtlog_head = 0; >>>> + s->evtlog_tail = 0; >>>> + s->excl_enabled = false; >>>> + s->excl_allow = false; >>>> + s->mmio_enabled = false; >>>> + dev->config_write = amd_iommu_write_capab; >>>> + >>>> + size_t offset; >>>> + /* Save offset for IVRS */ >>>> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, >>>> 0, >>>> CAPAB_SIZE); >>>> + pci_set_long(s->dev.config + offset, capab_header); >>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>>> capab_base_addr_low); >>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>>> capab_base_addr_high); >>>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>>> + >>>> + /* add msi and hypertransport capabilities */ >>>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>>> + >>>> + /* set up MMIO */ >>>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>>> "amd-iommu", MMIO_SIZE); >>>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>>> + >>>> + /* reset device ident */ >>>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>>> + >>>> + /* may not be necessary */ >>>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>>> + >>>> + return 0; >>>> +} >>>> + >>>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>>> +{ >>>> + amd_iommu_pci_initfn(dev); >>>> +} >>>> + >>>> +static const VMStateDescription vmstate_amd_iommu = { >>>> + .name = "amd-iommu", >>>> + .fields = (VMStateField[]) { >>>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>>> + VMSTATE_END_OF_LIST() >>>> + } >>>> +}; >>>> + >>>> +static Property amd_iommu_properties[] = { >>>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>>> + DEFINE_PROP_END_OF_LIST(), >>>> +}; >>>> + >>>> +/* not used for now but will be when cache is added */ >>>> +static void amd_iommu_uninit(PCIDevice *dev) >>>> +{ >>>> + return; >>>> +} >>>> + >>>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>>> +{ >>>> + DeviceClass *dc = DEVICE_CLASS(klass); >>>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>>> + >>>> + pci->realize = amd_iommu_realize; >>>> + pci->exit = amd_iommu_uninit; >>>> + >>>> + dc->reset = amd_iommu_reset; >>>> + dc->vmsd = &vmstate_amd_iommu; >>>> + dc->props = amd_iommu_properties; >>>> +} >>>> + >>>> +static const TypeInfo amd_iommu = { >>>> + .name = TYPE_AMD_IOMMU_DEVICE, >>>> + .parent = TYPE_PCI_DEVICE, >>>> + .instance_size = sizeof(AMDIOMMUState), >>>> + .class_init = amd_iommu_class_init >>>> +}; >>>> + >>>> +static void amd_iommu_register_types(void) >>>> +{ >>>> + type_register_static(&amd_iommu); >>>> +} >>>> + >>>> +type_init(amd_iommu_register_types); >>>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>>> new file mode 100644 >>>> index 0000000..90309eb >>>> --- /dev/null >>>> +++ b/hw/i386/amd_iommu.h >>>> @@ -0,0 +1,298 @@ >>>> +/* >>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>> + * >>>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License as published by >>>> + * the Free Software Foundation; either version 2 of the License, or >>>> + * (at your option) any later version. >>>> + >>>> + * This program is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + >>>> + * You should have received a copy of the GNU General Public License >>>> along >>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>> + */ >>>> + >>>> +#ifndef AMD_IOMMU_H_ >>>> +#define AMD_IOMMU_H_ >>>> + >>>> +#include "hw/hw.h" >>>> +#include "hw/pci/pci.h" >>>> +#include "hw/sysbus.h" >>>> +#include "sysemu/dma.h" >>>> +#include "qemu/osdep.h" >>>> +#include "qemu/event_notifier.h" >>>> + >>>> +/* Capability registers */ >>>> +#define CAPAB_HEADER 0x00 >>>> +#define CAPAB_REV_TYPE 0x02 >>>> +#define CAPAB_FLAGS 0x03 >>>> +#define CAPAB_BAR_LOW 0x04 >>>> +#define CAPAB_BAR_HIGH 0x08 >>>> +#define CAPAB_RANGE 0x0C >>>> +#define CAPAB_MISC 0x10 >>>> +#define CAPAB_MISC1 0x14 >>>> + >>>> +#define CAPAB_SIZE 0x18 >>>> +#define CAPAB_REG_SIZE 0x04 >>>> + >>>> +/* Capability header data */ >>>> +#define CAPAB_FLAT_EXT (1 << 28) >>>> +#define CAPAB_EFR_SUP (1 << 27) >>>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>>> +#define CAPAB_INIT_REV (1 << 19) >>>> +#define CAPAB_INIT_TYPE (3 << 16) >>>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>>> CAPAB_FLAG_HTTUNNEL) >>>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>>> + >>>> +/* MMIO registers */ >>>> +#define MMIO_DEVICE_TABLE 0x0000 >>>> +#define MMIO_COMMAND_BASE 0x0008 >>>> +#define MMIO_EVENT_BASE 0x0010 >>>> +#define MMIO_CONTROL 0x0018 >>>> +#define MMIO_EXCL_BASE 0x0020 >>>> +#define MMIO_EXCL_LIMIT 0x0028 >>>> +#define MMIO_EXT_FEATURES 0x0030 >>>> +#define MMIO_COMMAND_HEAD 0x2000 >>>> +#define MMIO_COMMAND_TAIL 0x2008 >>>> +#define MMIO_EVENT_HEAD 0x2010 >>>> +#define MMIO_EVENT_TAIL 0x2018 >>>> +#define MMIO_STATUS 0x2020 >>>> +#define MMIO_PPR_BASE 0x0038 >>>> +#define MMIO_PPR_HEAD 0x2030 >>>> +#define MMIO_PPR_TAIL 0x2038 >>>> + >>>> +#define MMIO_SIZE 0x4000 >>>> + >>>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>>> ~MMIO_DEVTAB_SIZE_MASK) >>>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>>> + >>>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>> + >>>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>> + >>>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>>> + >>>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>>> + >>>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>>> + >>>> +#define CMDBUF_ID_BYTE 0x07 >>>> +#define CMDBUF_ID_RSHIFT 4 >>>> +#define CMDBUF_ENTRY_SIZE 0x10 >>>> + >>>> +#define CMD_COMPLETION_WAIT 0x01 >>>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>>> +#define CMD_INVAL_INTR_TABLE 0x05 >>>> + >>>> +#define DEVTAB_ENTRY_SIZE 32 >>>> + >>>> +/* Device table entry bits 0:63 */ >>>> +#define DEV_VALID (1ULL << 0) >>>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>>> +#define DEV_MODE_MASK 0x7 >>>> +#define DEV_MODE_RSHIFT 9 >>>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>>> +#define DEV_PT_ROOT_RSHIFT 12 >>>> +#define DEV_PERM_SHIFT 61 >>>> +#define DEV_PERM_READ (1ULL << 61) >>>> +#define DEV_PERM_WRITE (1ULL << 62) >>>> + >>>> +/* Device table entry bits 64:127 */ >>>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>>> +#define DEV_IOCTL_MASK (~3) >>>> +#define DEV_IOCTL_RSHIFT 20 >>>> +#define DEV_IOCTL_DENY 0 >>>> +#define DEV_IOCTL_PASSTHROUGH 1 >>>> +#define DEV_IOCTL_TRANSLATE 2 >>>> +#define DEV_CACHE (1ULL << 37) >>>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>>> +#define DEV_EXCL (1ULL << 39) >>>> + >>>> +/* Event codes and flags, as stored in the info field */ >>>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>>> +#define EVENT_IOPF (0x2U << 24) >>>> +#define EVENT_IOPF_I (1U << 3) >>>> +#define EVENT_IOPF_PR (1U << 4) >>>> +#define EVENT_IOPF_RW (1U << 5) >>>> +#define EVENT_IOPF_PE (1U << 6) >>>> +#define EVENT_IOPF_RZ (1U << 7) >>>> +#define EVENT_IOPF_TR (1U << 8) >>>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>>> + >>>> +#define EVENT_LEN 16 >>>> + >>>> +#define IOMMU_PERM_READ (1 << 0) >>>> +#define IOMMU_PERM_WRITE (1 << 1) >>>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | >>>> IOMMU_PERM_WRITE) >>>> + >>>> +/* AMD RD890 Chipset */ >>>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>>> + >>>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>>> register */ >>>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>>> register */ >>>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>>> register */ >>>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>>> */ >>>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >>>> register 0 */ >>>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >>>> register 1 */ >>>> + >>>> +#define FEATURE_PREFETCH (1ULL<<0) >>>> +#define FEATURE_PPR (1ULL<<1) >>>> +#define FEATURE_NX (1ULL<<3) >>>> +#define FEATURE_GT (1ULL<<4) >>>> +#define FEATURE_IA (1ULL<<6) >>>> +#define FEATURE_GA (1ULL<<7) >>>> +#define FEATURE_HE (1ULL<<8) >>>> +#define FEATURE_PC (1ULL<<9) >>>> + >>>> +/* IOMMU paging mode */ >>>> +#define GATS_MODE (6ULL << 12) >>>> +#define HATS_MODE (6ULL << 10) >>>> +/* PCI SIG constants */ >>>> +#define PCI_BUS_MAX 256 >>>> +#define PCI_SLOT_MAX 32 >>>> +#define PCI_FUNC_MAX 8 >>>> +#define PCI_DEVFN_MAX 256 >>>> + >>>> +/* extended feature support */ >>>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | >>>> HATS_MODE ) >>>> + >>>> +/* capabilities header */ >>>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | >>>> CAPAB_FLAG_HTTUNNEL >>>> | CAPAB_EFR_SUP) >>>> + >>>> +/* command constants */ >>>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>>> +#define COM_COMPLETION_STORE_MASK 0x1 >>>> +#define COM_COMPLETION_INTR 0x2 >>>> +#define COM_COMPLETION_DATA_OFF 0x8 >>>> +#define IOMMU_COMMAND_SIZE 0x10 >>>> + >>>> +/* IOMMU default address */ >>>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>>> + >>>> +/* page management constants */ >>>> +#define IOMMU_PAGE_SHIFT 12 >>>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>>> + >>>> +#define IOMMU_PAGE_SHIFT_4K 12 >>>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>>> +#define IOMMU_PAGE_SHIFT_2M 21 >>>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>>> +#define IOMMU_PAGE_SHIFT_1G 30 >>>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>>> + >>>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>>> +#define AMD_IOMMU_DEVICE(obj)\ >>>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>>> + >>>> +typedef struct AMDIOMMUState AMDIOMMUState; >>>> + >>>> +typedef struct AMDIOMMUAddressSpace{ >>>> + uint8_t bus_num; /* bus number >>>> */ >>>> + uint8_t devfn; /* device function >>>> */ >>>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>>> */ >>>> + MemoryRegion iommu; /* Device's iommu region >>>> */ >>>> + AddressSpace as; /* device's corresponding address space >>>> */ >>>> +}AMDIOMMUAddressSpace; >>>> + >>>> +struct AMDIOMMUState { >>>> + PCIDevice dev; /* The PCI device itself */ >>>> + >>>> + uint32_t version; >>>> + >>>> + int capab_offset; /* capability offset pointer */ >>>> + unsigned char *capab; /* capabilities registers */ >>>> + >>>> + bool enabled; /* IOMMU enabled */ >>>> + bool ats_enabled; /* address translation enabled */ >>>> + bool cmdbuf_enabled; /* command buffer enabled */ >>>> + bool evtlog_enabled; /* event log enabled */ >>>> + bool excl_enabled; >>>> + >>>> + dma_addr_t devtab; /* base address device table */ >>>> + size_t devtab_len; /* device table length */ >>>> + >>>> + dma_addr_t cmdbuf; /* command buffer base address */ >>>> + uint64_t cmdbuf_len; /* command buffer length */ >>>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>>> + unsigned cmdbuf_tail; /* next Software write position */ >>>> + int completion_wait_intr; >>>> + >>>> + dma_addr_t evtlog; /* base address event log */ >>>> + size_t evtlog_intr; >>>> + size_t evtlog_len; /* event log length */ >>>> + size_t evtlog_head; /* event log head */ >>>> + size_t evtlog_tail; /* event log tail */ >>>> + >>>> + /* unused for now */ >>>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >>>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >>>> + bool excl_allow; /* translate accesses to the exclusion >>>> range */ >>>> + bool excl_enable; /* exclusion range enabled */ >>>> + >>>> + MemoryRegion mmio; /* MMIO region */ >>>> + unsigned char mmior[MMIO_SIZE]; >>>> + bool mmio_enabled; >>>> + >>>> + /* IOMMU function */ >>>> + MemoryRegionIOMMUOps iommu_ops; >>>> + >>>> + /* for each served device */ >>>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>>> +}; >>>> + >>>> +typedef struct AMDIOMMUEvent { >>>> + uint16_t devfn; >>>> + uint16_t reserved; >>>> + uint16_t domid; >>>> + uint16_t info; >>>> + uint16_t addr; >>>> +} __attribute__((packed)) AMDIOMMUEvent; >>>> + >>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>> devfn); >>>> + >>>> +#endif >>>> >>> >>> Thanks, >>> Valentine > > > Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-08-25 7:41 ` David kiarie @ 2015-08-25 7:43 ` Valentine Sinitsyn 2015-08-25 7:44 ` David kiarie 1 sibling, 0 replies; 22+ messages in thread From: Valentine Sinitsyn @ 2015-08-25 7:43 UTC (permalink / raw) To: David kiarie; +Cc: Jan Kiszka, qemu-devel, mst On 25.08.2015 12:41, David kiarie wrote: > On Tue, Aug 25, 2015 at 10:31 AM, Valentine Sinitsyn [...snip...] >> The spec doesn't say anything about this, I checked it. IIRC, I came across >> this behavior when submitted COMPLETION_WAIT command with interrupts off and >> spin in a while() loop waiting for the mask to be written. The loop never >> finished, but everything worked as intended if I removed COM_COMPLETION_INTR >> for the command. > > Is this behaviour useful in any way ?I'll try to fix this in the next version. I don't think it's useful. The reason I posted this question was to check if this is a bug in silicon or intended behavior. If the latter, I'd suggest to emulate it. Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-08-25 7:41 ` David kiarie 2015-08-25 7:43 ` Valentine Sinitsyn @ 2015-08-25 7:44 ` David kiarie 1 sibling, 0 replies; 22+ messages in thread From: David kiarie @ 2015-08-25 7:44 UTC (permalink / raw) To: Valentine Sinitsyn; +Cc: Jan Kiszka, qemu-devel, mst Also, am not sure what HATS, GATS and sizes of virtual addresses(for both guest and host) I should be using. On Tue, Aug 25, 2015 at 10:41 AM, David kiarie <davidkiarie4@gmail.com> wrote: > On Tue, Aug 25, 2015 at 10:31 AM, Valentine Sinitsyn > <valentine.sinitsyn@gmail.com> wrote: >> >> >> On 25.08.2015 12:25, David kiarie wrote: >>> >>> On Tue, Aug 25, 2015 at 9:39 AM, Valentine Sinitsyn >>> <valentine.sinitsyn@gmail.com> wrote: >>>> >>>> Hi, >>>> >>>> >>>> On 25.08.2015 04:19, David Kiarie wrote: >>>>> >>>>> >>>>> From: David <davidkiarie4@gmail.com> >>>>> >>>>> Add AMD IOMMU emulation to Qemu. This is a very basic AMD IOMMU >>>>> emulation that only does translation and some basic Event logging. >>>>> Guest translation enables nested PCI passthrough >>>>> >>>>> Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >>>>> --- >>>>> hw/i386/Makefile.objs | 1 + >>>>> hw/i386/amd_iommu.c | 993 >>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++ >>>>> hw/i386/amd_iommu.h | 298 +++++++++++++++ >>>>> 3 files changed, 1292 insertions(+) >>>>> create mode 100644 hw/i386/amd_iommu.c >>>>> create mode 100644 hw/i386/amd_iommu.h >>>>> >>>>> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs >>>>> index ebd1015..2bae11c 100644 >>>>> --- a/hw/i386/Makefile.objs >>>>> +++ b/hw/i386/Makefile.objs >>>>> @@ -3,6 +3,7 @@ obj-y += multiboot.o >>>>> obj-y += pc.o pc_piix.o pc_q35.o >>>>> obj-y += pc_sysfw.o >>>>> obj-y += intel_iommu.o >>>>> +obj-y += amd_iommu.o >>>>> obj-$(CONFIG_XEN) += ../xenpv/ xen/ >>>>> >>>>> obj-y += kvmvapic.o >>>>> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c >>>>> new file mode 100644 >>>>> index 0000000..a3a0b20 >>>>> --- /dev/null >>>>> +++ b/hw/i386/amd_iommu.c >>>>> @@ -0,0 +1,993 @@ >>>>> +/* >>>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>>> + * >>>>> + * Copyright (C) 2011 Eduard - Gabriel Munteanu >>>>> + * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >>>>> + * >>>>> + * This program is free software; you can redistribute it and/or modify >>>>> + * it under the terms of the GNU General Public License as published by >>>>> + * the Free Software Foundation; either version 2 of the License, or >>>>> + * (at your option) any later version. >>>>> + >>>>> + * This program is distributed in the hope that it will be useful, >>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>>> + * GNU General Public License for more details. >>>>> + >>>>> + * You should have received a copy of the GNU General Public License >>>>> along >>>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>>> + * >>>>> + */ >>>>> +#include "hw/i386/amd_iommu.h" >>>>> + >>>>> +#define PCI_EXT_CAP_ID_PASID 0x1B >>>>> +#define PCI_EXT_CAP_ID_PRI 0x13 >>>>> + >>>>> +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) >>>>> +#define PCI_FUNC(devfn) ((devfn) & 0x07) >>>>> + >>>>> +#define MAX_VA_ADDR (64UL << 5) >>>>> +#define MAX_PH_ADDR (48UL << 8) >>>>> +#define MAX_GVA_ADDR (64UL << 15) >>>>> + >>>>> +//#define DEBUG_AMD_IOMMU >>>>> +#ifdef DEBUG_AMD_IOMMU >>>>> +enum { >>>>> + DEBUG_GENERAL, DEBUG_CAPAB, DEBUG_MMIO, DEBUG_ELOG, >>>>> + DEBUG_CACHE, DEBUG_COMMAND, DEBUG_MMU >>>>> +}; >>>>> + >>>>> +#define IOMMU_DBGBIT(x) (1 << DEBUG_##x) >>>>> +static int iommu_dbgflags = IOMMU_DBGBIT(GENERAL) | IOMMU_DBGBIT(MMU) | >>>>> IOMMU_DBGBIT(MMIO); >>>>> +//| IOMMU_DBGBIT(CAPAB) | IOMMU_DBGBIT(ELOG) | IOMMU_DBGBIT(CACHE) | >>>>> IOMMU_DBGBIT(COMMAND); >>>>> + >>>>> +#define IOMMU_DPRINTF(what, fmt, ...) do { \ >>>>> + if (iommu_dbgflags & IOMMU_DBGBIT(what)) { \ >>>>> + fprintf(stderr, "(amd-iommu)%s: " fmt "\n", __func__, \ >>>>> + ## __VA_ARGS__); } \ >>>>> + } while (0) >>>>> +#else >>>>> +#define IOMMU_DPRINTF(what, fmt, ...) do {} while (0) >>>>> +#endif >>>>> + >>>>> +/* helper functions - FIXME - provide for reading one byte */ >>>>> +static uint16_t amd_iommu_readw(AMDIOMMUState *s, hwaddr addr) >>>>> +{ >>>>> + return lduw_le_p(&s->mmior[addr]); >>>>> +} >>>>> + >>>>> +static uint32_t amd_iommu_readl(AMDIOMMUState *s, hwaddr addr) >>>>> +{ >>>>> + return ldl_le_p(&s->mmior[addr]); >>>>> +} >>>>> + >>>>> +static uint64_t amd_iommu_readq(AMDIOMMUState *s, hwaddr addr) >>>>> +{ >>>>> + return ldq_le_p(&s->mmior[addr]); >>>>> +} >>>>> + >>>>> +static void amd_iommu_writew(AMDIOMMUState *s, hwaddr addr, uint16_t >>>>> val) >>>>> +{ >>>>> + stw_le_p(&s->mmior[addr], val); >>>>> +} >>>>> + >>>>> +static void amd_iommu_writel(AMDIOMMUState *s, hwaddr addr, uint32_t >>>>> val) >>>>> +{ >>>>> + stl_le_p(&s->mmior[addr], val); >>>>> +} >>>>> + >>>>> +static void amd_iommu_writeq(AMDIOMMUState *s, hwaddr addr, uint64_t >>>>> val) >>>>> +{ >>>>> + stq_le_p(&s->mmior[addr], val); >>>>> +} >>>>> + >>>>> +/* execute a completion wait command */ >>>>> +static void amd_iommu_completion_wait(AMDIOMMUState *s, uint8_t *cmd) >>>>> +{ >>>>> + unsigned int addr; >>>>> + >>>>> + /* completion store */ >>>>> + if(cmd[0] & COM_COMPLETION_STORE_MASK){ >>>>> + addr = le64_to_cpu(*(uint64_t*)cmd) & COM_STORE_ADDRESS_MASK; >>>>> + if(dma_memory_write(&address_space_memory, addr, cmd + 8, 8)){ >>>>> + IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>>> 0%x"PRIx64, addr); >>>>> + } >>>>> + >>>>> + } >>>>> + >>>>> + /* set completion interrupt */ >>>> >>>> >>>> When I was experimenting with a real IOMMU, it all looked like if both >>>> COM_COMPLETION_STORE_MASK and COM_COMPLETION_BIT are set in the command, >>>> only an interrupt is generated. Could someone comment on this? >>> >>> >>> Which bit do you mean by COM_COMPLETION_BIT ?Do you mean >>> 'COM_COMPLETION_INTR ? If yes, when would such a scenario occur ? >> >> I was referring to COM_COMPLETION_INTR, sorry for the typo. >> >>> I have checked on from the spec, I can't find anything worthwhile and >>> I don't any of us is running an IOMMU - except you, so I guess you >>> should tell us what to do... >> >> The spec doesn't say anything about this, I checked it. IIRC, I came across >> this behavior when submitted COMPLETION_WAIT command with interrupts off and >> spin in a while() loop waiting for the mask to be written. The loop never >> finished, but everything worked as intended if I removed COM_COMPLETION_INTR >> for the command. > > Is this behaviour useful in any way ?I'll try to fix this in the next version. > >> >> >>> >>>> >>>> >>>>> + if (cmd[0] & COM_COMPLETION_INTR){ >>>>> + s->mmior[MMIO_STATUS] |= MMIO_STATUS_COMWAIT_INTR; >>>>> + } >>>>> +} >>>>> + >>>>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>>>> +{ >>>>> + unsigned type; >>>>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>>>> + >>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>>>> + >>>>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + >>>>> s->cmdbuf_head, >>>>> cmd, IOMMU_COMMAND_SIZE)){ >>>>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>>>> 0x%"PRIx64 >>>>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>>>> + } >>>>> + >>>>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>>>> + >>>>> + switch(type){ >>>>> + case CMD_COMPLETION_WAIT: >>>>> + /* pretend to wait for command execution to complete */ >>>>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>>>> + amd_iommu_completion_wait(s, cmd); >>>>> + break; >>>>> + case CMD_INVAL_DEVTAB_ENTRY: >>>>> + /* Not implemented yet - should just clear device table >>>>> contents */ >>>>> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); >>>>> + break; >>>>> + case CMD_INVAL_IOMMU_PAGES: >>>>> + /* invalidate IOMMU cache for a particular domain */ >>>>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>>>> + break; >>>>> + case CMD_INVAL_IOTLB_PAGES: >>>>> + /* Only present if remote IOTLB present */ >>>>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>>>> + break; >>>>> + case CMD_INVAL_INTR_TABLE: >>>>> + /* no support for interrupt remapping yet */ >>>>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>>>> + break; >>>>> + default: >>>>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>>>> + break; >>>>> + } >>>>> + >>>>> +} >>>>> + >>>>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>>>> +{ >>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>> + >>>>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + >>>>> MMIO_COMMAND_HEAD; >>>>> + >>>>> + if(!s->cmdbuf_enabled){ >>>>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>>>> + return; >>>>> + } >>>>> + >>>>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>>>> + /* check if there is work to do. */ >>>>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND >>>>> BUFFER >>>>> tail at %x", >>>>> + s->cmdbuf_head, s->cmdbuf_tail); >>>>> + amd_iommu_cmdbuf_exec(s); >>>>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>>>> + >>>>> + /* wrap head pointer */ >>>>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>>>> + s->cmdbuf_head = 0; >>>>> + } >>>>> + } >>>>> + >>>>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>>>> +} >>>>> + >>>>> +/* System Software might never read from some of this fields but >>>>> anyways >>>>> */ >>>>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >>>>> size) >>>>> +{ >>>>> + AMDIOMMUState *s = opaque; >>>>> + >>>>> + uint64_t val = -1; >>>>> + if(addr + size > MMIO_SIZE) { >>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >>>>> + ", got 0x%"PRIx64 " %d", >>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>> + return (uint64_t) - 1; >>>>> + } >>>>> + >>>>> + switch(addr & ~0x07){ >>>>> + case MMIO_DEVICE_TABLE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_CONTROL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_LIMIT: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_STATUS: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXT_FEATURES: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + default: >>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + } >>>>> + >>>>> + return val; >>>>> +} >>>>> + >>>>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>>>> +{ >>>>> + /* read whatever is already written incase software is writing in >>>>> chucks less than 8 bytes */ >>>>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>>>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>>>> + >>>>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>>>> + s->evtlog_enabled = s->enabled && !!(control & >>>>> MMIO_CONTROL_EVENTLOGEN); >>>>> + >>>>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>>>> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >>>>> + s->cmdbuf_enabled = s->enabled && !!(control & >>>>> MMIO_CONTROL_CMDBUFLEN); >>>>> + >>>>> + /* update the flags depending on the control register */ >>>>> + if(s->cmdbuf_enabled) { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >>>>> + } else { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>> ~MMIO_STATUS_CMDBUF_RUN; >>>>> + } >>>>> + if (s->evtlog_enabled) { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >>>>> + } else { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>> ~MMIO_STATUS_EVTLOG_RUN; >>>>> + } >>>>> + >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>>>> + >>>>> + amd_iommu_cmdbuf_run(s); >>>>> +} >>>>> + >>>>> +/* FIXME: something might go wrong if System Software writes in chunks >>>>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>>>> + * works correctly with linux but will definitely be busted if software >>>>> + * reads/writes 8 bytes >>>>> + */ >>>>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t >>>>> val, >>>>> unsigned size) >>>>> +{ >>>>> + >>>>> + AMDIOMMUState *s = opaque; >>>>> + unsigned long offset = addr & 0x07; >>>>> + >>>>> + if(addr + size > MMIO_SIZE) { >>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >>>>> + ", got 0x%"PRIx64 " %d", >>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>> + return; >>>>> + } >>>>> + >>>>> + switch(addr & ~0x07){ >>>>> + case MMIO_CONTROL: >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64 >>>>> , addr, size, val, offset); >>>>> + iommu_handle_control_write(s); >>>>> + break; >>>>> + >>>>> + case MMIO_DEVICE_TABLE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr >>>>> 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + /* set device table address >>>>> + * This also suffers from inability to tell whether >>>>> software >>>>> is done writing >>>>> + */ >>>>> + if(offset || (size == 8)){ >>>>> + unsigned long device_base = amd_iommu_readq(s, >>>>> MMIO_DEVICE_TABLE); >>>>> + s->devtab = (dma_addr_t)(device_base & >>>>> MMIO_CMDBUF_BASE_MASK); >>>>> + /* set device table length */ >>>>> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) >>>>> + >>>>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>>>> + MMIO_DEVTAB_ENTRY_SIZE); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr >>>>> 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>>>> + amd_iommu_cmdbuf_run(s); >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr >>>>> 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + /* FIXME - make sure System Software has finished writing >>>>> incase it writes >>>>> + * in chucks less than 8 bytes in a robust way.As for now, >>>>> this hacks works >>>>> + * for the linux driver >>>>> + */ >>>>> + if(offset || (size == 8)){ >>>>> + unsigned long command_base = amd_iommu_readq(s, >>>>> MMIO_COMMAND_BASE); >>>>> + s->cmdbuf = (dma_addr_t)(command_base & >>>>> MMIO_CMDBUF_BASE_MASK); >>>>> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] >>>>> & >>>>> MMIO_CMDBUF_SIZE_MASK); >>>>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr >>>>> 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>>>> + amd_iommu_cmdbuf_run(s); >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>>>> + s->evtlog_len = 1UL << >>>>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_LIMIT: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>>>> MMIO_EXCL_LIMIT_LOW; >>>>> + break; >>>>> + //TODO : Event handling fixes >>>>> + >>>>> + case MMIO_EVENT_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log base - unused for now */ >>>>> + case MMIO_PPR_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log head - also unused for now */ >>>>> + case MMIO_PPR_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log tail - unused for now */ >>>>> + case MMIO_PPR_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + >>>>> + default: >>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + ; >>>>> + } >>>>> + >>>>> +} >>>>> + >>>>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>>>> +{ >>>>> + /* event logging not enabled */ >>>>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>>>> MMIO_STATUS_EVTLOG_OF){ >>>>> + return; >>>>> + } >>>>> + >>>>> + /* event log buffer full */ >>>>> + if(s->evtlog_tail >= s->evtlog_len) { >>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>>>> + } >>>>> + >>>>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>>>> s->evtlog_tail, &evt, EVENT_LEN)){ >>>>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>>> 0%x"PRIu8, >>>>> s->evtlog + s->evtlog_tail); >>>>> + } >>>>> + >>>>> + s->evtlog_tail += EVENT_LEN; >>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>>>> + /* Disable logging if Overflow ? */ >>>>> +} >>>>> + >>>>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >>>>> domid, dma_addr_t addr, int present, >>>>> + int is_write) >>>>> +{ >>>>> + IOMMU_DPRINTF(ELOG, ""); >>>>> + >>>>> + AMDIOMMUEvent evt; >>>>> + unsigned info; >>>>> + uint16_t status; >>>>> + >>>>> + evt.devfn = cpu_to_le16(devfn); >>>>> + evt.reserved = 0; >>>>> + evt.domid = cpu_to_le16(domid); >>>>> + evt.addr = cpu_to_le16(addr); >>>>> + >>>>> + info = EVENT_IOPF; >>>>> + >>>>> + if(present) { >>>>> + info |= EVENT_IOPF_PR; >>>>> + } >>>>> + >>>>> + if (is_write) { >>>>> + info |= EVENT_IOPF_RW; >>>>> + } >>>>> + >>>>> + /* log a page fault */ >>>>> + amd_iommu_log_event(s, &evt); >>>>> + >>>>> + /* Abort the translation */ >>>>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>>>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>>>> PCI_STATUS_SIG_TARGET_ABORT); >>>>> +} >>>>> + >>>>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>>>> +{ >>>>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >>>>> +} >>>>> + >>>>> +/* FIXME deduplication */ >>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>> devfn) >>>>> +{ >>>>> + AMDIOMMUState *s = opaque; >>>>> + AMDIOMMUAddressSpace **iommu_as; >>>>> + int bus_num = pci_bus_num(bus); >>>>> + >>>>> + /* just in case */ >>>>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>>>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>>>> + >>>>> + iommu_as = s->address_spaces[bus_num]; >>>>> + >>>>> + /* allocate memory during the first run */ >>>>> + if(!iommu_as) { >>>>> + iommu_as = >>>>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>>>> + s->address_spaces[bus_num] = iommu_as; >>>>> + } >>>>> + >>>>> + /* set up IOMMU region */ >>>>> + if(!iommu_as[devfn]){ >>>>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>>>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>>>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>>>> + iommu_as[devfn]->iommu_state = s; >>>>> + >>>>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>>>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>>>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>>>> "amd-iommu"); >>>>> + } >>>>> + return &iommu_as[devfn]->as; >>>>> +} >>>>> + >>>>> +/* validate a page table entry */ >>>>> +static bool amd_iommu_validate_pte(uint64_t pte) >>>>> +{ >>>>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>>>> +} >>>>> + >>>>> +/* get a device table entry given the device function */ >>>>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>>>> *entry) >>>>> +{ >>>>> + /* Could lead to out of range accesses */ >>>>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>>>> + >>>>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>>>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, >>>>> entry, >>>>> 32)){ >>>>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>>>> 0x%"PRIx64 >>>>> + "offset 0x%"PRIx32, s->devtab, offset); >>>>> + return false; >>>>> + } >>>>> + >>>>> + if(!amd_iommu_validate_pte(entry[0])){ >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >>>>> + return false; >>>>> + } >>>>> + >>>>> + return true; >>>>> +} >>>>> + >>>>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>>>> +{ >>>>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>> + >>>>> + if(level == 7){ >>>>> + /* reserved level - abort ? */ >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "Reserved translation level (7) detected"); >>>>> + return 0; >>>>> + } >>>>> + >>>>> + return level; >>>>> +} >>>>> + >>>>> +/* TODO : Mark addresses as Accessed and Dirty */ >>>>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr >>>>> addr, >>>>> bool is_write, IOMMUTLBEntry *ret) >>>>> +{ >>>>> + AMDIOMMUState *s = as->iommu_state; >>>>> + >>>>> + int present; >>>>> + dma_addr_t pte_addr; >>>>> + uint64_t entry[4], pte, pte_perms; >>>>> + unsigned level; >>>>> + unsigned perms; >>>>> + >>>>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>>>> + goto no_translation; >>>>> + } >>>>> + >>>>> + pte = entry[0]; >>>>> + >>>>> + /* >>>>> + * It's okay to check for either read or write permissions >>>>> + * even for memory maps, since we don't support R/W maps. >>>>> + */ >>>>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>>>> + >>>>> + if(!(level = get_pte_translation_mode(pte))){ >>>>> + goto no_translation; >>>>> + } >>>>> + >>>>> + while(level > 0){ >>>>> + /* >>>>> + * check permissions: the bitwise >>>>> + * implication perms -> entry_perms must be true. Pages must be >>>>> present >>>>> + * and permissions on all levels must be similar >>>>> + */ >>>>> + pte_perms = amd_iommu_get_perms(pte); >>>>> + present = pte & 1; >>>>> + if(!present || perms != (perms & pte_perms)){ >>>>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>>>> DEV_DOMID_ID_MASK, addr, present, >>>>> + !!(perms & IOMMU_PERM_WRITE)); >>>>> + return; >>>>> + } >>>>> + >>>>> + /* go to the next lower level */ >>>>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>>>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>>>> + pte = ldq_phys(&address_space_memory, pte_addr); >>>>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>> + } >>>>> + >>>>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & >>>>> IOMMU_PAGE_MASK_4K; >>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret->perm = IOMMU_RW; >>>>> + return; >>>>> + >>>>> +no_translation: >>>>> + ret->iova = addr; >>>>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret->perm = IOMMU_RW; >>>>> + return; >>>>> +} >>>>> + >>>>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>>>> addr, bool is_write) >>>>> +{ >>>>> + >>>>> + IOMMU_DPRINTF(GENERAL, ""); >>>>> + >>>>> + AMDIOMMUAddressSpace *as = container_of(iommu, >>>>> AMDIOMMUAddressSpace, >>>>> iommu); >>>>> + AMDIOMMUState *s = as->iommu_state; >>>>> + >>>>> + IOMMUTLBEntry ret = { >>>>> + .target_as = &address_space_memory, >>>>> + .iova = addr, >>>>> + .translated_addr = 0, >>>>> + .addr_mask = ~(hwaddr)0, >>>>> + .perm = IOMMU_NONE, >>>>> + }; >>>>> + >>>>> + if(!s->enabled){ >>>>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>>>> provide any parameter */ >>>>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret.perm = IOMMU_RW; >>>>> + return ret; >>>>> + } >>>>> + >>>>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>>>> + >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >>>>> as->bus_num, >>>>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>>>> ret.translated_addr); >>>>> + >>>>> + return ret; >>>>> +} >>>>> + >>>>> +static const MemoryRegionOps mmio_mem_ops = { >>>>> + .read = amd_iommu_mmio_read, >>>>> + .write = amd_iommu_mmio_write, >>>>> + .endianness = DEVICE_LITTLE_ENDIAN, >>>>> + .valid = { >>>>> + .min_access_size = 1, >>>>> + .max_access_size = 8, >>>>> + .unaligned = false, >>>>> + }, >>>>> + >>>>> + .valid = { >>>>> + .min_access_size = 8, >>>>> + .max_access_size = 8, >>>>> + }, >>>>> +}; >>>>> + >>>>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t >>>>> host_pa, >>>>> uint32_t guest_va, uint32_t *reg) >>>>> +{ >>>>> + *reg = 0; >>>>> + >>>>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>>>> +} >>>>> + >>>>> +/* FIXME: The similar code in reset and init could be combined into a >>>>> function */ >>>>> +static void amd_iommu_reset(DeviceState *dev) >>>>> +{ >>>>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>>>> + >>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>>>> + uint32_t capab_range = 0xff000000; >>>>> + uint32_t capab_misc = 0x0; >>>>> + >>>>> + /* reset MMIO */ >>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>>>> + /* TODO :Disable event logging and reset all buffers */ >>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>> &capab_misc); >>>>> + >>>>> + /* reset IOMMU specific capabilities */ >>>>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>>>> capab_base_addr_low); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>>>> capab_base_addr_high); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>>>> capab_range); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>>>> capab_misc); >>>>> + >>>>> + /* reset device ident */ >>>>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>>>> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >>>>> + pci_config_set_class(s->dev.config, 0x0806); >>>>> + pci_config_set_prog_interface(s->dev.config, 00); >>>>> +} >>>>> + >>>>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, >>>>> uint32_t >>>>> val, int len) >>>>> +{ >>>>> + pci_default_write_config(dev, addr, val, len); >>>>> +} >>>>> + >>>>> +/* I honestly don't know how to reserve MMIO */ >>>>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>>>> +{ >>>>> + if(s->mmio.addr == addr){ >>>>> + return; >>>>> + } >>>>> + >>>>> +// if(s->mmio.addr != (hwaddr)-1) { >>>>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>>>> +// } >>>>> + >>>>> + s->mmio.addr = addr; >>>>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>>>> + >>>>> +} >>>>> + >>>>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>>>> +{ >>>>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> >>>>> 16); >>>>> + uint32_t capab_range = 0xff000000; >>>>> + uint32_t capab_misc = 0x0; >>>>> + >>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>> &capab_misc); >>>>> + >>>>> + s->iommu_ops.translate = amd_iommu_translate; >>>>> + s->enabled = false; >>>>> + s->ats_enabled = false; >>>>> + s->cmdbuf_enabled = false; >>>>> + s->devtab_len = 0; >>>>> + s->cmdbuf_len = 0; >>>>> + s->cmdbuf_head = 0; >>>>> + s->cmdbuf_tail = 0; >>>>> + s->evtlog_head = 0; >>>>> + s->evtlog_tail = 0; >>>>> + s->excl_enabled = false; >>>>> + s->excl_allow = false; >>>>> + s->mmio_enabled = false; >>>>> + dev->config_write = amd_iommu_write_capab; >>>>> + >>>>> + size_t offset; >>>>> + /* Save offset for IVRS */ >>>>> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, >>>>> 0, >>>>> CAPAB_SIZE); >>>>> + pci_set_long(s->dev.config + offset, capab_header); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>>>> capab_base_addr_low); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>>>> capab_base_addr_high); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>>>> + >>>>> + /* add msi and hypertransport capabilities */ >>>>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>>>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>>>> + >>>>> + /* set up MMIO */ >>>>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>>>> "amd-iommu", MMIO_SIZE); >>>>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>>>> + >>>>> + /* reset device ident */ >>>>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>>>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>>>> + >>>>> + /* may not be necessary */ >>>>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>>>> +{ >>>>> + amd_iommu_pci_initfn(dev); >>>>> +} >>>>> + >>>>> +static const VMStateDescription vmstate_amd_iommu = { >>>>> + .name = "amd-iommu", >>>>> + .fields = (VMStateField[]) { >>>>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>>>> + VMSTATE_END_OF_LIST() >>>>> + } >>>>> +}; >>>>> + >>>>> +static Property amd_iommu_properties[] = { >>>>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>>>> + DEFINE_PROP_END_OF_LIST(), >>>>> +}; >>>>> + >>>>> +/* not used for now but will be when cache is added */ >>>>> +static void amd_iommu_uninit(PCIDevice *dev) >>>>> +{ >>>>> + return; >>>>> +} >>>>> + >>>>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>>>> +{ >>>>> + DeviceClass *dc = DEVICE_CLASS(klass); >>>>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>>>> + >>>>> + pci->realize = amd_iommu_realize; >>>>> + pci->exit = amd_iommu_uninit; >>>>> + >>>>> + dc->reset = amd_iommu_reset; >>>>> + dc->vmsd = &vmstate_amd_iommu; >>>>> + dc->props = amd_iommu_properties; >>>>> +} >>>>> + >>>>> +static const TypeInfo amd_iommu = { >>>>> + .name = TYPE_AMD_IOMMU_DEVICE, >>>>> + .parent = TYPE_PCI_DEVICE, >>>>> + .instance_size = sizeof(AMDIOMMUState), >>>>> + .class_init = amd_iommu_class_init >>>>> +}; >>>>> + >>>>> +static void amd_iommu_register_types(void) >>>>> +{ >>>>> + type_register_static(&amd_iommu); >>>>> +} >>>>> + >>>>> +type_init(amd_iommu_register_types); >>>>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>>>> new file mode 100644 >>>>> index 0000000..90309eb >>>>> --- /dev/null >>>>> +++ b/hw/i386/amd_iommu.h >>>>> @@ -0,0 +1,298 @@ >>>>> +/* >>>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>>> + * >>>>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>>>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>>>> + * >>>>> + * This program is free software; you can redistribute it and/or modify >>>>> + * it under the terms of the GNU General Public License as published by >>>>> + * the Free Software Foundation; either version 2 of the License, or >>>>> + * (at your option) any later version. >>>>> + >>>>> + * This program is distributed in the hope that it will be useful, >>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>>> + * GNU General Public License for more details. >>>>> + >>>>> + * You should have received a copy of the GNU General Public License >>>>> along >>>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>>> + */ >>>>> + >>>>> +#ifndef AMD_IOMMU_H_ >>>>> +#define AMD_IOMMU_H_ >>>>> + >>>>> +#include "hw/hw.h" >>>>> +#include "hw/pci/pci.h" >>>>> +#include "hw/sysbus.h" >>>>> +#include "sysemu/dma.h" >>>>> +#include "qemu/osdep.h" >>>>> +#include "qemu/event_notifier.h" >>>>> + >>>>> +/* Capability registers */ >>>>> +#define CAPAB_HEADER 0x00 >>>>> +#define CAPAB_REV_TYPE 0x02 >>>>> +#define CAPAB_FLAGS 0x03 >>>>> +#define CAPAB_BAR_LOW 0x04 >>>>> +#define CAPAB_BAR_HIGH 0x08 >>>>> +#define CAPAB_RANGE 0x0C >>>>> +#define CAPAB_MISC 0x10 >>>>> +#define CAPAB_MISC1 0x14 >>>>> + >>>>> +#define CAPAB_SIZE 0x18 >>>>> +#define CAPAB_REG_SIZE 0x04 >>>>> + >>>>> +/* Capability header data */ >>>>> +#define CAPAB_FLAT_EXT (1 << 28) >>>>> +#define CAPAB_EFR_SUP (1 << 27) >>>>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>>>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>>>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>>>> +#define CAPAB_INIT_REV (1 << 19) >>>>> +#define CAPAB_INIT_TYPE (3 << 16) >>>>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>>>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>>>> CAPAB_FLAG_HTTUNNEL) >>>>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>>>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>>>> + >>>>> +/* MMIO registers */ >>>>> +#define MMIO_DEVICE_TABLE 0x0000 >>>>> +#define MMIO_COMMAND_BASE 0x0008 >>>>> +#define MMIO_EVENT_BASE 0x0010 >>>>> +#define MMIO_CONTROL 0x0018 >>>>> +#define MMIO_EXCL_BASE 0x0020 >>>>> +#define MMIO_EXCL_LIMIT 0x0028 >>>>> +#define MMIO_EXT_FEATURES 0x0030 >>>>> +#define MMIO_COMMAND_HEAD 0x2000 >>>>> +#define MMIO_COMMAND_TAIL 0x2008 >>>>> +#define MMIO_EVENT_HEAD 0x2010 >>>>> +#define MMIO_EVENT_TAIL 0x2018 >>>>> +#define MMIO_STATUS 0x2020 >>>>> +#define MMIO_PPR_BASE 0x0038 >>>>> +#define MMIO_PPR_HEAD 0x2030 >>>>> +#define MMIO_PPR_TAIL 0x2038 >>>>> + >>>>> +#define MMIO_SIZE 0x4000 >>>>> + >>>>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>>>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>>>> ~MMIO_DEVTAB_SIZE_MASK) >>>>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>>>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>>>> + >>>>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>>>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>>>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>>>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>> + >>>>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>>>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>>>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>>>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>>>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>> + >>>>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>>>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>>>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>>>> + >>>>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>>>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>>>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>>>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>>>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>>>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>>>> + >>>>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>>>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>>>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>>>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>>>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>>>> + >>>>> +#define CMDBUF_ID_BYTE 0x07 >>>>> +#define CMDBUF_ID_RSHIFT 4 >>>>> +#define CMDBUF_ENTRY_SIZE 0x10 >>>>> + >>>>> +#define CMD_COMPLETION_WAIT 0x01 >>>>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>>>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>>>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>>>> +#define CMD_INVAL_INTR_TABLE 0x05 >>>>> + >>>>> +#define DEVTAB_ENTRY_SIZE 32 >>>>> + >>>>> +/* Device table entry bits 0:63 */ >>>>> +#define DEV_VALID (1ULL << 0) >>>>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>>>> +#define DEV_MODE_MASK 0x7 >>>>> +#define DEV_MODE_RSHIFT 9 >>>>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>>>> +#define DEV_PT_ROOT_RSHIFT 12 >>>>> +#define DEV_PERM_SHIFT 61 >>>>> +#define DEV_PERM_READ (1ULL << 61) >>>>> +#define DEV_PERM_WRITE (1ULL << 62) >>>>> + >>>>> +/* Device table entry bits 64:127 */ >>>>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>>>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>>>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>>>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>>>> +#define DEV_IOCTL_MASK (~3) >>>>> +#define DEV_IOCTL_RSHIFT 20 >>>>> +#define DEV_IOCTL_DENY 0 >>>>> +#define DEV_IOCTL_PASSTHROUGH 1 >>>>> +#define DEV_IOCTL_TRANSLATE 2 >>>>> +#define DEV_CACHE (1ULL << 37) >>>>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>>>> +#define DEV_EXCL (1ULL << 39) >>>>> + >>>>> +/* Event codes and flags, as stored in the info field */ >>>>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>>>> +#define EVENT_IOPF (0x2U << 24) >>>>> +#define EVENT_IOPF_I (1U << 3) >>>>> +#define EVENT_IOPF_PR (1U << 4) >>>>> +#define EVENT_IOPF_RW (1U << 5) >>>>> +#define EVENT_IOPF_PE (1U << 6) >>>>> +#define EVENT_IOPF_RZ (1U << 7) >>>>> +#define EVENT_IOPF_TR (1U << 8) >>>>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>>>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>>>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>>>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>>>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>>>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>>>> + >>>>> +#define EVENT_LEN 16 >>>>> + >>>>> +#define IOMMU_PERM_READ (1 << 0) >>>>> +#define IOMMU_PERM_WRITE (1 << 1) >>>>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | >>>>> IOMMU_PERM_WRITE) >>>>> + >>>>> +/* AMD RD890 Chipset */ >>>>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>>>> + >>>>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>>>> register */ >>>>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>>>> register */ >>>>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>>>> register */ >>>>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>>>> */ >>>>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >>>>> register 0 */ >>>>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >>>>> register 1 */ >>>>> + >>>>> +#define FEATURE_PREFETCH (1ULL<<0) >>>>> +#define FEATURE_PPR (1ULL<<1) >>>>> +#define FEATURE_NX (1ULL<<3) >>>>> +#define FEATURE_GT (1ULL<<4) >>>>> +#define FEATURE_IA (1ULL<<6) >>>>> +#define FEATURE_GA (1ULL<<7) >>>>> +#define FEATURE_HE (1ULL<<8) >>>>> +#define FEATURE_PC (1ULL<<9) >>>>> + >>>>> +/* IOMMU paging mode */ >>>>> +#define GATS_MODE (6ULL << 12) >>>>> +#define HATS_MODE (6ULL << 10) >>>>> +/* PCI SIG constants */ >>>>> +#define PCI_BUS_MAX 256 >>>>> +#define PCI_SLOT_MAX 32 >>>>> +#define PCI_FUNC_MAX 8 >>>>> +#define PCI_DEVFN_MAX 256 >>>>> + >>>>> +/* extended feature support */ >>>>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>>>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | >>>>> HATS_MODE ) >>>>> + >>>>> +/* capabilities header */ >>>>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>>>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | >>>>> CAPAB_FLAG_HTTUNNEL >>>>> | CAPAB_EFR_SUP) >>>>> + >>>>> +/* command constants */ >>>>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>>>> +#define COM_COMPLETION_STORE_MASK 0x1 >>>>> +#define COM_COMPLETION_INTR 0x2 >>>>> +#define COM_COMPLETION_DATA_OFF 0x8 >>>>> +#define IOMMU_COMMAND_SIZE 0x10 >>>>> + >>>>> +/* IOMMU default address */ >>>>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>>>> + >>>>> +/* page management constants */ >>>>> +#define IOMMU_PAGE_SHIFT 12 >>>>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>>>> + >>>>> +#define IOMMU_PAGE_SHIFT_4K 12 >>>>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>>>> +#define IOMMU_PAGE_SHIFT_2M 21 >>>>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>>>> +#define IOMMU_PAGE_SHIFT_1G 30 >>>>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>>>> + >>>>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>>>> +#define AMD_IOMMU_DEVICE(obj)\ >>>>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>>>> + >>>>> +typedef struct AMDIOMMUState AMDIOMMUState; >>>>> + >>>>> +typedef struct AMDIOMMUAddressSpace{ >>>>> + uint8_t bus_num; /* bus number >>>>> */ >>>>> + uint8_t devfn; /* device function >>>>> */ >>>>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>>>> */ >>>>> + MemoryRegion iommu; /* Device's iommu region >>>>> */ >>>>> + AddressSpace as; /* device's corresponding address space >>>>> */ >>>>> +}AMDIOMMUAddressSpace; >>>>> + >>>>> +struct AMDIOMMUState { >>>>> + PCIDevice dev; /* The PCI device itself */ >>>>> + >>>>> + uint32_t version; >>>>> + >>>>> + int capab_offset; /* capability offset pointer */ >>>>> + unsigned char *capab; /* capabilities registers */ >>>>> + >>>>> + bool enabled; /* IOMMU enabled */ >>>>> + bool ats_enabled; /* address translation enabled */ >>>>> + bool cmdbuf_enabled; /* command buffer enabled */ >>>>> + bool evtlog_enabled; /* event log enabled */ >>>>> + bool excl_enabled; >>>>> + >>>>> + dma_addr_t devtab; /* base address device table */ >>>>> + size_t devtab_len; /* device table length */ >>>>> + >>>>> + dma_addr_t cmdbuf; /* command buffer base address */ >>>>> + uint64_t cmdbuf_len; /* command buffer length */ >>>>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>>>> + unsigned cmdbuf_tail; /* next Software write position */ >>>>> + int completion_wait_intr; >>>>> + >>>>> + dma_addr_t evtlog; /* base address event log */ >>>>> + size_t evtlog_intr; >>>>> + size_t evtlog_len; /* event log length */ >>>>> + size_t evtlog_head; /* event log head */ >>>>> + size_t evtlog_tail; /* event log tail */ >>>>> + >>>>> + /* unused for now */ >>>>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >>>>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >>>>> + bool excl_allow; /* translate accesses to the exclusion >>>>> range */ >>>>> + bool excl_enable; /* exclusion range enabled */ >>>>> + >>>>> + MemoryRegion mmio; /* MMIO region */ >>>>> + unsigned char mmior[MMIO_SIZE]; >>>>> + bool mmio_enabled; >>>>> + >>>>> + /* IOMMU function */ >>>>> + MemoryRegionIOMMUOps iommu_ops; >>>>> + >>>>> + /* for each served device */ >>>>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>>>> +}; >>>>> + >>>>> +typedef struct AMDIOMMUEvent { >>>>> + uint16_t devfn; >>>>> + uint16_t reserved; >>>>> + uint16_t domid; >>>>> + uint16_t info; >>>>> + uint16_t addr; >>>>> +} __attribute__((packed)) AMDIOMMUEvent; >>>>> + >>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>> devfn); >>>>> + >>>>> +#endif >>>>> >>>> >>>> Thanks, >>>> Valentine >> >> >> Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-08-24 23:19 ` [Qemu-devel] [RFC 2/4] hw/i386: Introduce " David Kiarie 2015-08-25 6:39 ` Valentine Sinitsyn @ 2015-09-07 12:46 ` Valentine Sinitsyn 2015-09-09 7:30 ` David kiarie 2015-09-12 10:55 ` Valentine Sinitsyn 1 sibling, 2 replies; 22+ messages in thread From: Valentine Sinitsyn @ 2015-09-07 12:46 UTC (permalink / raw) To: David Kiarie, qemu-devel; +Cc: jan.kiszka, mst Hi David, Sorry for the long silence. I've skimmed through your patch, below are some thoughts. Please remember I'm looking for IOMMU implementation details, not how it is integrated with QEMU. On 25.08.2015 04:19, David Kiarie wrote: > From: David <davidkiarie4@gmail.com> > > Add AMD IOMMU emulation to Qemu. This is a very basic AMD IOMMU > emulation that only does translation and some basic Event logging. > Guest translation enables nested PCI passthrough > > Signed-off-by: David Kiarie <davidkiarie4@gmail.com> > --- > hw/i386/Makefile.objs | 1 + > hw/i386/amd_iommu.c | 993 ++++++++++++++++++++++++++++++++++++++++++++++++++ > hw/i386/amd_iommu.h | 298 +++++++++++++++ > 3 files changed, 1292 insertions(+) > create mode 100644 hw/i386/amd_iommu.c > create mode 100644 hw/i386/amd_iommu.h > > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs > index ebd1015..2bae11c 100644 > --- a/hw/i386/Makefile.objs > +++ b/hw/i386/Makefile.objs > @@ -3,6 +3,7 @@ obj-y += multiboot.o > obj-y += pc.o pc_piix.o pc_q35.o > obj-y += pc_sysfw.o > obj-y += intel_iommu.o > +obj-y += amd_iommu.o > obj-$(CONFIG_XEN) += ../xenpv/ xen/ > > obj-y += kvmvapic.o > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > new file mode 100644 > index 0000000..a3a0b20 > --- /dev/null > +++ b/hw/i386/amd_iommu.c > @@ -0,0 +1,993 @@ > +/* > + * QEMU emulation of an AMD IOMMU (AMD-Vi) > + * > + * Copyright (C) 2011 Eduard - Gabriel Munteanu > + * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see <http://www.gnu.org/licenses/>. > + * > + */ > +#include "hw/i386/amd_iommu.h" > + > +#define PCI_EXT_CAP_ID_PASID 0x1B > +#define PCI_EXT_CAP_ID_PRI 0x13 Do you really need those? They don't seem to be used. > + > +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) > +#define PCI_FUNC(devfn) ((devfn) & 0x07) > + > +#define MAX_VA_ADDR (64UL << 5) > +#define MAX_PH_ADDR (48UL << 8) > +#define MAX_GVA_ADDR (64UL << 15) > + > +//#define DEBUG_AMD_IOMMU It's generally advisable to avoid commented-out lines. Use #ifdefs, or remove them altogether. > +#ifdef DEBUG_AMD_IOMMU > +enum { > + DEBUG_GENERAL, DEBUG_CAPAB, DEBUG_MMIO, DEBUG_ELOG, > + DEBUG_CACHE, DEBUG_COMMAND, DEBUG_MMU > +}; > + > +#define IOMMU_DBGBIT(x) (1 << DEBUG_##x) > +static int iommu_dbgflags = IOMMU_DBGBIT(GENERAL) | IOMMU_DBGBIT(MMU) | IOMMU_DBGBIT(MMIO); > +//| IOMMU_DBGBIT(CAPAB) | IOMMU_DBGBIT(ELOG) | IOMMU_DBGBIT(CACHE) | IOMMU_DBGBIT(COMMAND); > + > +#define IOMMU_DPRINTF(what, fmt, ...) do { \ > + if (iommu_dbgflags & IOMMU_DBGBIT(what)) { \ > + fprintf(stderr, "(amd-iommu)%s: " fmt "\n", __func__, \ > + ## __VA_ARGS__); } \ > + } while (0) > +#else > +#define IOMMU_DPRINTF(what, fmt, ...) do {} while (0) > +#endif > + > +/* helper functions - FIXME - provide for reading one byte */ > +static uint16_t amd_iommu_readw(AMDIOMMUState *s, hwaddr addr) > +{ > + return lduw_le_p(&s->mmior[addr]); > +} > + > +static uint32_t amd_iommu_readl(AMDIOMMUState *s, hwaddr addr) > +{ > + return ldl_le_p(&s->mmior[addr]); > +} > + > +static uint64_t amd_iommu_readq(AMDIOMMUState *s, hwaddr addr) > +{ > + return ldq_le_p(&s->mmior[addr]); > +} > + > +static void amd_iommu_writew(AMDIOMMUState *s, hwaddr addr, uint16_t val) > +{ > + stw_le_p(&s->mmior[addr], val); > +} > + > +static void amd_iommu_writel(AMDIOMMUState *s, hwaddr addr, uint32_t val) > +{ > + stl_le_p(&s->mmior[addr], val); > +} > + > +static void amd_iommu_writeq(AMDIOMMUState *s, hwaddr addr, uint64_t val) > +{ > + stq_le_p(&s->mmior[addr], val); > +} > + > +/* execute a completion wait command */ > +static void amd_iommu_completion_wait(AMDIOMMUState *s, uint8_t *cmd) > +{ > + unsigned int addr; > + > + /* completion store */ > + if(cmd[0] & COM_COMPLETION_STORE_MASK){ > + addr = le64_to_cpu(*(uint64_t*)cmd) & COM_STORE_ADDRESS_MASK; > + if(dma_memory_write(&address_space_memory, addr, cmd + 8, 8)){ > + IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIx64, addr); > + } > + > + } > + > + /* set completion interrupt */ > + if (cmd[0] & COM_COMPLETION_INTR){ > + s->mmior[MMIO_STATUS] |= MMIO_STATUS_COMWAIT_INTR; > + } > +} > + > +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) > +{ > + unsigned type; > + uint8_t cmd[IOMMU_COMMAND_SIZE]; > + > + IOMMU_DPRINTF(COMMAND, ""); > + memset(cmd, 0, IOMMU_COMMAND_SIZE); > + > + if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, cmd, IOMMU_COMMAND_SIZE)){ > + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at 0x%"PRIx64 > + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); > + } > + > + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; > + > + switch(type){ > + case CMD_COMPLETION_WAIT: > + /* pretend to wait for command execution to complete */ > + IOMMU_DPRINTF(COMMAND, "completion wait requested"); > + amd_iommu_completion_wait(s, cmd); > + break; > + case CMD_INVAL_DEVTAB_ENTRY: > + /* Not implemented yet - should just clear device table contents */ > + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); Better make it clear that these commands are not implemented yet. An IOMMU is hardly usable without invalidators. > + break; > + case CMD_INVAL_IOMMU_PAGES: > + /* invalidate IOMMU cache for a particular domain */ > + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); > + break; > + case CMD_INVAL_IOTLB_PAGES: > + /* Only present if remote IOTLB present */ > + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); > + break; > + case CMD_INVAL_INTR_TABLE: > + /* no support for interrupt remapping yet */ > + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); > + break; > + default: > + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); > + break; > + } > + > +} > + > +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) > +{ > + IOMMU_DPRINTF(COMMAND, ""); > + > + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; > + > + if(!s->cmdbuf_enabled){ > + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); > + return; > + } > + > + while(s->cmdbuf_head != s->cmdbuf_tail) { > + /* check if there is work to do. */ > + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER tail at %x", > + s->cmdbuf_head, s->cmdbuf_tail); > + amd_iommu_cmdbuf_exec(s); > + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; > + > + /* wrap head pointer */ > + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { > + s->cmdbuf_head = 0; > + } > + } > + > + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); > +} > + > +/* System Software might never read from some of this fields but anyways */ > +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned size) > +{ > + AMDIOMMUState *s = opaque; > + > + uint64_t val = -1; > + if(addr + size > MMIO_SIZE) { > + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 > + ", got 0x%"PRIx64 " %d", > + (uint64_t)MMIO_SIZE, addr, size); > + return (uint64_t) - 1; > + } > + > + switch(addr & ~0x07){ > + case MMIO_DEVICE_TABLE: > + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; What makes these cases different, except debug printf()s? Maybe leave printf()s inside the switch, and factor out the rest. This applies to other similar cases as well. > + > + case MMIO_COMMAND_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EVENT_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_CONTROL: > + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EXCL_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EXCL_LIMIT: > + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_COMMAND_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_COMMAND_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EVENT_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EVENT_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_STATUS: > + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + case MMIO_EXT_FEATURES: > + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + if(size == 2){ > + val = amd_iommu_readw(s, addr); > + } else if(size == 4){ > + val = amd_iommu_readl(s, addr); > + } > + else if(size == 8){ > + val = amd_iommu_readq(s, addr); > + } > + break; > + > + default: > + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 > + ", size %d offset 0x%"PRIx64, addr, size, offset); > + } > + > + return val; > +} > + > +static void iommu_handle_control_write(AMDIOMMUState *s) > +{ > + /* read whatever is already written incase software is writing in chucks less than 8 bytes */ > + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); > + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); > + > + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); > + s->evtlog_enabled = s->enabled && !!(control & MMIO_CONTROL_EVENTLOGEN); > + > + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); > + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); > + s->cmdbuf_enabled = s->enabled && !!(control & MMIO_CONTROL_CMDBUFLEN); > + > + /* update the flags depending on the control register */ > + if(s->cmdbuf_enabled) { > + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; > + } else { > + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; > + } > + if (s->evtlog_enabled) { > + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; > + } else { > + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; > + } > + > + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); > + > + amd_iommu_cmdbuf_run(s); Does any write to control register result in draining command buffer? To me, it looks strange, and I'd expect IOMMU to execute commands only if I change tail pointer. > +} > + > +/* FIXME: something might go wrong if System Software writes in chunks > + * of one byte but linux writes in chunks of 4 bytes so currently it > + * works correctly with linux but will definitely be busted if software > + * reads/writes 8 bytes > + */ > +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) > +{ > + > + AMDIOMMUState *s = opaque; > + unsigned long offset = addr & 0x07; > + > + if(addr + size > MMIO_SIZE) { > + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 > + ", got 0x%"PRIx64 " %d", > + (uint64_t)MMIO_SIZE, addr, size); > + return; > + } > + > + switch(addr & ~0x07){ > + case MMIO_CONTROL: > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + > + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 , addr, size, val, offset); > + iommu_handle_control_write(s); > + break; > + > + case MMIO_DEVICE_TABLE: > + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + > + /* set device table address > + * This also suffers from inability to tell whether software is done writing > + */ > + if(offset || (size == 8)){ > + unsigned long device_base = amd_iommu_readq(s, MMIO_DEVICE_TABLE); > + s->devtab = (dma_addr_t)(device_base & MMIO_CMDBUF_BASE_MASK); > + /* set device table length */ > + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + 1) * (MMIO_DEVTAB_SIZE_UNIT / > + MMIO_DEVTAB_ENTRY_SIZE); > + } > + break; > + > + case MMIO_COMMAND_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; > + amd_iommu_cmdbuf_run(s); > + break; > + > + case MMIO_COMMAND_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + > + /* FIXME - make sure System Software has finished writing incase it writes > + * in chucks less than 8 bytes in a robust way.As for now, this hacks works > + * for the linux driver > + */ > + if(offset || (size == 8)){ > + unsigned long command_base = amd_iommu_readq(s, MMIO_COMMAND_BASE); > + s->cmdbuf = (dma_addr_t)(command_base & MMIO_CMDBUF_BASE_MASK); > + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & MMIO_CMDBUF_SIZE_MASK); > + s->cmdbuf_head = s->cmdbuf_tail = 0; > + } > + break; > + > + case MMIO_COMMAND_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + > + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; > + amd_iommu_cmdbuf_run(s); > + break; > + > + case MMIO_EVENT_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); > + s->evtlog_len = 1UL << (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); > + break; > + > + case MMIO_EXCL_LIMIT: > + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | MMIO_EXCL_LIMIT_LOW; > + break; > + //TODO : Event handling fixes > + > + case MMIO_EVENT_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + > + case MMIO_EVENT_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + /* PPR log base - unused for now */ > + case MMIO_PPR_BASE: > + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + /* PPR log head - also unused for now */ > + case MMIO_PPR_HEAD: > + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + /* PPR log tail - unused for now */ > + case MMIO_PPR_TAIL: > + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + if(size == 2){ > + amd_iommu_writew(s, addr, val); > + } else if(size == 4){ > + amd_iommu_writel(s, addr, val); > + } else if(size == 8){ > + amd_iommu_writeq(s, addr, val); > + } > + break; > + > + default: > + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 > + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64, addr, size, val, offset); > + ; > + } > + > +} > + > +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) > +{ > + /* event logging not enabled */ > + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | MMIO_STATUS_EVTLOG_OF){ > + return; > + } > + > + /* event log buffer full */ > + if(s->evtlog_tail >= s->evtlog_len) { > + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; > + } > + > + if(dma_memory_write(&address_space_memory, s->evtlog_len + s->evtlog_tail, &evt, EVENT_LEN)){ > + //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, s->evtlog + s->evtlog_tail); > + } > + > + s->evtlog_tail += EVENT_LEN; > + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; > + /* Disable logging if Overflow ? */ No, the spec details event logging restart procedure. Make sure emulated IOMMU behaves as described there. > +} > + > +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned domid, dma_addr_t addr, int present, > + int is_write) > +{ > + IOMMU_DPRINTF(ELOG, ""); > + > + AMDIOMMUEvent evt; > + unsigned info; > + uint16_t status; > + > + evt.devfn = cpu_to_le16(devfn); > + evt.reserved = 0; > + evt.domid = cpu_to_le16(domid); > + evt.addr = cpu_to_le16(addr); > + > + info = EVENT_IOPF; > + > + if(present) { > + info |= EVENT_IOPF_PR; > + } > + > + if (is_write) { > + info |= EVENT_IOPF_RW; > + } > + > + /* log a page fault */ > + amd_iommu_log_event(s, &evt); > + > + /* Abort the translation */ > + status = pci_get_word(s->dev.config + PCI_STATUS); > + pci_set_word(s->dev.config + PCI_STATUS, status | PCI_STATUS_SIG_TARGET_ABORT); > +} > + > +static inline uint64_t amd_iommu_get_perms(uint64_t entry) > +{ > + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; > +} > + > +/* FIXME deduplication */ > +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) > +{ > + AMDIOMMUState *s = opaque; > + AMDIOMMUAddressSpace **iommu_as; > + int bus_num = pci_bus_num(bus); > + > + /* just in case */ > + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); > + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); > + > + iommu_as = s->address_spaces[bus_num]; > + > + /* allocate memory during the first run */ > + if(!iommu_as) { > + iommu_as = g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); > + s->address_spaces[bus_num] = iommu_as; > + } > + > + /* set up IOMMU region */ > + if(!iommu_as[devfn]){ > + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); > + iommu_as[devfn]->bus_num = (uint8_t)bus_num; > + iommu_as[devfn]->devfn = (uint8_t)devfn; > + iommu_as[devfn]->iommu_state = s; > + > + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), &s->iommu_ops, "amd-iommu", UINT64_MAX); > + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, "amd-iommu"); > + } > + return &iommu_as[devfn]->as; > +} > + > +/* validate a page table entry */ > +static bool amd_iommu_validate_pte(uint64_t pte) > +{ > + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; I'd suggest parenthesis here. > +} > + > +/* get a device table entry given the device function */ > +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t *entry) > +{ > + /* Could lead to out of range accesses */ > + assert(0 < devfn && devfn < PCI_DEVFN_MAX); > + > + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; > + if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, 32)){ > + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab 0x%"PRIx64 > + "offset 0x%"PRIx32, s->devtab, offset); > + return false; > + } > + > + if(!amd_iommu_validate_pte(entry[0])){ > + IOMMU_DPRINTF(MMU, > + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); > + return false; > + } > + > + return true; > +} > + > +static uint64_t get_pte_translation_mode(uint64_t pte) > +{ > + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; > + > + if(level == 7){ > + /* reserved level - abort ? */ > + IOMMU_DPRINTF(MMU, > + "Reserved translation level (7) detected"); > + return 0; > + } > + > + return level; > +} > + > +/* TODO : Mark addresses as Accessed and Dirty */ > +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, bool is_write, IOMMUTLBEntry *ret) > +{ > + AMDIOMMUState *s = as->iommu_state; > + > + int present; > + dma_addr_t pte_addr; > + uint64_t entry[4], pte, pte_perms; > + unsigned level; > + unsigned perms; > + > + if(!amd_iommu_get_dte(s, as->devfn, entry)){ > + goto no_translation; > + } > + > + pte = entry[0]; > + > + /* > + * It's okay to check for either read or write permissions > + * even for memory maps, since we don't support R/W maps. > + */ > + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; > + > + if(!(level = get_pte_translation_mode(pte))){ > + goto no_translation; > + } > + > + while(level > 0){ > + /* > + * check permissions: the bitwise > + * implication perms -> entry_perms must be true. Pages must be present > + * and permissions on all levels must be similar > + */ > + pte_perms = amd_iommu_get_perms(pte); > + present = pte & 1; > + if(!present || perms != (perms & pte_perms)){ > + amd_iommu_page_fault(s, as->devfn, entry[1] & DEV_DOMID_ID_MASK, addr, present, > + !!(perms & IOMMU_PERM_WRITE)); > + return; > + } > + > + /* go to the next lower level */ > + pte_addr = pte & DEV_PT_ROOT_MASK; > + pte_addr += ((addr >> ( 9 * level)) & 0xff8); Does this work for six level page tables? The highest level has different bit size there IIRC. > + pte = ldq_phys(&address_space_memory, pte_addr); > + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; > + } > + > + ret->iova = addr & IOMMU_PAGE_MASK_4K; > + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; > + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; > + ret->perm = IOMMU_RW; > + return; > + > +no_translation: > + ret->iova = addr; > + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; > + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; > + ret->perm = IOMMU_RW; > + return; Are you sure these transactions needs to be passed through rather than target-aborted? > +} > + > +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr addr, bool is_write) > +{ > + > + IOMMU_DPRINTF(GENERAL, ""); > + > + AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, iommu); > + AMDIOMMUState *s = as->iommu_state; > + > + IOMMUTLBEntry ret = { > + .target_as = &address_space_memory, > + .iova = addr, > + .translated_addr = 0, > + .addr_mask = ~(hwaddr)0, > + .perm = IOMMU_NONE, > + }; > + > + if(!s->enabled){ > + /* IOMMU disabled - corresponds to iommu=off not failure to provide any parameter */ > + ret.iova = addr & IOMMU_PAGE_MASK_4K; > + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; > + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; > + ret.perm = IOMMU_RW; > + return ret; > + } > + > + amd_iommu_do_translate(as, addr, is_write, &ret); > + > + IOMMU_DPRINTF(MMU, > + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, as->bus_num, > + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, ret.translated_addr); > + > + return ret; > +} > + > +static const MemoryRegionOps mmio_mem_ops = { > + .read = amd_iommu_mmio_read, > + .write = amd_iommu_mmio_write, > + .endianness = DEVICE_LITTLE_ENDIAN, > + .valid = { > + .min_access_size = 1, > + .max_access_size = 8, > + .unaligned = false, > + }, > + > + .valid = { > + .min_access_size = 8, > + .max_access_size = 8, > + }, > +}; > + > +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, uint32_t guest_va, uint32_t *reg) > +{ > + *reg = 0; Redundant line. > + > + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; > +} > + > +/* FIXME: The similar code in reset and init could be combined into a function */ > +static void amd_iommu_reset(DeviceState *dev) > +{ > + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); > + > + uint32_t capab_header = CAPAB_FEATURES; > + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); > + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; > + uint32_t capab_range = 0xff000000; > + uint32_t capab_misc = 0x0; > + > + /* reset MMIO */ > + memset(s->mmior, 0, MMIO_SIZE); > + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); > + /* TODO :Disable event logging and reset all buffers */ > + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, &capab_misc); > + > + /* reset IOMMU specific capabilities */ > + pci_set_long(s->dev.config + s->capab_offset, capab_header); > + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, capab_base_addr_low); > + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, capab_base_addr_high); > + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, capab_range); > + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, capab_misc); Do we also need to reset MSI capability block? > + > + /* reset device ident */ > + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); > + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); > + pci_config_set_class(s->dev.config, 0x0806); > + pci_config_set_prog_interface(s->dev.config, 00); > +} > + > +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t val, int len) > +{ > + pci_default_write_config(dev, addr, val, len); > +} > + > +/* I honestly don't know how to reserve MMIO */ > +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) > +{ > + if(s->mmio.addr == addr){ > + return; > + } > + > +// if(s->mmio.addr != (hwaddr)-1) { > +// memory_region_del_subregion(get_system_memory(), &s->mmio); > +// } > + > + s->mmio.addr = addr; > + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); > + > +} > + > +static int amd_iommu_pci_initfn(PCIDevice *dev) > +{ > + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); > + uint32_t capab_header = CAPAB_FEATURES; > + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); > + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); > + uint32_t capab_range = 0xff000000; > + uint32_t capab_misc = 0x0; > + > + memset(s->mmior, 0, MMIO_SIZE); > + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, &capab_misc); > + > + s->iommu_ops.translate = amd_iommu_translate; > + s->enabled = false; > + s->ats_enabled = false; > + s->cmdbuf_enabled = false; > + s->devtab_len = 0; > + s->cmdbuf_len = 0; > + s->cmdbuf_head = 0; > + s->cmdbuf_tail = 0; > + s->evtlog_head = 0; > + s->evtlog_tail = 0; > + s->excl_enabled = false; > + s->excl_allow = false; > + s->mmio_enabled = false; > + dev->config_write = amd_iommu_write_capab; > + > + size_t offset; > + /* Save offset for IVRS */ > + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, CAPAB_SIZE); > + pci_set_long(s->dev.config + offset, capab_header); > + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, capab_base_addr_low); > + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, capab_base_addr_high); > + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); > + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); > + > + /* add msi and hypertransport capabilities */ > + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); > + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); > + > + /* set up MMIO */ > + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, "amd-iommu", MMIO_SIZE); > + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); > + > + /* reset device ident */ > + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); > + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); > + > + /* may not be necessary */ > + pci_config_set_interrupt_pin(dev->config, 0x1a); > + > + return 0; > +} > + > +static void amd_iommu_realize(PCIDevice *dev, Error **error) > +{ > + amd_iommu_pci_initfn(dev); > +} > + > +static const VMStateDescription vmstate_amd_iommu = { > + .name = "amd-iommu", > + .fields = (VMStateField[]) { > + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), > + VMSTATE_END_OF_LIST() > + } > +}; > + > +static Property amd_iommu_properties[] = { > + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), > + DEFINE_PROP_END_OF_LIST(), > +}; > + > +/* not used for now but will be when cache is added */ > +static void amd_iommu_uninit(PCIDevice *dev) > +{ > + return; > +} > + > +static void amd_iommu_class_init(ObjectClass *klass, void* data) > +{ > + DeviceClass *dc = DEVICE_CLASS(klass); > + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); > + > + pci->realize = amd_iommu_realize; > + pci->exit = amd_iommu_uninit; > + > + dc->reset = amd_iommu_reset; > + dc->vmsd = &vmstate_amd_iommu; > + dc->props = amd_iommu_properties; > +} > + > +static const TypeInfo amd_iommu = { > + .name = TYPE_AMD_IOMMU_DEVICE, > + .parent = TYPE_PCI_DEVICE, > + .instance_size = sizeof(AMDIOMMUState), > + .class_init = amd_iommu_class_init > +}; > + > +static void amd_iommu_register_types(void) > +{ > + type_register_static(&amd_iommu); > +} > + > +type_init(amd_iommu_register_types); > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > new file mode 100644 > index 0000000..90309eb > --- /dev/null > +++ b/hw/i386/amd_iommu.h > @@ -0,0 +1,298 @@ > +/* > + * QEMU emulation of an AMD IOMMU (AMD-Vi) > + * > + * Copyright (C) 2011 Eduard-Gabriel Mateanu > + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see <http://www.gnu.org/licenses/>. > + */ > + > +#ifndef AMD_IOMMU_H_ > +#define AMD_IOMMU_H_ > + > +#include "hw/hw.h" > +#include "hw/pci/pci.h" > +#include "hw/sysbus.h" > +#include "sysemu/dma.h" > +#include "qemu/osdep.h" > +#include "qemu/event_notifier.h" > + > +/* Capability registers */ > +#define CAPAB_HEADER 0x00 > +#define CAPAB_REV_TYPE 0x02 > +#define CAPAB_FLAGS 0x03 > +#define CAPAB_BAR_LOW 0x04 > +#define CAPAB_BAR_HIGH 0x08 > +#define CAPAB_RANGE 0x0C > +#define CAPAB_MISC 0x10 > +#define CAPAB_MISC1 0x14 > + > +#define CAPAB_SIZE 0x18 > +#define CAPAB_REG_SIZE 0x04 > + > +/* Capability header data */ > +#define CAPAB_FLAT_EXT (1 << 28) > +#define CAPAB_EFR_SUP (1 << 27) > +#define CAPAB_FLAG_NPCACHE (1 << 26) > +#define CAPAB_FLAG_HTTUNNEL (1 << 25) > +#define CAPAB_FLAG_IOTLBSUP (1 << 24) > +#define CAPAB_INIT_REV (1 << 19) > +#define CAPAB_INIT_TYPE (3 << 16) > +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) > +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | CAPAB_FLAG_HTTUNNEL) > +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) > +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) > + > +/* MMIO registers */ > +#define MMIO_DEVICE_TABLE 0x0000 > +#define MMIO_COMMAND_BASE 0x0008 > +#define MMIO_EVENT_BASE 0x0010 > +#define MMIO_CONTROL 0x0018 > +#define MMIO_EXCL_BASE 0x0020 > +#define MMIO_EXCL_LIMIT 0x0028 > +#define MMIO_EXT_FEATURES 0x0030 > +#define MMIO_COMMAND_HEAD 0x2000 > +#define MMIO_COMMAND_TAIL 0x2008 > +#define MMIO_EVENT_HEAD 0x2010 > +#define MMIO_EVENT_TAIL 0x2018 > +#define MMIO_STATUS 0x2020 > +#define MMIO_PPR_BASE 0x0038 > +#define MMIO_PPR_HEAD 0x2030 > +#define MMIO_PPR_TAIL 0x2038 > + > +#define MMIO_SIZE 0x4000 > + > +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) > +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & ~MMIO_DEVTAB_SIZE_MASK) > +#define MMIO_DEVTAB_ENTRY_SIZE 32 > +#define MMIO_DEVTAB_SIZE_UNIT 4096 > + > +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) > +#define MMIO_CMDBUF_SIZE_MASK 0x0F > +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK > +#define MMIO_CMDBUF_DEFAULT_SIZE 8 > +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) > +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK > + > +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) > +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK > +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK > +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE > +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) > +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK > + > +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK > +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) > +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) > +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK > +#define MMIO_EXCL_LIMIT_LOW 0xFFF > + > +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) > +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) > +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) > +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) > +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) > +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) > + > +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) > +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) > +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) > +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) > +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) > + > +#define CMDBUF_ID_BYTE 0x07 > +#define CMDBUF_ID_RSHIFT 4 > +#define CMDBUF_ENTRY_SIZE 0x10 > + > +#define CMD_COMPLETION_WAIT 0x01 > +#define CMD_INVAL_DEVTAB_ENTRY 0x02 > +#define CMD_INVAL_IOMMU_PAGES 0x03 > +#define CMD_INVAL_IOTLB_PAGES 0x04 > +#define CMD_INVAL_INTR_TABLE 0x05 > + > +#define DEVTAB_ENTRY_SIZE 32 > + > +/* Device table entry bits 0:63 */ > +#define DEV_VALID (1ULL << 0) > +#define DEV_TRANSLATION_VALID (1ULL << 1) > +#define DEV_MODE_MASK 0x7 > +#define DEV_MODE_RSHIFT 9 > +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 > +#define DEV_PT_ROOT_RSHIFT 12 > +#define DEV_PERM_SHIFT 61 > +#define DEV_PERM_READ (1ULL << 61) > +#define DEV_PERM_WRITE (1ULL << 62) > + > +/* Device table entry bits 64:127 */ > +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) > +#define DEV_IOTLB_SUPPORT (1ULL << 17) > +#define DEV_SUPPRESS_PF (1ULL << 18) > +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) > +#define DEV_IOCTL_MASK (~3) > +#define DEV_IOCTL_RSHIFT 20 > +#define DEV_IOCTL_DENY 0 > +#define DEV_IOCTL_PASSTHROUGH 1 > +#define DEV_IOCTL_TRANSLATE 2 > +#define DEV_CACHE (1ULL << 37) > +#define DEV_SNOOP_DISABLE (1ULL << 38) > +#define DEV_EXCL (1ULL << 39) > + > +/* Event codes and flags, as stored in the info field */ > +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) > +#define EVENT_IOPF (0x2U << 24) > +#define EVENT_IOPF_I (1U << 3) > +#define EVENT_IOPF_PR (1U << 4) > +#define EVENT_IOPF_RW (1U << 5) > +#define EVENT_IOPF_PE (1U << 6) > +#define EVENT_IOPF_RZ (1U << 7) > +#define EVENT_IOPF_TR (1U << 8) > +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) > +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) > +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) > +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) > +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) > +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) > + > +#define EVENT_LEN 16 > + > +#define IOMMU_PERM_READ (1 << 0) > +#define IOMMU_PERM_WRITE (1 << 1) > +#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) > + > +/* AMD RD890 Chipset */ > +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 > + > +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header register */ > +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low register */ > +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high register */ > +#define PCI_CAP_ID_RANGE 0x0 /* Device range register */ > +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information register 0 */ > +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information register 1 */ > + > +#define FEATURE_PREFETCH (1ULL<<0) > +#define FEATURE_PPR (1ULL<<1) > +#define FEATURE_NX (1ULL<<3) > +#define FEATURE_GT (1ULL<<4) > +#define FEATURE_IA (1ULL<<6) > +#define FEATURE_GA (1ULL<<7) > +#define FEATURE_HE (1ULL<<8) > +#define FEATURE_PC (1ULL<<9) > + > +/* IOMMU paging mode */ > +#define GATS_MODE (6ULL << 12) > +#define HATS_MODE (6ULL << 10) > +/* PCI SIG constants */ > +#define PCI_BUS_MAX 256 > +#define PCI_SLOT_MAX 32 > +#define PCI_FUNC_MAX 8 > +#define PCI_DEVFN_MAX 256 > + > +/* extended feature support */ > +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) > + > +/* capabilities header */ > +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL | CAPAB_EFR_SUP) > + > +/* command constants */ > +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 > +#define COM_COMPLETION_STORE_MASK 0x1 > +#define COM_COMPLETION_INTR 0x2 > +#define COM_COMPLETION_DATA_OFF 0x8 > +#define IOMMU_COMMAND_SIZE 0x10 > + > +/* IOMMU default address */ > +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 > + > +/* page management constants */ > +#define IOMMU_PAGE_SHIFT 12 > +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) > + > +#define IOMMU_PAGE_SHIFT_4K 12 > +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) > +#define IOMMU_PAGE_SHIFT_2M 21 > +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) > +#define IOMMU_PAGE_SHIFT_1G 30 > +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) > + > +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" > +#define AMD_IOMMU_DEVICE(obj)\ > + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) > + > +typedef struct AMDIOMMUState AMDIOMMUState; > + > +typedef struct AMDIOMMUAddressSpace{ > + uint8_t bus_num; /* bus number */ > + uint8_t devfn; /* device function */ > + AMDIOMMUState *iommu_state; /* IOMMU - one per machine */ > + MemoryRegion iommu; /* Device's iommu region */ > + AddressSpace as; /* device's corresponding address space */ > +}AMDIOMMUAddressSpace; > + > +struct AMDIOMMUState { > + PCIDevice dev; /* The PCI device itself */ > + > + uint32_t version; > + > + int capab_offset; /* capability offset pointer */ > + unsigned char *capab; /* capabilities registers */ > + > + bool enabled; /* IOMMU enabled */ > + bool ats_enabled; /* address translation enabled */ > + bool cmdbuf_enabled; /* command buffer enabled */ > + bool evtlog_enabled; /* event log enabled */ > + bool excl_enabled; > + > + dma_addr_t devtab; /* base address device table */ > + size_t devtab_len; /* device table length */ > + > + dma_addr_t cmdbuf; /* command buffer base address */ > + uint64_t cmdbuf_len; /* command buffer length */ > + unsigned cmdbuf_head; /* current IOMMU read position */ > + unsigned cmdbuf_tail; /* next Software write position */ > + int completion_wait_intr; > + > + dma_addr_t evtlog; /* base address event log */ > + size_t evtlog_intr; > + size_t evtlog_len; /* event log length */ > + size_t evtlog_head; /* event log head */ > + size_t evtlog_tail; /* event log tail */ > + > + /* unused for now */ > + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ > + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ > + bool excl_allow; /* translate accesses to the exclusion range */ > + bool excl_enable; /* exclusion range enabled */ > + > + MemoryRegion mmio; /* MMIO region */ > + unsigned char mmior[MMIO_SIZE]; > + bool mmio_enabled; > + > + /* IOMMU function */ > + MemoryRegionIOMMUOps iommu_ops; > + > + /* for each served device */ > + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; > +}; > + > +typedef struct AMDIOMMUEvent { > + uint16_t devfn; > + uint16_t reserved; > + uint16_t domid; > + uint16_t info; > + uint16_t addr; > +} __attribute__((packed)) AMDIOMMUEvent; > + > +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn); > + > +#endif > Regards, Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-07 12:46 ` Valentine Sinitsyn @ 2015-09-09 7:30 ` David kiarie 2015-09-09 7:45 ` Valentine Sinitsyn 2015-09-12 10:55 ` Valentine Sinitsyn 1 sibling, 1 reply; 22+ messages in thread From: David kiarie @ 2015-09-09 7:30 UTC (permalink / raw) To: Valentine Sinitsyn; +Cc: Jan Kiszka, QEMU Developers, mst On Mon, Sep 7, 2015 at 3:46 PM, Valentine Sinitsyn <valentine.sinitsyn@gmail.com> wrote: > Hi David, > > Sorry for the long silence. I've skimmed through your patch, below are some > thoughts. Please remember I'm looking for IOMMU implementation details, not > how it is integrated with QEMU. > > On 25.08.2015 04:19, David Kiarie wrote: >> >> From: David <davidkiarie4@gmail.com> >> >> Add AMD IOMMU emulation to Qemu. This is a very basic AMD IOMMU >> emulation that only does translation and some basic Event logging. >> Guest translation enables nested PCI passthrough >> >> Signed-off-by: David Kiarie <davidkiarie4@gmail.com> >> --- >> hw/i386/Makefile.objs | 1 + >> hw/i386/amd_iommu.c | 993 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> hw/i386/amd_iommu.h | 298 +++++++++++++++ >> 3 files changed, 1292 insertions(+) >> create mode 100644 hw/i386/amd_iommu.c >> create mode 100644 hw/i386/amd_iommu.h >> >> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs >> index ebd1015..2bae11c 100644 >> --- a/hw/i386/Makefile.objs >> +++ b/hw/i386/Makefile.objs >> @@ -3,6 +3,7 @@ obj-y += multiboot.o >> obj-y += pc.o pc_piix.o pc_q35.o >> obj-y += pc_sysfw.o >> obj-y += intel_iommu.o >> +obj-y += amd_iommu.o >> obj-$(CONFIG_XEN) += ../xenpv/ xen/ >> >> obj-y += kvmvapic.o >> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c >> new file mode 100644 >> index 0000000..a3a0b20 >> --- /dev/null >> +++ b/hw/i386/amd_iommu.c >> @@ -0,0 +1,993 @@ >> +/* >> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >> + * >> + * Copyright (C) 2011 Eduard - Gabriel Munteanu >> + * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + >> + * You should have received a copy of the GNU General Public License >> along >> + * with this program; if not, see <http://www.gnu.org/licenses/>. >> + * >> + */ >> +#include "hw/i386/amd_iommu.h" >> + >> +#define PCI_EXT_CAP_ID_PASID 0x1B >> +#define PCI_EXT_CAP_ID_PRI 0x13 > > Do you really need those? They don't seem to be used. >> >> + >> +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) >> +#define PCI_FUNC(devfn) ((devfn) & 0x07) >> + >> +#define MAX_VA_ADDR (64UL << 5) >> +#define MAX_PH_ADDR (48UL << 8) >> +#define MAX_GVA_ADDR (64UL << 15) >> + >> +//#define DEBUG_AMD_IOMMU > > It's generally advisable to avoid commented-out lines. Use #ifdefs, or > remove them altogether. > > >> +#ifdef DEBUG_AMD_IOMMU >> +enum { >> + DEBUG_GENERAL, DEBUG_CAPAB, DEBUG_MMIO, DEBUG_ELOG, >> + DEBUG_CACHE, DEBUG_COMMAND, DEBUG_MMU >> +}; >> + >> +#define IOMMU_DBGBIT(x) (1 << DEBUG_##x) >> +static int iommu_dbgflags = IOMMU_DBGBIT(GENERAL) | IOMMU_DBGBIT(MMU) | >> IOMMU_DBGBIT(MMIO); >> +//| IOMMU_DBGBIT(CAPAB) | IOMMU_DBGBIT(ELOG) | IOMMU_DBGBIT(CACHE) | >> IOMMU_DBGBIT(COMMAND); >> + >> +#define IOMMU_DPRINTF(what, fmt, ...) do { \ >> + if (iommu_dbgflags & IOMMU_DBGBIT(what)) { \ >> + fprintf(stderr, "(amd-iommu)%s: " fmt "\n", __func__, \ >> + ## __VA_ARGS__); } \ >> + } while (0) >> +#else >> +#define IOMMU_DPRINTF(what, fmt, ...) do {} while (0) >> +#endif >> + >> +/* helper functions - FIXME - provide for reading one byte */ >> +static uint16_t amd_iommu_readw(AMDIOMMUState *s, hwaddr addr) >> +{ >> + return lduw_le_p(&s->mmior[addr]); >> +} >> + >> +static uint32_t amd_iommu_readl(AMDIOMMUState *s, hwaddr addr) >> +{ >> + return ldl_le_p(&s->mmior[addr]); >> +} >> + >> +static uint64_t amd_iommu_readq(AMDIOMMUState *s, hwaddr addr) >> +{ >> + return ldq_le_p(&s->mmior[addr]); >> +} >> + >> +static void amd_iommu_writew(AMDIOMMUState *s, hwaddr addr, uint16_t val) >> +{ >> + stw_le_p(&s->mmior[addr], val); >> +} >> + >> +static void amd_iommu_writel(AMDIOMMUState *s, hwaddr addr, uint32_t val) >> +{ >> + stl_le_p(&s->mmior[addr], val); >> +} >> + >> +static void amd_iommu_writeq(AMDIOMMUState *s, hwaddr addr, uint64_t val) >> +{ >> + stq_le_p(&s->mmior[addr], val); >> +} >> + >> +/* execute a completion wait command */ >> +static void amd_iommu_completion_wait(AMDIOMMUState *s, uint8_t *cmd) >> +{ >> + unsigned int addr; >> + >> + /* completion store */ >> + if(cmd[0] & COM_COMPLETION_STORE_MASK){ >> + addr = le64_to_cpu(*(uint64_t*)cmd) & COM_STORE_ADDRESS_MASK; >> + if(dma_memory_write(&address_space_memory, addr, cmd + 8, 8)){ >> + IOMMU_DPRINTF(ELOG, "error: fail to write at address >> 0%x"PRIx64, addr); >> + } >> + >> + } >> + >> + /* set completion interrupt */ >> + if (cmd[0] & COM_COMPLETION_INTR){ >> + s->mmior[MMIO_STATUS] |= MMIO_STATUS_COMWAIT_INTR; >> + } >> +} >> + >> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >> +{ >> + unsigned type; >> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >> + >> + IOMMU_DPRINTF(COMMAND, ""); >> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >> + >> + if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, >> cmd, IOMMU_COMMAND_SIZE)){ >> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >> 0x%"PRIx64 >> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >> + } >> + >> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >> + >> + switch(type){ >> + case CMD_COMPLETION_WAIT: >> + /* pretend to wait for command execution to complete */ >> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >> + amd_iommu_completion_wait(s, cmd); >> + break; >> + case CMD_INVAL_DEVTAB_ENTRY: >> + /* Not implemented yet - should just clear device table >> contents */ >> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); > > Better make it clear that these commands are not implemented yet. An IOMMU > is hardly usable without invalidators. I think the "debug prinft" here is misleading. AFAIK, the commands listed here(there are others which I haven't listed) relate to 'cache' which means this commands do nothing in the absence of cache. The reason why I advertise 'cache' is because the linux driver checks for cache and other optional features to determine the IOMMU version whereby versions 2 of IOMMU are assummed to support this features. > >> + break; >> + case CMD_INVAL_IOMMU_PAGES: >> + /* invalidate IOMMU cache for a particular domain */ >> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >> + break; >> + case CMD_INVAL_IOTLB_PAGES: >> + /* Only present if remote IOTLB present */ >> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >> + break; >> + case CMD_INVAL_INTR_TABLE: >> + /* no support for interrupt remapping yet */ >> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >> + break; >> + default: >> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >> + break; >> + } >> + >> +} >> + >> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >> +{ >> + IOMMU_DPRINTF(COMMAND, ""); >> + >> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; >> + >> + if(!s->cmdbuf_enabled){ >> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >> + return; >> + } >> + >> + while(s->cmdbuf_head != s->cmdbuf_tail) { >> + /* check if there is work to do. */ >> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER >> tail at %x", >> + s->cmdbuf_head, s->cmdbuf_tail); >> + amd_iommu_cmdbuf_exec(s); >> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >> + >> + /* wrap head pointer */ >> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >> + s->cmdbuf_head = 0; >> + } >> + } >> + >> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >> +} >> + >> +/* System Software might never read from some of this fields but anyways >> */ >> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >> size) >> +{ >> + AMDIOMMUState *s = opaque; >> + >> + uint64_t val = -1; >> + if(addr + size > MMIO_SIZE) { >> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >> + ", got 0x%"PRIx64 " %d", >> + (uint64_t)MMIO_SIZE, addr, size); >> + return (uint64_t) - 1; >> + } >> + >> + switch(addr & ~0x07){ >> + case MMIO_DEVICE_TABLE: >> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; > > What makes these cases different, except debug printf()s? Maybe leave > printf()s inside the switch, and factor out the rest. This applies to other > similar cases as well. > > >> + >> + case MMIO_COMMAND_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EVENT_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_CONTROL: >> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EXCL_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EXCL_LIMIT: >> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_COMMAND_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_COMMAND_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EVENT_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EVENT_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_STATUS: >> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + case MMIO_EXT_FEATURES: >> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + if(size == 2){ >> + val = amd_iommu_readw(s, addr); >> + } else if(size == 4){ >> + val = amd_iommu_readl(s, addr); >> + } >> + else if(size == 8){ >> + val = amd_iommu_readq(s, addr); >> + } >> + break; >> + >> + default: >> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >> + ", size %d offset 0x%"PRIx64, addr, size, >> offset); >> + } >> + >> + return val; >> +} >> + >> +static void iommu_handle_control_write(AMDIOMMUState *s) >> +{ >> + /* read whatever is already written incase software is writing in >> chucks less than 8 bytes */ >> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >> + >> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >> + s->evtlog_enabled = s->enabled && !!(control & >> MMIO_CONTROL_EVENTLOGEN); >> + >> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >> + s->cmdbuf_enabled = s->enabled && !!(control & >> MMIO_CONTROL_CMDBUFLEN); >> + >> + /* update the flags depending on the control register */ >> + if(s->cmdbuf_enabled) { >> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >> + } else { >> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; >> + } >> + if (s->evtlog_enabled) { >> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >> + } else { >> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; >> + } >> + >> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >> + >> + amd_iommu_cmdbuf_run(s); > > Does any write to control register result in draining command buffer? To me, > it looks strange, and I'd expect IOMMU to execute commands only if I change > tail pointer. > > >> +} >> + >> +/* FIXME: something might go wrong if System Software writes in chunks >> + * of one byte but linux writes in chunks of 4 bytes so currently it >> + * works correctly with linux but will definitely be busted if software >> + * reads/writes 8 bytes >> + */ >> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, >> unsigned size) >> +{ >> + >> + AMDIOMMUState *s = opaque; >> + unsigned long offset = addr & 0x07; >> + >> + if(addr + size > MMIO_SIZE) { >> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >> + ", got 0x%"PRIx64 " %d", >> + (uint64_t)MMIO_SIZE, addr, size); >> + return; >> + } >> + >> + switch(addr & ~0x07){ >> + case MMIO_CONTROL: >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + >> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 >> , addr, size, val, offset); >> + iommu_handle_control_write(s); >> + break; >> + >> + case MMIO_DEVICE_TABLE: >> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + >> + /* set device table address >> + * This also suffers from inability to tell whether software >> is done writing >> + */ >> + if(offset || (size == 8)){ >> + unsigned long device_base = amd_iommu_readq(s, >> MMIO_DEVICE_TABLE); >> + s->devtab = (dma_addr_t)(device_base & >> MMIO_CMDBUF_BASE_MASK); >> + /* set device table length */ >> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + >> 1) * (MMIO_DEVTAB_SIZE_UNIT / >> + MMIO_DEVTAB_ENTRY_SIZE); >> + } >> + break; >> + >> + case MMIO_COMMAND_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >> + amd_iommu_cmdbuf_run(s); >> + break; >> + >> + case MMIO_COMMAND_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + >> + /* FIXME - make sure System Software has finished writing >> incase it writes >> + * in chucks less than 8 bytes in a robust way.As for now, >> this hacks works >> + * for the linux driver >> + */ >> + if(offset || (size == 8)){ >> + unsigned long command_base = amd_iommu_readq(s, >> MMIO_COMMAND_BASE); >> + s->cmdbuf = (dma_addr_t)(command_base & >> MMIO_CMDBUF_BASE_MASK); >> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & >> MMIO_CMDBUF_SIZE_MASK); >> + s->cmdbuf_head = s->cmdbuf_tail = 0; >> + } >> + break; >> + >> + case MMIO_COMMAND_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + >> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >> + amd_iommu_cmdbuf_run(s); >> + break; >> + >> + case MMIO_EVENT_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >> + s->evtlog_len = 1UL << >> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >> + break; >> + >> + case MMIO_EXCL_LIMIT: >> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >> MMIO_EXCL_LIMIT_LOW; >> + break; >> + //TODO : Event handling fixes >> + >> + case MMIO_EVENT_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + >> + case MMIO_EVENT_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + /* PPR log base - unused for now */ >> + case MMIO_PPR_BASE: >> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + /* PPR log head - also unused for now */ >> + case MMIO_PPR_HEAD: >> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + /* PPR log tail - unused for now */ >> + case MMIO_PPR_TAIL: >> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + if(size == 2){ >> + amd_iommu_writew(s, addr, val); >> + } else if(size == 4){ >> + amd_iommu_writel(s, addr, val); >> + } else if(size == 8){ >> + amd_iommu_writeq(s, addr, val); >> + } >> + break; >> + >> + default: >> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >> + ", size %d, val 0x%"PRIx64 ", offset >> 0x%"PRIx64, addr, size, val, offset); >> + ; >> + } >> + >> +} >> + >> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >> +{ >> + /* event logging not enabled */ >> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >> MMIO_STATUS_EVTLOG_OF){ >> + return; >> + } >> + >> + /* event log buffer full */ >> + if(s->evtlog_tail >= s->evtlog_len) { >> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >> + } >> + >> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >> s->evtlog_tail, &evt, EVENT_LEN)){ >> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, >> s->evtlog + s->evtlog_tail); >> + } >> + >> + s->evtlog_tail += EVENT_LEN; >> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >> + /* Disable logging if Overflow ? */ > > No, the spec details event logging restart procedure. Make sure emulated > IOMMU behaves as described there. > > >> +} >> + >> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >> domid, dma_addr_t addr, int present, >> + int is_write) >> +{ >> + IOMMU_DPRINTF(ELOG, ""); >> + >> + AMDIOMMUEvent evt; >> + unsigned info; >> + uint16_t status; >> + >> + evt.devfn = cpu_to_le16(devfn); >> + evt.reserved = 0; >> + evt.domid = cpu_to_le16(domid); >> + evt.addr = cpu_to_le16(addr); >> + >> + info = EVENT_IOPF; >> + >> + if(present) { >> + info |= EVENT_IOPF_PR; >> + } >> + >> + if (is_write) { >> + info |= EVENT_IOPF_RW; >> + } >> + >> + /* log a page fault */ >> + amd_iommu_log_event(s, &evt); >> + >> + /* Abort the translation */ >> + status = pci_get_word(s->dev.config + PCI_STATUS); >> + pci_set_word(s->dev.config + PCI_STATUS, status | >> PCI_STATUS_SIG_TARGET_ABORT); >> +} >> + >> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >> +{ >> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >> +} >> + >> +/* FIXME deduplication */ >> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) >> +{ >> + AMDIOMMUState *s = opaque; >> + AMDIOMMUAddressSpace **iommu_as; >> + int bus_num = pci_bus_num(bus); >> + >> + /* just in case */ >> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >> + >> + iommu_as = s->address_spaces[bus_num]; >> + >> + /* allocate memory during the first run */ >> + if(!iommu_as) { >> + iommu_as = >> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >> + s->address_spaces[bus_num] = iommu_as; >> + } >> + >> + /* set up IOMMU region */ >> + if(!iommu_as[devfn]){ >> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >> + iommu_as[devfn]->devfn = (uint8_t)devfn; >> + iommu_as[devfn]->iommu_state = s; >> + >> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >> &s->iommu_ops, "amd-iommu", UINT64_MAX); >> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >> "amd-iommu"); >> + } >> + return &iommu_as[devfn]->as; >> +} >> + >> +/* validate a page table entry */ >> +static bool amd_iommu_validate_pte(uint64_t pte) >> +{ >> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; > > I'd suggest parenthesis here. > > >> +} >> + >> +/* get a device table entry given the device function */ >> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >> *entry) >> +{ >> + /* Could lead to out of range accesses */ >> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >> + >> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >> + if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, >> 32)){ >> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >> 0x%"PRIx64 >> + "offset 0x%"PRIx32, s->devtab, offset); >> + return false; >> + } >> + >> + if(!amd_iommu_validate_pte(entry[0])){ >> + IOMMU_DPRINTF(MMU, >> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >> + return false; >> + } >> + >> + return true; >> +} >> + >> +static uint64_t get_pte_translation_mode(uint64_t pte) >> +{ >> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >> + >> + if(level == 7){ >> + /* reserved level - abort ? */ >> + IOMMU_DPRINTF(MMU, >> + "Reserved translation level (7) detected"); >> + return 0; >> + } >> + >> + return level; >> +} >> + >> +/* TODO : Mark addresses as Accessed and Dirty */ >> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, >> bool is_write, IOMMUTLBEntry *ret) >> +{ >> + AMDIOMMUState *s = as->iommu_state; >> + >> + int present; >> + dma_addr_t pte_addr; >> + uint64_t entry[4], pte, pte_perms; >> + unsigned level; >> + unsigned perms; >> + >> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >> + goto no_translation; >> + } >> + >> + pte = entry[0]; >> + >> + /* >> + * It's okay to check for either read or write permissions >> + * even for memory maps, since we don't support R/W maps. >> + */ >> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >> + >> + if(!(level = get_pte_translation_mode(pte))){ >> + goto no_translation; >> + } >> + >> + while(level > 0){ >> + /* >> + * check permissions: the bitwise >> + * implication perms -> entry_perms must be true. Pages must be >> present >> + * and permissions on all levels must be similar >> + */ >> + pte_perms = amd_iommu_get_perms(pte); >> + present = pte & 1; >> + if(!present || perms != (perms & pte_perms)){ >> + amd_iommu_page_fault(s, as->devfn, entry[1] & >> DEV_DOMID_ID_MASK, addr, present, >> + !!(perms & IOMMU_PERM_WRITE)); >> + return; >> + } >> + >> + /* go to the next lower level */ >> + pte_addr = pte & DEV_PT_ROOT_MASK; >> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); > > Does this work for six level page tables? The highest level has different > bit size there IIRC. > >> + pte = ldq_phys(&address_space_memory, pte_addr); >> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >> + } >> + >> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; >> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >> + ret->perm = IOMMU_RW; >> + return; >> + >> +no_translation: >> + ret->iova = addr; >> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >> + ret->perm = IOMMU_RW; >> + return; > > Are you sure these transactions needs to be passed through rather than > target-aborted? > >> +} >> + >> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >> addr, bool is_write) >> +{ >> + >> + IOMMU_DPRINTF(GENERAL, ""); >> + >> + AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, >> iommu); >> + AMDIOMMUState *s = as->iommu_state; >> + >> + IOMMUTLBEntry ret = { >> + .target_as = &address_space_memory, >> + .iova = addr, >> + .translated_addr = 0, >> + .addr_mask = ~(hwaddr)0, >> + .perm = IOMMU_NONE, >> + }; >> + >> + if(!s->enabled){ >> + /* IOMMU disabled - corresponds to iommu=off not failure to >> provide any parameter */ >> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >> + ret.perm = IOMMU_RW; >> + return ret; >> + } >> + >> + amd_iommu_do_translate(as, addr, is_write, &ret); >> + >> + IOMMU_DPRINTF(MMU, >> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >> as->bus_num, >> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >> ret.translated_addr); >> + >> + return ret; >> +} >> + >> +static const MemoryRegionOps mmio_mem_ops = { >> + .read = amd_iommu_mmio_read, >> + .write = amd_iommu_mmio_write, >> + .endianness = DEVICE_LITTLE_ENDIAN, >> + .valid = { >> + .min_access_size = 1, >> + .max_access_size = 8, >> + .unaligned = false, >> + }, >> + >> + .valid = { >> + .min_access_size = 8, >> + .max_access_size = 8, >> + }, >> +}; >> + >> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, >> uint32_t guest_va, uint32_t *reg) >> +{ >> + *reg = 0; > > Redundant line. > > >> + >> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >> +} >> + >> +/* FIXME: The similar code in reset and init could be combined into a >> function */ >> +static void amd_iommu_reset(DeviceState *dev) >> +{ >> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >> + >> + uint32_t capab_header = CAPAB_FEATURES; >> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >> + uint32_t capab_range = 0xff000000; >> + uint32_t capab_misc = 0x0; >> + >> + /* reset MMIO */ >> + memset(s->mmior, 0, MMIO_SIZE); >> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >> + /* TODO :Disable event logging and reset all buffers */ >> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >> &capab_misc); >> + >> + /* reset IOMMU specific capabilities */ >> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >> capab_base_addr_low); >> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >> capab_base_addr_high); >> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >> capab_range); >> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >> capab_misc); > > > Do we also need to reset MSI capability block? > > >> + >> + /* reset device ident */ >> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >> + pci_config_set_class(s->dev.config, 0x0806); >> + pci_config_set_prog_interface(s->dev.config, 00); >> +} >> + >> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t >> val, int len) >> +{ >> + pci_default_write_config(dev, addr, val, len); >> +} >> + >> +/* I honestly don't know how to reserve MMIO */ >> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >> +{ >> + if(s->mmio.addr == addr){ >> + return; >> + } >> + >> +// if(s->mmio.addr != (hwaddr)-1) { >> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >> +// } >> + >> + s->mmio.addr = addr; >> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >> + >> +} >> + >> +static int amd_iommu_pci_initfn(PCIDevice *dev) >> +{ >> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >> + uint32_t capab_header = CAPAB_FEATURES; >> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); >> + uint32_t capab_range = 0xff000000; >> + uint32_t capab_misc = 0x0; >> + >> + memset(s->mmior, 0, MMIO_SIZE); >> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >> &capab_misc); >> + >> + s->iommu_ops.translate = amd_iommu_translate; >> + s->enabled = false; >> + s->ats_enabled = false; >> + s->cmdbuf_enabled = false; >> + s->devtab_len = 0; >> + s->cmdbuf_len = 0; >> + s->cmdbuf_head = 0; >> + s->cmdbuf_tail = 0; >> + s->evtlog_head = 0; >> + s->evtlog_tail = 0; >> + s->excl_enabled = false; >> + s->excl_allow = false; >> + s->mmio_enabled = false; >> + dev->config_write = amd_iommu_write_capab; >> + >> + size_t offset; >> + /* Save offset for IVRS */ >> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, >> CAPAB_SIZE); >> + pci_set_long(s->dev.config + offset, capab_header); >> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >> capab_base_addr_low); >> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >> capab_base_addr_high); >> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >> + >> + /* add msi and hypertransport capabilities */ >> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >> + >> + /* set up MMIO */ >> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >> "amd-iommu", MMIO_SIZE); >> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >> + >> + /* reset device ident */ >> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >> + >> + /* may not be necessary */ >> + pci_config_set_interrupt_pin(dev->config, 0x1a); >> + >> + return 0; >> +} >> + >> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >> +{ >> + amd_iommu_pci_initfn(dev); >> +} >> + >> +static const VMStateDescription vmstate_amd_iommu = { >> + .name = "amd-iommu", >> + .fields = (VMStateField[]) { >> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >> + VMSTATE_END_OF_LIST() >> + } >> +}; >> + >> +static Property amd_iommu_properties[] = { >> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >> + DEFINE_PROP_END_OF_LIST(), >> +}; >> + >> +/* not used for now but will be when cache is added */ >> +static void amd_iommu_uninit(PCIDevice *dev) >> +{ >> + return; >> +} >> + >> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >> +{ >> + DeviceClass *dc = DEVICE_CLASS(klass); >> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >> + >> + pci->realize = amd_iommu_realize; >> + pci->exit = amd_iommu_uninit; >> + >> + dc->reset = amd_iommu_reset; >> + dc->vmsd = &vmstate_amd_iommu; >> + dc->props = amd_iommu_properties; >> +} >> + >> +static const TypeInfo amd_iommu = { >> + .name = TYPE_AMD_IOMMU_DEVICE, >> + .parent = TYPE_PCI_DEVICE, >> + .instance_size = sizeof(AMDIOMMUState), >> + .class_init = amd_iommu_class_init >> +}; >> + >> +static void amd_iommu_register_types(void) >> +{ >> + type_register_static(&amd_iommu); >> +} >> + >> +type_init(amd_iommu_register_types); >> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >> new file mode 100644 >> index 0000000..90309eb >> --- /dev/null >> +++ b/hw/i386/amd_iommu.h >> @@ -0,0 +1,298 @@ >> +/* >> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >> + * >> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + >> + * You should have received a copy of the GNU General Public License >> along >> + * with this program; if not, see <http://www.gnu.org/licenses/>. >> + */ >> + >> +#ifndef AMD_IOMMU_H_ >> +#define AMD_IOMMU_H_ >> + >> +#include "hw/hw.h" >> +#include "hw/pci/pci.h" >> +#include "hw/sysbus.h" >> +#include "sysemu/dma.h" >> +#include "qemu/osdep.h" >> +#include "qemu/event_notifier.h" >> + >> +/* Capability registers */ >> +#define CAPAB_HEADER 0x00 >> +#define CAPAB_REV_TYPE 0x02 >> +#define CAPAB_FLAGS 0x03 >> +#define CAPAB_BAR_LOW 0x04 >> +#define CAPAB_BAR_HIGH 0x08 >> +#define CAPAB_RANGE 0x0C >> +#define CAPAB_MISC 0x10 >> +#define CAPAB_MISC1 0x14 >> + >> +#define CAPAB_SIZE 0x18 >> +#define CAPAB_REG_SIZE 0x04 >> + >> +/* Capability header data */ >> +#define CAPAB_FLAT_EXT (1 << 28) >> +#define CAPAB_EFR_SUP (1 << 27) >> +#define CAPAB_FLAG_NPCACHE (1 << 26) >> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >> +#define CAPAB_INIT_REV (1 << 19) >> +#define CAPAB_INIT_TYPE (3 << 16) >> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >> CAPAB_FLAG_HTTUNNEL) >> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >> + >> +/* MMIO registers */ >> +#define MMIO_DEVICE_TABLE 0x0000 >> +#define MMIO_COMMAND_BASE 0x0008 >> +#define MMIO_EVENT_BASE 0x0010 >> +#define MMIO_CONTROL 0x0018 >> +#define MMIO_EXCL_BASE 0x0020 >> +#define MMIO_EXCL_LIMIT 0x0028 >> +#define MMIO_EXT_FEATURES 0x0030 >> +#define MMIO_COMMAND_HEAD 0x2000 >> +#define MMIO_COMMAND_TAIL 0x2008 >> +#define MMIO_EVENT_HEAD 0x2010 >> +#define MMIO_EVENT_TAIL 0x2018 >> +#define MMIO_STATUS 0x2020 >> +#define MMIO_PPR_BASE 0x0038 >> +#define MMIO_PPR_HEAD 0x2030 >> +#define MMIO_PPR_TAIL 0x2038 >> + >> +#define MMIO_SIZE 0x4000 >> + >> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >> ~MMIO_DEVTAB_SIZE_MASK) >> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >> + >> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >> + >> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >> + >> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >> + >> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >> + >> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >> + >> +#define CMDBUF_ID_BYTE 0x07 >> +#define CMDBUF_ID_RSHIFT 4 >> +#define CMDBUF_ENTRY_SIZE 0x10 >> + >> +#define CMD_COMPLETION_WAIT 0x01 >> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >> +#define CMD_INVAL_IOMMU_PAGES 0x03 >> +#define CMD_INVAL_IOTLB_PAGES 0x04 >> +#define CMD_INVAL_INTR_TABLE 0x05 >> + >> +#define DEVTAB_ENTRY_SIZE 32 >> + >> +/* Device table entry bits 0:63 */ >> +#define DEV_VALID (1ULL << 0) >> +#define DEV_TRANSLATION_VALID (1ULL << 1) >> +#define DEV_MODE_MASK 0x7 >> +#define DEV_MODE_RSHIFT 9 >> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >> +#define DEV_PT_ROOT_RSHIFT 12 >> +#define DEV_PERM_SHIFT 61 >> +#define DEV_PERM_READ (1ULL << 61) >> +#define DEV_PERM_WRITE (1ULL << 62) >> + >> +/* Device table entry bits 64:127 */ >> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >> +#define DEV_SUPPRESS_PF (1ULL << 18) >> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >> +#define DEV_IOCTL_MASK (~3) >> +#define DEV_IOCTL_RSHIFT 20 >> +#define DEV_IOCTL_DENY 0 >> +#define DEV_IOCTL_PASSTHROUGH 1 >> +#define DEV_IOCTL_TRANSLATE 2 >> +#define DEV_CACHE (1ULL << 37) >> +#define DEV_SNOOP_DISABLE (1ULL << 38) >> +#define DEV_EXCL (1ULL << 39) >> + >> +/* Event codes and flags, as stored in the info field */ >> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >> +#define EVENT_IOPF (0x2U << 24) >> +#define EVENT_IOPF_I (1U << 3) >> +#define EVENT_IOPF_PR (1U << 4) >> +#define EVENT_IOPF_RW (1U << 5) >> +#define EVENT_IOPF_PE (1U << 6) >> +#define EVENT_IOPF_RZ (1U << 7) >> +#define EVENT_IOPF_TR (1U << 8) >> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >> + >> +#define EVENT_LEN 16 >> + >> +#define IOMMU_PERM_READ (1 << 0) >> +#define IOMMU_PERM_WRITE (1 << 1) >> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) >> + >> +/* AMD RD890 Chipset */ >> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >> + >> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >> register */ >> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >> register */ >> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >> register */ >> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >> */ >> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >> register 0 */ >> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >> register 1 */ >> + >> +#define FEATURE_PREFETCH (1ULL<<0) >> +#define FEATURE_PPR (1ULL<<1) >> +#define FEATURE_NX (1ULL<<3) >> +#define FEATURE_GT (1ULL<<4) >> +#define FEATURE_IA (1ULL<<6) >> +#define FEATURE_GA (1ULL<<7) >> +#define FEATURE_HE (1ULL<<8) >> +#define FEATURE_PC (1ULL<<9) >> + >> +/* IOMMU paging mode */ >> +#define GATS_MODE (6ULL << 12) >> +#define HATS_MODE (6ULL << 10) >> +/* PCI SIG constants */ >> +#define PCI_BUS_MAX 256 >> +#define PCI_SLOT_MAX 32 >> +#define PCI_FUNC_MAX 8 >> +#define PCI_DEVFN_MAX 256 >> + >> +/* extended feature support */ >> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) >> + >> +/* capabilities header */ >> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL >> | CAPAB_EFR_SUP) >> + >> +/* command constants */ >> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >> +#define COM_COMPLETION_STORE_MASK 0x1 >> +#define COM_COMPLETION_INTR 0x2 >> +#define COM_COMPLETION_DATA_OFF 0x8 >> +#define IOMMU_COMMAND_SIZE 0x10 >> + >> +/* IOMMU default address */ >> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >> + >> +/* page management constants */ >> +#define IOMMU_PAGE_SHIFT 12 >> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >> + >> +#define IOMMU_PAGE_SHIFT_4K 12 >> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >> +#define IOMMU_PAGE_SHIFT_2M 21 >> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >> +#define IOMMU_PAGE_SHIFT_1G 30 >> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >> + >> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >> +#define AMD_IOMMU_DEVICE(obj)\ >> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >> + >> +typedef struct AMDIOMMUState AMDIOMMUState; >> + >> +typedef struct AMDIOMMUAddressSpace{ >> + uint8_t bus_num; /* bus number >> */ >> + uint8_t devfn; /* device function >> */ >> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >> */ >> + MemoryRegion iommu; /* Device's iommu region >> */ >> + AddressSpace as; /* device's corresponding address space >> */ >> +}AMDIOMMUAddressSpace; >> + >> +struct AMDIOMMUState { >> + PCIDevice dev; /* The PCI device itself */ >> + >> + uint32_t version; >> + >> + int capab_offset; /* capability offset pointer */ >> + unsigned char *capab; /* capabilities registers */ >> + >> + bool enabled; /* IOMMU enabled */ >> + bool ats_enabled; /* address translation enabled */ >> + bool cmdbuf_enabled; /* command buffer enabled */ >> + bool evtlog_enabled; /* event log enabled */ >> + bool excl_enabled; >> + >> + dma_addr_t devtab; /* base address device table */ >> + size_t devtab_len; /* device table length */ >> + >> + dma_addr_t cmdbuf; /* command buffer base address */ >> + uint64_t cmdbuf_len; /* command buffer length */ >> + unsigned cmdbuf_head; /* current IOMMU read position */ >> + unsigned cmdbuf_tail; /* next Software write position */ >> + int completion_wait_intr; >> + >> + dma_addr_t evtlog; /* base address event log */ >> + size_t evtlog_intr; >> + size_t evtlog_len; /* event log length */ >> + size_t evtlog_head; /* event log head */ >> + size_t evtlog_tail; /* event log tail */ >> + >> + /* unused for now */ >> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >> + bool excl_allow; /* translate accesses to the exclusion >> range */ >> + bool excl_enable; /* exclusion range enabled */ >> + >> + MemoryRegion mmio; /* MMIO region */ >> + unsigned char mmior[MMIO_SIZE]; >> + bool mmio_enabled; >> + >> + /* IOMMU function */ >> + MemoryRegionIOMMUOps iommu_ops; >> + >> + /* for each served device */ >> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >> +}; >> + >> +typedef struct AMDIOMMUEvent { >> + uint16_t devfn; >> + uint16_t reserved; >> + uint16_t domid; >> + uint16_t info; >> + uint16_t addr; >> +} __attribute__((packed)) AMDIOMMUEvent; >> + >> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >> devfn); >> + >> +#endif >> > > Regards, > Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-09 7:30 ` David kiarie @ 2015-09-09 7:45 ` Valentine Sinitsyn 2015-09-09 7:59 ` David kiarie 2015-09-09 7:59 ` Michael S. Tsirkin 0 siblings, 2 replies; 22+ messages in thread From: Valentine Sinitsyn @ 2015-09-09 7:45 UTC (permalink / raw) To: David kiarie; +Cc: Jan Kiszka, QEMU Developers, mst On 09.09.2015 12:30, David kiarie wrote: ...snip... >>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>> +{ >>> + unsigned type; >>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>> + >>> + IOMMU_DPRINTF(COMMAND, ""); >>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>> + >>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, >>> cmd, IOMMU_COMMAND_SIZE)){ >>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>> 0x%"PRIx64 >>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>> + } >>> + >>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>> + >>> + switch(type){ >>> + case CMD_COMPLETION_WAIT: >>> + /* pretend to wait for command execution to complete */ >>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>> + amd_iommu_completion_wait(s, cmd); >>> + break; >>> + case CMD_INVAL_DEVTAB_ENTRY: >>> + /* Not implemented yet - should just clear device table >>> contents */ >>> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); >> >> Better make it clear that these commands are not implemented yet. An IOMMU >> is hardly usable without invalidators. > > I think the "debug prinft" here is misleading. AFAIK, the commands > listed here(there are others which I haven't listed) relate to 'cache' > which means this commands do nothing in the absence of cache. > > The reason why I advertise 'cache' is because the linux driver checks > for cache and other optional features to determine the IOMMU version > whereby versions 2 of IOMMU are assummed to support this features. Did you check how address translation is emulated in QEMU. I didn't :) But you return IOMMTLBEntry from your translation routine, and I'd rather ensure it is not cached in some other layer. Besides, omitting invalidation commands will be a problem on real hardware. As IOMMU emulation is mainly useful for debugging, I'd reproduce this behaviour in the emulator. I mean, if I forget to do CMD_INVAL_DEVTAB_ENTRY in my guest code, things shouldn't work properly. You can just copy all data structures to AMDIOMMUState and use this "cahced" copies, updated when you run invalidation commands. But this isn't a #1 priority, you are right. Can you share some tests results for this code? > >> >>> + break; >>> + case CMD_INVAL_IOMMU_PAGES: >>> + /* invalidate IOMMU cache for a particular domain */ >>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>> + break; >>> + case CMD_INVAL_IOTLB_PAGES: >>> + /* Only present if remote IOTLB present */ >>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>> + break; >>> + case CMD_INVAL_INTR_TABLE: >>> + /* no support for interrupt remapping yet */ >>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>> + break; >>> + default: >>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>> + break; >>> + } >>> + >>> +} >>> + >>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>> +{ >>> + IOMMU_DPRINTF(COMMAND, ""); >>> + >>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; >>> + >>> + if(!s->cmdbuf_enabled){ >>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>> + return; >>> + } >>> + >>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>> + /* check if there is work to do. */ >>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER >>> tail at %x", >>> + s->cmdbuf_head, s->cmdbuf_tail); >>> + amd_iommu_cmdbuf_exec(s); >>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>> + >>> + /* wrap head pointer */ >>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>> + s->cmdbuf_head = 0; >>> + } >>> + } >>> + >>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>> +} >>> + >>> +/* System Software might never read from some of this fields but anyways >>> */ >>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >>> size) >>> +{ >>> + AMDIOMMUState *s = opaque; >>> + >>> + uint64_t val = -1; >>> + if(addr + size > MMIO_SIZE) { >>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >>> + ", got 0x%"PRIx64 " %d", >>> + (uint64_t)MMIO_SIZE, addr, size); >>> + return (uint64_t) - 1; >>> + } >>> + >>> + switch(addr & ~0x07){ >>> + case MMIO_DEVICE_TABLE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >> >> What makes these cases different, except debug printf()s? Maybe leave >> printf()s inside the switch, and factor out the rest. This applies to other >> similar cases as well. >> >> >>> + >>> + case MMIO_COMMAND_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EVENT_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_CONTROL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EXCL_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EXCL_LIMIT: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EVENT_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EVENT_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_STATUS: >>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + case MMIO_EXT_FEATURES: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + if(size == 2){ >>> + val = amd_iommu_readw(s, addr); >>> + } else if(size == 4){ >>> + val = amd_iommu_readl(s, addr); >>> + } >>> + else if(size == 8){ >>> + val = amd_iommu_readq(s, addr); >>> + } >>> + break; >>> + >>> + default: >>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>> + ", size %d offset 0x%"PRIx64, addr, size, >>> offset); >>> + } >>> + >>> + return val; >>> +} >>> + >>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>> +{ >>> + /* read whatever is already written incase software is writing in >>> chucks less than 8 bytes */ >>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>> + >>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>> + s->evtlog_enabled = s->enabled && !!(control & >>> MMIO_CONTROL_EVENTLOGEN); >>> + >>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >>> + s->cmdbuf_enabled = s->enabled && !!(control & >>> MMIO_CONTROL_CMDBUFLEN); >>> + >>> + /* update the flags depending on the control register */ >>> + if(s->cmdbuf_enabled) { >>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >>> + } else { >>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; >>> + } >>> + if (s->evtlog_enabled) { >>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >>> + } else { >>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; >>> + } >>> + >>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>> + >>> + amd_iommu_cmdbuf_run(s); >> >> Does any write to control register result in draining command buffer? To me, >> it looks strange, and I'd expect IOMMU to execute commands only if I change >> tail pointer. >> >> >>> +} >>> + >>> +/* FIXME: something might go wrong if System Software writes in chunks >>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>> + * works correctly with linux but will definitely be busted if software >>> + * reads/writes 8 bytes >>> + */ >>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, >>> unsigned size) >>> +{ >>> + >>> + AMDIOMMUState *s = opaque; >>> + unsigned long offset = addr & 0x07; >>> + >>> + if(addr + size > MMIO_SIZE) { >>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >>> + ", got 0x%"PRIx64 " %d", >>> + (uint64_t)MMIO_SIZE, addr, size); >>> + return; >>> + } >>> + >>> + switch(addr & ~0x07){ >>> + case MMIO_CONTROL: >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + >>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 >>> , addr, size, val, offset); >>> + iommu_handle_control_write(s); >>> + break; >>> + >>> + case MMIO_DEVICE_TABLE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + >>> + /* set device table address >>> + * This also suffers from inability to tell whether software >>> is done writing >>> + */ >>> + if(offset || (size == 8)){ >>> + unsigned long device_base = amd_iommu_readq(s, >>> MMIO_DEVICE_TABLE); >>> + s->devtab = (dma_addr_t)(device_base & >>> MMIO_CMDBUF_BASE_MASK); >>> + /* set device table length */ >>> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + >>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>> + MMIO_DEVTAB_ENTRY_SIZE); >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>> + amd_iommu_cmdbuf_run(s); >>> + break; >>> + >>> + case MMIO_COMMAND_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + >>> + /* FIXME - make sure System Software has finished writing >>> incase it writes >>> + * in chucks less than 8 bytes in a robust way.As for now, >>> this hacks works >>> + * for the linux driver >>> + */ >>> + if(offset || (size == 8)){ >>> + unsigned long command_base = amd_iommu_readq(s, >>> MMIO_COMMAND_BASE); >>> + s->cmdbuf = (dma_addr_t)(command_base & >>> MMIO_CMDBUF_BASE_MASK); >>> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & >>> MMIO_CMDBUF_SIZE_MASK); >>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>> + } >>> + break; >>> + >>> + case MMIO_COMMAND_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + >>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>> + amd_iommu_cmdbuf_run(s); >>> + break; >>> + >>> + case MMIO_EVENT_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>> + s->evtlog_len = 1UL << >>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >>> + break; >>> + >>> + case MMIO_EXCL_LIMIT: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>> MMIO_EXCL_LIMIT_LOW; >>> + break; >>> + //TODO : Event handling fixes >>> + >>> + case MMIO_EVENT_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + >>> + case MMIO_EVENT_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + /* PPR log base - unused for now */ >>> + case MMIO_PPR_BASE: >>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + /* PPR log head - also unused for now */ >>> + case MMIO_PPR_HEAD: >>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + /* PPR log tail - unused for now */ >>> + case MMIO_PPR_TAIL: >>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + if(size == 2){ >>> + amd_iommu_writew(s, addr, val); >>> + } else if(size == 4){ >>> + amd_iommu_writel(s, addr, val); >>> + } else if(size == 8){ >>> + amd_iommu_writeq(s, addr, val); >>> + } >>> + break; >>> + >>> + default: >>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>> + ", size %d, val 0x%"PRIx64 ", offset >>> 0x%"PRIx64, addr, size, val, offset); >>> + ; >>> + } >>> + >>> +} >>> + >>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>> +{ >>> + /* event logging not enabled */ >>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>> MMIO_STATUS_EVTLOG_OF){ >>> + return; >>> + } >>> + >>> + /* event log buffer full */ >>> + if(s->evtlog_tail >= s->evtlog_len) { >>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>> + } >>> + >>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>> s->evtlog_tail, &evt, EVENT_LEN)){ >>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, >>> s->evtlog + s->evtlog_tail); >>> + } >>> + >>> + s->evtlog_tail += EVENT_LEN; >>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>> + /* Disable logging if Overflow ? */ >> >> No, the spec details event logging restart procedure. Make sure emulated >> IOMMU behaves as described there. >> >> >>> +} >>> + >>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >>> domid, dma_addr_t addr, int present, >>> + int is_write) >>> +{ >>> + IOMMU_DPRINTF(ELOG, ""); >>> + >>> + AMDIOMMUEvent evt; >>> + unsigned info; >>> + uint16_t status; >>> + >>> + evt.devfn = cpu_to_le16(devfn); >>> + evt.reserved = 0; >>> + evt.domid = cpu_to_le16(domid); >>> + evt.addr = cpu_to_le16(addr); >>> + >>> + info = EVENT_IOPF; >>> + >>> + if(present) { >>> + info |= EVENT_IOPF_PR; >>> + } >>> + >>> + if (is_write) { >>> + info |= EVENT_IOPF_RW; >>> + } >>> + >>> + /* log a page fault */ >>> + amd_iommu_log_event(s, &evt); >>> + >>> + /* Abort the translation */ >>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>> PCI_STATUS_SIG_TARGET_ABORT); >>> +} >>> + >>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>> +{ >>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >>> +} >>> + >>> +/* FIXME deduplication */ >>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) >>> +{ >>> + AMDIOMMUState *s = opaque; >>> + AMDIOMMUAddressSpace **iommu_as; >>> + int bus_num = pci_bus_num(bus); >>> + >>> + /* just in case */ >>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>> + >>> + iommu_as = s->address_spaces[bus_num]; >>> + >>> + /* allocate memory during the first run */ >>> + if(!iommu_as) { >>> + iommu_as = >>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>> + s->address_spaces[bus_num] = iommu_as; >>> + } >>> + >>> + /* set up IOMMU region */ >>> + if(!iommu_as[devfn]){ >>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>> + iommu_as[devfn]->iommu_state = s; >>> + >>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>> "amd-iommu"); >>> + } >>> + return &iommu_as[devfn]->as; >>> +} >>> + >>> +/* validate a page table entry */ >>> +static bool amd_iommu_validate_pte(uint64_t pte) >>> +{ >>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >> >> I'd suggest parenthesis here. >> >> >>> +} >>> + >>> +/* get a device table entry given the device function */ >>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>> *entry) >>> +{ >>> + /* Could lead to out of range accesses */ >>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>> + >>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, >>> 32)){ >>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>> 0x%"PRIx64 >>> + "offset 0x%"PRIx32, s->devtab, offset); >>> + return false; >>> + } >>> + >>> + if(!amd_iommu_validate_pte(entry[0])){ >>> + IOMMU_DPRINTF(MMU, >>> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >>> + return false; >>> + } >>> + >>> + return true; >>> +} >>> + >>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>> +{ >>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>> + >>> + if(level == 7){ >>> + /* reserved level - abort ? */ >>> + IOMMU_DPRINTF(MMU, >>> + "Reserved translation level (7) detected"); >>> + return 0; >>> + } >>> + >>> + return level; >>> +} >>> + >>> +/* TODO : Mark addresses as Accessed and Dirty */ >>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, >>> bool is_write, IOMMUTLBEntry *ret) >>> +{ >>> + AMDIOMMUState *s = as->iommu_state; >>> + >>> + int present; >>> + dma_addr_t pte_addr; >>> + uint64_t entry[4], pte, pte_perms; >>> + unsigned level; >>> + unsigned perms; >>> + >>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>> + goto no_translation; >>> + } >>> + >>> + pte = entry[0]; >>> + >>> + /* >>> + * It's okay to check for either read or write permissions >>> + * even for memory maps, since we don't support R/W maps. >>> + */ >>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>> + >>> + if(!(level = get_pte_translation_mode(pte))){ >>> + goto no_translation; >>> + } >>> + >>> + while(level > 0){ >>> + /* >>> + * check permissions: the bitwise >>> + * implication perms -> entry_perms must be true. Pages must be >>> present >>> + * and permissions on all levels must be similar >>> + */ >>> + pte_perms = amd_iommu_get_perms(pte); >>> + present = pte & 1; >>> + if(!present || perms != (perms & pte_perms)){ >>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>> DEV_DOMID_ID_MASK, addr, present, >>> + !!(perms & IOMMU_PERM_WRITE)); >>> + return; >>> + } >>> + >>> + /* go to the next lower level */ >>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >> >> Does this work for six level page tables? The highest level has different >> bit size there IIRC. >> >>> + pte = ldq_phys(&address_space_memory, pte_addr); >>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>> + } >>> + >>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; >>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>> + ret->perm = IOMMU_RW; >>> + return; >>> + >>> +no_translation: >>> + ret->iova = addr; >>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>> + ret->perm = IOMMU_RW; >>> + return; >> >> Are you sure these transactions needs to be passed through rather than >> target-aborted? >> >>> +} >>> + >>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>> addr, bool is_write) >>> +{ >>> + >>> + IOMMU_DPRINTF(GENERAL, ""); >>> + >>> + AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, >>> iommu); >>> + AMDIOMMUState *s = as->iommu_state; >>> + >>> + IOMMUTLBEntry ret = { >>> + .target_as = &address_space_memory, >>> + .iova = addr, >>> + .translated_addr = 0, >>> + .addr_mask = ~(hwaddr)0, >>> + .perm = IOMMU_NONE, >>> + }; >>> + >>> + if(!s->enabled){ >>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>> provide any parameter */ >>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>> + ret.perm = IOMMU_RW; >>> + return ret; >>> + } >>> + >>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>> + >>> + IOMMU_DPRINTF(MMU, >>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >>> as->bus_num, >>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>> ret.translated_addr); >>> + >>> + return ret; >>> +} >>> + >>> +static const MemoryRegionOps mmio_mem_ops = { >>> + .read = amd_iommu_mmio_read, >>> + .write = amd_iommu_mmio_write, >>> + .endianness = DEVICE_LITTLE_ENDIAN, >>> + .valid = { >>> + .min_access_size = 1, >>> + .max_access_size = 8, >>> + .unaligned = false, >>> + }, >>> + >>> + .valid = { >>> + .min_access_size = 8, >>> + .max_access_size = 8, >>> + }, >>> +}; >>> + >>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, >>> uint32_t guest_va, uint32_t *reg) >>> +{ >>> + *reg = 0; >> >> Redundant line. >> >> >>> + >>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>> +} >>> + >>> +/* FIXME: The similar code in reset and init could be combined into a >>> function */ >>> +static void amd_iommu_reset(DeviceState *dev) >>> +{ >>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>> + >>> + uint32_t capab_header = CAPAB_FEATURES; >>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>> + uint32_t capab_range = 0xff000000; >>> + uint32_t capab_misc = 0x0; >>> + >>> + /* reset MMIO */ >>> + memset(s->mmior, 0, MMIO_SIZE); >>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>> + /* TODO :Disable event logging and reset all buffers */ >>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>> &capab_misc); >>> + >>> + /* reset IOMMU specific capabilities */ >>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>> capab_base_addr_low); >>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>> capab_base_addr_high); >>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>> capab_range); >>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>> capab_misc); >> >> >> Do we also need to reset MSI capability block? >> >> >>> + >>> + /* reset device ident */ >>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >>> + pci_config_set_class(s->dev.config, 0x0806); >>> + pci_config_set_prog_interface(s->dev.config, 00); >>> +} >>> + >>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t >>> val, int len) >>> +{ >>> + pci_default_write_config(dev, addr, val, len); >>> +} >>> + >>> +/* I honestly don't know how to reserve MMIO */ >>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>> +{ >>> + if(s->mmio.addr == addr){ >>> + return; >>> + } >>> + >>> +// if(s->mmio.addr != (hwaddr)-1) { >>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>> +// } >>> + >>> + s->mmio.addr = addr; >>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>> + >>> +} >>> + >>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>> +{ >>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>> + uint32_t capab_header = CAPAB_FEATURES; >>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); >>> + uint32_t capab_range = 0xff000000; >>> + uint32_t capab_misc = 0x0; >>> + >>> + memset(s->mmior, 0, MMIO_SIZE); >>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>> &capab_misc); >>> + >>> + s->iommu_ops.translate = amd_iommu_translate; >>> + s->enabled = false; >>> + s->ats_enabled = false; >>> + s->cmdbuf_enabled = false; >>> + s->devtab_len = 0; >>> + s->cmdbuf_len = 0; >>> + s->cmdbuf_head = 0; >>> + s->cmdbuf_tail = 0; >>> + s->evtlog_head = 0; >>> + s->evtlog_tail = 0; >>> + s->excl_enabled = false; >>> + s->excl_allow = false; >>> + s->mmio_enabled = false; >>> + dev->config_write = amd_iommu_write_capab; >>> + >>> + size_t offset; >>> + /* Save offset for IVRS */ >>> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, >>> CAPAB_SIZE); >>> + pci_set_long(s->dev.config + offset, capab_header); >>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>> capab_base_addr_low); >>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>> capab_base_addr_high); >>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>> + >>> + /* add msi and hypertransport capabilities */ >>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>> + >>> + /* set up MMIO */ >>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>> "amd-iommu", MMIO_SIZE); >>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>> + >>> + /* reset device ident */ >>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>> + >>> + /* may not be necessary */ >>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>> + >>> + return 0; >>> +} >>> + >>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>> +{ >>> + amd_iommu_pci_initfn(dev); >>> +} >>> + >>> +static const VMStateDescription vmstate_amd_iommu = { >>> + .name = "amd-iommu", >>> + .fields = (VMStateField[]) { >>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>> + VMSTATE_END_OF_LIST() >>> + } >>> +}; >>> + >>> +static Property amd_iommu_properties[] = { >>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>> + DEFINE_PROP_END_OF_LIST(), >>> +}; >>> + >>> +/* not used for now but will be when cache is added */ >>> +static void amd_iommu_uninit(PCIDevice *dev) >>> +{ >>> + return; >>> +} >>> + >>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>> +{ >>> + DeviceClass *dc = DEVICE_CLASS(klass); >>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>> + >>> + pci->realize = amd_iommu_realize; >>> + pci->exit = amd_iommu_uninit; >>> + >>> + dc->reset = amd_iommu_reset; >>> + dc->vmsd = &vmstate_amd_iommu; >>> + dc->props = amd_iommu_properties; >>> +} >>> + >>> +static const TypeInfo amd_iommu = { >>> + .name = TYPE_AMD_IOMMU_DEVICE, >>> + .parent = TYPE_PCI_DEVICE, >>> + .instance_size = sizeof(AMDIOMMUState), >>> + .class_init = amd_iommu_class_init >>> +}; >>> + >>> +static void amd_iommu_register_types(void) >>> +{ >>> + type_register_static(&amd_iommu); >>> +} >>> + >>> +type_init(amd_iommu_register_types); >>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>> new file mode 100644 >>> index 0000000..90309eb >>> --- /dev/null >>> +++ b/hw/i386/amd_iommu.h >>> @@ -0,0 +1,298 @@ >>> +/* >>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>> + * >>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + >>> + * You should have received a copy of the GNU General Public License >>> along >>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>> + */ >>> + >>> +#ifndef AMD_IOMMU_H_ >>> +#define AMD_IOMMU_H_ >>> + >>> +#include "hw/hw.h" >>> +#include "hw/pci/pci.h" >>> +#include "hw/sysbus.h" >>> +#include "sysemu/dma.h" >>> +#include "qemu/osdep.h" >>> +#include "qemu/event_notifier.h" >>> + >>> +/* Capability registers */ >>> +#define CAPAB_HEADER 0x00 >>> +#define CAPAB_REV_TYPE 0x02 >>> +#define CAPAB_FLAGS 0x03 >>> +#define CAPAB_BAR_LOW 0x04 >>> +#define CAPAB_BAR_HIGH 0x08 >>> +#define CAPAB_RANGE 0x0C >>> +#define CAPAB_MISC 0x10 >>> +#define CAPAB_MISC1 0x14 >>> + >>> +#define CAPAB_SIZE 0x18 >>> +#define CAPAB_REG_SIZE 0x04 >>> + >>> +/* Capability header data */ >>> +#define CAPAB_FLAT_EXT (1 << 28) >>> +#define CAPAB_EFR_SUP (1 << 27) >>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>> +#define CAPAB_INIT_REV (1 << 19) >>> +#define CAPAB_INIT_TYPE (3 << 16) >>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>> CAPAB_FLAG_HTTUNNEL) >>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>> + >>> +/* MMIO registers */ >>> +#define MMIO_DEVICE_TABLE 0x0000 >>> +#define MMIO_COMMAND_BASE 0x0008 >>> +#define MMIO_EVENT_BASE 0x0010 >>> +#define MMIO_CONTROL 0x0018 >>> +#define MMIO_EXCL_BASE 0x0020 >>> +#define MMIO_EXCL_LIMIT 0x0028 >>> +#define MMIO_EXT_FEATURES 0x0030 >>> +#define MMIO_COMMAND_HEAD 0x2000 >>> +#define MMIO_COMMAND_TAIL 0x2008 >>> +#define MMIO_EVENT_HEAD 0x2010 >>> +#define MMIO_EVENT_TAIL 0x2018 >>> +#define MMIO_STATUS 0x2020 >>> +#define MMIO_PPR_BASE 0x0038 >>> +#define MMIO_PPR_HEAD 0x2030 >>> +#define MMIO_PPR_TAIL 0x2038 >>> + >>> +#define MMIO_SIZE 0x4000 >>> + >>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>> ~MMIO_DEVTAB_SIZE_MASK) >>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>> + >>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>> + >>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>> + >>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>> + >>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>> + >>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>> + >>> +#define CMDBUF_ID_BYTE 0x07 >>> +#define CMDBUF_ID_RSHIFT 4 >>> +#define CMDBUF_ENTRY_SIZE 0x10 >>> + >>> +#define CMD_COMPLETION_WAIT 0x01 >>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>> +#define CMD_INVAL_INTR_TABLE 0x05 >>> + >>> +#define DEVTAB_ENTRY_SIZE 32 >>> + >>> +/* Device table entry bits 0:63 */ >>> +#define DEV_VALID (1ULL << 0) >>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>> +#define DEV_MODE_MASK 0x7 >>> +#define DEV_MODE_RSHIFT 9 >>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>> +#define DEV_PT_ROOT_RSHIFT 12 >>> +#define DEV_PERM_SHIFT 61 >>> +#define DEV_PERM_READ (1ULL << 61) >>> +#define DEV_PERM_WRITE (1ULL << 62) >>> + >>> +/* Device table entry bits 64:127 */ >>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>> +#define DEV_IOCTL_MASK (~3) >>> +#define DEV_IOCTL_RSHIFT 20 >>> +#define DEV_IOCTL_DENY 0 >>> +#define DEV_IOCTL_PASSTHROUGH 1 >>> +#define DEV_IOCTL_TRANSLATE 2 >>> +#define DEV_CACHE (1ULL << 37) >>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>> +#define DEV_EXCL (1ULL << 39) >>> + >>> +/* Event codes and flags, as stored in the info field */ >>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>> +#define EVENT_IOPF (0x2U << 24) >>> +#define EVENT_IOPF_I (1U << 3) >>> +#define EVENT_IOPF_PR (1U << 4) >>> +#define EVENT_IOPF_RW (1U << 5) >>> +#define EVENT_IOPF_PE (1U << 6) >>> +#define EVENT_IOPF_RZ (1U << 7) >>> +#define EVENT_IOPF_TR (1U << 8) >>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>> + >>> +#define EVENT_LEN 16 >>> + >>> +#define IOMMU_PERM_READ (1 << 0) >>> +#define IOMMU_PERM_WRITE (1 << 1) >>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) >>> + >>> +/* AMD RD890 Chipset */ >>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>> + >>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>> register */ >>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>> register */ >>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>> register */ >>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>> */ >>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >>> register 0 */ >>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >>> register 1 */ >>> + >>> +#define FEATURE_PREFETCH (1ULL<<0) >>> +#define FEATURE_PPR (1ULL<<1) >>> +#define FEATURE_NX (1ULL<<3) >>> +#define FEATURE_GT (1ULL<<4) >>> +#define FEATURE_IA (1ULL<<6) >>> +#define FEATURE_GA (1ULL<<7) >>> +#define FEATURE_HE (1ULL<<8) >>> +#define FEATURE_PC (1ULL<<9) >>> + >>> +/* IOMMU paging mode */ >>> +#define GATS_MODE (6ULL << 12) >>> +#define HATS_MODE (6ULL << 10) >>> +/* PCI SIG constants */ >>> +#define PCI_BUS_MAX 256 >>> +#define PCI_SLOT_MAX 32 >>> +#define PCI_FUNC_MAX 8 >>> +#define PCI_DEVFN_MAX 256 >>> + >>> +/* extended feature support */ >>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) >>> + >>> +/* capabilities header */ >>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL >>> | CAPAB_EFR_SUP) >>> + >>> +/* command constants */ >>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>> +#define COM_COMPLETION_STORE_MASK 0x1 >>> +#define COM_COMPLETION_INTR 0x2 >>> +#define COM_COMPLETION_DATA_OFF 0x8 >>> +#define IOMMU_COMMAND_SIZE 0x10 >>> + >>> +/* IOMMU default address */ >>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>> + >>> +/* page management constants */ >>> +#define IOMMU_PAGE_SHIFT 12 >>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>> + >>> +#define IOMMU_PAGE_SHIFT_4K 12 >>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>> +#define IOMMU_PAGE_SHIFT_2M 21 >>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>> +#define IOMMU_PAGE_SHIFT_1G 30 >>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>> + >>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>> +#define AMD_IOMMU_DEVICE(obj)\ >>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>> + >>> +typedef struct AMDIOMMUState AMDIOMMUState; >>> + >>> +typedef struct AMDIOMMUAddressSpace{ >>> + uint8_t bus_num; /* bus number >>> */ >>> + uint8_t devfn; /* device function >>> */ >>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>> */ >>> + MemoryRegion iommu; /* Device's iommu region >>> */ >>> + AddressSpace as; /* device's corresponding address space >>> */ >>> +}AMDIOMMUAddressSpace; >>> + >>> +struct AMDIOMMUState { >>> + PCIDevice dev; /* The PCI device itself */ >>> + >>> + uint32_t version; >>> + >>> + int capab_offset; /* capability offset pointer */ >>> + unsigned char *capab; /* capabilities registers */ >>> + >>> + bool enabled; /* IOMMU enabled */ >>> + bool ats_enabled; /* address translation enabled */ >>> + bool cmdbuf_enabled; /* command buffer enabled */ >>> + bool evtlog_enabled; /* event log enabled */ >>> + bool excl_enabled; >>> + >>> + dma_addr_t devtab; /* base address device table */ >>> + size_t devtab_len; /* device table length */ >>> + >>> + dma_addr_t cmdbuf; /* command buffer base address */ >>> + uint64_t cmdbuf_len; /* command buffer length */ >>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>> + unsigned cmdbuf_tail; /* next Software write position */ >>> + int completion_wait_intr; >>> + >>> + dma_addr_t evtlog; /* base address event log */ >>> + size_t evtlog_intr; >>> + size_t evtlog_len; /* event log length */ >>> + size_t evtlog_head; /* event log head */ >>> + size_t evtlog_tail; /* event log tail */ >>> + >>> + /* unused for now */ >>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >>> + bool excl_allow; /* translate accesses to the exclusion >>> range */ >>> + bool excl_enable; /* exclusion range enabled */ >>> + >>> + MemoryRegion mmio; /* MMIO region */ >>> + unsigned char mmior[MMIO_SIZE]; >>> + bool mmio_enabled; >>> + >>> + /* IOMMU function */ >>> + MemoryRegionIOMMUOps iommu_ops; >>> + >>> + /* for each served device */ >>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>> +}; >>> + >>> +typedef struct AMDIOMMUEvent { >>> + uint16_t devfn; >>> + uint16_t reserved; >>> + uint16_t domid; >>> + uint16_t info; >>> + uint16_t addr; >>> +} __attribute__((packed)) AMDIOMMUEvent; >>> + >>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>> devfn); >>> + >>> +#endif >>> >> >> Regards, >> Valentine -- С уважением, Синицын Валентин ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-09 7:45 ` Valentine Sinitsyn @ 2015-09-09 7:59 ` David kiarie 2015-09-09 8:07 ` Valentine Sinitsyn 2015-09-09 7:59 ` Michael S. Tsirkin 1 sibling, 1 reply; 22+ messages in thread From: David kiarie @ 2015-09-09 7:59 UTC (permalink / raw) To: Valentine Sinitsyn; +Cc: Jan Kiszka, QEMU Developers, mst On Wed, Sep 9, 2015 at 10:45 AM, Valentine Sinitsyn <valentine.sinitsyn@gmail.com> wrote: > On 09.09.2015 12:30, David kiarie wrote: > ...snip... > > >>>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>>> +{ >>>> + unsigned type; >>>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>>> + >>>> + IOMMU_DPRINTF(COMMAND, ""); >>>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>>> + >>>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + >>>> s->cmdbuf_head, >>>> cmd, IOMMU_COMMAND_SIZE)){ >>>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>>> 0x%"PRIx64 >>>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>>> + } >>>> + >>>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>>> + >>>> + switch(type){ >>>> + case CMD_COMPLETION_WAIT: >>>> + /* pretend to wait for command execution to complete */ >>>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>>> + amd_iommu_completion_wait(s, cmd); >>>> + break; >>>> + case CMD_INVAL_DEVTAB_ENTRY: >>>> + /* Not implemented yet - should just clear device table >>>> contents */ >>>> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); >>> >>> >>> Better make it clear that these commands are not implemented yet. An >>> IOMMU >>> is hardly usable without invalidators. >> >> >> I think the "debug prinft" here is misleading. AFAIK, the commands >> listed here(there are others which I haven't listed) relate to 'cache' >> which means this commands do nothing in the absence of cache. >> >> The reason why I advertise 'cache' is because the linux driver checks >> for cache and other optional features to determine the IOMMU version >> whereby versions 2 of IOMMU are assummed to support this features. > > Did you check how address translation is emulated in QEMU. I didn't :) But > you return IOMMTLBEntry from your translation routine, and I'd rather ensure > it is not cached in some other layer. Am expected to cache the IOMMUTLBEntries myself, probably through a hashtable. Also, that's what emulated VT-d in Qemu does. > > Besides, omitting invalidation commands will be a problem on real hardware. > As IOMMU emulation is mainly useful for debugging, I'd reproduce this > behaviour in the emulator. I mean, if I forget to do CMD_INVAL_DEVTAB_ENTRY > in my guest code, things shouldn't work properly. Yes, 'cache' is important for debugging. I or someone else could work on cache, now or later. > > You can just copy all data structures to AMDIOMMUState and use this "cahced" > copies, updated when you run invalidation commands. But this isn't a #1 > priority, you are right. > > Can you share some tests results for this code? Do you mean the whole IOMMU?It works, as far as am concerned. I got was able to 'passthrough' a sound device but that's the only device I tested. > >> >>> >>>> + break; >>>> + case CMD_INVAL_IOMMU_PAGES: >>>> + /* invalidate IOMMU cache for a particular domain */ >>>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>>> + break; >>>> + case CMD_INVAL_IOTLB_PAGES: >>>> + /* Only present if remote IOTLB present */ >>>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>>> + break; >>>> + case CMD_INVAL_INTR_TABLE: >>>> + /* no support for interrupt remapping yet */ >>>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>>> + break; >>>> + default: >>>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>>> + break; >>>> + } >>>> + >>>> +} >>>> + >>>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>>> +{ >>>> + IOMMU_DPRINTF(COMMAND, ""); >>>> + >>>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + >>>> MMIO_COMMAND_HEAD; >>>> + >>>> + if(!s->cmdbuf_enabled){ >>>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>>> + return; >>>> + } >>>> + >>>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>>> + /* check if there is work to do. */ >>>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND >>>> BUFFER >>>> tail at %x", >>>> + s->cmdbuf_head, s->cmdbuf_tail); >>>> + amd_iommu_cmdbuf_exec(s); >>>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>>> + >>>> + /* wrap head pointer */ >>>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>>> + s->cmdbuf_head = 0; >>>> + } >>>> + } >>>> + >>>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>>> +} >>>> + >>>> +/* System Software might never read from some of this fields but >>>> anyways >>>> */ >>>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >>>> size) >>>> +{ >>>> + AMDIOMMUState *s = opaque; >>>> + >>>> + uint64_t val = -1; >>>> + if(addr + size > MMIO_SIZE) { >>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >>>> + ", got 0x%"PRIx64 " %d", >>>> + (uint64_t)MMIO_SIZE, addr, size); >>>> + return (uint64_t) - 1; >>>> + } >>>> + >>>> + switch(addr & ~0x07){ >>>> + case MMIO_DEVICE_TABLE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>> >>> >>> What makes these cases different, except debug printf()s? Maybe leave >>> printf()s inside the switch, and factor out the rest. This applies to >>> other >>> similar cases as well. >>> >>> >>>> + >>>> + case MMIO_COMMAND_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EVENT_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_CONTROL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EXCL_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EXCL_LIMIT: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EVENT_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EVENT_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_STATUS: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EXT_FEATURES: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + if(size == 2){ >>>> + val = amd_iommu_readw(s, addr); >>>> + } else if(size == 4){ >>>> + val = amd_iommu_readl(s, addr); >>>> + } >>>> + else if(size == 8){ >>>> + val = amd_iommu_readq(s, addr); >>>> + } >>>> + break; >>>> + >>>> + default: >>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>> offset); >>>> + } >>>> + >>>> + return val; >>>> +} >>>> + >>>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>>> +{ >>>> + /* read whatever is already written incase software is writing in >>>> chucks less than 8 bytes */ >>>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>>> + >>>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>>> + s->evtlog_enabled = s->enabled && !!(control & >>>> MMIO_CONTROL_EVENTLOGEN); >>>> + >>>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>>> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >>>> + s->cmdbuf_enabled = s->enabled && !!(control & >>>> MMIO_CONTROL_CMDBUFLEN); >>>> + >>>> + /* update the flags depending on the control register */ >>>> + if(s->cmdbuf_enabled) { >>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >>>> + } else { >>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>> ~MMIO_STATUS_CMDBUF_RUN; >>>> + } >>>> + if (s->evtlog_enabled) { >>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >>>> + } else { >>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>> ~MMIO_STATUS_EVTLOG_RUN; >>>> + } >>>> + >>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>>> + >>>> + amd_iommu_cmdbuf_run(s); >>> >>> >>> Does any write to control register result in draining command buffer? To >>> me, >>> it looks strange, and I'd expect IOMMU to execute commands only if I >>> change >>> tail pointer. >>> >>> >>>> +} >>>> + >>>> +/* FIXME: something might go wrong if System Software writes in chunks >>>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>>> + * works correctly with linux but will definitely be busted if software >>>> + * reads/writes 8 bytes >>>> + */ >>>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t >>>> val, >>>> unsigned size) >>>> +{ >>>> + >>>> + AMDIOMMUState *s = opaque; >>>> + unsigned long offset = addr & 0x07; >>>> + >>>> + if(addr + size > MMIO_SIZE) { >>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >>>> + ", got 0x%"PRIx64 " %d", >>>> + (uint64_t)MMIO_SIZE, addr, size); >>>> + return; >>>> + } >>>> + >>>> + switch(addr & ~0x07){ >>>> + case MMIO_CONTROL: >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + >>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64 >>>> , addr, size, val, offset); >>>> + iommu_handle_control_write(s); >>>> + break; >>>> + >>>> + case MMIO_DEVICE_TABLE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr >>>> 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + >>>> + /* set device table address >>>> + * This also suffers from inability to tell whether >>>> software >>>> is done writing >>>> + */ >>>> + if(offset || (size == 8)){ >>>> + unsigned long device_base = amd_iommu_readq(s, >>>> MMIO_DEVICE_TABLE); >>>> + s->devtab = (dma_addr_t)(device_base & >>>> MMIO_CMDBUF_BASE_MASK); >>>> + /* set device table length */ >>>> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) >>>> + >>>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>>> + MMIO_DEVTAB_ENTRY_SIZE); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr >>>> 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>>> + amd_iommu_cmdbuf_run(s); >>>> + break; >>>> + >>>> + case MMIO_COMMAND_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr >>>> 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + >>>> + /* FIXME - make sure System Software has finished writing >>>> incase it writes >>>> + * in chucks less than 8 bytes in a robust way.As for now, >>>> this hacks works >>>> + * for the linux driver >>>> + */ >>>> + if(offset || (size == 8)){ >>>> + unsigned long command_base = amd_iommu_readq(s, >>>> MMIO_COMMAND_BASE); >>>> + s->cmdbuf = (dma_addr_t)(command_base & >>>> MMIO_CMDBUF_BASE_MASK); >>>> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] >>>> & >>>> MMIO_CMDBUF_SIZE_MASK); >>>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>>> + } >>>> + break; >>>> + >>>> + case MMIO_COMMAND_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr >>>> 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + >>>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>>> + amd_iommu_cmdbuf_run(s); >>>> + break; >>>> + >>>> + case MMIO_EVENT_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>>> + s->evtlog_len = 1UL << >>>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >>>> + break; >>>> + >>>> + case MMIO_EXCL_LIMIT: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>>> MMIO_EXCL_LIMIT_LOW; >>>> + break; >>>> + //TODO : Event handling fixes >>>> + >>>> + case MMIO_EVENT_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + >>>> + case MMIO_EVENT_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + /* PPR log base - unused for now */ >>>> + case MMIO_PPR_BASE: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + /* PPR log head - also unused for now */ >>>> + case MMIO_PPR_HEAD: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + /* PPR log tail - unused for now */ >>>> + case MMIO_PPR_TAIL: >>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + if(size == 2){ >>>> + amd_iommu_writew(s, addr, val); >>>> + } else if(size == 4){ >>>> + amd_iommu_writel(s, addr, val); >>>> + } else if(size == 8){ >>>> + amd_iommu_writeq(s, addr, val); >>>> + } >>>> + break; >>>> + >>>> + default: >>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>>> + ", size %d, val 0x%"PRIx64 ", offset >>>> 0x%"PRIx64, addr, size, val, offset); >>>> + ; >>>> + } >>>> + >>>> +} >>>> + >>>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>>> +{ >>>> + /* event logging not enabled */ >>>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>>> MMIO_STATUS_EVTLOG_OF){ >>>> + return; >>>> + } >>>> + >>>> + /* event log buffer full */ >>>> + if(s->evtlog_tail >= s->evtlog_len) { >>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>>> + } >>>> + >>>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>>> s->evtlog_tail, &evt, EVENT_LEN)){ >>>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>> 0%x"PRIu8, >>>> s->evtlog + s->evtlog_tail); >>>> + } >>>> + >>>> + s->evtlog_tail += EVENT_LEN; >>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>>> + /* Disable logging if Overflow ? */ >>> >>> >>> No, the spec details event logging restart procedure. Make sure emulated >>> IOMMU behaves as described there. >>> >>> >>>> +} >>>> + >>>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >>>> domid, dma_addr_t addr, int present, >>>> + int is_write) >>>> +{ >>>> + IOMMU_DPRINTF(ELOG, ""); >>>> + >>>> + AMDIOMMUEvent evt; >>>> + unsigned info; >>>> + uint16_t status; >>>> + >>>> + evt.devfn = cpu_to_le16(devfn); >>>> + evt.reserved = 0; >>>> + evt.domid = cpu_to_le16(domid); >>>> + evt.addr = cpu_to_le16(addr); >>>> + >>>> + info = EVENT_IOPF; >>>> + >>>> + if(present) { >>>> + info |= EVENT_IOPF_PR; >>>> + } >>>> + >>>> + if (is_write) { >>>> + info |= EVENT_IOPF_RW; >>>> + } >>>> + >>>> + /* log a page fault */ >>>> + amd_iommu_log_event(s, &evt); >>>> + >>>> + /* Abort the translation */ >>>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>>> PCI_STATUS_SIG_TARGET_ABORT); >>>> +} >>>> + >>>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>>> +{ >>>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >>>> +} >>>> + >>>> +/* FIXME deduplication */ >>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>> devfn) >>>> +{ >>>> + AMDIOMMUState *s = opaque; >>>> + AMDIOMMUAddressSpace **iommu_as; >>>> + int bus_num = pci_bus_num(bus); >>>> + >>>> + /* just in case */ >>>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>>> + >>>> + iommu_as = s->address_spaces[bus_num]; >>>> + >>>> + /* allocate memory during the first run */ >>>> + if(!iommu_as) { >>>> + iommu_as = >>>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>>> + s->address_spaces[bus_num] = iommu_as; >>>> + } >>>> + >>>> + /* set up IOMMU region */ >>>> + if(!iommu_as[devfn]){ >>>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>>> + iommu_as[devfn]->iommu_state = s; >>>> + >>>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>>> "amd-iommu"); >>>> + } >>>> + return &iommu_as[devfn]->as; >>>> +} >>>> + >>>> +/* validate a page table entry */ >>>> +static bool amd_iommu_validate_pte(uint64_t pte) >>>> +{ >>>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>> >>> >>> I'd suggest parenthesis here. >>> >>> >>>> +} >>>> + >>>> +/* get a device table entry given the device function */ >>>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>>> *entry) >>>> +{ >>>> + /* Could lead to out of range accesses */ >>>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>>> + >>>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, >>>> entry, >>>> 32)){ >>>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>>> 0x%"PRIx64 >>>> + "offset 0x%"PRIx32, s->devtab, offset); >>>> + return false; >>>> + } >>>> + >>>> + if(!amd_iommu_validate_pte(entry[0])){ >>>> + IOMMU_DPRINTF(MMU, >>>> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >>>> + return false; >>>> + } >>>> + >>>> + return true; >>>> +} >>>> + >>>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>>> +{ >>>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>> + >>>> + if(level == 7){ >>>> + /* reserved level - abort ? */ >>>> + IOMMU_DPRINTF(MMU, >>>> + "Reserved translation level (7) detected"); >>>> + return 0; >>>> + } >>>> + >>>> + return level; >>>> +} >>>> + >>>> +/* TODO : Mark addresses as Accessed and Dirty */ >>>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr >>>> addr, >>>> bool is_write, IOMMUTLBEntry *ret) >>>> +{ >>>> + AMDIOMMUState *s = as->iommu_state; >>>> + >>>> + int present; >>>> + dma_addr_t pte_addr; >>>> + uint64_t entry[4], pte, pte_perms; >>>> + unsigned level; >>>> + unsigned perms; >>>> + >>>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>>> + goto no_translation; >>>> + } >>>> + >>>> + pte = entry[0]; >>>> + >>>> + /* >>>> + * It's okay to check for either read or write permissions >>>> + * even for memory maps, since we don't support R/W maps. >>>> + */ >>>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>>> + >>>> + if(!(level = get_pte_translation_mode(pte))){ >>>> + goto no_translation; >>>> + } >>>> + >>>> + while(level > 0){ >>>> + /* >>>> + * check permissions: the bitwise >>>> + * implication perms -> entry_perms must be true. Pages must be >>>> present >>>> + * and permissions on all levels must be similar >>>> + */ >>>> + pte_perms = amd_iommu_get_perms(pte); >>>> + present = pte & 1; >>>> + if(!present || perms != (perms & pte_perms)){ >>>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>>> DEV_DOMID_ID_MASK, addr, present, >>>> + !!(perms & IOMMU_PERM_WRITE)); >>>> + return; >>>> + } >>>> + >>>> + /* go to the next lower level */ >>>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>> >>> >>> Does this work for six level page tables? The highest level has different >>> bit size there IIRC. >>> >>>> + pte = ldq_phys(&address_space_memory, pte_addr); >>>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>> + } >>>> + >>>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & >>>> IOMMU_PAGE_MASK_4K; >>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>> + ret->perm = IOMMU_RW; >>>> + return; >>>> + >>>> +no_translation: >>>> + ret->iova = addr; >>>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>> + ret->perm = IOMMU_RW; >>>> + return; >>> >>> >>> Are you sure these transactions needs to be passed through rather than >>> target-aborted? >>> >>>> +} >>>> + >>>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>>> addr, bool is_write) >>>> +{ >>>> + >>>> + IOMMU_DPRINTF(GENERAL, ""); >>>> + >>>> + AMDIOMMUAddressSpace *as = container_of(iommu, >>>> AMDIOMMUAddressSpace, >>>> iommu); >>>> + AMDIOMMUState *s = as->iommu_state; >>>> + >>>> + IOMMUTLBEntry ret = { >>>> + .target_as = &address_space_memory, >>>> + .iova = addr, >>>> + .translated_addr = 0, >>>> + .addr_mask = ~(hwaddr)0, >>>> + .perm = IOMMU_NONE, >>>> + }; >>>> + >>>> + if(!s->enabled){ >>>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>>> provide any parameter */ >>>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>>> + ret.perm = IOMMU_RW; >>>> + return ret; >>>> + } >>>> + >>>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>>> + >>>> + IOMMU_DPRINTF(MMU, >>>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >>>> as->bus_num, >>>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>>> ret.translated_addr); >>>> + >>>> + return ret; >>>> +} >>>> + >>>> +static const MemoryRegionOps mmio_mem_ops = { >>>> + .read = amd_iommu_mmio_read, >>>> + .write = amd_iommu_mmio_write, >>>> + .endianness = DEVICE_LITTLE_ENDIAN, >>>> + .valid = { >>>> + .min_access_size = 1, >>>> + .max_access_size = 8, >>>> + .unaligned = false, >>>> + }, >>>> + >>>> + .valid = { >>>> + .min_access_size = 8, >>>> + .max_access_size = 8, >>>> + }, >>>> +}; >>>> + >>>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t >>>> host_pa, >>>> uint32_t guest_va, uint32_t *reg) >>>> +{ >>>> + *reg = 0; >>> >>> >>> Redundant line. >>> >>> >>>> + >>>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>>> +} >>>> + >>>> +/* FIXME: The similar code in reset and init could be combined into a >>>> function */ >>>> +static void amd_iommu_reset(DeviceState *dev) >>>> +{ >>>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>>> + >>>> + uint32_t capab_header = CAPAB_FEATURES; >>>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>>> + uint32_t capab_range = 0xff000000; >>>> + uint32_t capab_misc = 0x0; >>>> + >>>> + /* reset MMIO */ >>>> + memset(s->mmior, 0, MMIO_SIZE); >>>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>>> + /* TODO :Disable event logging and reset all buffers */ >>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>> &capab_misc); >>>> + >>>> + /* reset IOMMU specific capabilities */ >>>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>>> capab_base_addr_low); >>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>>> capab_base_addr_high); >>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>>> capab_range); >>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>>> capab_misc); >>> >>> >>> >>> Do we also need to reset MSI capability block? >>> >>> >>>> + >>>> + /* reset device ident */ >>>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>>> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >>>> + pci_config_set_class(s->dev.config, 0x0806); >>>> + pci_config_set_prog_interface(s->dev.config, 00); >>>> +} >>>> + >>>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, >>>> uint32_t >>>> val, int len) >>>> +{ >>>> + pci_default_write_config(dev, addr, val, len); >>>> +} >>>> + >>>> +/* I honestly don't know how to reserve MMIO */ >>>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>>> +{ >>>> + if(s->mmio.addr == addr){ >>>> + return; >>>> + } >>>> + >>>> +// if(s->mmio.addr != (hwaddr)-1) { >>>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>>> +// } >>>> + >>>> + s->mmio.addr = addr; >>>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>>> + >>>> +} >>>> + >>>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>>> +{ >>>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>>> + uint32_t capab_header = CAPAB_FEATURES; >>>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> >>>> 16); >>>> + uint32_t capab_range = 0xff000000; >>>> + uint32_t capab_misc = 0x0; >>>> + >>>> + memset(s->mmior, 0, MMIO_SIZE); >>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>> &capab_misc); >>>> + >>>> + s->iommu_ops.translate = amd_iommu_translate; >>>> + s->enabled = false; >>>> + s->ats_enabled = false; >>>> + s->cmdbuf_enabled = false; >>>> + s->devtab_len = 0; >>>> + s->cmdbuf_len = 0; >>>> + s->cmdbuf_head = 0; >>>> + s->cmdbuf_tail = 0; >>>> + s->evtlog_head = 0; >>>> + s->evtlog_tail = 0; >>>> + s->excl_enabled = false; >>>> + s->excl_allow = false; >>>> + s->mmio_enabled = false; >>>> + dev->config_write = amd_iommu_write_capab; >>>> + >>>> + size_t offset; >>>> + /* Save offset for IVRS */ >>>> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, >>>> 0, >>>> CAPAB_SIZE); >>>> + pci_set_long(s->dev.config + offset, capab_header); >>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>>> capab_base_addr_low); >>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>>> capab_base_addr_high); >>>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>>> + >>>> + /* add msi and hypertransport capabilities */ >>>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>>> + >>>> + /* set up MMIO */ >>>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>>> "amd-iommu", MMIO_SIZE); >>>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>>> + >>>> + /* reset device ident */ >>>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>>> + >>>> + /* may not be necessary */ >>>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>>> + >>>> + return 0; >>>> +} >>>> + >>>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>>> +{ >>>> + amd_iommu_pci_initfn(dev); >>>> +} >>>> + >>>> +static const VMStateDescription vmstate_amd_iommu = { >>>> + .name = "amd-iommu", >>>> + .fields = (VMStateField[]) { >>>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>>> + VMSTATE_END_OF_LIST() >>>> + } >>>> +}; >>>> + >>>> +static Property amd_iommu_properties[] = { >>>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>>> + DEFINE_PROP_END_OF_LIST(), >>>> +}; >>>> + >>>> +/* not used for now but will be when cache is added */ >>>> +static void amd_iommu_uninit(PCIDevice *dev) >>>> +{ >>>> + return; >>>> +} >>>> + >>>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>>> +{ >>>> + DeviceClass *dc = DEVICE_CLASS(klass); >>>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>>> + >>>> + pci->realize = amd_iommu_realize; >>>> + pci->exit = amd_iommu_uninit; >>>> + >>>> + dc->reset = amd_iommu_reset; >>>> + dc->vmsd = &vmstate_amd_iommu; >>>> + dc->props = amd_iommu_properties; >>>> +} >>>> + >>>> +static const TypeInfo amd_iommu = { >>>> + .name = TYPE_AMD_IOMMU_DEVICE, >>>> + .parent = TYPE_PCI_DEVICE, >>>> + .instance_size = sizeof(AMDIOMMUState), >>>> + .class_init = amd_iommu_class_init >>>> +}; >>>> + >>>> +static void amd_iommu_register_types(void) >>>> +{ >>>> + type_register_static(&amd_iommu); >>>> +} >>>> + >>>> +type_init(amd_iommu_register_types); >>>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>>> new file mode 100644 >>>> index 0000000..90309eb >>>> --- /dev/null >>>> +++ b/hw/i386/amd_iommu.h >>>> @@ -0,0 +1,298 @@ >>>> +/* >>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>> + * >>>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License as published by >>>> + * the Free Software Foundation; either version 2 of the License, or >>>> + * (at your option) any later version. >>>> + >>>> + * This program is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + >>>> + * You should have received a copy of the GNU General Public License >>>> along >>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>> + */ >>>> + >>>> +#ifndef AMD_IOMMU_H_ >>>> +#define AMD_IOMMU_H_ >>>> + >>>> +#include "hw/hw.h" >>>> +#include "hw/pci/pci.h" >>>> +#include "hw/sysbus.h" >>>> +#include "sysemu/dma.h" >>>> +#include "qemu/osdep.h" >>>> +#include "qemu/event_notifier.h" >>>> + >>>> +/* Capability registers */ >>>> +#define CAPAB_HEADER 0x00 >>>> +#define CAPAB_REV_TYPE 0x02 >>>> +#define CAPAB_FLAGS 0x03 >>>> +#define CAPAB_BAR_LOW 0x04 >>>> +#define CAPAB_BAR_HIGH 0x08 >>>> +#define CAPAB_RANGE 0x0C >>>> +#define CAPAB_MISC 0x10 >>>> +#define CAPAB_MISC1 0x14 >>>> + >>>> +#define CAPAB_SIZE 0x18 >>>> +#define CAPAB_REG_SIZE 0x04 >>>> + >>>> +/* Capability header data */ >>>> +#define CAPAB_FLAT_EXT (1 << 28) >>>> +#define CAPAB_EFR_SUP (1 << 27) >>>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>>> +#define CAPAB_INIT_REV (1 << 19) >>>> +#define CAPAB_INIT_TYPE (3 << 16) >>>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>>> CAPAB_FLAG_HTTUNNEL) >>>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>>> + >>>> +/* MMIO registers */ >>>> +#define MMIO_DEVICE_TABLE 0x0000 >>>> +#define MMIO_COMMAND_BASE 0x0008 >>>> +#define MMIO_EVENT_BASE 0x0010 >>>> +#define MMIO_CONTROL 0x0018 >>>> +#define MMIO_EXCL_BASE 0x0020 >>>> +#define MMIO_EXCL_LIMIT 0x0028 >>>> +#define MMIO_EXT_FEATURES 0x0030 >>>> +#define MMIO_COMMAND_HEAD 0x2000 >>>> +#define MMIO_COMMAND_TAIL 0x2008 >>>> +#define MMIO_EVENT_HEAD 0x2010 >>>> +#define MMIO_EVENT_TAIL 0x2018 >>>> +#define MMIO_STATUS 0x2020 >>>> +#define MMIO_PPR_BASE 0x0038 >>>> +#define MMIO_PPR_HEAD 0x2030 >>>> +#define MMIO_PPR_TAIL 0x2038 >>>> + >>>> +#define MMIO_SIZE 0x4000 >>>> + >>>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>>> ~MMIO_DEVTAB_SIZE_MASK) >>>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>>> + >>>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>> + >>>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>> + >>>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>>> + >>>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>>> + >>>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>>> + >>>> +#define CMDBUF_ID_BYTE 0x07 >>>> +#define CMDBUF_ID_RSHIFT 4 >>>> +#define CMDBUF_ENTRY_SIZE 0x10 >>>> + >>>> +#define CMD_COMPLETION_WAIT 0x01 >>>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>>> +#define CMD_INVAL_INTR_TABLE 0x05 >>>> + >>>> +#define DEVTAB_ENTRY_SIZE 32 >>>> + >>>> +/* Device table entry bits 0:63 */ >>>> +#define DEV_VALID (1ULL << 0) >>>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>>> +#define DEV_MODE_MASK 0x7 >>>> +#define DEV_MODE_RSHIFT 9 >>>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>>> +#define DEV_PT_ROOT_RSHIFT 12 >>>> +#define DEV_PERM_SHIFT 61 >>>> +#define DEV_PERM_READ (1ULL << 61) >>>> +#define DEV_PERM_WRITE (1ULL << 62) >>>> + >>>> +/* Device table entry bits 64:127 */ >>>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>>> +#define DEV_IOCTL_MASK (~3) >>>> +#define DEV_IOCTL_RSHIFT 20 >>>> +#define DEV_IOCTL_DENY 0 >>>> +#define DEV_IOCTL_PASSTHROUGH 1 >>>> +#define DEV_IOCTL_TRANSLATE 2 >>>> +#define DEV_CACHE (1ULL << 37) >>>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>>> +#define DEV_EXCL (1ULL << 39) >>>> + >>>> +/* Event codes and flags, as stored in the info field */ >>>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>>> +#define EVENT_IOPF (0x2U << 24) >>>> +#define EVENT_IOPF_I (1U << 3) >>>> +#define EVENT_IOPF_PR (1U << 4) >>>> +#define EVENT_IOPF_RW (1U << 5) >>>> +#define EVENT_IOPF_PE (1U << 6) >>>> +#define EVENT_IOPF_RZ (1U << 7) >>>> +#define EVENT_IOPF_TR (1U << 8) >>>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>>> + >>>> +#define EVENT_LEN 16 >>>> + >>>> +#define IOMMU_PERM_READ (1 << 0) >>>> +#define IOMMU_PERM_WRITE (1 << 1) >>>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | >>>> IOMMU_PERM_WRITE) >>>> + >>>> +/* AMD RD890 Chipset */ >>>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>>> + >>>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>>> register */ >>>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>>> register */ >>>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>>> register */ >>>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>>> */ >>>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >>>> register 0 */ >>>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >>>> register 1 */ >>>> + >>>> +#define FEATURE_PREFETCH (1ULL<<0) >>>> +#define FEATURE_PPR (1ULL<<1) >>>> +#define FEATURE_NX (1ULL<<3) >>>> +#define FEATURE_GT (1ULL<<4) >>>> +#define FEATURE_IA (1ULL<<6) >>>> +#define FEATURE_GA (1ULL<<7) >>>> +#define FEATURE_HE (1ULL<<8) >>>> +#define FEATURE_PC (1ULL<<9) >>>> + >>>> +/* IOMMU paging mode */ >>>> +#define GATS_MODE (6ULL << 12) >>>> +#define HATS_MODE (6ULL << 10) >>>> +/* PCI SIG constants */ >>>> +#define PCI_BUS_MAX 256 >>>> +#define PCI_SLOT_MAX 32 >>>> +#define PCI_FUNC_MAX 8 >>>> +#define PCI_DEVFN_MAX 256 >>>> + >>>> +/* extended feature support */ >>>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | >>>> HATS_MODE ) >>>> + >>>> +/* capabilities header */ >>>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | >>>> CAPAB_FLAG_HTTUNNEL >>>> | CAPAB_EFR_SUP) >>>> + >>>> +/* command constants */ >>>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>>> +#define COM_COMPLETION_STORE_MASK 0x1 >>>> +#define COM_COMPLETION_INTR 0x2 >>>> +#define COM_COMPLETION_DATA_OFF 0x8 >>>> +#define IOMMU_COMMAND_SIZE 0x10 >>>> + >>>> +/* IOMMU default address */ >>>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>>> + >>>> +/* page management constants */ >>>> +#define IOMMU_PAGE_SHIFT 12 >>>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>>> + >>>> +#define IOMMU_PAGE_SHIFT_4K 12 >>>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>>> +#define IOMMU_PAGE_SHIFT_2M 21 >>>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>>> +#define IOMMU_PAGE_SHIFT_1G 30 >>>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>>> + >>>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>>> +#define AMD_IOMMU_DEVICE(obj)\ >>>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>>> + >>>> +typedef struct AMDIOMMUState AMDIOMMUState; >>>> + >>>> +typedef struct AMDIOMMUAddressSpace{ >>>> + uint8_t bus_num; /* bus number >>>> */ >>>> + uint8_t devfn; /* device function >>>> */ >>>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>>> */ >>>> + MemoryRegion iommu; /* Device's iommu region >>>> */ >>>> + AddressSpace as; /* device's corresponding address space >>>> */ >>>> +}AMDIOMMUAddressSpace; >>>> + >>>> +struct AMDIOMMUState { >>>> + PCIDevice dev; /* The PCI device itself */ >>>> + >>>> + uint32_t version; >>>> + >>>> + int capab_offset; /* capability offset pointer */ >>>> + unsigned char *capab; /* capabilities registers */ >>>> + >>>> + bool enabled; /* IOMMU enabled */ >>>> + bool ats_enabled; /* address translation enabled */ >>>> + bool cmdbuf_enabled; /* command buffer enabled */ >>>> + bool evtlog_enabled; /* event log enabled */ >>>> + bool excl_enabled; >>>> + >>>> + dma_addr_t devtab; /* base address device table */ >>>> + size_t devtab_len; /* device table length */ >>>> + >>>> + dma_addr_t cmdbuf; /* command buffer base address */ >>>> + uint64_t cmdbuf_len; /* command buffer length */ >>>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>>> + unsigned cmdbuf_tail; /* next Software write position */ >>>> + int completion_wait_intr; >>>> + >>>> + dma_addr_t evtlog; /* base address event log */ >>>> + size_t evtlog_intr; >>>> + size_t evtlog_len; /* event log length */ >>>> + size_t evtlog_head; /* event log head */ >>>> + size_t evtlog_tail; /* event log tail */ >>>> + >>>> + /* unused for now */ >>>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >>>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >>>> + bool excl_allow; /* translate accesses to the exclusion >>>> range */ >>>> + bool excl_enable; /* exclusion range enabled */ >>>> + >>>> + MemoryRegion mmio; /* MMIO region */ >>>> + unsigned char mmior[MMIO_SIZE]; >>>> + bool mmio_enabled; >>>> + >>>> + /* IOMMU function */ >>>> + MemoryRegionIOMMUOps iommu_ops; >>>> + >>>> + /* for each served device */ >>>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>>> +}; >>>> + >>>> +typedef struct AMDIOMMUEvent { >>>> + uint16_t devfn; >>>> + uint16_t reserved; >>>> + uint16_t domid; >>>> + uint16_t info; >>>> + uint16_t addr; >>>> +} __attribute__((packed)) AMDIOMMUEvent; >>>> + >>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>> devfn); >>>> + >>>> +#endif >>>> >>> >>> Regards, >>> Valentine > > > -- > С уважением, > Синицын Валентин ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-09 7:59 ` David kiarie @ 2015-09-09 8:07 ` Valentine Sinitsyn 2015-09-09 8:12 ` David kiarie 0 siblings, 1 reply; 22+ messages in thread From: Valentine Sinitsyn @ 2015-09-09 8:07 UTC (permalink / raw) To: David kiarie; +Cc: Jan Kiszka, QEMU Developers, mst On 09.09.2015 12:59, David kiarie wrote: > On Wed, Sep 9, 2015 at 10:45 AM, Valentine Sinitsyn > <valentine.sinitsyn@gmail.com> wrote: >> On 09.09.2015 12:30, David kiarie wrote: >> ...snip... >> >> >>>>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>>>> +{ >>>>> + unsigned type; >>>>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>>>> + >>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>>>> + >>>>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + >>>>> s->cmdbuf_head, >>>>> cmd, IOMMU_COMMAND_SIZE)){ >>>>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>>>> 0x%"PRIx64 >>>>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>>>> + } >>>>> + >>>>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>>>> + >>>>> + switch(type){ >>>>> + case CMD_COMPLETION_WAIT: >>>>> + /* pretend to wait for command execution to complete */ >>>>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>>>> + amd_iommu_completion_wait(s, cmd); >>>>> + break; >>>>> + case CMD_INVAL_DEVTAB_ENTRY: >>>>> + /* Not implemented yet - should just clear device table >>>>> contents */ >>>>> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); >>>> >>>> >>>> Better make it clear that these commands are not implemented yet. An >>>> IOMMU >>>> is hardly usable without invalidators. >>> >>> >>> I think the "debug prinft" here is misleading. AFAIK, the commands >>> listed here(there are others which I haven't listed) relate to 'cache' >>> which means this commands do nothing in the absence of cache. >>> >>> The reason why I advertise 'cache' is because the linux driver checks >>> for cache and other optional features to determine the IOMMU version >>> whereby versions 2 of IOMMU are assummed to support this features. >> >> Did you check how address translation is emulated in QEMU. I didn't :) But >> you return IOMMTLBEntry from your translation routine, and I'd rather ensure >> it is not cached in some other layer. > > Am expected to cache the IOMMUTLBEntries myself, probably through a > hashtable. Also, that's what emulated VT-d in Qemu does. > >> >> Besides, omitting invalidation commands will be a problem on real hardware. >> As IOMMU emulation is mainly useful for debugging, I'd reproduce this >> behaviour in the emulator. I mean, if I forget to do CMD_INVAL_DEVTAB_ENTRY >> in my guest code, things shouldn't work properly. > > Yes, 'cache' is important for debugging. I or someone else could work > on cache, now or later. > >> >> You can just copy all data structures to AMDIOMMUState and use this "cahced" >> copies, updated when you run invalidation commands. But this isn't a #1 >> priority, you are right. >> >> Can you share some tests results for this code? > > Do you mean the whole IOMMU?It works, as far as am concerned. I got > was able to 'passthrough' a sound device but that's the only device I > tested. That's great. Could you describe your tests setup, please? Maybe in README or in the cover letter, so anyone interested could reproduce it just following your steps. Valentine > >> >>> >>>> >>>>> + break; >>>>> + case CMD_INVAL_IOMMU_PAGES: >>>>> + /* invalidate IOMMU cache for a particular domain */ >>>>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>>>> + break; >>>>> + case CMD_INVAL_IOTLB_PAGES: >>>>> + /* Only present if remote IOTLB present */ >>>>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>>>> + break; >>>>> + case CMD_INVAL_INTR_TABLE: >>>>> + /* no support for interrupt remapping yet */ >>>>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>>>> + break; >>>>> + default: >>>>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>>>> + break; >>>>> + } >>>>> + >>>>> +} >>>>> + >>>>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>>>> +{ >>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>> + >>>>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + >>>>> MMIO_COMMAND_HEAD; >>>>> + >>>>> + if(!s->cmdbuf_enabled){ >>>>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>>>> + return; >>>>> + } >>>>> + >>>>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>>>> + /* check if there is work to do. */ >>>>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND >>>>> BUFFER >>>>> tail at %x", >>>>> + s->cmdbuf_head, s->cmdbuf_tail); >>>>> + amd_iommu_cmdbuf_exec(s); >>>>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>>>> + >>>>> + /* wrap head pointer */ >>>>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>>>> + s->cmdbuf_head = 0; >>>>> + } >>>>> + } >>>>> + >>>>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>>>> +} >>>>> + >>>>> +/* System Software might never read from some of this fields but >>>>> anyways >>>>> */ >>>>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >>>>> size) >>>>> +{ >>>>> + AMDIOMMUState *s = opaque; >>>>> + >>>>> + uint64_t val = -1; >>>>> + if(addr + size > MMIO_SIZE) { >>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >>>>> + ", got 0x%"PRIx64 " %d", >>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>> + return (uint64_t) - 1; >>>>> + } >>>>> + >>>>> + switch(addr & ~0x07){ >>>>> + case MMIO_DEVICE_TABLE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>> >>>> >>>> What makes these cases different, except debug printf()s? Maybe leave >>>> printf()s inside the switch, and factor out the rest. This applies to >>>> other >>>> similar cases as well. >>>> >>>> >>>>> + >>>>> + case MMIO_COMMAND_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_CONTROL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_LIMIT: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_STATUS: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXT_FEATURES: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + default: >>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + } >>>>> + >>>>> + return val; >>>>> +} >>>>> + >>>>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>>>> +{ >>>>> + /* read whatever is already written incase software is writing in >>>>> chucks less than 8 bytes */ >>>>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>>>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>>>> + >>>>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>>>> + s->evtlog_enabled = s->enabled && !!(control & >>>>> MMIO_CONTROL_EVENTLOGEN); >>>>> + >>>>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>>>> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >>>>> + s->cmdbuf_enabled = s->enabled && !!(control & >>>>> MMIO_CONTROL_CMDBUFLEN); >>>>> + >>>>> + /* update the flags depending on the control register */ >>>>> + if(s->cmdbuf_enabled) { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >>>>> + } else { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>> ~MMIO_STATUS_CMDBUF_RUN; >>>>> + } >>>>> + if (s->evtlog_enabled) { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >>>>> + } else { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>> ~MMIO_STATUS_EVTLOG_RUN; >>>>> + } >>>>> + >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>>>> + >>>>> + amd_iommu_cmdbuf_run(s); >>>> >>>> >>>> Does any write to control register result in draining command buffer? To >>>> me, >>>> it looks strange, and I'd expect IOMMU to execute commands only if I >>>> change >>>> tail pointer. >>>> >>>> >>>>> +} >>>>> + >>>>> +/* FIXME: something might go wrong if System Software writes in chunks >>>>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>>>> + * works correctly with linux but will definitely be busted if software >>>>> + * reads/writes 8 bytes >>>>> + */ >>>>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t >>>>> val, >>>>> unsigned size) >>>>> +{ >>>>> + >>>>> + AMDIOMMUState *s = opaque; >>>>> + unsigned long offset = addr & 0x07; >>>>> + >>>>> + if(addr + size > MMIO_SIZE) { >>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >>>>> + ", got 0x%"PRIx64 " %d", >>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>> + return; >>>>> + } >>>>> + >>>>> + switch(addr & ~0x07){ >>>>> + case MMIO_CONTROL: >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64 >>>>> , addr, size, val, offset); >>>>> + iommu_handle_control_write(s); >>>>> + break; >>>>> + >>>>> + case MMIO_DEVICE_TABLE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr >>>>> 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + /* set device table address >>>>> + * This also suffers from inability to tell whether >>>>> software >>>>> is done writing >>>>> + */ >>>>> + if(offset || (size == 8)){ >>>>> + unsigned long device_base = amd_iommu_readq(s, >>>>> MMIO_DEVICE_TABLE); >>>>> + s->devtab = (dma_addr_t)(device_base & >>>>> MMIO_CMDBUF_BASE_MASK); >>>>> + /* set device table length */ >>>>> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) >>>>> + >>>>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>>>> + MMIO_DEVTAB_ENTRY_SIZE); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr >>>>> 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>>>> + amd_iommu_cmdbuf_run(s); >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr >>>>> 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + /* FIXME - make sure System Software has finished writing >>>>> incase it writes >>>>> + * in chucks less than 8 bytes in a robust way.As for now, >>>>> this hacks works >>>>> + * for the linux driver >>>>> + */ >>>>> + if(offset || (size == 8)){ >>>>> + unsigned long command_base = amd_iommu_readq(s, >>>>> MMIO_COMMAND_BASE); >>>>> + s->cmdbuf = (dma_addr_t)(command_base & >>>>> MMIO_CMDBUF_BASE_MASK); >>>>> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] >>>>> & >>>>> MMIO_CMDBUF_SIZE_MASK); >>>>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr >>>>> 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>>>> + amd_iommu_cmdbuf_run(s); >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>>>> + s->evtlog_len = 1UL << >>>>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_LIMIT: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>>>> MMIO_EXCL_LIMIT_LOW; >>>>> + break; >>>>> + //TODO : Event handling fixes >>>>> + >>>>> + case MMIO_EVENT_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log base - unused for now */ >>>>> + case MMIO_PPR_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log head - also unused for now */ >>>>> + case MMIO_PPR_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log tail - unused for now */ >>>>> + case MMIO_PPR_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + >>>>> + default: >>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + ; >>>>> + } >>>>> + >>>>> +} >>>>> + >>>>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>>>> +{ >>>>> + /* event logging not enabled */ >>>>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>>>> MMIO_STATUS_EVTLOG_OF){ >>>>> + return; >>>>> + } >>>>> + >>>>> + /* event log buffer full */ >>>>> + if(s->evtlog_tail >= s->evtlog_len) { >>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>>>> + } >>>>> + >>>>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>>>> s->evtlog_tail, &evt, EVENT_LEN)){ >>>>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>>> 0%x"PRIu8, >>>>> s->evtlog + s->evtlog_tail); >>>>> + } >>>>> + >>>>> + s->evtlog_tail += EVENT_LEN; >>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>>>> + /* Disable logging if Overflow ? */ >>>> >>>> >>>> No, the spec details event logging restart procedure. Make sure emulated >>>> IOMMU behaves as described there. >>>> >>>> >>>>> +} >>>>> + >>>>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >>>>> domid, dma_addr_t addr, int present, >>>>> + int is_write) >>>>> +{ >>>>> + IOMMU_DPRINTF(ELOG, ""); >>>>> + >>>>> + AMDIOMMUEvent evt; >>>>> + unsigned info; >>>>> + uint16_t status; >>>>> + >>>>> + evt.devfn = cpu_to_le16(devfn); >>>>> + evt.reserved = 0; >>>>> + evt.domid = cpu_to_le16(domid); >>>>> + evt.addr = cpu_to_le16(addr); >>>>> + >>>>> + info = EVENT_IOPF; >>>>> + >>>>> + if(present) { >>>>> + info |= EVENT_IOPF_PR; >>>>> + } >>>>> + >>>>> + if (is_write) { >>>>> + info |= EVENT_IOPF_RW; >>>>> + } >>>>> + >>>>> + /* log a page fault */ >>>>> + amd_iommu_log_event(s, &evt); >>>>> + >>>>> + /* Abort the translation */ >>>>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>>>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>>>> PCI_STATUS_SIG_TARGET_ABORT); >>>>> +} >>>>> + >>>>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>>>> +{ >>>>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >>>>> +} >>>>> + >>>>> +/* FIXME deduplication */ >>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>> devfn) >>>>> +{ >>>>> + AMDIOMMUState *s = opaque; >>>>> + AMDIOMMUAddressSpace **iommu_as; >>>>> + int bus_num = pci_bus_num(bus); >>>>> + >>>>> + /* just in case */ >>>>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>>>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>>>> + >>>>> + iommu_as = s->address_spaces[bus_num]; >>>>> + >>>>> + /* allocate memory during the first run */ >>>>> + if(!iommu_as) { >>>>> + iommu_as = >>>>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>>>> + s->address_spaces[bus_num] = iommu_as; >>>>> + } >>>>> + >>>>> + /* set up IOMMU region */ >>>>> + if(!iommu_as[devfn]){ >>>>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>>>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>>>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>>>> + iommu_as[devfn]->iommu_state = s; >>>>> + >>>>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>>>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>>>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>>>> "amd-iommu"); >>>>> + } >>>>> + return &iommu_as[devfn]->as; >>>>> +} >>>>> + >>>>> +/* validate a page table entry */ >>>>> +static bool amd_iommu_validate_pte(uint64_t pte) >>>>> +{ >>>>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>>> >>>> >>>> I'd suggest parenthesis here. >>>> >>>> >>>>> +} >>>>> + >>>>> +/* get a device table entry given the device function */ >>>>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>>>> *entry) >>>>> +{ >>>>> + /* Could lead to out of range accesses */ >>>>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>>>> + >>>>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>>>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, >>>>> entry, >>>>> 32)){ >>>>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>>>> 0x%"PRIx64 >>>>> + "offset 0x%"PRIx32, s->devtab, offset); >>>>> + return false; >>>>> + } >>>>> + >>>>> + if(!amd_iommu_validate_pte(entry[0])){ >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >>>>> + return false; >>>>> + } >>>>> + >>>>> + return true; >>>>> +} >>>>> + >>>>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>>>> +{ >>>>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>> + >>>>> + if(level == 7){ >>>>> + /* reserved level - abort ? */ >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "Reserved translation level (7) detected"); >>>>> + return 0; >>>>> + } >>>>> + >>>>> + return level; >>>>> +} >>>>> + >>>>> +/* TODO : Mark addresses as Accessed and Dirty */ >>>>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr >>>>> addr, >>>>> bool is_write, IOMMUTLBEntry *ret) >>>>> +{ >>>>> + AMDIOMMUState *s = as->iommu_state; >>>>> + >>>>> + int present; >>>>> + dma_addr_t pte_addr; >>>>> + uint64_t entry[4], pte, pte_perms; >>>>> + unsigned level; >>>>> + unsigned perms; >>>>> + >>>>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>>>> + goto no_translation; >>>>> + } >>>>> + >>>>> + pte = entry[0]; >>>>> + >>>>> + /* >>>>> + * It's okay to check for either read or write permissions >>>>> + * even for memory maps, since we don't support R/W maps. >>>>> + */ >>>>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>>>> + >>>>> + if(!(level = get_pte_translation_mode(pte))){ >>>>> + goto no_translation; >>>>> + } >>>>> + >>>>> + while(level > 0){ >>>>> + /* >>>>> + * check permissions: the bitwise >>>>> + * implication perms -> entry_perms must be true. Pages must be >>>>> present >>>>> + * and permissions on all levels must be similar >>>>> + */ >>>>> + pte_perms = amd_iommu_get_perms(pte); >>>>> + present = pte & 1; >>>>> + if(!present || perms != (perms & pte_perms)){ >>>>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>>>> DEV_DOMID_ID_MASK, addr, present, >>>>> + !!(perms & IOMMU_PERM_WRITE)); >>>>> + return; >>>>> + } >>>>> + >>>>> + /* go to the next lower level */ >>>>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>>>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>>> >>>> >>>> Does this work for six level page tables? The highest level has different >>>> bit size there IIRC. >>>> >>>>> + pte = ldq_phys(&address_space_memory, pte_addr); >>>>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>> + } >>>>> + >>>>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & >>>>> IOMMU_PAGE_MASK_4K; >>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret->perm = IOMMU_RW; >>>>> + return; >>>>> + >>>>> +no_translation: >>>>> + ret->iova = addr; >>>>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret->perm = IOMMU_RW; >>>>> + return; >>>> >>>> >>>> Are you sure these transactions needs to be passed through rather than >>>> target-aborted? >>>> >>>>> +} >>>>> + >>>>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>>>> addr, bool is_write) >>>>> +{ >>>>> + >>>>> + IOMMU_DPRINTF(GENERAL, ""); >>>>> + >>>>> + AMDIOMMUAddressSpace *as = container_of(iommu, >>>>> AMDIOMMUAddressSpace, >>>>> iommu); >>>>> + AMDIOMMUState *s = as->iommu_state; >>>>> + >>>>> + IOMMUTLBEntry ret = { >>>>> + .target_as = &address_space_memory, >>>>> + .iova = addr, >>>>> + .translated_addr = 0, >>>>> + .addr_mask = ~(hwaddr)0, >>>>> + .perm = IOMMU_NONE, >>>>> + }; >>>>> + >>>>> + if(!s->enabled){ >>>>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>>>> provide any parameter */ >>>>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret.perm = IOMMU_RW; >>>>> + return ret; >>>>> + } >>>>> + >>>>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>>>> + >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >>>>> as->bus_num, >>>>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>>>> ret.translated_addr); >>>>> + >>>>> + return ret; >>>>> +} >>>>> + >>>>> +static const MemoryRegionOps mmio_mem_ops = { >>>>> + .read = amd_iommu_mmio_read, >>>>> + .write = amd_iommu_mmio_write, >>>>> + .endianness = DEVICE_LITTLE_ENDIAN, >>>>> + .valid = { >>>>> + .min_access_size = 1, >>>>> + .max_access_size = 8, >>>>> + .unaligned = false, >>>>> + }, >>>>> + >>>>> + .valid = { >>>>> + .min_access_size = 8, >>>>> + .max_access_size = 8, >>>>> + }, >>>>> +}; >>>>> + >>>>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t >>>>> host_pa, >>>>> uint32_t guest_va, uint32_t *reg) >>>>> +{ >>>>> + *reg = 0; >>>> >>>> >>>> Redundant line. >>>> >>>> >>>>> + >>>>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>>>> +} >>>>> + >>>>> +/* FIXME: The similar code in reset and init could be combined into a >>>>> function */ >>>>> +static void amd_iommu_reset(DeviceState *dev) >>>>> +{ >>>>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>>>> + >>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>>>> + uint32_t capab_range = 0xff000000; >>>>> + uint32_t capab_misc = 0x0; >>>>> + >>>>> + /* reset MMIO */ >>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>>>> + /* TODO :Disable event logging and reset all buffers */ >>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>> &capab_misc); >>>>> + >>>>> + /* reset IOMMU specific capabilities */ >>>>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>>>> capab_base_addr_low); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>>>> capab_base_addr_high); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>>>> capab_range); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>>>> capab_misc); >>>> >>>> >>>> >>>> Do we also need to reset MSI capability block? >>>> >>>> >>>>> + >>>>> + /* reset device ident */ >>>>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>>>> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >>>>> + pci_config_set_class(s->dev.config, 0x0806); >>>>> + pci_config_set_prog_interface(s->dev.config, 00); >>>>> +} >>>>> + >>>>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, >>>>> uint32_t >>>>> val, int len) >>>>> +{ >>>>> + pci_default_write_config(dev, addr, val, len); >>>>> +} >>>>> + >>>>> +/* I honestly don't know how to reserve MMIO */ >>>>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>>>> +{ >>>>> + if(s->mmio.addr == addr){ >>>>> + return; >>>>> + } >>>>> + >>>>> +// if(s->mmio.addr != (hwaddr)-1) { >>>>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>>>> +// } >>>>> + >>>>> + s->mmio.addr = addr; >>>>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>>>> + >>>>> +} >>>>> + >>>>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>>>> +{ >>>>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> >>>>> 16); >>>>> + uint32_t capab_range = 0xff000000; >>>>> + uint32_t capab_misc = 0x0; >>>>> + >>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>> &capab_misc); >>>>> + >>>>> + s->iommu_ops.translate = amd_iommu_translate; >>>>> + s->enabled = false; >>>>> + s->ats_enabled = false; >>>>> + s->cmdbuf_enabled = false; >>>>> + s->devtab_len = 0; >>>>> + s->cmdbuf_len = 0; >>>>> + s->cmdbuf_head = 0; >>>>> + s->cmdbuf_tail = 0; >>>>> + s->evtlog_head = 0; >>>>> + s->evtlog_tail = 0; >>>>> + s->excl_enabled = false; >>>>> + s->excl_allow = false; >>>>> + s->mmio_enabled = false; >>>>> + dev->config_write = amd_iommu_write_capab; >>>>> + >>>>> + size_t offset; >>>>> + /* Save offset for IVRS */ >>>>> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, >>>>> 0, >>>>> CAPAB_SIZE); >>>>> + pci_set_long(s->dev.config + offset, capab_header); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>>>> capab_base_addr_low); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>>>> capab_base_addr_high); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>>>> + >>>>> + /* add msi and hypertransport capabilities */ >>>>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>>>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>>>> + >>>>> + /* set up MMIO */ >>>>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>>>> "amd-iommu", MMIO_SIZE); >>>>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>>>> + >>>>> + /* reset device ident */ >>>>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>>>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>>>> + >>>>> + /* may not be necessary */ >>>>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>>>> +{ >>>>> + amd_iommu_pci_initfn(dev); >>>>> +} >>>>> + >>>>> +static const VMStateDescription vmstate_amd_iommu = { >>>>> + .name = "amd-iommu", >>>>> + .fields = (VMStateField[]) { >>>>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>>>> + VMSTATE_END_OF_LIST() >>>>> + } >>>>> +}; >>>>> + >>>>> +static Property amd_iommu_properties[] = { >>>>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>>>> + DEFINE_PROP_END_OF_LIST(), >>>>> +}; >>>>> + >>>>> +/* not used for now but will be when cache is added */ >>>>> +static void amd_iommu_uninit(PCIDevice *dev) >>>>> +{ >>>>> + return; >>>>> +} >>>>> + >>>>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>>>> +{ >>>>> + DeviceClass *dc = DEVICE_CLASS(klass); >>>>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>>>> + >>>>> + pci->realize = amd_iommu_realize; >>>>> + pci->exit = amd_iommu_uninit; >>>>> + >>>>> + dc->reset = amd_iommu_reset; >>>>> + dc->vmsd = &vmstate_amd_iommu; >>>>> + dc->props = amd_iommu_properties; >>>>> +} >>>>> + >>>>> +static const TypeInfo amd_iommu = { >>>>> + .name = TYPE_AMD_IOMMU_DEVICE, >>>>> + .parent = TYPE_PCI_DEVICE, >>>>> + .instance_size = sizeof(AMDIOMMUState), >>>>> + .class_init = amd_iommu_class_init >>>>> +}; >>>>> + >>>>> +static void amd_iommu_register_types(void) >>>>> +{ >>>>> + type_register_static(&amd_iommu); >>>>> +} >>>>> + >>>>> +type_init(amd_iommu_register_types); >>>>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>>>> new file mode 100644 >>>>> index 0000000..90309eb >>>>> --- /dev/null >>>>> +++ b/hw/i386/amd_iommu.h >>>>> @@ -0,0 +1,298 @@ >>>>> +/* >>>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>>> + * >>>>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>>>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>>>> + * >>>>> + * This program is free software; you can redistribute it and/or modify >>>>> + * it under the terms of the GNU General Public License as published by >>>>> + * the Free Software Foundation; either version 2 of the License, or >>>>> + * (at your option) any later version. >>>>> + >>>>> + * This program is distributed in the hope that it will be useful, >>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>>> + * GNU General Public License for more details. >>>>> + >>>>> + * You should have received a copy of the GNU General Public License >>>>> along >>>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>>> + */ >>>>> + >>>>> +#ifndef AMD_IOMMU_H_ >>>>> +#define AMD_IOMMU_H_ >>>>> + >>>>> +#include "hw/hw.h" >>>>> +#include "hw/pci/pci.h" >>>>> +#include "hw/sysbus.h" >>>>> +#include "sysemu/dma.h" >>>>> +#include "qemu/osdep.h" >>>>> +#include "qemu/event_notifier.h" >>>>> + >>>>> +/* Capability registers */ >>>>> +#define CAPAB_HEADER 0x00 >>>>> +#define CAPAB_REV_TYPE 0x02 >>>>> +#define CAPAB_FLAGS 0x03 >>>>> +#define CAPAB_BAR_LOW 0x04 >>>>> +#define CAPAB_BAR_HIGH 0x08 >>>>> +#define CAPAB_RANGE 0x0C >>>>> +#define CAPAB_MISC 0x10 >>>>> +#define CAPAB_MISC1 0x14 >>>>> + >>>>> +#define CAPAB_SIZE 0x18 >>>>> +#define CAPAB_REG_SIZE 0x04 >>>>> + >>>>> +/* Capability header data */ >>>>> +#define CAPAB_FLAT_EXT (1 << 28) >>>>> +#define CAPAB_EFR_SUP (1 << 27) >>>>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>>>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>>>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>>>> +#define CAPAB_INIT_REV (1 << 19) >>>>> +#define CAPAB_INIT_TYPE (3 << 16) >>>>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>>>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>>>> CAPAB_FLAG_HTTUNNEL) >>>>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>>>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>>>> + >>>>> +/* MMIO registers */ >>>>> +#define MMIO_DEVICE_TABLE 0x0000 >>>>> +#define MMIO_COMMAND_BASE 0x0008 >>>>> +#define MMIO_EVENT_BASE 0x0010 >>>>> +#define MMIO_CONTROL 0x0018 >>>>> +#define MMIO_EXCL_BASE 0x0020 >>>>> +#define MMIO_EXCL_LIMIT 0x0028 >>>>> +#define MMIO_EXT_FEATURES 0x0030 >>>>> +#define MMIO_COMMAND_HEAD 0x2000 >>>>> +#define MMIO_COMMAND_TAIL 0x2008 >>>>> +#define MMIO_EVENT_HEAD 0x2010 >>>>> +#define MMIO_EVENT_TAIL 0x2018 >>>>> +#define MMIO_STATUS 0x2020 >>>>> +#define MMIO_PPR_BASE 0x0038 >>>>> +#define MMIO_PPR_HEAD 0x2030 >>>>> +#define MMIO_PPR_TAIL 0x2038 >>>>> + >>>>> +#define MMIO_SIZE 0x4000 >>>>> + >>>>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>>>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>>>> ~MMIO_DEVTAB_SIZE_MASK) >>>>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>>>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>>>> + >>>>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>>>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>>>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>>>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>> + >>>>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>>>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>>>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>>>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>>>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>> + >>>>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>>>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>>>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>>>> + >>>>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>>>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>>>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>>>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>>>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>>>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>>>> + >>>>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>>>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>>>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>>>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>>>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>>>> + >>>>> +#define CMDBUF_ID_BYTE 0x07 >>>>> +#define CMDBUF_ID_RSHIFT 4 >>>>> +#define CMDBUF_ENTRY_SIZE 0x10 >>>>> + >>>>> +#define CMD_COMPLETION_WAIT 0x01 >>>>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>>>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>>>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>>>> +#define CMD_INVAL_INTR_TABLE 0x05 >>>>> + >>>>> +#define DEVTAB_ENTRY_SIZE 32 >>>>> + >>>>> +/* Device table entry bits 0:63 */ >>>>> +#define DEV_VALID (1ULL << 0) >>>>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>>>> +#define DEV_MODE_MASK 0x7 >>>>> +#define DEV_MODE_RSHIFT 9 >>>>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>>>> +#define DEV_PT_ROOT_RSHIFT 12 >>>>> +#define DEV_PERM_SHIFT 61 >>>>> +#define DEV_PERM_READ (1ULL << 61) >>>>> +#define DEV_PERM_WRITE (1ULL << 62) >>>>> + >>>>> +/* Device table entry bits 64:127 */ >>>>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>>>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>>>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>>>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>>>> +#define DEV_IOCTL_MASK (~3) >>>>> +#define DEV_IOCTL_RSHIFT 20 >>>>> +#define DEV_IOCTL_DENY 0 >>>>> +#define DEV_IOCTL_PASSTHROUGH 1 >>>>> +#define DEV_IOCTL_TRANSLATE 2 >>>>> +#define DEV_CACHE (1ULL << 37) >>>>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>>>> +#define DEV_EXCL (1ULL << 39) >>>>> + >>>>> +/* Event codes and flags, as stored in the info field */ >>>>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>>>> +#define EVENT_IOPF (0x2U << 24) >>>>> +#define EVENT_IOPF_I (1U << 3) >>>>> +#define EVENT_IOPF_PR (1U << 4) >>>>> +#define EVENT_IOPF_RW (1U << 5) >>>>> +#define EVENT_IOPF_PE (1U << 6) >>>>> +#define EVENT_IOPF_RZ (1U << 7) >>>>> +#define EVENT_IOPF_TR (1U << 8) >>>>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>>>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>>>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>>>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>>>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>>>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>>>> + >>>>> +#define EVENT_LEN 16 >>>>> + >>>>> +#define IOMMU_PERM_READ (1 << 0) >>>>> +#define IOMMU_PERM_WRITE (1 << 1) >>>>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | >>>>> IOMMU_PERM_WRITE) >>>>> + >>>>> +/* AMD RD890 Chipset */ >>>>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>>>> + >>>>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>>>> register */ >>>>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>>>> register */ >>>>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>>>> register */ >>>>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>>>> */ >>>>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >>>>> register 0 */ >>>>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >>>>> register 1 */ >>>>> + >>>>> +#define FEATURE_PREFETCH (1ULL<<0) >>>>> +#define FEATURE_PPR (1ULL<<1) >>>>> +#define FEATURE_NX (1ULL<<3) >>>>> +#define FEATURE_GT (1ULL<<4) >>>>> +#define FEATURE_IA (1ULL<<6) >>>>> +#define FEATURE_GA (1ULL<<7) >>>>> +#define FEATURE_HE (1ULL<<8) >>>>> +#define FEATURE_PC (1ULL<<9) >>>>> + >>>>> +/* IOMMU paging mode */ >>>>> +#define GATS_MODE (6ULL << 12) >>>>> +#define HATS_MODE (6ULL << 10) >>>>> +/* PCI SIG constants */ >>>>> +#define PCI_BUS_MAX 256 >>>>> +#define PCI_SLOT_MAX 32 >>>>> +#define PCI_FUNC_MAX 8 >>>>> +#define PCI_DEVFN_MAX 256 >>>>> + >>>>> +/* extended feature support */ >>>>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>>>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | >>>>> HATS_MODE ) >>>>> + >>>>> +/* capabilities header */ >>>>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>>>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | >>>>> CAPAB_FLAG_HTTUNNEL >>>>> | CAPAB_EFR_SUP) >>>>> + >>>>> +/* command constants */ >>>>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>>>> +#define COM_COMPLETION_STORE_MASK 0x1 >>>>> +#define COM_COMPLETION_INTR 0x2 >>>>> +#define COM_COMPLETION_DATA_OFF 0x8 >>>>> +#define IOMMU_COMMAND_SIZE 0x10 >>>>> + >>>>> +/* IOMMU default address */ >>>>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>>>> + >>>>> +/* page management constants */ >>>>> +#define IOMMU_PAGE_SHIFT 12 >>>>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>>>> + >>>>> +#define IOMMU_PAGE_SHIFT_4K 12 >>>>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>>>> +#define IOMMU_PAGE_SHIFT_2M 21 >>>>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>>>> +#define IOMMU_PAGE_SHIFT_1G 30 >>>>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>>>> + >>>>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>>>> +#define AMD_IOMMU_DEVICE(obj)\ >>>>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>>>> + >>>>> +typedef struct AMDIOMMUState AMDIOMMUState; >>>>> + >>>>> +typedef struct AMDIOMMUAddressSpace{ >>>>> + uint8_t bus_num; /* bus number >>>>> */ >>>>> + uint8_t devfn; /* device function >>>>> */ >>>>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>>>> */ >>>>> + MemoryRegion iommu; /* Device's iommu region >>>>> */ >>>>> + AddressSpace as; /* device's corresponding address space >>>>> */ >>>>> +}AMDIOMMUAddressSpace; >>>>> + >>>>> +struct AMDIOMMUState { >>>>> + PCIDevice dev; /* The PCI device itself */ >>>>> + >>>>> + uint32_t version; >>>>> + >>>>> + int capab_offset; /* capability offset pointer */ >>>>> + unsigned char *capab; /* capabilities registers */ >>>>> + >>>>> + bool enabled; /* IOMMU enabled */ >>>>> + bool ats_enabled; /* address translation enabled */ >>>>> + bool cmdbuf_enabled; /* command buffer enabled */ >>>>> + bool evtlog_enabled; /* event log enabled */ >>>>> + bool excl_enabled; >>>>> + >>>>> + dma_addr_t devtab; /* base address device table */ >>>>> + size_t devtab_len; /* device table length */ >>>>> + >>>>> + dma_addr_t cmdbuf; /* command buffer base address */ >>>>> + uint64_t cmdbuf_len; /* command buffer length */ >>>>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>>>> + unsigned cmdbuf_tail; /* next Software write position */ >>>>> + int completion_wait_intr; >>>>> + >>>>> + dma_addr_t evtlog; /* base address event log */ >>>>> + size_t evtlog_intr; >>>>> + size_t evtlog_len; /* event log length */ >>>>> + size_t evtlog_head; /* event log head */ >>>>> + size_t evtlog_tail; /* event log tail */ >>>>> + >>>>> + /* unused for now */ >>>>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >>>>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >>>>> + bool excl_allow; /* translate accesses to the exclusion >>>>> range */ >>>>> + bool excl_enable; /* exclusion range enabled */ >>>>> + >>>>> + MemoryRegion mmio; /* MMIO region */ >>>>> + unsigned char mmior[MMIO_SIZE]; >>>>> + bool mmio_enabled; >>>>> + >>>>> + /* IOMMU function */ >>>>> + MemoryRegionIOMMUOps iommu_ops; >>>>> + >>>>> + /* for each served device */ >>>>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>>>> +}; >>>>> + >>>>> +typedef struct AMDIOMMUEvent { >>>>> + uint16_t devfn; >>>>> + uint16_t reserved; >>>>> + uint16_t domid; >>>>> + uint16_t info; >>>>> + uint16_t addr; >>>>> +} __attribute__((packed)) AMDIOMMUEvent; >>>>> + >>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>> devfn); >>>>> + >>>>> +#endif >>>>> >>>> >>>> Regards, >>>> Valentine >> >> >> -- >> С уважением, >> Синицын Валентин ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-09 8:07 ` Valentine Sinitsyn @ 2015-09-09 8:12 ` David kiarie 2015-09-09 8:14 ` Valentine Sinitsyn 0 siblings, 1 reply; 22+ messages in thread From: David kiarie @ 2015-09-09 8:12 UTC (permalink / raw) To: Valentine Sinitsyn; +Cc: Jan Kiszka, QEMU Developers, mst I wrote something basic on the cover letter http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg02759.html On Wed, Sep 9, 2015 at 11:07 AM, Valentine Sinitsyn <valentine.sinitsyn@gmail.com> wrote: > On 09.09.2015 12:59, David kiarie wrote: >> >> On Wed, Sep 9, 2015 at 10:45 AM, Valentine Sinitsyn >> <valentine.sinitsyn@gmail.com> wrote: >>> >>> On 09.09.2015 12:30, David kiarie wrote: >>> ...snip... >>> >>> >>>>>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>>>>> +{ >>>>>> + unsigned type; >>>>>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>>>>> + >>>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>>>>> + >>>>>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + >>>>>> s->cmdbuf_head, >>>>>> cmd, IOMMU_COMMAND_SIZE)){ >>>>>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>>>>> 0x%"PRIx64 >>>>>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>>>>> + } >>>>>> + >>>>>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>>>>> + >>>>>> + switch(type){ >>>>>> + case CMD_COMPLETION_WAIT: >>>>>> + /* pretend to wait for command execution to complete */ >>>>>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>>>>> + amd_iommu_completion_wait(s, cmd); >>>>>> + break; >>>>>> + case CMD_INVAL_DEVTAB_ENTRY: >>>>>> + /* Not implemented yet - should just clear device table >>>>>> contents */ >>>>>> + IOMMU_DPRINTF(COMMAND, "device table entries >>>>>> invalidated"); >>>>> >>>>> >>>>> >>>>> Better make it clear that these commands are not implemented yet. An >>>>> IOMMU >>>>> is hardly usable without invalidators. >>>> >>>> >>>> >>>> I think the "debug prinft" here is misleading. AFAIK, the commands >>>> listed here(there are others which I haven't listed) relate to 'cache' >>>> which means this commands do nothing in the absence of cache. >>>> >>>> The reason why I advertise 'cache' is because the linux driver checks >>>> for cache and other optional features to determine the IOMMU version >>>> whereby versions 2 of IOMMU are assummed to support this features. >>> >>> >>> Did you check how address translation is emulated in QEMU. I didn't :) >>> But >>> you return IOMMTLBEntry from your translation routine, and I'd rather >>> ensure >>> it is not cached in some other layer. >> >> >> Am expected to cache the IOMMUTLBEntries myself, probably through a >> hashtable. Also, that's what emulated VT-d in Qemu does. >> >>> >>> Besides, omitting invalidation commands will be a problem on real >>> hardware. >>> As IOMMU emulation is mainly useful for debugging, I'd reproduce this >>> behaviour in the emulator. I mean, if I forget to do >>> CMD_INVAL_DEVTAB_ENTRY >>> in my guest code, things shouldn't work properly. >> >> >> Yes, 'cache' is important for debugging. I or someone else could work >> on cache, now or later. >> >>> >>> You can just copy all data structures to AMDIOMMUState and use this >>> "cahced" >>> copies, updated when you run invalidation commands. But this isn't a #1 >>> priority, you are right. >>> >>> Can you share some tests results for this code? >> >> >> Do you mean the whole IOMMU?It works, as far as am concerned. I got >> was able to 'passthrough' a sound device but that's the only device I >> tested. > > That's great. Could you describe your tests setup, please? Maybe in README > or in the cover letter, so anyone interested could reproduce it just > following your steps. > > Valentine > > >> >>> >>>> >>>>> >>>>>> + break; >>>>>> + case CMD_INVAL_IOMMU_PAGES: >>>>>> + /* invalidate IOMMU cache for a particular domain */ >>>>>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>>>>> + break; >>>>>> + case CMD_INVAL_IOTLB_PAGES: >>>>>> + /* Only present if remote IOTLB present */ >>>>>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>>>>> + break; >>>>>> + case CMD_INVAL_INTR_TABLE: >>>>>> + /* no support for interrupt remapping yet */ >>>>>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>>>>> + break; >>>>>> + default: >>>>>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>>>>> + break; >>>>>> + } >>>>>> + >>>>>> +} >>>>>> + >>>>>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>>>>> +{ >>>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>>> + >>>>>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + >>>>>> MMIO_COMMAND_HEAD; >>>>>> + >>>>>> + if(!s->cmdbuf_enabled){ >>>>>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>>>>> + return; >>>>>> + } >>>>>> + >>>>>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>>>>> + /* check if there is work to do. */ >>>>>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND >>>>>> BUFFER >>>>>> tail at %x", >>>>>> + s->cmdbuf_head, s->cmdbuf_tail); >>>>>> + amd_iommu_cmdbuf_exec(s); >>>>>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>>>>> + >>>>>> + /* wrap head pointer */ >>>>>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>>>>> + s->cmdbuf_head = 0; >>>>>> + } >>>>>> + } >>>>>> + >>>>>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>>>>> +} >>>>>> + >>>>>> +/* System Software might never read from some of this fields but >>>>>> anyways >>>>>> */ >>>>>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, >>>>>> unsigned >>>>>> size) >>>>>> +{ >>>>>> + AMDIOMMUState *s = opaque; >>>>>> + >>>>>> + uint64_t val = -1; >>>>>> + if(addr + size > MMIO_SIZE) { >>>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max >>>>>> 0x%"PRIX64 >>>>>> + ", got 0x%"PRIx64 " %d", >>>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>>> + return (uint64_t) - 1; >>>>>> + } >>>>>> + >>>>>> + switch(addr & ~0x07){ >>>>>> + case MMIO_DEVICE_TABLE: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>> >>>>> >>>>> >>>>> What makes these cases different, except debug printf()s? Maybe leave >>>>> printf()s inside the switch, and factor out the rest. This applies to >>>>> other >>>>> similar cases as well. >>>>> >>>>> >>>>>> + >>>>>> + case MMIO_COMMAND_BASE: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EVENT_BASE: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_CONTROL: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EXCL_BASE: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EXCL_LIMIT: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_COMMAND_HEAD: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_COMMAND_TAIL: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EVENT_HEAD: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EVENT_TAIL: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_STATUS: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EXT_FEATURES: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + if(size == 2){ >>>>>> + val = amd_iommu_readw(s, addr); >>>>>> + } else if(size == 4){ >>>>>> + val = amd_iommu_readl(s, addr); >>>>>> + } >>>>>> + else if(size == 8){ >>>>>> + val = amd_iommu_readq(s, addr); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + default: >>>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>> offset); >>>>>> + } >>>>>> + >>>>>> + return val; >>>>>> +} >>>>>> + >>>>>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>>>>> +{ >>>>>> + /* read whatever is already written incase software is writing in >>>>>> chucks less than 8 bytes */ >>>>>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>>>>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>>>>> + >>>>>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>>>>> + s->evtlog_enabled = s->enabled && !!(control & >>>>>> MMIO_CONTROL_EVENTLOGEN); >>>>>> + >>>>>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>>>>> + s->completion_wait_intr = !!(control & >>>>>> MMIO_CONTROL_COMWAITINTEN); >>>>>> + s->cmdbuf_enabled = s->enabled && !!(control & >>>>>> MMIO_CONTROL_CMDBUFLEN); >>>>>> + >>>>>> + /* update the flags depending on the control register */ >>>>>> + if(s->cmdbuf_enabled) { >>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= >>>>>> MMIO_STATUS_CMDBUF_RUN; >>>>>> + } else { >>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>>> ~MMIO_STATUS_CMDBUF_RUN; >>>>>> + } >>>>>> + if (s->evtlog_enabled) { >>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= >>>>>> MMIO_STATUS_EVTLOG_RUN; >>>>>> + } else { >>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>>> ~MMIO_STATUS_EVTLOG_RUN; >>>>>> + } >>>>>> + >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>>>>> + >>>>>> + amd_iommu_cmdbuf_run(s); >>>>> >>>>> >>>>> >>>>> Does any write to control register result in draining command buffer? >>>>> To >>>>> me, >>>>> it looks strange, and I'd expect IOMMU to execute commands only if I >>>>> change >>>>> tail pointer. >>>>> >>>>> >>>>>> +} >>>>>> + >>>>>> +/* FIXME: something might go wrong if System Software writes in >>>>>> chunks >>>>>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>>>>> + * works correctly with linux but will definitely be busted if >>>>>> software >>>>>> + * reads/writes 8 bytes >>>>>> + */ >>>>>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t >>>>>> val, >>>>>> unsigned size) >>>>>> +{ >>>>>> + >>>>>> + AMDIOMMUState *s = opaque; >>>>>> + unsigned long offset = addr & 0x07; >>>>>> + >>>>>> + if(addr + size > MMIO_SIZE) { >>>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max >>>>>> 0x%"PRIx64 >>>>>> + ", got 0x%"PRIx64 " %d", >>>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>>> + return; >>>>>> + } >>>>>> + >>>>>> + switch(addr & ~0x07){ >>>>>> + case MMIO_CONTROL: >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64 >>>>>> , addr, size, val, offset); >>>>>> + iommu_handle_control_write(s); >>>>>> + break; >>>>>> + >>>>>> + case MMIO_DEVICE_TABLE: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + >>>>>> + /* set device table address >>>>>> + * This also suffers from inability to tell whether >>>>>> software >>>>>> is done writing >>>>>> + */ >>>>>> + if(offset || (size == 8)){ >>>>>> + unsigned long device_base = amd_iommu_readq(s, >>>>>> MMIO_DEVICE_TABLE); >>>>>> + s->devtab = (dma_addr_t)(device_base & >>>>>> MMIO_CMDBUF_BASE_MASK); >>>>>> + /* set device table length */ >>>>>> + s->devtab_len = ((device_base & >>>>>> MMIO_DEVTAB_SIZE_MASK) >>>>>> + >>>>>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>>>>> + MMIO_DEVTAB_ENTRY_SIZE); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_COMMAND_HEAD: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>>>>> + amd_iommu_cmdbuf_run(s); >>>>>> + break; >>>>>> + >>>>>> + case MMIO_COMMAND_BASE: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + >>>>>> + /* FIXME - make sure System Software has finished writing >>>>>> incase it writes >>>>>> + * in chucks less than 8 bytes in a robust way.As for >>>>>> now, >>>>>> this hacks works >>>>>> + * for the linux driver >>>>>> + */ >>>>>> + if(offset || (size == 8)){ >>>>>> + unsigned long command_base = amd_iommu_readq(s, >>>>>> MMIO_COMMAND_BASE); >>>>>> + s->cmdbuf = (dma_addr_t)(command_base & >>>>>> MMIO_CMDBUF_BASE_MASK); >>>>>> + s->cmdbuf_len = 1UL << >>>>>> (s->mmior[MMIO_CMDBUF_SIZE_BYTE] >>>>>> & >>>>>> MMIO_CMDBUF_SIZE_MASK); >>>>>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_COMMAND_TAIL: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + >>>>>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>>>>> + amd_iommu_cmdbuf_run(s); >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EVENT_BASE: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>>>>> + s->evtlog_len = 1UL << >>>>>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & >>>>>> MMIO_EVTLOG_SIZE_MASK); >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EXCL_LIMIT: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>>>>> MMIO_EXCL_LIMIT_LOW; >>>>>> + break; >>>>>> + //TODO : Event handling fixes >>>>>> + >>>>>> + case MMIO_EVENT_HEAD: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + case MMIO_EVENT_TAIL: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr >>>>>> 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + break; >>>>>> + /* PPR log base - unused for now */ >>>>>> + case MMIO_PPR_BASE: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + break; >>>>>> + /* PPR log head - also unused for now */ >>>>>> + case MMIO_PPR_HEAD: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + break; >>>>>> + /* PPR log tail - unused for now */ >>>>>> + case MMIO_PPR_TAIL: >>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + if(size == 2){ >>>>>> + amd_iommu_writew(s, addr, val); >>>>>> + } else if(size == 4){ >>>>>> + amd_iommu_writel(s, addr, val); >>>>>> + } else if(size == 8){ >>>>>> + amd_iommu_writeq(s, addr, val); >>>>>> + } >>>>>> + break; >>>>>> + >>>>>> + default: >>>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>> + ; >>>>>> + } >>>>>> + >>>>>> +} >>>>>> + >>>>>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>>>>> +{ >>>>>> + /* event logging not enabled */ >>>>>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>>>>> MMIO_STATUS_EVTLOG_OF){ >>>>>> + return; >>>>>> + } >>>>>> + >>>>>> + /* event log buffer full */ >>>>>> + if(s->evtlog_tail >= s->evtlog_len) { >>>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>>>>> + } >>>>>> + >>>>>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>>>>> s->evtlog_tail, &evt, EVENT_LEN)){ >>>>>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>>>> 0%x"PRIu8, >>>>>> s->evtlog + s->evtlog_tail); >>>>>> + } >>>>>> + >>>>>> + s->evtlog_tail += EVENT_LEN; >>>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>>>>> + /* Disable logging if Overflow ? */ >>>>> >>>>> >>>>> >>>>> No, the spec details event logging restart procedure. Make sure >>>>> emulated >>>>> IOMMU behaves as described there. >>>>> >>>>> >>>>>> +} >>>>>> + >>>>>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, >>>>>> unsigned >>>>>> domid, dma_addr_t addr, int present, >>>>>> + int is_write) >>>>>> +{ >>>>>> + IOMMU_DPRINTF(ELOG, ""); >>>>>> + >>>>>> + AMDIOMMUEvent evt; >>>>>> + unsigned info; >>>>>> + uint16_t status; >>>>>> + >>>>>> + evt.devfn = cpu_to_le16(devfn); >>>>>> + evt.reserved = 0; >>>>>> + evt.domid = cpu_to_le16(domid); >>>>>> + evt.addr = cpu_to_le16(addr); >>>>>> + >>>>>> + info = EVENT_IOPF; >>>>>> + >>>>>> + if(present) { >>>>>> + info |= EVENT_IOPF_PR; >>>>>> + } >>>>>> + >>>>>> + if (is_write) { >>>>>> + info |= EVENT_IOPF_RW; >>>>>> + } >>>>>> + >>>>>> + /* log a page fault */ >>>>>> + amd_iommu_log_event(s, &evt); >>>>>> + >>>>>> + /* Abort the translation */ >>>>>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>>>>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>>>>> PCI_STATUS_SIG_TARGET_ABORT); >>>>>> +} >>>>>> + >>>>>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>>>>> +{ >>>>>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> >>>>>> DEV_PERM_SHIFT; >>>>>> +} >>>>>> + >>>>>> +/* FIXME deduplication */ >>>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>>> devfn) >>>>>> +{ >>>>>> + AMDIOMMUState *s = opaque; >>>>>> + AMDIOMMUAddressSpace **iommu_as; >>>>>> + int bus_num = pci_bus_num(bus); >>>>>> + >>>>>> + /* just in case */ >>>>>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>>>>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>>>>> + >>>>>> + iommu_as = s->address_spaces[bus_num]; >>>>>> + >>>>>> + /* allocate memory during the first run */ >>>>>> + if(!iommu_as) { >>>>>> + iommu_as = >>>>>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>>>>> + s->address_spaces[bus_num] = iommu_as; >>>>>> + } >>>>>> + >>>>>> + /* set up IOMMU region */ >>>>>> + if(!iommu_as[devfn]){ >>>>>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>>>>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>>>>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>>>>> + iommu_as[devfn]->iommu_state = s; >>>>>> + >>>>>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>>>>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>>>>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>>>>> "amd-iommu"); >>>>>> + } >>>>>> + return &iommu_as[devfn]->as; >>>>>> +} >>>>>> + >>>>>> +/* validate a page table entry */ >>>>>> +static bool amd_iommu_validate_pte(uint64_t pte) >>>>>> +{ >>>>>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>>>> >>>>> >>>>> >>>>> I'd suggest parenthesis here. >>>>> >>>>> >>>>>> +} >>>>>> + >>>>>> +/* get a device table entry given the device function */ >>>>>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>>>>> *entry) >>>>>> +{ >>>>>> + /* Could lead to out of range accesses */ >>>>>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>>>>> + >>>>>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>>>>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, >>>>>> entry, >>>>>> 32)){ >>>>>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>>>>> 0x%"PRIx64 >>>>>> + "offset 0x%"PRIx32, s->devtab, offset); >>>>>> + return false; >>>>>> + } >>>>>> + >>>>>> + if(!amd_iommu_validate_pte(entry[0])){ >>>>>> + IOMMU_DPRINTF(MMU, >>>>>> + "Pte entry at 0x%"PRIx64" is invalid", >>>>>> entry[0]); >>>>>> + return false; >>>>>> + } >>>>>> + >>>>>> + return true; >>>>>> +} >>>>>> + >>>>>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>>>>> +{ >>>>>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>>> + >>>>>> + if(level == 7){ >>>>>> + /* reserved level - abort ? */ >>>>>> + IOMMU_DPRINTF(MMU, >>>>>> + "Reserved translation level (7) detected"); >>>>>> + return 0; >>>>>> + } >>>>>> + >>>>>> + return level; >>>>>> +} >>>>>> + >>>>>> +/* TODO : Mark addresses as Accessed and Dirty */ >>>>>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr >>>>>> addr, >>>>>> bool is_write, IOMMUTLBEntry *ret) >>>>>> +{ >>>>>> + AMDIOMMUState *s = as->iommu_state; >>>>>> + >>>>>> + int present; >>>>>> + dma_addr_t pte_addr; >>>>>> + uint64_t entry[4], pte, pte_perms; >>>>>> + unsigned level; >>>>>> + unsigned perms; >>>>>> + >>>>>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>>>>> + goto no_translation; >>>>>> + } >>>>>> + >>>>>> + pte = entry[0]; >>>>>> + >>>>>> + /* >>>>>> + * It's okay to check for either read or write permissions >>>>>> + * even for memory maps, since we don't support R/W maps. >>>>>> + */ >>>>>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>>>>> + >>>>>> + if(!(level = get_pte_translation_mode(pte))){ >>>>>> + goto no_translation; >>>>>> + } >>>>>> + >>>>>> + while(level > 0){ >>>>>> + /* >>>>>> + * check permissions: the bitwise >>>>>> + * implication perms -> entry_perms must be true. Pages must >>>>>> be >>>>>> present >>>>>> + * and permissions on all levels must be similar >>>>>> + */ >>>>>> + pte_perms = amd_iommu_get_perms(pte); >>>>>> + present = pte & 1; >>>>>> + if(!present || perms != (perms & pte_perms)){ >>>>>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>>>>> DEV_DOMID_ID_MASK, addr, present, >>>>>> + !!(perms & IOMMU_PERM_WRITE)); >>>>>> + return; >>>>>> + } >>>>>> + >>>>>> + /* go to the next lower level */ >>>>>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>>>>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>>>> >>>>> >>>>> >>>>> Does this work for six level page tables? The highest level has >>>>> different >>>>> bit size there IIRC. >>>>> >>>>>> + pte = ldq_phys(&address_space_memory, pte_addr); >>>>>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>>> + } >>>>>> + >>>>>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>>>>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & >>>>>> IOMMU_PAGE_MASK_4K; >>>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>> + ret->perm = IOMMU_RW; >>>>>> + return; >>>>>> + >>>>>> +no_translation: >>>>>> + ret->iova = addr; >>>>>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>> + ret->perm = IOMMU_RW; >>>>>> + return; >>>>> >>>>> >>>>> >>>>> Are you sure these transactions needs to be passed through rather than >>>>> target-aborted? >>>>> >>>>>> +} >>>>>> + >>>>>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>>>>> addr, bool is_write) >>>>>> +{ >>>>>> + >>>>>> + IOMMU_DPRINTF(GENERAL, ""); >>>>>> + >>>>>> + AMDIOMMUAddressSpace *as = container_of(iommu, >>>>>> AMDIOMMUAddressSpace, >>>>>> iommu); >>>>>> + AMDIOMMUState *s = as->iommu_state; >>>>>> + >>>>>> + IOMMUTLBEntry ret = { >>>>>> + .target_as = &address_space_memory, >>>>>> + .iova = addr, >>>>>> + .translated_addr = 0, >>>>>> + .addr_mask = ~(hwaddr)0, >>>>>> + .perm = IOMMU_NONE, >>>>>> + }; >>>>>> + >>>>>> + if(!s->enabled){ >>>>>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>>>>> provide any parameter */ >>>>>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>>>>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>> + ret.perm = IOMMU_RW; >>>>>> + return ret; >>>>>> + } >>>>>> + >>>>>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>>>>> + >>>>>> + IOMMU_DPRINTF(MMU, >>>>>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa >>>>>> 0x%"PRIx64, >>>>>> as->bus_num, >>>>>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>>>>> ret.translated_addr); >>>>>> + >>>>>> + return ret; >>>>>> +} >>>>>> + >>>>>> +static const MemoryRegionOps mmio_mem_ops = { >>>>>> + .read = amd_iommu_mmio_read, >>>>>> + .write = amd_iommu_mmio_write, >>>>>> + .endianness = DEVICE_LITTLE_ENDIAN, >>>>>> + .valid = { >>>>>> + .min_access_size = 1, >>>>>> + .max_access_size = 8, >>>>>> + .unaligned = false, >>>>>> + }, >>>>>> + >>>>>> + .valid = { >>>>>> + .min_access_size = 8, >>>>>> + .max_access_size = 8, >>>>>> + }, >>>>>> +}; >>>>>> + >>>>>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t >>>>>> host_pa, >>>>>> uint32_t guest_va, uint32_t *reg) >>>>>> +{ >>>>>> + *reg = 0; >>>>> >>>>> >>>>> >>>>> Redundant line. >>>>> >>>>> >>>>>> + >>>>>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>>>>> +} >>>>>> + >>>>>> +/* FIXME: The similar code in reset and init could be combined into a >>>>>> function */ >>>>>> +static void amd_iommu_reset(DeviceState *dev) >>>>>> +{ >>>>>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>>>>> + >>>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>>>>> + uint32_t capab_range = 0xff000000; >>>>>> + uint32_t capab_misc = 0x0; >>>>>> + >>>>>> + /* reset MMIO */ >>>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>>>>> + /* TODO :Disable event logging and reset all buffers */ >>>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>>> &capab_misc); >>>>>> + >>>>>> + /* reset IOMMU specific capabilities */ >>>>>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>>>>> capab_base_addr_low); >>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>>>>> capab_base_addr_high); >>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>>>>> capab_range); >>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>>>>> capab_misc); >>>>> >>>>> >>>>> >>>>> >>>>> Do we also need to reset MSI capability block? >>>>> >>>>> >>>>>> + >>>>>> + /* reset device ident */ >>>>>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>>>>> + pci_config_set_device_id(s->dev.config, >>>>>> PCI_DEVICE_ID_RD890_IOMMU); >>>>>> + pci_config_set_class(s->dev.config, 0x0806); >>>>>> + pci_config_set_prog_interface(s->dev.config, 00); >>>>>> +} >>>>>> + >>>>>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, >>>>>> uint32_t >>>>>> val, int len) >>>>>> +{ >>>>>> + pci_default_write_config(dev, addr, val, len); >>>>>> +} >>>>>> + >>>>>> +/* I honestly don't know how to reserve MMIO */ >>>>>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>>>>> +{ >>>>>> + if(s->mmio.addr == addr){ >>>>>> + return; >>>>>> + } >>>>>> + >>>>>> +// if(s->mmio.addr != (hwaddr)-1) { >>>>>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>>>>> +// } >>>>>> + >>>>>> + s->mmio.addr = addr; >>>>>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>>>>> + >>>>>> +} >>>>>> + >>>>>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>>>>> +{ >>>>>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> >>>>>> 16); >>>>>> + uint32_t capab_range = 0xff000000; >>>>>> + uint32_t capab_misc = 0x0; >>>>>> + >>>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>>> &capab_misc); >>>>>> + >>>>>> + s->iommu_ops.translate = amd_iommu_translate; >>>>>> + s->enabled = false; >>>>>> + s->ats_enabled = false; >>>>>> + s->cmdbuf_enabled = false; >>>>>> + s->devtab_len = 0; >>>>>> + s->cmdbuf_len = 0; >>>>>> + s->cmdbuf_head = 0; >>>>>> + s->cmdbuf_tail = 0; >>>>>> + s->evtlog_head = 0; >>>>>> + s->evtlog_tail = 0; >>>>>> + s->excl_enabled = false; >>>>>> + s->excl_allow = false; >>>>>> + s->mmio_enabled = false; >>>>>> + dev->config_write = amd_iommu_write_capab; >>>>>> + >>>>>> + size_t offset; >>>>>> + /* Save offset for IVRS */ >>>>>> + s->capab_offset = offset = pci_add_capability(dev, >>>>>> PCI_CAP_ID_SEC, >>>>>> 0, >>>>>> CAPAB_SIZE); >>>>>> + pci_set_long(s->dev.config + offset, capab_header); >>>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>>>>> capab_base_addr_low); >>>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>>>>> capab_base_addr_high); >>>>>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>>>>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>>>>> + >>>>>> + /* add msi and hypertransport capabilities */ >>>>>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>>>>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>>>>> + >>>>>> + /* set up MMIO */ >>>>>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>>>>> "amd-iommu", MMIO_SIZE); >>>>>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>>>>> + >>>>>> + /* reset device ident */ >>>>>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>>>>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>>>>> + >>>>>> + /* may not be necessary */ >>>>>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>>>>> + >>>>>> + return 0; >>>>>> +} >>>>>> + >>>>>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>>>>> +{ >>>>>> + amd_iommu_pci_initfn(dev); >>>>>> +} >>>>>> + >>>>>> +static const VMStateDescription vmstate_amd_iommu = { >>>>>> + .name = "amd-iommu", >>>>>> + .fields = (VMStateField[]) { >>>>>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>>>>> + VMSTATE_END_OF_LIST() >>>>>> + } >>>>>> +}; >>>>>> + >>>>>> +static Property amd_iommu_properties[] = { >>>>>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>>>>> + DEFINE_PROP_END_OF_LIST(), >>>>>> +}; >>>>>> + >>>>>> +/* not used for now but will be when cache is added */ >>>>>> +static void amd_iommu_uninit(PCIDevice *dev) >>>>>> +{ >>>>>> + return; >>>>>> +} >>>>>> + >>>>>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>>>>> +{ >>>>>> + DeviceClass *dc = DEVICE_CLASS(klass); >>>>>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>>>>> + >>>>>> + pci->realize = amd_iommu_realize; >>>>>> + pci->exit = amd_iommu_uninit; >>>>>> + >>>>>> + dc->reset = amd_iommu_reset; >>>>>> + dc->vmsd = &vmstate_amd_iommu; >>>>>> + dc->props = amd_iommu_properties; >>>>>> +} >>>>>> + >>>>>> +static const TypeInfo amd_iommu = { >>>>>> + .name = TYPE_AMD_IOMMU_DEVICE, >>>>>> + .parent = TYPE_PCI_DEVICE, >>>>>> + .instance_size = sizeof(AMDIOMMUState), >>>>>> + .class_init = amd_iommu_class_init >>>>>> +}; >>>>>> + >>>>>> +static void amd_iommu_register_types(void) >>>>>> +{ >>>>>> + type_register_static(&amd_iommu); >>>>>> +} >>>>>> + >>>>>> +type_init(amd_iommu_register_types); >>>>>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>>>>> new file mode 100644 >>>>>> index 0000000..90309eb >>>>>> --- /dev/null >>>>>> +++ b/hw/i386/amd_iommu.h >>>>>> @@ -0,0 +1,298 @@ >>>>>> +/* >>>>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>>>> + * >>>>>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>>>>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>>>>> + * >>>>>> + * This program is free software; you can redistribute it and/or >>>>>> modify >>>>>> + * it under the terms of the GNU General Public License as published >>>>>> by >>>>>> + * the Free Software Foundation; either version 2 of the License, or >>>>>> + * (at your option) any later version. >>>>>> + >>>>>> + * This program is distributed in the hope that it will be useful, >>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>>>> + * GNU General Public License for more details. >>>>>> + >>>>>> + * You should have received a copy of the GNU General Public License >>>>>> along >>>>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>>>> + */ >>>>>> + >>>>>> +#ifndef AMD_IOMMU_H_ >>>>>> +#define AMD_IOMMU_H_ >>>>>> + >>>>>> +#include "hw/hw.h" >>>>>> +#include "hw/pci/pci.h" >>>>>> +#include "hw/sysbus.h" >>>>>> +#include "sysemu/dma.h" >>>>>> +#include "qemu/osdep.h" >>>>>> +#include "qemu/event_notifier.h" >>>>>> + >>>>>> +/* Capability registers */ >>>>>> +#define CAPAB_HEADER 0x00 >>>>>> +#define CAPAB_REV_TYPE 0x02 >>>>>> +#define CAPAB_FLAGS 0x03 >>>>>> +#define CAPAB_BAR_LOW 0x04 >>>>>> +#define CAPAB_BAR_HIGH 0x08 >>>>>> +#define CAPAB_RANGE 0x0C >>>>>> +#define CAPAB_MISC 0x10 >>>>>> +#define CAPAB_MISC1 0x14 >>>>>> + >>>>>> +#define CAPAB_SIZE 0x18 >>>>>> +#define CAPAB_REG_SIZE 0x04 >>>>>> + >>>>>> +/* Capability header data */ >>>>>> +#define CAPAB_FLAT_EXT (1 << 28) >>>>>> +#define CAPAB_EFR_SUP (1 << 27) >>>>>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>>>>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>>>>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>>>>> +#define CAPAB_INIT_REV (1 << 19) >>>>>> +#define CAPAB_INIT_TYPE (3 << 16) >>>>>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>>>>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>>>>> CAPAB_FLAG_HTTUNNEL) >>>>>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>>>>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>>>>> + >>>>>> +/* MMIO registers */ >>>>>> +#define MMIO_DEVICE_TABLE 0x0000 >>>>>> +#define MMIO_COMMAND_BASE 0x0008 >>>>>> +#define MMIO_EVENT_BASE 0x0010 >>>>>> +#define MMIO_CONTROL 0x0018 >>>>>> +#define MMIO_EXCL_BASE 0x0020 >>>>>> +#define MMIO_EXCL_LIMIT 0x0028 >>>>>> +#define MMIO_EXT_FEATURES 0x0030 >>>>>> +#define MMIO_COMMAND_HEAD 0x2000 >>>>>> +#define MMIO_COMMAND_TAIL 0x2008 >>>>>> +#define MMIO_EVENT_HEAD 0x2010 >>>>>> +#define MMIO_EVENT_TAIL 0x2018 >>>>>> +#define MMIO_STATUS 0x2020 >>>>>> +#define MMIO_PPR_BASE 0x0038 >>>>>> +#define MMIO_PPR_HEAD 0x2030 >>>>>> +#define MMIO_PPR_TAIL 0x2038 >>>>>> + >>>>>> +#define MMIO_SIZE 0x4000 >>>>>> + >>>>>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>>>>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>>>>> ~MMIO_DEVTAB_SIZE_MASK) >>>>>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>>>>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>>>>> + >>>>>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>>>>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>>>>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>>>>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>>> + >>>>>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>>>>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>>>>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>>>>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>>>>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>>> + >>>>>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>>>>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>>>>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>>>>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>>>>> + >>>>>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>>>>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>>>>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>>>>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>>>>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>>>>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>>>>> + >>>>>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>>>>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>>>>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>>>>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>>>>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>>>>> + >>>>>> +#define CMDBUF_ID_BYTE 0x07 >>>>>> +#define CMDBUF_ID_RSHIFT 4 >>>>>> +#define CMDBUF_ENTRY_SIZE 0x10 >>>>>> + >>>>>> +#define CMD_COMPLETION_WAIT 0x01 >>>>>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>>>>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>>>>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>>>>> +#define CMD_INVAL_INTR_TABLE 0x05 >>>>>> + >>>>>> +#define DEVTAB_ENTRY_SIZE 32 >>>>>> + >>>>>> +/* Device table entry bits 0:63 */ >>>>>> +#define DEV_VALID (1ULL << 0) >>>>>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>>>>> +#define DEV_MODE_MASK 0x7 >>>>>> +#define DEV_MODE_RSHIFT 9 >>>>>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>>>>> +#define DEV_PT_ROOT_RSHIFT 12 >>>>>> +#define DEV_PERM_SHIFT 61 >>>>>> +#define DEV_PERM_READ (1ULL << 61) >>>>>> +#define DEV_PERM_WRITE (1ULL << 62) >>>>>> + >>>>>> +/* Device table entry bits 64:127 */ >>>>>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>>>>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>>>>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>>>>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>>>>> +#define DEV_IOCTL_MASK (~3) >>>>>> +#define DEV_IOCTL_RSHIFT 20 >>>>>> +#define DEV_IOCTL_DENY 0 >>>>>> +#define DEV_IOCTL_PASSTHROUGH 1 >>>>>> +#define DEV_IOCTL_TRANSLATE 2 >>>>>> +#define DEV_CACHE (1ULL << 37) >>>>>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>>>>> +#define DEV_EXCL (1ULL << 39) >>>>>> + >>>>>> +/* Event codes and flags, as stored in the info field */ >>>>>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>>>>> +#define EVENT_IOPF (0x2U << 24) >>>>>> +#define EVENT_IOPF_I (1U << 3) >>>>>> +#define EVENT_IOPF_PR (1U << 4) >>>>>> +#define EVENT_IOPF_RW (1U << 5) >>>>>> +#define EVENT_IOPF_PE (1U << 6) >>>>>> +#define EVENT_IOPF_RZ (1U << 7) >>>>>> +#define EVENT_IOPF_TR (1U << 8) >>>>>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>>>>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>>>>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>>>>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>>>>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>>>>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>>>>> + >>>>>> +#define EVENT_LEN 16 >>>>>> + >>>>>> +#define IOMMU_PERM_READ (1 << 0) >>>>>> +#define IOMMU_PERM_WRITE (1 << 1) >>>>>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | >>>>>> IOMMU_PERM_WRITE) >>>>>> + >>>>>> +/* AMD RD890 Chipset */ >>>>>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>>>>> + >>>>>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>>>>> register */ >>>>>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>>>>> register */ >>>>>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>>>>> register */ >>>>>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>>>>> */ >>>>>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous >>>>>> Information >>>>>> register 0 */ >>>>>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous >>>>>> Information >>>>>> register 1 */ >>>>>> + >>>>>> +#define FEATURE_PREFETCH (1ULL<<0) >>>>>> +#define FEATURE_PPR (1ULL<<1) >>>>>> +#define FEATURE_NX (1ULL<<3) >>>>>> +#define FEATURE_GT (1ULL<<4) >>>>>> +#define FEATURE_IA (1ULL<<6) >>>>>> +#define FEATURE_GA (1ULL<<7) >>>>>> +#define FEATURE_HE (1ULL<<8) >>>>>> +#define FEATURE_PC (1ULL<<9) >>>>>> + >>>>>> +/* IOMMU paging mode */ >>>>>> +#define GATS_MODE (6ULL << 12) >>>>>> +#define HATS_MODE (6ULL << 10) >>>>>> +/* PCI SIG constants */ >>>>>> +#define PCI_BUS_MAX 256 >>>>>> +#define PCI_SLOT_MAX 32 >>>>>> +#define PCI_FUNC_MAX 8 >>>>>> +#define PCI_DEVFN_MAX 256 >>>>>> + >>>>>> +/* extended feature support */ >>>>>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>>>>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | >>>>>> HATS_MODE ) >>>>>> + >>>>>> +/* capabilities header */ >>>>>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>>>>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | >>>>>> CAPAB_FLAG_HTTUNNEL >>>>>> | CAPAB_EFR_SUP) >>>>>> + >>>>>> +/* command constants */ >>>>>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>>>>> +#define COM_COMPLETION_STORE_MASK 0x1 >>>>>> +#define COM_COMPLETION_INTR 0x2 >>>>>> +#define COM_COMPLETION_DATA_OFF 0x8 >>>>>> +#define IOMMU_COMMAND_SIZE 0x10 >>>>>> + >>>>>> +/* IOMMU default address */ >>>>>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>>>>> + >>>>>> +/* page management constants */ >>>>>> +#define IOMMU_PAGE_SHIFT 12 >>>>>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>>>>> + >>>>>> +#define IOMMU_PAGE_SHIFT_4K 12 >>>>>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>>>>> +#define IOMMU_PAGE_SHIFT_2M 21 >>>>>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>>>>> +#define IOMMU_PAGE_SHIFT_1G 30 >>>>>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>>>>> + >>>>>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>>>>> +#define AMD_IOMMU_DEVICE(obj)\ >>>>>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>>>>> + >>>>>> +typedef struct AMDIOMMUState AMDIOMMUState; >>>>>> + >>>>>> +typedef struct AMDIOMMUAddressSpace{ >>>>>> + uint8_t bus_num; /* bus number >>>>>> */ >>>>>> + uint8_t devfn; /* device function >>>>>> */ >>>>>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>>>>> */ >>>>>> + MemoryRegion iommu; /* Device's iommu region >>>>>> */ >>>>>> + AddressSpace as; /* device's corresponding address >>>>>> space >>>>>> */ >>>>>> +}AMDIOMMUAddressSpace; >>>>>> + >>>>>> +struct AMDIOMMUState { >>>>>> + PCIDevice dev; /* The PCI device itself */ >>>>>> + >>>>>> + uint32_t version; >>>>>> + >>>>>> + int capab_offset; /* capability offset pointer */ >>>>>> + unsigned char *capab; /* capabilities registers */ >>>>>> + >>>>>> + bool enabled; /* IOMMU enabled */ >>>>>> + bool ats_enabled; /* address translation enabled */ >>>>>> + bool cmdbuf_enabled; /* command buffer enabled */ >>>>>> + bool evtlog_enabled; /* event log enabled */ >>>>>> + bool excl_enabled; >>>>>> + >>>>>> + dma_addr_t devtab; /* base address device table */ >>>>>> + size_t devtab_len; /* device table length */ >>>>>> + >>>>>> + dma_addr_t cmdbuf; /* command buffer base address */ >>>>>> + uint64_t cmdbuf_len; /* command buffer length */ >>>>>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>>>>> + unsigned cmdbuf_tail; /* next Software write position */ >>>>>> + int completion_wait_intr; >>>>>> + >>>>>> + dma_addr_t evtlog; /* base address event log */ >>>>>> + size_t evtlog_intr; >>>>>> + size_t evtlog_len; /* event log length */ >>>>>> + size_t evtlog_head; /* event log head */ >>>>>> + size_t evtlog_tail; /* event log tail */ >>>>>> + >>>>>> + /* unused for now */ >>>>>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range >>>>>> */ >>>>>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range >>>>>> */ >>>>>> + bool excl_allow; /* translate accesses to the >>>>>> exclusion >>>>>> range */ >>>>>> + bool excl_enable; /* exclusion range enabled >>>>>> */ >>>>>> + >>>>>> + MemoryRegion mmio; /* MMIO region */ >>>>>> + unsigned char mmior[MMIO_SIZE]; >>>>>> + bool mmio_enabled; >>>>>> + >>>>>> + /* IOMMU function */ >>>>>> + MemoryRegionIOMMUOps iommu_ops; >>>>>> + >>>>>> + /* for each served device */ >>>>>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>>>>> +}; >>>>>> + >>>>>> +typedef struct AMDIOMMUEvent { >>>>>> + uint16_t devfn; >>>>>> + uint16_t reserved; >>>>>> + uint16_t domid; >>>>>> + uint16_t info; >>>>>> + uint16_t addr; >>>>>> +} __attribute__((packed)) AMDIOMMUEvent; >>>>>> + >>>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>>> devfn); >>>>>> + >>>>>> +#endif >>>>>> >>>>> >>>>> Regards, >>>>> Valentine >>> >>> >>> >>> -- >>> С уважением, >>> Синицын Валентин ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-09 8:12 ` David kiarie @ 2015-09-09 8:14 ` Valentine Sinitsyn 2015-09-09 8:31 ` David kiarie 0 siblings, 1 reply; 22+ messages in thread From: Valentine Sinitsyn @ 2015-09-09 8:14 UTC (permalink / raw) To: David kiarie; +Cc: Jan Kiszka, QEMU Developers, mst Oops, that was a long ago. Sorry & thanks. Valentine On 09.09.2015 13:12, David kiarie wrote: > I wrote something basic on the cover letter > http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg02759.html > > On Wed, Sep 9, 2015 at 11:07 AM, Valentine Sinitsyn > <valentine.sinitsyn@gmail.com> wrote: >> On 09.09.2015 12:59, David kiarie wrote: >>> >>> On Wed, Sep 9, 2015 at 10:45 AM, Valentine Sinitsyn >>> <valentine.sinitsyn@gmail.com> wrote: >>>> >>>> On 09.09.2015 12:30, David kiarie wrote: >>>> ...snip... >>>> >>>> >>>>>>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>>>>>> +{ >>>>>>> + unsigned type; >>>>>>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>>>>>> + >>>>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>>>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>>>>>> + >>>>>>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + >>>>>>> s->cmdbuf_head, >>>>>>> cmd, IOMMU_COMMAND_SIZE)){ >>>>>>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>>>>>> 0x%"PRIx64 >>>>>>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>>>>>> + } >>>>>>> + >>>>>>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>>>>>> + >>>>>>> + switch(type){ >>>>>>> + case CMD_COMPLETION_WAIT: >>>>>>> + /* pretend to wait for command execution to complete */ >>>>>>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>>>>>> + amd_iommu_completion_wait(s, cmd); >>>>>>> + break; >>>>>>> + case CMD_INVAL_DEVTAB_ENTRY: >>>>>>> + /* Not implemented yet - should just clear device table >>>>>>> contents */ >>>>>>> + IOMMU_DPRINTF(COMMAND, "device table entries >>>>>>> invalidated"); >>>>>> >>>>>> >>>>>> >>>>>> Better make it clear that these commands are not implemented yet. An >>>>>> IOMMU >>>>>> is hardly usable without invalidators. >>>>> >>>>> >>>>> >>>>> I think the "debug prinft" here is misleading. AFAIK, the commands >>>>> listed here(there are others which I haven't listed) relate to 'cache' >>>>> which means this commands do nothing in the absence of cache. >>>>> >>>>> The reason why I advertise 'cache' is because the linux driver checks >>>>> for cache and other optional features to determine the IOMMU version >>>>> whereby versions 2 of IOMMU are assummed to support this features. >>>> >>>> >>>> Did you check how address translation is emulated in QEMU. I didn't :) >>>> But >>>> you return IOMMTLBEntry from your translation routine, and I'd rather >>>> ensure >>>> it is not cached in some other layer. >>> >>> >>> Am expected to cache the IOMMUTLBEntries myself, probably through a >>> hashtable. Also, that's what emulated VT-d in Qemu does. >>> >>>> >>>> Besides, omitting invalidation commands will be a problem on real >>>> hardware. >>>> As IOMMU emulation is mainly useful for debugging, I'd reproduce this >>>> behaviour in the emulator. I mean, if I forget to do >>>> CMD_INVAL_DEVTAB_ENTRY >>>> in my guest code, things shouldn't work properly. >>> >>> >>> Yes, 'cache' is important for debugging. I or someone else could work >>> on cache, now or later. >>> >>>> >>>> You can just copy all data structures to AMDIOMMUState and use this >>>> "cahced" >>>> copies, updated when you run invalidation commands. But this isn't a #1 >>>> priority, you are right. >>>> >>>> Can you share some tests results for this code? >>> >>> >>> Do you mean the whole IOMMU?It works, as far as am concerned. I got >>> was able to 'passthrough' a sound device but that's the only device I >>> tested. >> >> That's great. Could you describe your tests setup, please? Maybe in README >> or in the cover letter, so anyone interested could reproduce it just >> following your steps. >> >> Valentine >> >> >>> >>>> >>>>> >>>>>> >>>>>>> + break; >>>>>>> + case CMD_INVAL_IOMMU_PAGES: >>>>>>> + /* invalidate IOMMU cache for a particular domain */ >>>>>>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>>>>>> + break; >>>>>>> + case CMD_INVAL_IOTLB_PAGES: >>>>>>> + /* Only present if remote IOTLB present */ >>>>>>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>>>>>> + break; >>>>>>> + case CMD_INVAL_INTR_TABLE: >>>>>>> + /* no support for interrupt remapping yet */ >>>>>>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>>>>>> + break; >>>>>>> + default: >>>>>>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>>>>>> + break; >>>>>>> + } >>>>>>> + >>>>>>> +} >>>>>>> + >>>>>>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>>>>>> +{ >>>>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>>>> + >>>>>>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + >>>>>>> MMIO_COMMAND_HEAD; >>>>>>> + >>>>>>> + if(!s->cmdbuf_enabled){ >>>>>>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>>>>>> + return; >>>>>>> + } >>>>>>> + >>>>>>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>>>>>> + /* check if there is work to do. */ >>>>>>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND >>>>>>> BUFFER >>>>>>> tail at %x", >>>>>>> + s->cmdbuf_head, s->cmdbuf_tail); >>>>>>> + amd_iommu_cmdbuf_exec(s); >>>>>>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>>>>>> + >>>>>>> + /* wrap head pointer */ >>>>>>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>>>>>> + s->cmdbuf_head = 0; >>>>>>> + } >>>>>>> + } >>>>>>> + >>>>>>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>>>>>> +} >>>>>>> + >>>>>>> +/* System Software might never read from some of this fields but >>>>>>> anyways >>>>>>> */ >>>>>>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, >>>>>>> unsigned >>>>>>> size) >>>>>>> +{ >>>>>>> + AMDIOMMUState *s = opaque; >>>>>>> + >>>>>>> + uint64_t val = -1; >>>>>>> + if(addr + size > MMIO_SIZE) { >>>>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max >>>>>>> 0x%"PRIX64 >>>>>>> + ", got 0x%"PRIx64 " %d", >>>>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>>>> + return (uint64_t) - 1; >>>>>>> + } >>>>>>> + >>>>>>> + switch(addr & ~0x07){ >>>>>>> + case MMIO_DEVICE_TABLE: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>> >>>>>> >>>>>> >>>>>> What makes these cases different, except debug printf()s? Maybe leave >>>>>> printf()s inside the switch, and factor out the rest. This applies to >>>>>> other >>>>>> similar cases as well. >>>>>> >>>>>> >>>>>>> + >>>>>>> + case MMIO_COMMAND_BASE: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EVENT_BASE: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_CONTROL: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EXCL_BASE: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EXCL_LIMIT: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_COMMAND_HEAD: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_COMMAND_TAIL: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EVENT_HEAD: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EVENT_TAIL: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_STATUS: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EXT_FEATURES: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + if(size == 2){ >>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>> + } else if(size == 4){ >>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>> + } >>>>>>> + else if(size == 8){ >>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + default: >>>>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>> offset); >>>>>>> + } >>>>>>> + >>>>>>> + return val; >>>>>>> +} >>>>>>> + >>>>>>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>>>>>> +{ >>>>>>> + /* read whatever is already written incase software is writing in >>>>>>> chucks less than 8 bytes */ >>>>>>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>>>>>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>>>>>> + >>>>>>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>>>>>> + s->evtlog_enabled = s->enabled && !!(control & >>>>>>> MMIO_CONTROL_EVENTLOGEN); >>>>>>> + >>>>>>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>>>>>> + s->completion_wait_intr = !!(control & >>>>>>> MMIO_CONTROL_COMWAITINTEN); >>>>>>> + s->cmdbuf_enabled = s->enabled && !!(control & >>>>>>> MMIO_CONTROL_CMDBUFLEN); >>>>>>> + >>>>>>> + /* update the flags depending on the control register */ >>>>>>> + if(s->cmdbuf_enabled) { >>>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= >>>>>>> MMIO_STATUS_CMDBUF_RUN; >>>>>>> + } else { >>>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>>>> ~MMIO_STATUS_CMDBUF_RUN; >>>>>>> + } >>>>>>> + if (s->evtlog_enabled) { >>>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= >>>>>>> MMIO_STATUS_EVTLOG_RUN; >>>>>>> + } else { >>>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>>>> ~MMIO_STATUS_EVTLOG_RUN; >>>>>>> + } >>>>>>> + >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>>>>>> + >>>>>>> + amd_iommu_cmdbuf_run(s); >>>>>> >>>>>> >>>>>> >>>>>> Does any write to control register result in draining command buffer? >>>>>> To >>>>>> me, >>>>>> it looks strange, and I'd expect IOMMU to execute commands only if I >>>>>> change >>>>>> tail pointer. >>>>>> >>>>>> >>>>>>> +} >>>>>>> + >>>>>>> +/* FIXME: something might go wrong if System Software writes in >>>>>>> chunks >>>>>>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>>>>>> + * works correctly with linux but will definitely be busted if >>>>>>> software >>>>>>> + * reads/writes 8 bytes >>>>>>> + */ >>>>>>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t >>>>>>> val, >>>>>>> unsigned size) >>>>>>> +{ >>>>>>> + >>>>>>> + AMDIOMMUState *s = opaque; >>>>>>> + unsigned long offset = addr & 0x07; >>>>>>> + >>>>>>> + if(addr + size > MMIO_SIZE) { >>>>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max >>>>>>> 0x%"PRIx64 >>>>>>> + ", got 0x%"PRIx64 " %d", >>>>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>>>> + return; >>>>>>> + } >>>>>>> + >>>>>>> + switch(addr & ~0x07){ >>>>>>> + case MMIO_CONTROL: >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64 >>>>>>> , addr, size, val, offset); >>>>>>> + iommu_handle_control_write(s); >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_DEVICE_TABLE: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + >>>>>>> + /* set device table address >>>>>>> + * This also suffers from inability to tell whether >>>>>>> software >>>>>>> is done writing >>>>>>> + */ >>>>>>> + if(offset || (size == 8)){ >>>>>>> + unsigned long device_base = amd_iommu_readq(s, >>>>>>> MMIO_DEVICE_TABLE); >>>>>>> + s->devtab = (dma_addr_t)(device_base & >>>>>>> MMIO_CMDBUF_BASE_MASK); >>>>>>> + /* set device table length */ >>>>>>> + s->devtab_len = ((device_base & >>>>>>> MMIO_DEVTAB_SIZE_MASK) >>>>>>> + >>>>>>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>>>>>> + MMIO_DEVTAB_ENTRY_SIZE); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_COMMAND_HEAD: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>>>>>> + amd_iommu_cmdbuf_run(s); >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_COMMAND_BASE: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + >>>>>>> + /* FIXME - make sure System Software has finished writing >>>>>>> incase it writes >>>>>>> + * in chucks less than 8 bytes in a robust way.As for >>>>>>> now, >>>>>>> this hacks works >>>>>>> + * for the linux driver >>>>>>> + */ >>>>>>> + if(offset || (size == 8)){ >>>>>>> + unsigned long command_base = amd_iommu_readq(s, >>>>>>> MMIO_COMMAND_BASE); >>>>>>> + s->cmdbuf = (dma_addr_t)(command_base & >>>>>>> MMIO_CMDBUF_BASE_MASK); >>>>>>> + s->cmdbuf_len = 1UL << >>>>>>> (s->mmior[MMIO_CMDBUF_SIZE_BYTE] >>>>>>> & >>>>>>> MMIO_CMDBUF_SIZE_MASK); >>>>>>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_COMMAND_TAIL: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + >>>>>>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>>>>>> + amd_iommu_cmdbuf_run(s); >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EVENT_BASE: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>>>>>> + s->evtlog_len = 1UL << >>>>>>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & >>>>>>> MMIO_EVTLOG_SIZE_MASK); >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EXCL_LIMIT: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>>>>>> MMIO_EXCL_LIMIT_LOW; >>>>>>> + break; >>>>>>> + //TODO : Event handling fixes >>>>>>> + >>>>>>> + case MMIO_EVENT_HEAD: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + case MMIO_EVENT_TAIL: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr >>>>>>> 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + break; >>>>>>> + /* PPR log base - unused for now */ >>>>>>> + case MMIO_PPR_BASE: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + break; >>>>>>> + /* PPR log head - also unused for now */ >>>>>>> + case MMIO_PPR_HEAD: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + break; >>>>>>> + /* PPR log tail - unused for now */ >>>>>>> + case MMIO_PPR_TAIL: >>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + if(size == 2){ >>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>> + } else if(size == 4){ >>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>> + } else if(size == 8){ >>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>> + } >>>>>>> + break; >>>>>>> + >>>>>>> + default: >>>>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>> + ; >>>>>>> + } >>>>>>> + >>>>>>> +} >>>>>>> + >>>>>>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>>>>>> +{ >>>>>>> + /* event logging not enabled */ >>>>>>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>>>>>> MMIO_STATUS_EVTLOG_OF){ >>>>>>> + return; >>>>>>> + } >>>>>>> + >>>>>>> + /* event log buffer full */ >>>>>>> + if(s->evtlog_tail >= s->evtlog_len) { >>>>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>>>>>> + } >>>>>>> + >>>>>>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>>>>>> s->evtlog_tail, &evt, EVENT_LEN)){ >>>>>>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>>>>> 0%x"PRIu8, >>>>>>> s->evtlog + s->evtlog_tail); >>>>>>> + } >>>>>>> + >>>>>>> + s->evtlog_tail += EVENT_LEN; >>>>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>>>>>> + /* Disable logging if Overflow ? */ >>>>>> >>>>>> >>>>>> >>>>>> No, the spec details event logging restart procedure. Make sure >>>>>> emulated >>>>>> IOMMU behaves as described there. >>>>>> >>>>>> >>>>>>> +} >>>>>>> + >>>>>>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, >>>>>>> unsigned >>>>>>> domid, dma_addr_t addr, int present, >>>>>>> + int is_write) >>>>>>> +{ >>>>>>> + IOMMU_DPRINTF(ELOG, ""); >>>>>>> + >>>>>>> + AMDIOMMUEvent evt; >>>>>>> + unsigned info; >>>>>>> + uint16_t status; >>>>>>> + >>>>>>> + evt.devfn = cpu_to_le16(devfn); >>>>>>> + evt.reserved = 0; >>>>>>> + evt.domid = cpu_to_le16(domid); >>>>>>> + evt.addr = cpu_to_le16(addr); >>>>>>> + >>>>>>> + info = EVENT_IOPF; >>>>>>> + >>>>>>> + if(present) { >>>>>>> + info |= EVENT_IOPF_PR; >>>>>>> + } >>>>>>> + >>>>>>> + if (is_write) { >>>>>>> + info |= EVENT_IOPF_RW; >>>>>>> + } >>>>>>> + >>>>>>> + /* log a page fault */ >>>>>>> + amd_iommu_log_event(s, &evt); >>>>>>> + >>>>>>> + /* Abort the translation */ >>>>>>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>>>>>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>>>>>> PCI_STATUS_SIG_TARGET_ABORT); >>>>>>> +} >>>>>>> + >>>>>>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>>>>>> +{ >>>>>>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> >>>>>>> DEV_PERM_SHIFT; >>>>>>> +} >>>>>>> + >>>>>>> +/* FIXME deduplication */ >>>>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>>>> devfn) >>>>>>> +{ >>>>>>> + AMDIOMMUState *s = opaque; >>>>>>> + AMDIOMMUAddressSpace **iommu_as; >>>>>>> + int bus_num = pci_bus_num(bus); >>>>>>> + >>>>>>> + /* just in case */ >>>>>>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>>>>>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>>>>>> + >>>>>>> + iommu_as = s->address_spaces[bus_num]; >>>>>>> + >>>>>>> + /* allocate memory during the first run */ >>>>>>> + if(!iommu_as) { >>>>>>> + iommu_as = >>>>>>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>>>>>> + s->address_spaces[bus_num] = iommu_as; >>>>>>> + } >>>>>>> + >>>>>>> + /* set up IOMMU region */ >>>>>>> + if(!iommu_as[devfn]){ >>>>>>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>>>>>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>>>>>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>>>>>> + iommu_as[devfn]->iommu_state = s; >>>>>>> + >>>>>>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>>>>>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>>>>>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>>>>>> "amd-iommu"); >>>>>>> + } >>>>>>> + return &iommu_as[devfn]->as; >>>>>>> +} >>>>>>> + >>>>>>> +/* validate a page table entry */ >>>>>>> +static bool amd_iommu_validate_pte(uint64_t pte) >>>>>>> +{ >>>>>>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>>>>> >>>>>> >>>>>> >>>>>> I'd suggest parenthesis here. >>>>>> >>>>>> >>>>>>> +} >>>>>>> + >>>>>>> +/* get a device table entry given the device function */ >>>>>>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>>>>>> *entry) >>>>>>> +{ >>>>>>> + /* Could lead to out of range accesses */ >>>>>>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>>>>>> + >>>>>>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>>>>>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, >>>>>>> entry, >>>>>>> 32)){ >>>>>>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>>>>>> 0x%"PRIx64 >>>>>>> + "offset 0x%"PRIx32, s->devtab, offset); >>>>>>> + return false; >>>>>>> + } >>>>>>> + >>>>>>> + if(!amd_iommu_validate_pte(entry[0])){ >>>>>>> + IOMMU_DPRINTF(MMU, >>>>>>> + "Pte entry at 0x%"PRIx64" is invalid", >>>>>>> entry[0]); >>>>>>> + return false; >>>>>>> + } >>>>>>> + >>>>>>> + return true; >>>>>>> +} >>>>>>> + >>>>>>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>>>>>> +{ >>>>>>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>>>> + >>>>>>> + if(level == 7){ >>>>>>> + /* reserved level - abort ? */ >>>>>>> + IOMMU_DPRINTF(MMU, >>>>>>> + "Reserved translation level (7) detected"); >>>>>>> + return 0; >>>>>>> + } >>>>>>> + >>>>>>> + return level; >>>>>>> +} >>>>>>> + >>>>>>> +/* TODO : Mark addresses as Accessed and Dirty */ >>>>>>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr >>>>>>> addr, >>>>>>> bool is_write, IOMMUTLBEntry *ret) >>>>>>> +{ >>>>>>> + AMDIOMMUState *s = as->iommu_state; >>>>>>> + >>>>>>> + int present; >>>>>>> + dma_addr_t pte_addr; >>>>>>> + uint64_t entry[4], pte, pte_perms; >>>>>>> + unsigned level; >>>>>>> + unsigned perms; >>>>>>> + >>>>>>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>>>>>> + goto no_translation; >>>>>>> + } >>>>>>> + >>>>>>> + pte = entry[0]; >>>>>>> + >>>>>>> + /* >>>>>>> + * It's okay to check for either read or write permissions >>>>>>> + * even for memory maps, since we don't support R/W maps. >>>>>>> + */ >>>>>>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>>>>>> + >>>>>>> + if(!(level = get_pte_translation_mode(pte))){ >>>>>>> + goto no_translation; >>>>>>> + } >>>>>>> + >>>>>>> + while(level > 0){ >>>>>>> + /* >>>>>>> + * check permissions: the bitwise >>>>>>> + * implication perms -> entry_perms must be true. Pages must >>>>>>> be >>>>>>> present >>>>>>> + * and permissions on all levels must be similar >>>>>>> + */ >>>>>>> + pte_perms = amd_iommu_get_perms(pte); >>>>>>> + present = pte & 1; >>>>>>> + if(!present || perms != (perms & pte_perms)){ >>>>>>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>>>>>> DEV_DOMID_ID_MASK, addr, present, >>>>>>> + !!(perms & IOMMU_PERM_WRITE)); >>>>>>> + return; >>>>>>> + } >>>>>>> + >>>>>>> + /* go to the next lower level */ >>>>>>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>>>>>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>>>>> >>>>>> >>>>>> >>>>>> Does this work for six level page tables? The highest level has >>>>>> different >>>>>> bit size there IIRC. >>>>>> >>>>>>> + pte = ldq_phys(&address_space_memory, pte_addr); >>>>>>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>>>> + } >>>>>>> + >>>>>>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>>>>>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & >>>>>>> IOMMU_PAGE_MASK_4K; >>>>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>>> + ret->perm = IOMMU_RW; >>>>>>> + return; >>>>>>> + >>>>>>> +no_translation: >>>>>>> + ret->iova = addr; >>>>>>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>>> + ret->perm = IOMMU_RW; >>>>>>> + return; >>>>>> >>>>>> >>>>>> >>>>>> Are you sure these transactions needs to be passed through rather than >>>>>> target-aborted? >>>>>> >>>>>>> +} >>>>>>> + >>>>>>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>>>>>> addr, bool is_write) >>>>>>> +{ >>>>>>> + >>>>>>> + IOMMU_DPRINTF(GENERAL, ""); >>>>>>> + >>>>>>> + AMDIOMMUAddressSpace *as = container_of(iommu, >>>>>>> AMDIOMMUAddressSpace, >>>>>>> iommu); >>>>>>> + AMDIOMMUState *s = as->iommu_state; >>>>>>> + >>>>>>> + IOMMUTLBEntry ret = { >>>>>>> + .target_as = &address_space_memory, >>>>>>> + .iova = addr, >>>>>>> + .translated_addr = 0, >>>>>>> + .addr_mask = ~(hwaddr)0, >>>>>>> + .perm = IOMMU_NONE, >>>>>>> + }; >>>>>>> + >>>>>>> + if(!s->enabled){ >>>>>>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>>>>>> provide any parameter */ >>>>>>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>>>>>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>>>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>>> + ret.perm = IOMMU_RW; >>>>>>> + return ret; >>>>>>> + } >>>>>>> + >>>>>>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>>>>>> + >>>>>>> + IOMMU_DPRINTF(MMU, >>>>>>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa >>>>>>> 0x%"PRIx64, >>>>>>> as->bus_num, >>>>>>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>>>>>> ret.translated_addr); >>>>>>> + >>>>>>> + return ret; >>>>>>> +} >>>>>>> + >>>>>>> +static const MemoryRegionOps mmio_mem_ops = { >>>>>>> + .read = amd_iommu_mmio_read, >>>>>>> + .write = amd_iommu_mmio_write, >>>>>>> + .endianness = DEVICE_LITTLE_ENDIAN, >>>>>>> + .valid = { >>>>>>> + .min_access_size = 1, >>>>>>> + .max_access_size = 8, >>>>>>> + .unaligned = false, >>>>>>> + }, >>>>>>> + >>>>>>> + .valid = { >>>>>>> + .min_access_size = 8, >>>>>>> + .max_access_size = 8, >>>>>>> + }, >>>>>>> +}; >>>>>>> + >>>>>>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t >>>>>>> host_pa, >>>>>>> uint32_t guest_va, uint32_t *reg) >>>>>>> +{ >>>>>>> + *reg = 0; >>>>>> >>>>>> >>>>>> >>>>>> Redundant line. >>>>>> >>>>>> >>>>>>> + >>>>>>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>>>>>> +} >>>>>>> + >>>>>>> +/* FIXME: The similar code in reset and init could be combined into a >>>>>>> function */ >>>>>>> +static void amd_iommu_reset(DeviceState *dev) >>>>>>> +{ >>>>>>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>>>>>> + >>>>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>>>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>>>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>>>>>> + uint32_t capab_range = 0xff000000; >>>>>>> + uint32_t capab_misc = 0x0; >>>>>>> + >>>>>>> + /* reset MMIO */ >>>>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>>>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>>>>>> + /* TODO :Disable event logging and reset all buffers */ >>>>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>>>> &capab_misc); >>>>>>> + >>>>>>> + /* reset IOMMU specific capabilities */ >>>>>>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>>>>>> capab_base_addr_low); >>>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>>>>>> capab_base_addr_high); >>>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>>>>>> capab_range); >>>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>>>>>> capab_misc); >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Do we also need to reset MSI capability block? >>>>>> >>>>>> >>>>>>> + >>>>>>> + /* reset device ident */ >>>>>>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>>>>>> + pci_config_set_device_id(s->dev.config, >>>>>>> PCI_DEVICE_ID_RD890_IOMMU); >>>>>>> + pci_config_set_class(s->dev.config, 0x0806); >>>>>>> + pci_config_set_prog_interface(s->dev.config, 00); >>>>>>> +} >>>>>>> + >>>>>>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, >>>>>>> uint32_t >>>>>>> val, int len) >>>>>>> +{ >>>>>>> + pci_default_write_config(dev, addr, val, len); >>>>>>> +} >>>>>>> + >>>>>>> +/* I honestly don't know how to reserve MMIO */ >>>>>>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>>>>>> +{ >>>>>>> + if(s->mmio.addr == addr){ >>>>>>> + return; >>>>>>> + } >>>>>>> + >>>>>>> +// if(s->mmio.addr != (hwaddr)-1) { >>>>>>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>>>>>> +// } >>>>>>> + >>>>>>> + s->mmio.addr = addr; >>>>>>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>>>>>> + >>>>>>> +} >>>>>>> + >>>>>>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>>>>>> +{ >>>>>>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>>>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>>>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>>>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> >>>>>>> 16); >>>>>>> + uint32_t capab_range = 0xff000000; >>>>>>> + uint32_t capab_misc = 0x0; >>>>>>> + >>>>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>>>> &capab_misc); >>>>>>> + >>>>>>> + s->iommu_ops.translate = amd_iommu_translate; >>>>>>> + s->enabled = false; >>>>>>> + s->ats_enabled = false; >>>>>>> + s->cmdbuf_enabled = false; >>>>>>> + s->devtab_len = 0; >>>>>>> + s->cmdbuf_len = 0; >>>>>>> + s->cmdbuf_head = 0; >>>>>>> + s->cmdbuf_tail = 0; >>>>>>> + s->evtlog_head = 0; >>>>>>> + s->evtlog_tail = 0; >>>>>>> + s->excl_enabled = false; >>>>>>> + s->excl_allow = false; >>>>>>> + s->mmio_enabled = false; >>>>>>> + dev->config_write = amd_iommu_write_capab; >>>>>>> + >>>>>>> + size_t offset; >>>>>>> + /* Save offset for IVRS */ >>>>>>> + s->capab_offset = offset = pci_add_capability(dev, >>>>>>> PCI_CAP_ID_SEC, >>>>>>> 0, >>>>>>> CAPAB_SIZE); >>>>>>> + pci_set_long(s->dev.config + offset, capab_header); >>>>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>>>>>> capab_base_addr_low); >>>>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>>>>>> capab_base_addr_high); >>>>>>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>>>>>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>>>>>> + >>>>>>> + /* add msi and hypertransport capabilities */ >>>>>>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>>>>>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>>>>>> + >>>>>>> + /* set up MMIO */ >>>>>>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>>>>>> "amd-iommu", MMIO_SIZE); >>>>>>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>>>>>> + >>>>>>> + /* reset device ident */ >>>>>>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>>>>>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>>>>>> + >>>>>>> + /* may not be necessary */ >>>>>>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>>>>>> + >>>>>>> + return 0; >>>>>>> +} >>>>>>> + >>>>>>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>>>>>> +{ >>>>>>> + amd_iommu_pci_initfn(dev); >>>>>>> +} >>>>>>> + >>>>>>> +static const VMStateDescription vmstate_amd_iommu = { >>>>>>> + .name = "amd-iommu", >>>>>>> + .fields = (VMStateField[]) { >>>>>>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>>>>>> + VMSTATE_END_OF_LIST() >>>>>>> + } >>>>>>> +}; >>>>>>> + >>>>>>> +static Property amd_iommu_properties[] = { >>>>>>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>>>>>> + DEFINE_PROP_END_OF_LIST(), >>>>>>> +}; >>>>>>> + >>>>>>> +/* not used for now but will be when cache is added */ >>>>>>> +static void amd_iommu_uninit(PCIDevice *dev) >>>>>>> +{ >>>>>>> + return; >>>>>>> +} >>>>>>> + >>>>>>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>>>>>> +{ >>>>>>> + DeviceClass *dc = DEVICE_CLASS(klass); >>>>>>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>>>>>> + >>>>>>> + pci->realize = amd_iommu_realize; >>>>>>> + pci->exit = amd_iommu_uninit; >>>>>>> + >>>>>>> + dc->reset = amd_iommu_reset; >>>>>>> + dc->vmsd = &vmstate_amd_iommu; >>>>>>> + dc->props = amd_iommu_properties; >>>>>>> +} >>>>>>> + >>>>>>> +static const TypeInfo amd_iommu = { >>>>>>> + .name = TYPE_AMD_IOMMU_DEVICE, >>>>>>> + .parent = TYPE_PCI_DEVICE, >>>>>>> + .instance_size = sizeof(AMDIOMMUState), >>>>>>> + .class_init = amd_iommu_class_init >>>>>>> +}; >>>>>>> + >>>>>>> +static void amd_iommu_register_types(void) >>>>>>> +{ >>>>>>> + type_register_static(&amd_iommu); >>>>>>> +} >>>>>>> + >>>>>>> +type_init(amd_iommu_register_types); >>>>>>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>>>>>> new file mode 100644 >>>>>>> index 0000000..90309eb >>>>>>> --- /dev/null >>>>>>> +++ b/hw/i386/amd_iommu.h >>>>>>> @@ -0,0 +1,298 @@ >>>>>>> +/* >>>>>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>>>>> + * >>>>>>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>>>>>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>>>>>> + * >>>>>>> + * This program is free software; you can redistribute it and/or >>>>>>> modify >>>>>>> + * it under the terms of the GNU General Public License as published >>>>>>> by >>>>>>> + * the Free Software Foundation; either version 2 of the License, or >>>>>>> + * (at your option) any later version. >>>>>>> + >>>>>>> + * This program is distributed in the hope that it will be useful, >>>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>>>>> + * GNU General Public License for more details. >>>>>>> + >>>>>>> + * You should have received a copy of the GNU General Public License >>>>>>> along >>>>>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>>>>> + */ >>>>>>> + >>>>>>> +#ifndef AMD_IOMMU_H_ >>>>>>> +#define AMD_IOMMU_H_ >>>>>>> + >>>>>>> +#include "hw/hw.h" >>>>>>> +#include "hw/pci/pci.h" >>>>>>> +#include "hw/sysbus.h" >>>>>>> +#include "sysemu/dma.h" >>>>>>> +#include "qemu/osdep.h" >>>>>>> +#include "qemu/event_notifier.h" >>>>>>> + >>>>>>> +/* Capability registers */ >>>>>>> +#define CAPAB_HEADER 0x00 >>>>>>> +#define CAPAB_REV_TYPE 0x02 >>>>>>> +#define CAPAB_FLAGS 0x03 >>>>>>> +#define CAPAB_BAR_LOW 0x04 >>>>>>> +#define CAPAB_BAR_HIGH 0x08 >>>>>>> +#define CAPAB_RANGE 0x0C >>>>>>> +#define CAPAB_MISC 0x10 >>>>>>> +#define CAPAB_MISC1 0x14 >>>>>>> + >>>>>>> +#define CAPAB_SIZE 0x18 >>>>>>> +#define CAPAB_REG_SIZE 0x04 >>>>>>> + >>>>>>> +/* Capability header data */ >>>>>>> +#define CAPAB_FLAT_EXT (1 << 28) >>>>>>> +#define CAPAB_EFR_SUP (1 << 27) >>>>>>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>>>>>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>>>>>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>>>>>> +#define CAPAB_INIT_REV (1 << 19) >>>>>>> +#define CAPAB_INIT_TYPE (3 << 16) >>>>>>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>>>>>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>>>>>> CAPAB_FLAG_HTTUNNEL) >>>>>>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>>>>>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>>>>>> + >>>>>>> +/* MMIO registers */ >>>>>>> +#define MMIO_DEVICE_TABLE 0x0000 >>>>>>> +#define MMIO_COMMAND_BASE 0x0008 >>>>>>> +#define MMIO_EVENT_BASE 0x0010 >>>>>>> +#define MMIO_CONTROL 0x0018 >>>>>>> +#define MMIO_EXCL_BASE 0x0020 >>>>>>> +#define MMIO_EXCL_LIMIT 0x0028 >>>>>>> +#define MMIO_EXT_FEATURES 0x0030 >>>>>>> +#define MMIO_COMMAND_HEAD 0x2000 >>>>>>> +#define MMIO_COMMAND_TAIL 0x2008 >>>>>>> +#define MMIO_EVENT_HEAD 0x2010 >>>>>>> +#define MMIO_EVENT_TAIL 0x2018 >>>>>>> +#define MMIO_STATUS 0x2020 >>>>>>> +#define MMIO_PPR_BASE 0x0038 >>>>>>> +#define MMIO_PPR_HEAD 0x2030 >>>>>>> +#define MMIO_PPR_TAIL 0x2038 >>>>>>> + >>>>>>> +#define MMIO_SIZE 0x4000 >>>>>>> + >>>>>>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>>>>>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>>>>>> ~MMIO_DEVTAB_SIZE_MASK) >>>>>>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>>>>>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>>>>>> + >>>>>>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>>>>>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>>>>>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>>>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>>>>>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>>>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>>>> + >>>>>>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>>>>>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>>>>>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>>>>>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>>>>>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>>>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>>>> + >>>>>>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>>>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>>>>>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>>>>>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>>>>>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>>>>>> + >>>>>>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>>>>>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>>>>>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>>>>>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>>>>>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>>>>>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>>>>>> + >>>>>>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>>>>>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>>>>>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>>>>>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>>>>>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>>>>>> + >>>>>>> +#define CMDBUF_ID_BYTE 0x07 >>>>>>> +#define CMDBUF_ID_RSHIFT 4 >>>>>>> +#define CMDBUF_ENTRY_SIZE 0x10 >>>>>>> + >>>>>>> +#define CMD_COMPLETION_WAIT 0x01 >>>>>>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>>>>>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>>>>>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>>>>>> +#define CMD_INVAL_INTR_TABLE 0x05 >>>>>>> + >>>>>>> +#define DEVTAB_ENTRY_SIZE 32 >>>>>>> + >>>>>>> +/* Device table entry bits 0:63 */ >>>>>>> +#define DEV_VALID (1ULL << 0) >>>>>>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>>>>>> +#define DEV_MODE_MASK 0x7 >>>>>>> +#define DEV_MODE_RSHIFT 9 >>>>>>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>>>>>> +#define DEV_PT_ROOT_RSHIFT 12 >>>>>>> +#define DEV_PERM_SHIFT 61 >>>>>>> +#define DEV_PERM_READ (1ULL << 61) >>>>>>> +#define DEV_PERM_WRITE (1ULL << 62) >>>>>>> + >>>>>>> +/* Device table entry bits 64:127 */ >>>>>>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>>>>>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>>>>>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>>>>>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>>>>>> +#define DEV_IOCTL_MASK (~3) >>>>>>> +#define DEV_IOCTL_RSHIFT 20 >>>>>>> +#define DEV_IOCTL_DENY 0 >>>>>>> +#define DEV_IOCTL_PASSTHROUGH 1 >>>>>>> +#define DEV_IOCTL_TRANSLATE 2 >>>>>>> +#define DEV_CACHE (1ULL << 37) >>>>>>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>>>>>> +#define DEV_EXCL (1ULL << 39) >>>>>>> + >>>>>>> +/* Event codes and flags, as stored in the info field */ >>>>>>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>>>>>> +#define EVENT_IOPF (0x2U << 24) >>>>>>> +#define EVENT_IOPF_I (1U << 3) >>>>>>> +#define EVENT_IOPF_PR (1U << 4) >>>>>>> +#define EVENT_IOPF_RW (1U << 5) >>>>>>> +#define EVENT_IOPF_PE (1U << 6) >>>>>>> +#define EVENT_IOPF_RZ (1U << 7) >>>>>>> +#define EVENT_IOPF_TR (1U << 8) >>>>>>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>>>>>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>>>>>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>>>>>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>>>>>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>>>>>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>>>>>> + >>>>>>> +#define EVENT_LEN 16 >>>>>>> + >>>>>>> +#define IOMMU_PERM_READ (1 << 0) >>>>>>> +#define IOMMU_PERM_WRITE (1 << 1) >>>>>>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | >>>>>>> IOMMU_PERM_WRITE) >>>>>>> + >>>>>>> +/* AMD RD890 Chipset */ >>>>>>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>>>>>> + >>>>>>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>>>>>> register */ >>>>>>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>>>>>> register */ >>>>>>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>>>>>> register */ >>>>>>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>>>>>> */ >>>>>>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous >>>>>>> Information >>>>>>> register 0 */ >>>>>>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous >>>>>>> Information >>>>>>> register 1 */ >>>>>>> + >>>>>>> +#define FEATURE_PREFETCH (1ULL<<0) >>>>>>> +#define FEATURE_PPR (1ULL<<1) >>>>>>> +#define FEATURE_NX (1ULL<<3) >>>>>>> +#define FEATURE_GT (1ULL<<4) >>>>>>> +#define FEATURE_IA (1ULL<<6) >>>>>>> +#define FEATURE_GA (1ULL<<7) >>>>>>> +#define FEATURE_HE (1ULL<<8) >>>>>>> +#define FEATURE_PC (1ULL<<9) >>>>>>> + >>>>>>> +/* IOMMU paging mode */ >>>>>>> +#define GATS_MODE (6ULL << 12) >>>>>>> +#define HATS_MODE (6ULL << 10) >>>>>>> +/* PCI SIG constants */ >>>>>>> +#define PCI_BUS_MAX 256 >>>>>>> +#define PCI_SLOT_MAX 32 >>>>>>> +#define PCI_FUNC_MAX 8 >>>>>>> +#define PCI_DEVFN_MAX 256 >>>>>>> + >>>>>>> +/* extended feature support */ >>>>>>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>>>>>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | >>>>>>> HATS_MODE ) >>>>>>> + >>>>>>> +/* capabilities header */ >>>>>>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>>>>>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | >>>>>>> CAPAB_FLAG_HTTUNNEL >>>>>>> | CAPAB_EFR_SUP) >>>>>>> + >>>>>>> +/* command constants */ >>>>>>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>>>>>> +#define COM_COMPLETION_STORE_MASK 0x1 >>>>>>> +#define COM_COMPLETION_INTR 0x2 >>>>>>> +#define COM_COMPLETION_DATA_OFF 0x8 >>>>>>> +#define IOMMU_COMMAND_SIZE 0x10 >>>>>>> + >>>>>>> +/* IOMMU default address */ >>>>>>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>>>>>> + >>>>>>> +/* page management constants */ >>>>>>> +#define IOMMU_PAGE_SHIFT 12 >>>>>>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>>>>>> + >>>>>>> +#define IOMMU_PAGE_SHIFT_4K 12 >>>>>>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>>>>>> +#define IOMMU_PAGE_SHIFT_2M 21 >>>>>>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>>>>>> +#define IOMMU_PAGE_SHIFT_1G 30 >>>>>>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>>>>>> + >>>>>>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>>>>>> +#define AMD_IOMMU_DEVICE(obj)\ >>>>>>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>>>>>> + >>>>>>> +typedef struct AMDIOMMUState AMDIOMMUState; >>>>>>> + >>>>>>> +typedef struct AMDIOMMUAddressSpace{ >>>>>>> + uint8_t bus_num; /* bus number >>>>>>> */ >>>>>>> + uint8_t devfn; /* device function >>>>>>> */ >>>>>>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>>>>>> */ >>>>>>> + MemoryRegion iommu; /* Device's iommu region >>>>>>> */ >>>>>>> + AddressSpace as; /* device's corresponding address >>>>>>> space >>>>>>> */ >>>>>>> +}AMDIOMMUAddressSpace; >>>>>>> + >>>>>>> +struct AMDIOMMUState { >>>>>>> + PCIDevice dev; /* The PCI device itself */ >>>>>>> + >>>>>>> + uint32_t version; >>>>>>> + >>>>>>> + int capab_offset; /* capability offset pointer */ >>>>>>> + unsigned char *capab; /* capabilities registers */ >>>>>>> + >>>>>>> + bool enabled; /* IOMMU enabled */ >>>>>>> + bool ats_enabled; /* address translation enabled */ >>>>>>> + bool cmdbuf_enabled; /* command buffer enabled */ >>>>>>> + bool evtlog_enabled; /* event log enabled */ >>>>>>> + bool excl_enabled; >>>>>>> + >>>>>>> + dma_addr_t devtab; /* base address device table */ >>>>>>> + size_t devtab_len; /* device table length */ >>>>>>> + >>>>>>> + dma_addr_t cmdbuf; /* command buffer base address */ >>>>>>> + uint64_t cmdbuf_len; /* command buffer length */ >>>>>>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>>>>>> + unsigned cmdbuf_tail; /* next Software write position */ >>>>>>> + int completion_wait_intr; >>>>>>> + >>>>>>> + dma_addr_t evtlog; /* base address event log */ >>>>>>> + size_t evtlog_intr; >>>>>>> + size_t evtlog_len; /* event log length */ >>>>>>> + size_t evtlog_head; /* event log head */ >>>>>>> + size_t evtlog_tail; /* event log tail */ >>>>>>> + >>>>>>> + /* unused for now */ >>>>>>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range >>>>>>> */ >>>>>>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range >>>>>>> */ >>>>>>> + bool excl_allow; /* translate accesses to the >>>>>>> exclusion >>>>>>> range */ >>>>>>> + bool excl_enable; /* exclusion range enabled >>>>>>> */ >>>>>>> + >>>>>>> + MemoryRegion mmio; /* MMIO region */ >>>>>>> + unsigned char mmior[MMIO_SIZE]; >>>>>>> + bool mmio_enabled; >>>>>>> + >>>>>>> + /* IOMMU function */ >>>>>>> + MemoryRegionIOMMUOps iommu_ops; >>>>>>> + >>>>>>> + /* for each served device */ >>>>>>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>>>>>> +}; >>>>>>> + >>>>>>> +typedef struct AMDIOMMUEvent { >>>>>>> + uint16_t devfn; >>>>>>> + uint16_t reserved; >>>>>>> + uint16_t domid; >>>>>>> + uint16_t info; >>>>>>> + uint16_t addr; >>>>>>> +} __attribute__((packed)) AMDIOMMUEvent; >>>>>>> + >>>>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>>>> devfn); >>>>>>> + >>>>>>> +#endif >>>>>>> >>>>>> >>>>>> Regards, >>>>>> Valentine >>>> >>>> >>>> >>>> -- >>>> С уважением, >>>> Синицын Валентин ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-09 8:14 ` Valentine Sinitsyn @ 2015-09-09 8:31 ` David kiarie 0 siblings, 0 replies; 22+ messages in thread From: David kiarie @ 2015-09-09 8:31 UTC (permalink / raw) To: Valentine Sinitsyn; +Cc: Jan Kiszka, QEMU Developers, mst On Wed, Sep 9, 2015 at 11:14 AM, Valentine Sinitsyn <valentine.sinitsyn@gmail.com> wrote: > Oops, that was a long ago. Sorry & thanks. No problem. Will fix all other comments. > > Valentine > > > On 09.09.2015 13:12, David kiarie wrote: >> >> I wrote something basic on the cover letter >> http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg02759.html >> >> On Wed, Sep 9, 2015 at 11:07 AM, Valentine Sinitsyn >> <valentine.sinitsyn@gmail.com> wrote: >>> >>> On 09.09.2015 12:59, David kiarie wrote: >>>> >>>> >>>> On Wed, Sep 9, 2015 at 10:45 AM, Valentine Sinitsyn >>>> <valentine.sinitsyn@gmail.com> wrote: >>>>> >>>>> >>>>> On 09.09.2015 12:30, David kiarie wrote: >>>>> ...snip... >>>>> >>>>> >>>>>>>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>>>>>>> +{ >>>>>>>> + unsigned type; >>>>>>>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>>>>>>> + >>>>>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>>>>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>>>>>>> + >>>>>>>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + >>>>>>>> s->cmdbuf_head, >>>>>>>> cmd, IOMMU_COMMAND_SIZE)){ >>>>>>>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>>>>>>> 0x%"PRIx64 >>>>>>>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>>>>>>> + } >>>>>>>> + >>>>>>>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>>>>>>> + >>>>>>>> + switch(type){ >>>>>>>> + case CMD_COMPLETION_WAIT: >>>>>>>> + /* pretend to wait for command execution to complete */ >>>>>>>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>>>>>>> + amd_iommu_completion_wait(s, cmd); >>>>>>>> + break; >>>>>>>> + case CMD_INVAL_DEVTAB_ENTRY: >>>>>>>> + /* Not implemented yet - should just clear device table >>>>>>>> contents */ >>>>>>>> + IOMMU_DPRINTF(COMMAND, "device table entries >>>>>>>> invalidated"); >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Better make it clear that these commands are not implemented yet. An >>>>>>> IOMMU >>>>>>> is hardly usable without invalidators. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> I think the "debug prinft" here is misleading. AFAIK, the commands >>>>>> listed here(there are others which I haven't listed) relate to 'cache' >>>>>> which means this commands do nothing in the absence of cache. >>>>>> >>>>>> The reason why I advertise 'cache' is because the linux driver checks >>>>>> for cache and other optional features to determine the IOMMU version >>>>>> whereby versions 2 of IOMMU are assummed to support this features. >>>>> >>>>> >>>>> >>>>> Did you check how address translation is emulated in QEMU. I didn't :) >>>>> But >>>>> you return IOMMTLBEntry from your translation routine, and I'd rather >>>>> ensure >>>>> it is not cached in some other layer. >>>> >>>> >>>> >>>> Am expected to cache the IOMMUTLBEntries myself, probably through a >>>> hashtable. Also, that's what emulated VT-d in Qemu does. >>>> >>>>> >>>>> Besides, omitting invalidation commands will be a problem on real >>>>> hardware. >>>>> As IOMMU emulation is mainly useful for debugging, I'd reproduce this >>>>> behaviour in the emulator. I mean, if I forget to do >>>>> CMD_INVAL_DEVTAB_ENTRY >>>>> in my guest code, things shouldn't work properly. >>>> >>>> >>>> >>>> Yes, 'cache' is important for debugging. I or someone else could work >>>> on cache, now or later. >>>> >>>>> >>>>> You can just copy all data structures to AMDIOMMUState and use this >>>>> "cahced" >>>>> copies, updated when you run invalidation commands. But this isn't a #1 >>>>> priority, you are right. >>>>> >>>>> Can you share some tests results for this code? >>>> >>>> >>>> >>>> Do you mean the whole IOMMU?It works, as far as am concerned. I got >>>> was able to 'passthrough' a sound device but that's the only device I >>>> tested. >>> >>> >>> That's great. Could you describe your tests setup, please? Maybe in >>> README >>> or in the cover letter, so anyone interested could reproduce it just >>> following your steps. >>> >>> Valentine >>> >>> >>>> >>>>> >>>>>> >>>>>>> >>>>>>>> + break; >>>>>>>> + case CMD_INVAL_IOMMU_PAGES: >>>>>>>> + /* invalidate IOMMU cache for a particular domain */ >>>>>>>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>>>>>>> + break; >>>>>>>> + case CMD_INVAL_IOTLB_PAGES: >>>>>>>> + /* Only present if remote IOTLB present */ >>>>>>>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>>>>>>> + break; >>>>>>>> + case CMD_INVAL_INTR_TABLE: >>>>>>>> + /* no support for interrupt remapping yet */ >>>>>>>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>>>>>>> + break; >>>>>>>> + default: >>>>>>>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>>>>>>> + break; >>>>>>>> + } >>>>>>>> + >>>>>>>> +} >>>>>>>> + >>>>>>>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>>>>>>> +{ >>>>>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>>>>> + >>>>>>>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + >>>>>>>> MMIO_COMMAND_HEAD; >>>>>>>> + >>>>>>>> + if(!s->cmdbuf_enabled){ >>>>>>>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>>>>>>> + return; >>>>>>>> + } >>>>>>>> + >>>>>>>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>>>>>>> + /* check if there is work to do. */ >>>>>>>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND >>>>>>>> BUFFER >>>>>>>> tail at %x", >>>>>>>> + s->cmdbuf_head, s->cmdbuf_tail); >>>>>>>> + amd_iommu_cmdbuf_exec(s); >>>>>>>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>>>>>>> + >>>>>>>> + /* wrap head pointer */ >>>>>>>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>>>>>>> + s->cmdbuf_head = 0; >>>>>>>> + } >>>>>>>> + } >>>>>>>> + >>>>>>>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>>>>>>> +} >>>>>>>> + >>>>>>>> +/* System Software might never read from some of this fields but >>>>>>>> anyways >>>>>>>> */ >>>>>>>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, >>>>>>>> unsigned >>>>>>>> size) >>>>>>>> +{ >>>>>>>> + AMDIOMMUState *s = opaque; >>>>>>>> + >>>>>>>> + uint64_t val = -1; >>>>>>>> + if(addr + size > MMIO_SIZE) { >>>>>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max >>>>>>>> 0x%"PRIX64 >>>>>>>> + ", got 0x%"PRIx64 " %d", >>>>>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>>>>> + return (uint64_t) - 1; >>>>>>>> + } >>>>>>>> + >>>>>>>> + switch(addr & ~0x07){ >>>>>>>> + case MMIO_DEVICE_TABLE: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> What makes these cases different, except debug printf()s? Maybe leave >>>>>>> printf()s inside the switch, and factor out the rest. This applies to >>>>>>> other >>>>>>> similar cases as well. >>>>>>> >>>>>>> >>>>>>>> + >>>>>>>> + case MMIO_COMMAND_BASE: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EVENT_BASE: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_CONTROL: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EXCL_BASE: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EXCL_LIMIT: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_COMMAND_HEAD: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_COMMAND_TAIL: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EVENT_HEAD: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EVENT_TAIL: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_STATUS: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EXT_FEATURES: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + if(size == 2){ >>>>>>>> + val = amd_iommu_readw(s, addr); >>>>>>>> + } else if(size == 4){ >>>>>>>> + val = amd_iommu_readl(s, addr); >>>>>>>> + } >>>>>>>> + else if(size == 8){ >>>>>>>> + val = amd_iommu_readq(s, addr); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + default: >>>>>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>>>>> offset); >>>>>>>> + } >>>>>>>> + >>>>>>>> + return val; >>>>>>>> +} >>>>>>>> + >>>>>>>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>>>>>>> +{ >>>>>>>> + /* read whatever is already written incase software is writing >>>>>>>> in >>>>>>>> chucks less than 8 bytes */ >>>>>>>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>>>>>>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>>>>>>> + >>>>>>>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>>>>>>> + s->evtlog_enabled = s->enabled && !!(control & >>>>>>>> MMIO_CONTROL_EVENTLOGEN); >>>>>>>> + >>>>>>>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>>>>>>> + s->completion_wait_intr = !!(control & >>>>>>>> MMIO_CONTROL_COMWAITINTEN); >>>>>>>> + s->cmdbuf_enabled = s->enabled && !!(control & >>>>>>>> MMIO_CONTROL_CMDBUFLEN); >>>>>>>> + >>>>>>>> + /* update the flags depending on the control register */ >>>>>>>> + if(s->cmdbuf_enabled) { >>>>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= >>>>>>>> MMIO_STATUS_CMDBUF_RUN; >>>>>>>> + } else { >>>>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>>>>> ~MMIO_STATUS_CMDBUF_RUN; >>>>>>>> + } >>>>>>>> + if (s->evtlog_enabled) { >>>>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= >>>>>>>> MMIO_STATUS_EVTLOG_RUN; >>>>>>>> + } else { >>>>>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= >>>>>>>> ~MMIO_STATUS_EVTLOG_RUN; >>>>>>>> + } >>>>>>>> + >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>>>>>>> + >>>>>>>> + amd_iommu_cmdbuf_run(s); >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Does any write to control register result in draining command buffer? >>>>>>> To >>>>>>> me, >>>>>>> it looks strange, and I'd expect IOMMU to execute commands only if I >>>>>>> change >>>>>>> tail pointer. >>>>>>> >>>>>>> >>>>>>>> +} >>>>>>>> + >>>>>>>> +/* FIXME: something might go wrong if System Software writes in >>>>>>>> chunks >>>>>>>> + * of one byte but linux writes in chunks of 4 bytes so currently >>>>>>>> it >>>>>>>> + * works correctly with linux but will definitely be busted if >>>>>>>> software >>>>>>>> + * reads/writes 8 bytes >>>>>>>> + */ >>>>>>>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, >>>>>>>> uint64_t >>>>>>>> val, >>>>>>>> unsigned size) >>>>>>>> +{ >>>>>>>> + >>>>>>>> + AMDIOMMUState *s = opaque; >>>>>>>> + unsigned long offset = addr & 0x07; >>>>>>>> + >>>>>>>> + if(addr + size > MMIO_SIZE) { >>>>>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", got 0x%"PRIx64 " %d", >>>>>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>>>>> + return; >>>>>>>> + } >>>>>>>> + >>>>>>>> + switch(addr & ~0x07){ >>>>>>>> + case MMIO_CONTROL: >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64 >>>>>>>> , addr, size, val, offset); >>>>>>>> + iommu_handle_control_write(s); >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_DEVICE_TABLE: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + >>>>>>>> + /* set device table address >>>>>>>> + * This also suffers from inability to tell whether >>>>>>>> software >>>>>>>> is done writing >>>>>>>> + */ >>>>>>>> + if(offset || (size == 8)){ >>>>>>>> + unsigned long device_base = amd_iommu_readq(s, >>>>>>>> MMIO_DEVICE_TABLE); >>>>>>>> + s->devtab = (dma_addr_t)(device_base & >>>>>>>> MMIO_CMDBUF_BASE_MASK); >>>>>>>> + /* set device table length */ >>>>>>>> + s->devtab_len = ((device_base & >>>>>>>> MMIO_DEVTAB_SIZE_MASK) >>>>>>>> + >>>>>>>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>>>>>>> + MMIO_DEVTAB_ENTRY_SIZE); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_COMMAND_HEAD: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>>>>>>> + amd_iommu_cmdbuf_run(s); >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_COMMAND_BASE: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + >>>>>>>> + /* FIXME - make sure System Software has finished >>>>>>>> writing >>>>>>>> incase it writes >>>>>>>> + * in chucks less than 8 bytes in a robust way.As for >>>>>>>> now, >>>>>>>> this hacks works >>>>>>>> + * for the linux driver >>>>>>>> + */ >>>>>>>> + if(offset || (size == 8)){ >>>>>>>> + unsigned long command_base = amd_iommu_readq(s, >>>>>>>> MMIO_COMMAND_BASE); >>>>>>>> + s->cmdbuf = (dma_addr_t)(command_base & >>>>>>>> MMIO_CMDBUF_BASE_MASK); >>>>>>>> + s->cmdbuf_len = 1UL << >>>>>>>> (s->mmior[MMIO_CMDBUF_SIZE_BYTE] >>>>>>>> & >>>>>>>> MMIO_CMDBUF_SIZE_MASK); >>>>>>>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_COMMAND_TAIL: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + >>>>>>>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>>>>>>> + amd_iommu_cmdbuf_run(s); >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EVENT_BASE: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>>>>>>> + s->evtlog_len = 1UL << >>>>>>>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & >>>>>>>> MMIO_EVTLOG_SIZE_MASK); >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EXCL_LIMIT: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>>>>>>> MMIO_EXCL_LIMIT_LOW; >>>>>>>> + break; >>>>>>>> + //TODO : Event handling fixes >>>>>>>> + >>>>>>>> + case MMIO_EVENT_HEAD: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + case MMIO_EVENT_TAIL: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + /* PPR log base - unused for now */ >>>>>>>> + case MMIO_PPR_BASE: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + /* PPR log head - also unused for now */ >>>>>>>> + case MMIO_PPR_HEAD: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + /* PPR log tail - unused for now */ >>>>>>>> + case MMIO_PPR_TAIL: >>>>>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + if(size == 2){ >>>>>>>> + amd_iommu_writew(s, addr, val); >>>>>>>> + } else if(size == 4){ >>>>>>>> + amd_iommu_writel(s, addr, val); >>>>>>>> + } else if(size == 8){ >>>>>>>> + amd_iommu_writeq(s, addr, val); >>>>>>>> + } >>>>>>>> + break; >>>>>>>> + >>>>>>>> + default: >>>>>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr >>>>>>>> 0x%"PRIx64 >>>>>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>>>>> 0x%"PRIx64, addr, size, val, offset); >>>>>>>> + ; >>>>>>>> + } >>>>>>>> + >>>>>>>> +} >>>>>>>> + >>>>>>>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent >>>>>>>> *evt) >>>>>>>> +{ >>>>>>>> + /* event logging not enabled */ >>>>>>>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>>>>>>> MMIO_STATUS_EVTLOG_OF){ >>>>>>>> + return; >>>>>>>> + } >>>>>>>> + >>>>>>>> + /* event log buffer full */ >>>>>>>> + if(s->evtlog_tail >= s->evtlog_len) { >>>>>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= >>>>>>>> MMIO_STATUS_EVTLOG_OF; >>>>>>>> + } >>>>>>>> + >>>>>>>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>>>>>>> s->evtlog_tail, &evt, EVENT_LEN)){ >>>>>>>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address >>>>>>>> 0%x"PRIu8, >>>>>>>> s->evtlog + s->evtlog_tail); >>>>>>>> + } >>>>>>>> + >>>>>>>> + s->evtlog_tail += EVENT_LEN; >>>>>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>>>>>>> + /* Disable logging if Overflow ? */ >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> No, the spec details event logging restart procedure. Make sure >>>>>>> emulated >>>>>>> IOMMU behaves as described there. >>>>>>> >>>>>>> >>>>>>>> +} >>>>>>>> + >>>>>>>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, >>>>>>>> unsigned >>>>>>>> domid, dma_addr_t addr, int present, >>>>>>>> + int is_write) >>>>>>>> +{ >>>>>>>> + IOMMU_DPRINTF(ELOG, ""); >>>>>>>> + >>>>>>>> + AMDIOMMUEvent evt; >>>>>>>> + unsigned info; >>>>>>>> + uint16_t status; >>>>>>>> + >>>>>>>> + evt.devfn = cpu_to_le16(devfn); >>>>>>>> + evt.reserved = 0; >>>>>>>> + evt.domid = cpu_to_le16(domid); >>>>>>>> + evt.addr = cpu_to_le16(addr); >>>>>>>> + >>>>>>>> + info = EVENT_IOPF; >>>>>>>> + >>>>>>>> + if(present) { >>>>>>>> + info |= EVENT_IOPF_PR; >>>>>>>> + } >>>>>>>> + >>>>>>>> + if (is_write) { >>>>>>>> + info |= EVENT_IOPF_RW; >>>>>>>> + } >>>>>>>> + >>>>>>>> + /* log a page fault */ >>>>>>>> + amd_iommu_log_event(s, &evt); >>>>>>>> + >>>>>>>> + /* Abort the translation */ >>>>>>>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>>>>>>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>>>>>>> PCI_STATUS_SIG_TARGET_ABORT); >>>>>>>> +} >>>>>>>> + >>>>>>>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>>>>>>> +{ >>>>>>>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> >>>>>>>> DEV_PERM_SHIFT; >>>>>>>> +} >>>>>>>> + >>>>>>>> +/* FIXME deduplication */ >>>>>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>>>>> devfn) >>>>>>>> +{ >>>>>>>> + AMDIOMMUState *s = opaque; >>>>>>>> + AMDIOMMUAddressSpace **iommu_as; >>>>>>>> + int bus_num = pci_bus_num(bus); >>>>>>>> + >>>>>>>> + /* just in case */ >>>>>>>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>>>>>>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>>>>>>> + >>>>>>>> + iommu_as = s->address_spaces[bus_num]; >>>>>>>> + >>>>>>>> + /* allocate memory during the first run */ >>>>>>>> + if(!iommu_as) { >>>>>>>> + iommu_as = >>>>>>>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>>>>>>> + s->address_spaces[bus_num] = iommu_as; >>>>>>>> + } >>>>>>>> + >>>>>>>> + /* set up IOMMU region */ >>>>>>>> + if(!iommu_as[devfn]){ >>>>>>>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>>>>>>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>>>>>>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>>>>>>> + iommu_as[devfn]->iommu_state = s; >>>>>>>> + >>>>>>>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>>>>>>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>>>>>>> + address_space_init(&iommu_as[devfn]->as, >>>>>>>> &iommu_as[devfn]->iommu, >>>>>>>> "amd-iommu"); >>>>>>>> + } >>>>>>>> + return &iommu_as[devfn]->as; >>>>>>>> +} >>>>>>>> + >>>>>>>> +/* validate a page table entry */ >>>>>>>> +static bool amd_iommu_validate_pte(uint64_t pte) >>>>>>>> +{ >>>>>>>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> I'd suggest parenthesis here. >>>>>>> >>>>>>> >>>>>>>> +} >>>>>>>> + >>>>>>>> +/* get a device table entry given the device function */ >>>>>>>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>>>>>>> *entry) >>>>>>>> +{ >>>>>>>> + /* Could lead to out of range accesses */ >>>>>>>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>>>>>>> + >>>>>>>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>>>>>>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, >>>>>>>> entry, >>>>>>>> 32)){ >>>>>>>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry >>>>>>>> devtab >>>>>>>> 0x%"PRIx64 >>>>>>>> + "offset 0x%"PRIx32, s->devtab, offset); >>>>>>>> + return false; >>>>>>>> + } >>>>>>>> + >>>>>>>> + if(!amd_iommu_validate_pte(entry[0])){ >>>>>>>> + IOMMU_DPRINTF(MMU, >>>>>>>> + "Pte entry at 0x%"PRIx64" is invalid", >>>>>>>> entry[0]); >>>>>>>> + return false; >>>>>>>> + } >>>>>>>> + >>>>>>>> + return true; >>>>>>>> +} >>>>>>>> + >>>>>>>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>>>>>>> +{ >>>>>>>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>>>>> + >>>>>>>> + if(level == 7){ >>>>>>>> + /* reserved level - abort ? */ >>>>>>>> + IOMMU_DPRINTF(MMU, >>>>>>>> + "Reserved translation level (7) detected"); >>>>>>>> + return 0; >>>>>>>> + } >>>>>>>> + >>>>>>>> + return level; >>>>>>>> +} >>>>>>>> + >>>>>>>> +/* TODO : Mark addresses as Accessed and Dirty */ >>>>>>>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr >>>>>>>> addr, >>>>>>>> bool is_write, IOMMUTLBEntry *ret) >>>>>>>> +{ >>>>>>>> + AMDIOMMUState *s = as->iommu_state; >>>>>>>> + >>>>>>>> + int present; >>>>>>>> + dma_addr_t pte_addr; >>>>>>>> + uint64_t entry[4], pte, pte_perms; >>>>>>>> + unsigned level; >>>>>>>> + unsigned perms; >>>>>>>> + >>>>>>>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>>>>>>> + goto no_translation; >>>>>>>> + } >>>>>>>> + >>>>>>>> + pte = entry[0]; >>>>>>>> + >>>>>>>> + /* >>>>>>>> + * It's okay to check for either read or write permissions >>>>>>>> + * even for memory maps, since we don't support R/W maps. >>>>>>>> + */ >>>>>>>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>>>>>>> + >>>>>>>> + if(!(level = get_pte_translation_mode(pte))){ >>>>>>>> + goto no_translation; >>>>>>>> + } >>>>>>>> + >>>>>>>> + while(level > 0){ >>>>>>>> + /* >>>>>>>> + * check permissions: the bitwise >>>>>>>> + * implication perms -> entry_perms must be true. Pages >>>>>>>> must >>>>>>>> be >>>>>>>> present >>>>>>>> + * and permissions on all levels must be similar >>>>>>>> + */ >>>>>>>> + pte_perms = amd_iommu_get_perms(pte); >>>>>>>> + present = pte & 1; >>>>>>>> + if(!present || perms != (perms & pte_perms)){ >>>>>>>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>>>>>>> DEV_DOMID_ID_MASK, addr, present, >>>>>>>> + !!(perms & IOMMU_PERM_WRITE)); >>>>>>>> + return; >>>>>>>> + } >>>>>>>> + >>>>>>>> + /* go to the next lower level */ >>>>>>>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>>>>>>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Does this work for six level page tables? The highest level has >>>>>>> different >>>>>>> bit size there IIRC. >>>>>>> >>>>>>>> + pte = ldq_phys(&address_space_memory, pte_addr); >>>>>>>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>>>>> + } >>>>>>>> + >>>>>>>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>>>>>>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & >>>>>>>> IOMMU_PAGE_MASK_4K; >>>>>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>>>> + ret->perm = IOMMU_RW; >>>>>>>> + return; >>>>>>>> + >>>>>>>> +no_translation: >>>>>>>> + ret->iova = addr; >>>>>>>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>>>> + ret->perm = IOMMU_RW; >>>>>>>> + return; >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Are you sure these transactions needs to be passed through rather >>>>>>> than >>>>>>> target-aborted? >>>>>>> >>>>>>>> +} >>>>>>>> + >>>>>>>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, >>>>>>>> hwaddr >>>>>>>> addr, bool is_write) >>>>>>>> +{ >>>>>>>> + >>>>>>>> + IOMMU_DPRINTF(GENERAL, ""); >>>>>>>> + >>>>>>>> + AMDIOMMUAddressSpace *as = container_of(iommu, >>>>>>>> AMDIOMMUAddressSpace, >>>>>>>> iommu); >>>>>>>> + AMDIOMMUState *s = as->iommu_state; >>>>>>>> + >>>>>>>> + IOMMUTLBEntry ret = { >>>>>>>> + .target_as = &address_space_memory, >>>>>>>> + .iova = addr, >>>>>>>> + .translated_addr = 0, >>>>>>>> + .addr_mask = ~(hwaddr)0, >>>>>>>> + .perm = IOMMU_NONE, >>>>>>>> + }; >>>>>>>> + >>>>>>>> + if(!s->enabled){ >>>>>>>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>>>>>>> provide any parameter */ >>>>>>>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>>>>>>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>>>>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>>>>> + ret.perm = IOMMU_RW; >>>>>>>> + return ret; >>>>>>>> + } >>>>>>>> + >>>>>>>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>>>>>>> + >>>>>>>> + IOMMU_DPRINTF(MMU, >>>>>>>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa >>>>>>>> 0x%"PRIx64, >>>>>>>> as->bus_num, >>>>>>>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>>>>>>> ret.translated_addr); >>>>>>>> + >>>>>>>> + return ret; >>>>>>>> +} >>>>>>>> + >>>>>>>> +static const MemoryRegionOps mmio_mem_ops = { >>>>>>>> + .read = amd_iommu_mmio_read, >>>>>>>> + .write = amd_iommu_mmio_write, >>>>>>>> + .endianness = DEVICE_LITTLE_ENDIAN, >>>>>>>> + .valid = { >>>>>>>> + .min_access_size = 1, >>>>>>>> + .max_access_size = 8, >>>>>>>> + .unaligned = false, >>>>>>>> + }, >>>>>>>> + >>>>>>>> + .valid = { >>>>>>>> + .min_access_size = 8, >>>>>>>> + .max_access_size = 8, >>>>>>>> + }, >>>>>>>> +}; >>>>>>>> + >>>>>>>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t >>>>>>>> host_pa, >>>>>>>> uint32_t guest_va, uint32_t *reg) >>>>>>>> +{ >>>>>>>> + *reg = 0; >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Redundant line. >>>>>>> >>>>>>> >>>>>>>> + >>>>>>>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>>>>>>> +} >>>>>>>> + >>>>>>>> +/* FIXME: The similar code in reset and init could be combined into >>>>>>>> a >>>>>>>> function */ >>>>>>>> +static void amd_iommu_reset(DeviceState *dev) >>>>>>>> +{ >>>>>>>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>>>>>>> + >>>>>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>>>>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>>>>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> >>>>>>>> 16; >>>>>>>> + uint32_t capab_range = 0xff000000; >>>>>>>> + uint32_t capab_misc = 0x0; >>>>>>>> + >>>>>>>> + /* reset MMIO */ >>>>>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>>>>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>>>>>>> + /* TODO :Disable event logging and reset all buffers */ >>>>>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, >>>>>>>> MAX_GVA_ADDR, >>>>>>>> &capab_misc); >>>>>>>> + >>>>>>>> + /* reset IOMMU specific capabilities */ >>>>>>>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>>>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>>>>>>> capab_base_addr_low); >>>>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>>>>>>> capab_base_addr_high); >>>>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>>>>>>> capab_range); >>>>>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>>>>>>> capab_misc); >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Do we also need to reset MSI capability block? >>>>>>> >>>>>>> >>>>>>>> + >>>>>>>> + /* reset device ident */ >>>>>>>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>>>>>>> + pci_config_set_device_id(s->dev.config, >>>>>>>> PCI_DEVICE_ID_RD890_IOMMU); >>>>>>>> + pci_config_set_class(s->dev.config, 0x0806); >>>>>>>> + pci_config_set_prog_interface(s->dev.config, 00); >>>>>>>> +} >>>>>>>> + >>>>>>>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, >>>>>>>> uint32_t >>>>>>>> val, int len) >>>>>>>> +{ >>>>>>>> + pci_default_write_config(dev, addr, val, len); >>>>>>>> +} >>>>>>>> + >>>>>>>> +/* I honestly don't know how to reserve MMIO */ >>>>>>>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>>>>>>> +{ >>>>>>>> + if(s->mmio.addr == addr){ >>>>>>>> + return; >>>>>>>> + } >>>>>>>> + >>>>>>>> +// if(s->mmio.addr != (hwaddr)-1) { >>>>>>>> +// memory_region_del_subregion(get_system_memory(), >>>>>>>> &s->mmio); >>>>>>>> +// } >>>>>>>> + >>>>>>>> + s->mmio.addr = addr; >>>>>>>> + memory_region_add_subregion(get_system_memory(), addr, >>>>>>>> &s->mmio); >>>>>>>> + >>>>>>>> +} >>>>>>>> + >>>>>>>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>>>>>>> +{ >>>>>>>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>>>>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>>>>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>>>>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >>>>>>>> >> >>>>>>>> 16); >>>>>>>> + uint32_t capab_range = 0xff000000; >>>>>>>> + uint32_t capab_misc = 0x0; >>>>>>>> + >>>>>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, >>>>>>>> MAX_GVA_ADDR, >>>>>>>> &capab_misc); >>>>>>>> + >>>>>>>> + s->iommu_ops.translate = amd_iommu_translate; >>>>>>>> + s->enabled = false; >>>>>>>> + s->ats_enabled = false; >>>>>>>> + s->cmdbuf_enabled = false; >>>>>>>> + s->devtab_len = 0; >>>>>>>> + s->cmdbuf_len = 0; >>>>>>>> + s->cmdbuf_head = 0; >>>>>>>> + s->cmdbuf_tail = 0; >>>>>>>> + s->evtlog_head = 0; >>>>>>>> + s->evtlog_tail = 0; >>>>>>>> + s->excl_enabled = false; >>>>>>>> + s->excl_allow = false; >>>>>>>> + s->mmio_enabled = false; >>>>>>>> + dev->config_write = amd_iommu_write_capab; >>>>>>>> + >>>>>>>> + size_t offset; >>>>>>>> + /* Save offset for IVRS */ >>>>>>>> + s->capab_offset = offset = pci_add_capability(dev, >>>>>>>> PCI_CAP_ID_SEC, >>>>>>>> 0, >>>>>>>> CAPAB_SIZE); >>>>>>>> + pci_set_long(s->dev.config + offset, capab_header); >>>>>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>>>>>>> capab_base_addr_low); >>>>>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>>>>>>> capab_base_addr_high); >>>>>>>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, >>>>>>>> capab_range); >>>>>>>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>>>>>>> + >>>>>>>> + /* add msi and hypertransport capabilities */ >>>>>>>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>>>>>>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>>>>>>> + >>>>>>>> + /* set up MMIO */ >>>>>>>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>>>>>>> "amd-iommu", MMIO_SIZE); >>>>>>>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>>>>>>> + >>>>>>>> + /* reset device ident */ >>>>>>>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>>>>>>> + pci_config_set_device_id(dev->config, >>>>>>>> PCI_DEVICE_ID_RD890_IOMMU); >>>>>>>> + >>>>>>>> + /* may not be necessary */ >>>>>>>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>>>>>>> + >>>>>>>> + return 0; >>>>>>>> +} >>>>>>>> + >>>>>>>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>>>>>>> +{ >>>>>>>> + amd_iommu_pci_initfn(dev); >>>>>>>> +} >>>>>>>> + >>>>>>>> +static const VMStateDescription vmstate_amd_iommu = { >>>>>>>> + .name = "amd-iommu", >>>>>>>> + .fields = (VMStateField[]) { >>>>>>>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>>>>>>> + VMSTATE_END_OF_LIST() >>>>>>>> + } >>>>>>>> +}; >>>>>>>> + >>>>>>>> +static Property amd_iommu_properties[] = { >>>>>>>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>>>>>>> + DEFINE_PROP_END_OF_LIST(), >>>>>>>> +}; >>>>>>>> + >>>>>>>> +/* not used for now but will be when cache is added */ >>>>>>>> +static void amd_iommu_uninit(PCIDevice *dev) >>>>>>>> +{ >>>>>>>> + return; >>>>>>>> +} >>>>>>>> + >>>>>>>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>>>>>>> +{ >>>>>>>> + DeviceClass *dc = DEVICE_CLASS(klass); >>>>>>>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>>>>>>> + >>>>>>>> + pci->realize = amd_iommu_realize; >>>>>>>> + pci->exit = amd_iommu_uninit; >>>>>>>> + >>>>>>>> + dc->reset = amd_iommu_reset; >>>>>>>> + dc->vmsd = &vmstate_amd_iommu; >>>>>>>> + dc->props = amd_iommu_properties; >>>>>>>> +} >>>>>>>> + >>>>>>>> +static const TypeInfo amd_iommu = { >>>>>>>> + .name = TYPE_AMD_IOMMU_DEVICE, >>>>>>>> + .parent = TYPE_PCI_DEVICE, >>>>>>>> + .instance_size = sizeof(AMDIOMMUState), >>>>>>>> + .class_init = amd_iommu_class_init >>>>>>>> +}; >>>>>>>> + >>>>>>>> +static void amd_iommu_register_types(void) >>>>>>>> +{ >>>>>>>> + type_register_static(&amd_iommu); >>>>>>>> +} >>>>>>>> + >>>>>>>> +type_init(amd_iommu_register_types); >>>>>>>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>>>>>>> new file mode 100644 >>>>>>>> index 0000000..90309eb >>>>>>>> --- /dev/null >>>>>>>> +++ b/hw/i386/amd_iommu.h >>>>>>>> @@ -0,0 +1,298 @@ >>>>>>>> +/* >>>>>>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>>>>>> + * >>>>>>>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>>>>>>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>>>>>>> + * >>>>>>>> + * This program is free software; you can redistribute it and/or >>>>>>>> modify >>>>>>>> + * it under the terms of the GNU General Public License as >>>>>>>> published >>>>>>>> by >>>>>>>> + * the Free Software Foundation; either version 2 of the License, >>>>>>>> or >>>>>>>> + * (at your option) any later version. >>>>>>>> + >>>>>>>> + * This program is distributed in the hope that it will be useful, >>>>>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>>>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>>>>>> + * GNU General Public License for more details. >>>>>>>> + >>>>>>>> + * You should have received a copy of the GNU General Public >>>>>>>> License >>>>>>>> along >>>>>>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>>>>>> + */ >>>>>>>> + >>>>>>>> +#ifndef AMD_IOMMU_H_ >>>>>>>> +#define AMD_IOMMU_H_ >>>>>>>> + >>>>>>>> +#include "hw/hw.h" >>>>>>>> +#include "hw/pci/pci.h" >>>>>>>> +#include "hw/sysbus.h" >>>>>>>> +#include "sysemu/dma.h" >>>>>>>> +#include "qemu/osdep.h" >>>>>>>> +#include "qemu/event_notifier.h" >>>>>>>> + >>>>>>>> +/* Capability registers */ >>>>>>>> +#define CAPAB_HEADER 0x00 >>>>>>>> +#define CAPAB_REV_TYPE 0x02 >>>>>>>> +#define CAPAB_FLAGS 0x03 >>>>>>>> +#define CAPAB_BAR_LOW 0x04 >>>>>>>> +#define CAPAB_BAR_HIGH 0x08 >>>>>>>> +#define CAPAB_RANGE 0x0C >>>>>>>> +#define CAPAB_MISC 0x10 >>>>>>>> +#define CAPAB_MISC1 0x14 >>>>>>>> + >>>>>>>> +#define CAPAB_SIZE 0x18 >>>>>>>> +#define CAPAB_REG_SIZE 0x04 >>>>>>>> + >>>>>>>> +/* Capability header data */ >>>>>>>> +#define CAPAB_FLAT_EXT (1 << 28) >>>>>>>> +#define CAPAB_EFR_SUP (1 << 27) >>>>>>>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>>>>>>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>>>>>>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>>>>>>> +#define CAPAB_INIT_REV (1 << 19) >>>>>>>> +#define CAPAB_INIT_TYPE (3 << 16) >>>>>>>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>>>>>>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>>>>>>> CAPAB_FLAG_HTTUNNEL) >>>>>>>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>>>>>>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>>>>>>> + >>>>>>>> +/* MMIO registers */ >>>>>>>> +#define MMIO_DEVICE_TABLE 0x0000 >>>>>>>> +#define MMIO_COMMAND_BASE 0x0008 >>>>>>>> +#define MMIO_EVENT_BASE 0x0010 >>>>>>>> +#define MMIO_CONTROL 0x0018 >>>>>>>> +#define MMIO_EXCL_BASE 0x0020 >>>>>>>> +#define MMIO_EXCL_LIMIT 0x0028 >>>>>>>> +#define MMIO_EXT_FEATURES 0x0030 >>>>>>>> +#define MMIO_COMMAND_HEAD 0x2000 >>>>>>>> +#define MMIO_COMMAND_TAIL 0x2008 >>>>>>>> +#define MMIO_EVENT_HEAD 0x2010 >>>>>>>> +#define MMIO_EVENT_TAIL 0x2018 >>>>>>>> +#define MMIO_STATUS 0x2020 >>>>>>>> +#define MMIO_PPR_BASE 0x0038 >>>>>>>> +#define MMIO_PPR_HEAD 0x2030 >>>>>>>> +#define MMIO_PPR_TAIL 0x2038 >>>>>>>> + >>>>>>>> +#define MMIO_SIZE 0x4000 >>>>>>>> + >>>>>>>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>>>>>>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>>>>>>> ~MMIO_DEVTAB_SIZE_MASK) >>>>>>>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>>>>>>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>>>>>>> + >>>>>>>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>>>>>>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>>>>>>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>>>>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>>>>>>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>>>>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>>>>> + >>>>>>>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>>>>>>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>>>>>>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>>>>>>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>>>>>>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>>>>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>>>>> + >>>>>>>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>>>>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>>>>>>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>>>>>>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>>>>>>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>>>>>>> + >>>>>>>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>>>>>>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>>>>>>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>>>>>>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>>>>>>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>>>>>>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>>>>>>> + >>>>>>>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>>>>>>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>>>>>>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>>>>>>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>>>>>>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>>>>>>> + >>>>>>>> +#define CMDBUF_ID_BYTE 0x07 >>>>>>>> +#define CMDBUF_ID_RSHIFT 4 >>>>>>>> +#define CMDBUF_ENTRY_SIZE 0x10 >>>>>>>> + >>>>>>>> +#define CMD_COMPLETION_WAIT 0x01 >>>>>>>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>>>>>>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>>>>>>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>>>>>>> +#define CMD_INVAL_INTR_TABLE 0x05 >>>>>>>> + >>>>>>>> +#define DEVTAB_ENTRY_SIZE 32 >>>>>>>> + >>>>>>>> +/* Device table entry bits 0:63 */ >>>>>>>> +#define DEV_VALID (1ULL << 0) >>>>>>>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>>>>>>> +#define DEV_MODE_MASK 0x7 >>>>>>>> +#define DEV_MODE_RSHIFT 9 >>>>>>>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>>>>>>> +#define DEV_PT_ROOT_RSHIFT 12 >>>>>>>> +#define DEV_PERM_SHIFT 61 >>>>>>>> +#define DEV_PERM_READ (1ULL << 61) >>>>>>>> +#define DEV_PERM_WRITE (1ULL << 62) >>>>>>>> + >>>>>>>> +/* Device table entry bits 64:127 */ >>>>>>>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>>>>>>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>>>>>>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>>>>>>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>>>>>>> +#define DEV_IOCTL_MASK (~3) >>>>>>>> +#define DEV_IOCTL_RSHIFT 20 >>>>>>>> +#define DEV_IOCTL_DENY 0 >>>>>>>> +#define DEV_IOCTL_PASSTHROUGH 1 >>>>>>>> +#define DEV_IOCTL_TRANSLATE 2 >>>>>>>> +#define DEV_CACHE (1ULL << 37) >>>>>>>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>>>>>>> +#define DEV_EXCL (1ULL << 39) >>>>>>>> + >>>>>>>> +/* Event codes and flags, as stored in the info field */ >>>>>>>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>>>>>>> +#define EVENT_IOPF (0x2U << 24) >>>>>>>> +#define EVENT_IOPF_I (1U << 3) >>>>>>>> +#define EVENT_IOPF_PR (1U << 4) >>>>>>>> +#define EVENT_IOPF_RW (1U << 5) >>>>>>>> +#define EVENT_IOPF_PE (1U << 6) >>>>>>>> +#define EVENT_IOPF_RZ (1U << 7) >>>>>>>> +#define EVENT_IOPF_TR (1U << 8) >>>>>>>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>>>>>>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>>>>>>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>>>>>>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>>>>>>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>>>>>>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>>>>>>> + >>>>>>>> +#define EVENT_LEN 16 >>>>>>>> + >>>>>>>> +#define IOMMU_PERM_READ (1 << 0) >>>>>>>> +#define IOMMU_PERM_WRITE (1 << 1) >>>>>>>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | >>>>>>>> IOMMU_PERM_WRITE) >>>>>>>> + >>>>>>>> +/* AMD RD890 Chipset */ >>>>>>>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>>>>>>> + >>>>>>>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability >>>>>>>> header >>>>>>>> register */ >>>>>>>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>>>>>>> register */ >>>>>>>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>>>>>>> register */ >>>>>>>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>>>>>>> */ >>>>>>>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous >>>>>>>> Information >>>>>>>> register 0 */ >>>>>>>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous >>>>>>>> Information >>>>>>>> register 1 */ >>>>>>>> + >>>>>>>> +#define FEATURE_PREFETCH (1ULL<<0) >>>>>>>> +#define FEATURE_PPR (1ULL<<1) >>>>>>>> +#define FEATURE_NX (1ULL<<3) >>>>>>>> +#define FEATURE_GT (1ULL<<4) >>>>>>>> +#define FEATURE_IA (1ULL<<6) >>>>>>>> +#define FEATURE_GA (1ULL<<7) >>>>>>>> +#define FEATURE_HE (1ULL<<8) >>>>>>>> +#define FEATURE_PC (1ULL<<9) >>>>>>>> + >>>>>>>> +/* IOMMU paging mode */ >>>>>>>> +#define GATS_MODE (6ULL << 12) >>>>>>>> +#define HATS_MODE (6ULL << 10) >>>>>>>> +/* PCI SIG constants */ >>>>>>>> +#define PCI_BUS_MAX 256 >>>>>>>> +#define PCI_SLOT_MAX 32 >>>>>>>> +#define PCI_FUNC_MAX 8 >>>>>>>> +#define PCI_DEVFN_MAX 256 >>>>>>>> + >>>>>>>> +/* extended feature support */ >>>>>>>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>>>>>>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | >>>>>>>> HATS_MODE ) >>>>>>>> + >>>>>>>> +/* capabilities header */ >>>>>>>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>>>>>>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | >>>>>>>> CAPAB_FLAG_HTTUNNEL >>>>>>>> | CAPAB_EFR_SUP) >>>>>>>> + >>>>>>>> +/* command constants */ >>>>>>>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>>>>>>> +#define COM_COMPLETION_STORE_MASK 0x1 >>>>>>>> +#define COM_COMPLETION_INTR 0x2 >>>>>>>> +#define COM_COMPLETION_DATA_OFF 0x8 >>>>>>>> +#define IOMMU_COMMAND_SIZE 0x10 >>>>>>>> + >>>>>>>> +/* IOMMU default address */ >>>>>>>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>>>>>>> + >>>>>>>> +/* page management constants */ >>>>>>>> +#define IOMMU_PAGE_SHIFT 12 >>>>>>>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>>>>>>> + >>>>>>>> +#define IOMMU_PAGE_SHIFT_4K 12 >>>>>>>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>>>>>>> +#define IOMMU_PAGE_SHIFT_2M 21 >>>>>>>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>>>>>>> +#define IOMMU_PAGE_SHIFT_1G 30 >>>>>>>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>>>>>>> + >>>>>>>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>>>>>>> +#define AMD_IOMMU_DEVICE(obj)\ >>>>>>>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>>>>>>> + >>>>>>>> +typedef struct AMDIOMMUState AMDIOMMUState; >>>>>>>> + >>>>>>>> +typedef struct AMDIOMMUAddressSpace{ >>>>>>>> + uint8_t bus_num; /* bus number >>>>>>>> */ >>>>>>>> + uint8_t devfn; /* device function >>>>>>>> */ >>>>>>>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>>>>>>> */ >>>>>>>> + MemoryRegion iommu; /* Device's iommu region >>>>>>>> */ >>>>>>>> + AddressSpace as; /* device's corresponding address >>>>>>>> space >>>>>>>> */ >>>>>>>> +}AMDIOMMUAddressSpace; >>>>>>>> + >>>>>>>> +struct AMDIOMMUState { >>>>>>>> + PCIDevice dev; /* The PCI device itself */ >>>>>>>> + >>>>>>>> + uint32_t version; >>>>>>>> + >>>>>>>> + int capab_offset; /* capability offset pointer */ >>>>>>>> + unsigned char *capab; /* capabilities registers */ >>>>>>>> + >>>>>>>> + bool enabled; /* IOMMU enabled */ >>>>>>>> + bool ats_enabled; /* address translation enabled */ >>>>>>>> + bool cmdbuf_enabled; /* command buffer enabled */ >>>>>>>> + bool evtlog_enabled; /* event log enabled */ >>>>>>>> + bool excl_enabled; >>>>>>>> + >>>>>>>> + dma_addr_t devtab; /* base address device table */ >>>>>>>> + size_t devtab_len; /* device table length */ >>>>>>>> + >>>>>>>> + dma_addr_t cmdbuf; /* command buffer base address */ >>>>>>>> + uint64_t cmdbuf_len; /* command buffer length */ >>>>>>>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>>>>>>> + unsigned cmdbuf_tail; /* next Software write position */ >>>>>>>> + int completion_wait_intr; >>>>>>>> + >>>>>>>> + dma_addr_t evtlog; /* base address event log */ >>>>>>>> + size_t evtlog_intr; >>>>>>>> + size_t evtlog_len; /* event log length */ >>>>>>>> + size_t evtlog_head; /* event log head */ >>>>>>>> + size_t evtlog_tail; /* event log tail */ >>>>>>>> + >>>>>>>> + /* unused for now */ >>>>>>>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion >>>>>>>> range >>>>>>>> */ >>>>>>>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range >>>>>>>> */ >>>>>>>> + bool excl_allow; /* translate accesses to the >>>>>>>> exclusion >>>>>>>> range */ >>>>>>>> + bool excl_enable; /* exclusion range enabled >>>>>>>> */ >>>>>>>> + >>>>>>>> + MemoryRegion mmio; /* MMIO region */ >>>>>>>> + unsigned char mmior[MMIO_SIZE]; >>>>>>>> + bool mmio_enabled; >>>>>>>> + >>>>>>>> + /* IOMMU function */ >>>>>>>> + MemoryRegionIOMMUOps iommu_ops; >>>>>>>> + >>>>>>>> + /* for each served device */ >>>>>>>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>>>>>>> +}; >>>>>>>> + >>>>>>>> +typedef struct AMDIOMMUEvent { >>>>>>>> + uint16_t devfn; >>>>>>>> + uint16_t reserved; >>>>>>>> + uint16_t domid; >>>>>>>> + uint16_t info; >>>>>>>> + uint16_t addr; >>>>>>>> +} __attribute__((packed)) AMDIOMMUEvent; >>>>>>>> + >>>>>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>>>>> devfn); >>>>>>>> + >>>>>>>> +#endif >>>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> Valentine >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> С уважением, >>>>> Синицын Валентин ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-09 7:45 ` Valentine Sinitsyn 2015-09-09 7:59 ` David kiarie @ 2015-09-09 7:59 ` Michael S. Tsirkin 2015-09-09 8:04 ` Valentine Sinitsyn 1 sibling, 1 reply; 22+ messages in thread From: Michael S. Tsirkin @ 2015-09-09 7:59 UTC (permalink / raw) To: Valentine Sinitsyn; +Cc: David kiarie, Jan Kiszka, QEMU Developers On Wed, Sep 09, 2015 at 12:45:10PM +0500, Valentine Sinitsyn wrote: > On 09.09.2015 12:30, David kiarie wrote: > ...snip... > > >>>+static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) > >>>+{ > >>>+ unsigned type; > >>>+ uint8_t cmd[IOMMU_COMMAND_SIZE]; > >>>+ > >>>+ IOMMU_DPRINTF(COMMAND, ""); > >>>+ memset(cmd, 0, IOMMU_COMMAND_SIZE); > >>>+ > >>>+ if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, > >>>cmd, IOMMU_COMMAND_SIZE)){ > >>>+ IOMMU_DPRINTF(COMMAND, "error: fail to access memory at > >>>0x%"PRIx64 > >>>+ " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); > >>>+ } > >>>+ > >>>+ type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; > >>>+ > >>>+ switch(type){ > >>>+ case CMD_COMPLETION_WAIT: > >>>+ /* pretend to wait for command execution to complete */ > >>>+ IOMMU_DPRINTF(COMMAND, "completion wait requested"); > >>>+ amd_iommu_completion_wait(s, cmd); > >>>+ break; > >>>+ case CMD_INVAL_DEVTAB_ENTRY: > >>>+ /* Not implemented yet - should just clear device table > >>>contents */ > >>>+ IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); > >> > >>Better make it clear that these commands are not implemented yet. An IOMMU > >>is hardly usable without invalidators. > > > >I think the "debug prinft" here is misleading. AFAIK, the commands > >listed here(there are others which I haven't listed) relate to 'cache' > >which means this commands do nothing in the absence of cache. > > > >The reason why I advertise 'cache' is because the linux driver checks > >for cache and other optional features to determine the IOMMU version > >whereby versions 2 of IOMMU are assummed to support this features. > Did you check how address translation is emulated in QEMU. I didn't :) But > you return IOMMTLBEntry from your translation routine, and I'd rather ensure > it is not cached in some other layer. > > Besides, omitting invalidation commands will be a problem on real hardware. > As IOMMU emulation is mainly useful for debugging, I'd reproduce this > behaviour in the emulator. I mean, if I forget to do CMD_INVAL_DEVTAB_ENTRY > in my guest code, things shouldn't work properly. That's hardly a priority. IOMMU is useful for other things besides debugging. > You can just copy all data structures to AMDIOMMUState and use this "cahced" > copies, updated when you run invalidation commands. But this isn't a #1 > priority, you are right. > > Can you share some tests results for this code? > > > >> > >>>+ break; > >>>+ case CMD_INVAL_IOMMU_PAGES: > >>>+ /* invalidate IOMMU cache for a particular domain */ > >>>+ IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); > >>>+ break; > >>>+ case CMD_INVAL_IOTLB_PAGES: > >>>+ /* Only present if remote IOTLB present */ > >>>+ IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); > >>>+ break; > >>>+ case CMD_INVAL_INTR_TABLE: > >>>+ /* no support for interrupt remapping yet */ > >>>+ IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); > >>>+ break; > >>>+ default: > >>>+ IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); > >>>+ break; > >>>+ } > >>>+ > >>>+} > >>>+ > >>>+static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) > >>>+{ > >>>+ IOMMU_DPRINTF(COMMAND, ""); > >>>+ > >>>+ uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; > >>>+ > >>>+ if(!s->cmdbuf_enabled){ > >>>+ IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); > >>>+ return; > >>>+ } > >>>+ > >>>+ while(s->cmdbuf_head != s->cmdbuf_tail) { > >>>+ /* check if there is work to do. */ > >>>+ IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER > >>>tail at %x", > >>>+ s->cmdbuf_head, s->cmdbuf_tail); > >>>+ amd_iommu_cmdbuf_exec(s); > >>>+ s->cmdbuf_head += CMDBUF_ENTRY_SIZE; > >>>+ > >>>+ /* wrap head pointer */ > >>>+ if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { > >>>+ s->cmdbuf_head = 0; > >>>+ } > >>>+ } > >>>+ > >>>+ *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); > >>>+} > >>>+ > >>>+/* System Software might never read from some of this fields but anyways > >>>*/ > >>>+static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned > >>>size) > >>>+{ > >>>+ AMDIOMMUState *s = opaque; > >>>+ > >>>+ uint64_t val = -1; > >>>+ if(addr + size > MMIO_SIZE) { > >>>+ IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 > >>>+ ", got 0x%"PRIx64 " %d", > >>>+ (uint64_t)MMIO_SIZE, addr, size); > >>>+ return (uint64_t) - 1; > >>>+ } > >>>+ > >>>+ switch(addr & ~0x07){ > >>>+ case MMIO_DEVICE_TABLE: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >> > >>What makes these cases different, except debug printf()s? Maybe leave > >>printf()s inside the switch, and factor out the rest. This applies to other > >>similar cases as well. > >> > >> > >>>+ > >>>+ case MMIO_COMMAND_BASE: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_EVENT_BASE: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_CONTROL: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_EXCL_BASE: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_EXCL_LIMIT: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_COMMAND_HEAD: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_COMMAND_TAIL: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_EVENT_HEAD: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_EVENT_TAIL: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_STATUS: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_EXT_FEATURES: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ if(size == 2){ > >>>+ val = amd_iommu_readw(s, addr); > >>>+ } else if(size == 4){ > >>>+ val = amd_iommu_readl(s, addr); > >>>+ } > >>>+ else if(size == 8){ > >>>+ val = amd_iommu_readq(s, addr); > >>>+ } > >>>+ break; > >>>+ > >>>+ default: > >>>+ IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 > >>>+ ", size %d offset 0x%"PRIx64, addr, size, > >>>offset); > >>>+ } > >>>+ > >>>+ return val; > >>>+} > >>>+ > >>>+static void iommu_handle_control_write(AMDIOMMUState *s) > >>>+{ > >>>+ /* read whatever is already written incase software is writing in > >>>chucks less than 8 bytes */ > >>>+ unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); > >>>+ s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); > >>>+ > >>>+ s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); > >>>+ s->evtlog_enabled = s->enabled && !!(control & > >>>MMIO_CONTROL_EVENTLOGEN); > >>>+ > >>>+ s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); > >>>+ s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); > >>>+ s->cmdbuf_enabled = s->enabled && !!(control & > >>>MMIO_CONTROL_CMDBUFLEN); > >>>+ > >>>+ /* update the flags depending on the control register */ > >>>+ if(s->cmdbuf_enabled) { > >>>+ (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; > >>>+ } else { > >>>+ (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; > >>>+ } > >>>+ if (s->evtlog_enabled) { > >>>+ (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; > >>>+ } else { > >>>+ (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; > >>>+ } > >>>+ > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); > >>>+ > >>>+ amd_iommu_cmdbuf_run(s); > >> > >>Does any write to control register result in draining command buffer? To me, > >>it looks strange, and I'd expect IOMMU to execute commands only if I change > >>tail pointer. > >> > >> > >>>+} > >>>+ > >>>+/* FIXME: something might go wrong if System Software writes in chunks > >>>+ * of one byte but linux writes in chunks of 4 bytes so currently it > >>>+ * works correctly with linux but will definitely be busted if software > >>>+ * reads/writes 8 bytes > >>>+ */ > >>>+static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, > >>>unsigned size) > >>>+{ > >>>+ > >>>+ AMDIOMMUState *s = opaque; > >>>+ unsigned long offset = addr & 0x07; > >>>+ > >>>+ if(addr + size > MMIO_SIZE) { > >>>+ IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 > >>>+ ", got 0x%"PRIx64 " %d", > >>>+ (uint64_t)MMIO_SIZE, addr, size); > >>>+ return; > >>>+ } > >>>+ > >>>+ switch(addr & ~0x07){ > >>>+ case MMIO_CONTROL: > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 > >>>, addr, size, val, offset); > >>>+ iommu_handle_control_write(s); > >>>+ break; > >>>+ > >>>+ case MMIO_DEVICE_TABLE: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ > >>>+ /* set device table address > >>>+ * This also suffers from inability to tell whether software > >>>is done writing > >>>+ */ > >>>+ if(offset || (size == 8)){ > >>>+ unsigned long device_base = amd_iommu_readq(s, > >>>MMIO_DEVICE_TABLE); > >>>+ s->devtab = (dma_addr_t)(device_base & > >>>MMIO_CMDBUF_BASE_MASK); > >>>+ /* set device table length */ > >>>+ s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + > >>>1) * (MMIO_DEVTAB_SIZE_UNIT / > >>>+ MMIO_DEVTAB_ENTRY_SIZE); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_COMMAND_HEAD: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; > >>>+ amd_iommu_cmdbuf_run(s); > >>>+ break; > >>>+ > >>>+ case MMIO_COMMAND_BASE: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ > >>>+ /* FIXME - make sure System Software has finished writing > >>>incase it writes > >>>+ * in chucks less than 8 bytes in a robust way.As for now, > >>>this hacks works > >>>+ * for the linux driver > >>>+ */ > >>>+ if(offset || (size == 8)){ > >>>+ unsigned long command_base = amd_iommu_readq(s, > >>>MMIO_COMMAND_BASE); > >>>+ s->cmdbuf = (dma_addr_t)(command_base & > >>>MMIO_CMDBUF_BASE_MASK); > >>>+ s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & > >>>MMIO_CMDBUF_SIZE_MASK); > >>>+ s->cmdbuf_head = s->cmdbuf_tail = 0; > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_COMMAND_TAIL: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ > >>>+ s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; > >>>+ amd_iommu_cmdbuf_run(s); > >>>+ break; > >>>+ > >>>+ case MMIO_EVENT_BASE: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); > >>>+ s->evtlog_len = 1UL << > >>>(*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); > >>>+ break; > >>>+ > >>>+ case MMIO_EXCL_LIMIT: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | > >>>MMIO_EXCL_LIMIT_LOW; > >>>+ break; > >>>+ //TODO : Event handling fixes > >>>+ > >>>+ case MMIO_EVENT_HEAD: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ break; > >>>+ > >>>+ case MMIO_EVENT_TAIL: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ break; > >>>+ /* PPR log base - unused for now */ > >>>+ case MMIO_PPR_BASE: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ break; > >>>+ /* PPR log head - also unused for now */ > >>>+ case MMIO_PPR_HEAD: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ break; > >>>+ /* PPR log tail - unused for now */ > >>>+ case MMIO_PPR_TAIL: > >>>+ IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ if(size == 2){ > >>>+ amd_iommu_writew(s, addr, val); > >>>+ } else if(size == 4){ > >>>+ amd_iommu_writel(s, addr, val); > >>>+ } else if(size == 8){ > >>>+ amd_iommu_writeq(s, addr, val); > >>>+ } > >>>+ break; > >>>+ > >>>+ default: > >>>+ IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 > >>>+ ", size %d, val 0x%"PRIx64 ", offset > >>>0x%"PRIx64, addr, size, val, offset); > >>>+ ; > >>>+ } > >>>+ > >>>+} > >>>+ > >>>+static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) > >>>+{ > >>>+ /* event logging not enabled */ > >>>+ if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | > >>>MMIO_STATUS_EVTLOG_OF){ > >>>+ return; > >>>+ } > >>>+ > >>>+ /* event log buffer full */ > >>>+ if(s->evtlog_tail >= s->evtlog_len) { > >>>+ *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; > >>>+ } > >>>+ > >>>+ if(dma_memory_write(&address_space_memory, s->evtlog_len + > >>>s->evtlog_tail, &evt, EVENT_LEN)){ > >>>+ //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, > >>>s->evtlog + s->evtlog_tail); > >>>+ } > >>>+ > >>>+ s->evtlog_tail += EVENT_LEN; > >>>+ *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; > >>>+ /* Disable logging if Overflow ? */ > >> > >>No, the spec details event logging restart procedure. Make sure emulated > >>IOMMU behaves as described there. > >> > >> > >>>+} > >>>+ > >>>+static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned > >>>domid, dma_addr_t addr, int present, > >>>+ int is_write) > >>>+{ > >>>+ IOMMU_DPRINTF(ELOG, ""); > >>>+ > >>>+ AMDIOMMUEvent evt; > >>>+ unsigned info; > >>>+ uint16_t status; > >>>+ > >>>+ evt.devfn = cpu_to_le16(devfn); > >>>+ evt.reserved = 0; > >>>+ evt.domid = cpu_to_le16(domid); > >>>+ evt.addr = cpu_to_le16(addr); > >>>+ > >>>+ info = EVENT_IOPF; > >>>+ > >>>+ if(present) { > >>>+ info |= EVENT_IOPF_PR; > >>>+ } > >>>+ > >>>+ if (is_write) { > >>>+ info |= EVENT_IOPF_RW; > >>>+ } > >>>+ > >>>+ /* log a page fault */ > >>>+ amd_iommu_log_event(s, &evt); > >>>+ > >>>+ /* Abort the translation */ > >>>+ status = pci_get_word(s->dev.config + PCI_STATUS); > >>>+ pci_set_word(s->dev.config + PCI_STATUS, status | > >>>PCI_STATUS_SIG_TARGET_ABORT); > >>>+} > >>>+ > >>>+static inline uint64_t amd_iommu_get_perms(uint64_t entry) > >>>+{ > >>>+ return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; > >>>+} > >>>+ > >>>+/* FIXME deduplication */ > >>>+AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) > >>>+{ > >>>+ AMDIOMMUState *s = opaque; > >>>+ AMDIOMMUAddressSpace **iommu_as; > >>>+ int bus_num = pci_bus_num(bus); > >>>+ > >>>+ /* just in case */ > >>>+ assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); > >>>+ assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); > >>>+ > >>>+ iommu_as = s->address_spaces[bus_num]; > >>>+ > >>>+ /* allocate memory during the first run */ > >>>+ if(!iommu_as) { > >>>+ iommu_as = > >>>g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); > >>>+ s->address_spaces[bus_num] = iommu_as; > >>>+ } > >>>+ > >>>+ /* set up IOMMU region */ > >>>+ if(!iommu_as[devfn]){ > >>>+ iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); > >>>+ iommu_as[devfn]->bus_num = (uint8_t)bus_num; > >>>+ iommu_as[devfn]->devfn = (uint8_t)devfn; > >>>+ iommu_as[devfn]->iommu_state = s; > >>>+ > >>>+ memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), > >>>&s->iommu_ops, "amd-iommu", UINT64_MAX); > >>>+ address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, > >>>"amd-iommu"); > >>>+ } > >>>+ return &iommu_as[devfn]->as; > >>>+} > >>>+ > >>>+/* validate a page table entry */ > >>>+static bool amd_iommu_validate_pte(uint64_t pte) > >>>+{ > >>>+ return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; > >> > >>I'd suggest parenthesis here. > >> > >> > >>>+} > >>>+ > >>>+/* get a device table entry given the device function */ > >>>+static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t > >>>*entry) > >>>+{ > >>>+ /* Could lead to out of range accesses */ > >>>+ assert(0 < devfn && devfn < PCI_DEVFN_MAX); > >>>+ > >>>+ uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; > >>>+ if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, > >>>32)){ > >>>+ IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab > >>>0x%"PRIx64 > >>>+ "offset 0x%"PRIx32, s->devtab, offset); > >>>+ return false; > >>>+ } > >>>+ > >>>+ if(!amd_iommu_validate_pte(entry[0])){ > >>>+ IOMMU_DPRINTF(MMU, > >>>+ "Pte entry at 0x%"PRIx64" is invalid", entry[0]); > >>>+ return false; > >>>+ } > >>>+ > >>>+ return true; > >>>+} > >>>+ > >>>+static uint64_t get_pte_translation_mode(uint64_t pte) > >>>+{ > >>>+ uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; > >>>+ > >>>+ if(level == 7){ > >>>+ /* reserved level - abort ? */ > >>>+ IOMMU_DPRINTF(MMU, > >>>+ "Reserved translation level (7) detected"); > >>>+ return 0; > >>>+ } > >>>+ > >>>+ return level; > >>>+} > >>>+ > >>>+/* TODO : Mark addresses as Accessed and Dirty */ > >>>+static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, > >>>bool is_write, IOMMUTLBEntry *ret) > >>>+{ > >>>+ AMDIOMMUState *s = as->iommu_state; > >>>+ > >>>+ int present; > >>>+ dma_addr_t pte_addr; > >>>+ uint64_t entry[4], pte, pte_perms; > >>>+ unsigned level; > >>>+ unsigned perms; > >>>+ > >>>+ if(!amd_iommu_get_dte(s, as->devfn, entry)){ > >>>+ goto no_translation; > >>>+ } > >>>+ > >>>+ pte = entry[0]; > >>>+ > >>>+ /* > >>>+ * It's okay to check for either read or write permissions > >>>+ * even for memory maps, since we don't support R/W maps. > >>>+ */ > >>>+ perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; > >>>+ > >>>+ if(!(level = get_pte_translation_mode(pte))){ > >>>+ goto no_translation; > >>>+ } > >>>+ > >>>+ while(level > 0){ > >>>+ /* > >>>+ * check permissions: the bitwise > >>>+ * implication perms -> entry_perms must be true. Pages must be > >>>present > >>>+ * and permissions on all levels must be similar > >>>+ */ > >>>+ pte_perms = amd_iommu_get_perms(pte); > >>>+ present = pte & 1; > >>>+ if(!present || perms != (perms & pte_perms)){ > >>>+ amd_iommu_page_fault(s, as->devfn, entry[1] & > >>>DEV_DOMID_ID_MASK, addr, present, > >>>+ !!(perms & IOMMU_PERM_WRITE)); > >>>+ return; > >>>+ } > >>>+ > >>>+ /* go to the next lower level */ > >>>+ pte_addr = pte & DEV_PT_ROOT_MASK; > >>>+ pte_addr += ((addr >> ( 9 * level)) & 0xff8); > >> > >>Does this work for six level page tables? The highest level has different > >>bit size there IIRC. > >> > >>>+ pte = ldq_phys(&address_space_memory, pte_addr); > >>>+ level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; > >>>+ } > >>>+ > >>>+ ret->iova = addr & IOMMU_PAGE_MASK_4K; > >>>+ ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; > >>>+ ret->addr_mask = ~IOMMU_PAGE_MASK_4K; > >>>+ ret->perm = IOMMU_RW; > >>>+ return; > >>>+ > >>>+no_translation: > >>>+ ret->iova = addr; > >>>+ ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; > >>>+ ret->addr_mask = ~IOMMU_PAGE_MASK_4K; > >>>+ ret->perm = IOMMU_RW; > >>>+ return; > >> > >>Are you sure these transactions needs to be passed through rather than > >>target-aborted? > >> > >>>+} > >>>+ > >>>+static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr > >>>addr, bool is_write) > >>>+{ > >>>+ > >>>+ IOMMU_DPRINTF(GENERAL, ""); > >>>+ > >>>+ AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, > >>>iommu); > >>>+ AMDIOMMUState *s = as->iommu_state; > >>>+ > >>>+ IOMMUTLBEntry ret = { > >>>+ .target_as = &address_space_memory, > >>>+ .iova = addr, > >>>+ .translated_addr = 0, > >>>+ .addr_mask = ~(hwaddr)0, > >>>+ .perm = IOMMU_NONE, > >>>+ }; > >>>+ > >>>+ if(!s->enabled){ > >>>+ /* IOMMU disabled - corresponds to iommu=off not failure to > >>>provide any parameter */ > >>>+ ret.iova = addr & IOMMU_PAGE_MASK_4K; > >>>+ ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; > >>>+ ret.addr_mask = ~IOMMU_PAGE_MASK_4K; > >>>+ ret.perm = IOMMU_RW; > >>>+ return ret; > >>>+ } > >>>+ > >>>+ amd_iommu_do_translate(as, addr, is_write, &ret); > >>>+ > >>>+ IOMMU_DPRINTF(MMU, > >>>+ "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, > >>>as->bus_num, > >>>+ PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, > >>>ret.translated_addr); > >>>+ > >>>+ return ret; > >>>+} > >>>+ > >>>+static const MemoryRegionOps mmio_mem_ops = { > >>>+ .read = amd_iommu_mmio_read, > >>>+ .write = amd_iommu_mmio_write, > >>>+ .endianness = DEVICE_LITTLE_ENDIAN, > >>>+ .valid = { > >>>+ .min_access_size = 1, > >>>+ .max_access_size = 8, > >>>+ .unaligned = false, > >>>+ }, > >>>+ > >>>+ .valid = { > >>>+ .min_access_size = 8, > >>>+ .max_access_size = 8, > >>>+ }, > >>>+}; > >>>+ > >>>+static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, > >>>uint32_t guest_va, uint32_t *reg) > >>>+{ > >>>+ *reg = 0; > >> > >>Redundant line. > >> > >> > >>>+ > >>>+ *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; > >>>+} > >>>+ > >>>+/* FIXME: The similar code in reset and init could be combined into a > >>>function */ > >>>+static void amd_iommu_reset(DeviceState *dev) > >>>+{ > >>>+ AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); > >>>+ > >>>+ uint32_t capab_header = CAPAB_FEATURES; > >>>+ uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); > >>>+ uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; > >>>+ uint32_t capab_range = 0xff000000; > >>>+ uint32_t capab_misc = 0x0; > >>>+ > >>>+ /* reset MMIO */ > >>>+ memset(s->mmior, 0, MMIO_SIZE); > >>>+ amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); > >>>+ /* TODO :Disable event logging and reset all buffers */ > >>>+ amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, > >>>&capab_misc); > >>>+ > >>>+ /* reset IOMMU specific capabilities */ > >>>+ pci_set_long(s->dev.config + s->capab_offset, capab_header); > >>>+ pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, > >>>capab_base_addr_low); > >>>+ pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, > >>>capab_base_addr_high); > >>>+ pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, > >>>capab_range); > >>>+ pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, > >>>capab_misc); > >> > >> > >>Do we also need to reset MSI capability block? > >> > >> > >>>+ > >>>+ /* reset device ident */ > >>>+ pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); > >>>+ pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); > >>>+ pci_config_set_class(s->dev.config, 0x0806); > >>>+ pci_config_set_prog_interface(s->dev.config, 00); > >>>+} > >>>+ > >>>+static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t > >>>val, int len) > >>>+{ > >>>+ pci_default_write_config(dev, addr, val, len); > >>>+} > >>>+ > >>>+/* I honestly don't know how to reserve MMIO */ > >>>+static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) > >>>+{ > >>>+ if(s->mmio.addr == addr){ > >>>+ return; > >>>+ } > >>>+ > >>>+// if(s->mmio.addr != (hwaddr)-1) { > >>>+// memory_region_del_subregion(get_system_memory(), &s->mmio); > >>>+// } > >>>+ > >>>+ s->mmio.addr = addr; > >>>+ memory_region_add_subregion(get_system_memory(), addr, &s->mmio); > >>>+ > >>>+} > >>>+ > >>>+static int amd_iommu_pci_initfn(PCIDevice *dev) > >>>+{ > >>>+ AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); > >>>+ uint32_t capab_header = CAPAB_FEATURES; > >>>+ uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); > >>>+ uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); > >>>+ uint32_t capab_range = 0xff000000; > >>>+ uint32_t capab_misc = 0x0; > >>>+ > >>>+ memset(s->mmior, 0, MMIO_SIZE); > >>>+ amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, > >>>&capab_misc); > >>>+ > >>>+ s->iommu_ops.translate = amd_iommu_translate; > >>>+ s->enabled = false; > >>>+ s->ats_enabled = false; > >>>+ s->cmdbuf_enabled = false; > >>>+ s->devtab_len = 0; > >>>+ s->cmdbuf_len = 0; > >>>+ s->cmdbuf_head = 0; > >>>+ s->cmdbuf_tail = 0; > >>>+ s->evtlog_head = 0; > >>>+ s->evtlog_tail = 0; > >>>+ s->excl_enabled = false; > >>>+ s->excl_allow = false; > >>>+ s->mmio_enabled = false; > >>>+ dev->config_write = amd_iommu_write_capab; > >>>+ > >>>+ size_t offset; > >>>+ /* Save offset for IVRS */ > >>>+ s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, > >>>CAPAB_SIZE); > >>>+ pci_set_long(s->dev.config + offset, capab_header); > >>>+ pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, > >>>capab_base_addr_low); > >>>+ pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, > >>>capab_base_addr_high); > >>>+ pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); > >>>+ pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); > >>>+ > >>>+ /* add msi and hypertransport capabilities */ > >>>+ pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); > >>>+ pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); > >>>+ > >>>+ /* set up MMIO */ > >>>+ memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, > >>>"amd-iommu", MMIO_SIZE); > >>>+ amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); > >>>+ > >>>+ /* reset device ident */ > >>>+ pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); > >>>+ pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); > >>>+ > >>>+ /* may not be necessary */ > >>>+ pci_config_set_interrupt_pin(dev->config, 0x1a); > >>>+ > >>>+ return 0; > >>>+} > >>>+ > >>>+static void amd_iommu_realize(PCIDevice *dev, Error **error) > >>>+{ > >>>+ amd_iommu_pci_initfn(dev); > >>>+} > >>>+ > >>>+static const VMStateDescription vmstate_amd_iommu = { > >>>+ .name = "amd-iommu", > >>>+ .fields = (VMStateField[]) { > >>>+ VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), > >>>+ VMSTATE_END_OF_LIST() > >>>+ } > >>>+}; > >>>+ > >>>+static Property amd_iommu_properties[] = { > >>>+ DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), > >>>+ DEFINE_PROP_END_OF_LIST(), > >>>+}; > >>>+ > >>>+/* not used for now but will be when cache is added */ > >>>+static void amd_iommu_uninit(PCIDevice *dev) > >>>+{ > >>>+ return; > >>>+} > >>>+ > >>>+static void amd_iommu_class_init(ObjectClass *klass, void* data) > >>>+{ > >>>+ DeviceClass *dc = DEVICE_CLASS(klass); > >>>+ PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); > >>>+ > >>>+ pci->realize = amd_iommu_realize; > >>>+ pci->exit = amd_iommu_uninit; > >>>+ > >>>+ dc->reset = amd_iommu_reset; > >>>+ dc->vmsd = &vmstate_amd_iommu; > >>>+ dc->props = amd_iommu_properties; > >>>+} > >>>+ > >>>+static const TypeInfo amd_iommu = { > >>>+ .name = TYPE_AMD_IOMMU_DEVICE, > >>>+ .parent = TYPE_PCI_DEVICE, > >>>+ .instance_size = sizeof(AMDIOMMUState), > >>>+ .class_init = amd_iommu_class_init > >>>+}; > >>>+ > >>>+static void amd_iommu_register_types(void) > >>>+{ > >>>+ type_register_static(&amd_iommu); > >>>+} > >>>+ > >>>+type_init(amd_iommu_register_types); > >>>diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > >>>new file mode 100644 > >>>index 0000000..90309eb > >>>--- /dev/null > >>>+++ b/hw/i386/amd_iommu.h > >>>@@ -0,0 +1,298 @@ > >>>+/* > >>>+ * QEMU emulation of an AMD IOMMU (AMD-Vi) > >>>+ * > >>>+ * Copyright (C) 2011 Eduard-Gabriel Mateanu > >>>+ * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> > >>>+ * > >>>+ * This program is free software; you can redistribute it and/or modify > >>>+ * it under the terms of the GNU General Public License as published by > >>>+ * the Free Software Foundation; either version 2 of the License, or > >>>+ * (at your option) any later version. > >>>+ > >>>+ * This program is distributed in the hope that it will be useful, > >>>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of > >>>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >>>+ * GNU General Public License for more details. > >>>+ > >>>+ * You should have received a copy of the GNU General Public License > >>>along > >>>+ * with this program; if not, see <http://www.gnu.org/licenses/>. > >>>+ */ > >>>+ > >>>+#ifndef AMD_IOMMU_H_ > >>>+#define AMD_IOMMU_H_ > >>>+ > >>>+#include "hw/hw.h" > >>>+#include "hw/pci/pci.h" > >>>+#include "hw/sysbus.h" > >>>+#include "sysemu/dma.h" > >>>+#include "qemu/osdep.h" > >>>+#include "qemu/event_notifier.h" > >>>+ > >>>+/* Capability registers */ > >>>+#define CAPAB_HEADER 0x00 > >>>+#define CAPAB_REV_TYPE 0x02 > >>>+#define CAPAB_FLAGS 0x03 > >>>+#define CAPAB_BAR_LOW 0x04 > >>>+#define CAPAB_BAR_HIGH 0x08 > >>>+#define CAPAB_RANGE 0x0C > >>>+#define CAPAB_MISC 0x10 > >>>+#define CAPAB_MISC1 0x14 > >>>+ > >>>+#define CAPAB_SIZE 0x18 > >>>+#define CAPAB_REG_SIZE 0x04 > >>>+ > >>>+/* Capability header data */ > >>>+#define CAPAB_FLAT_EXT (1 << 28) > >>>+#define CAPAB_EFR_SUP (1 << 27) > >>>+#define CAPAB_FLAG_NPCACHE (1 << 26) > >>>+#define CAPAB_FLAG_HTTUNNEL (1 << 25) > >>>+#define CAPAB_FLAG_IOTLBSUP (1 << 24) > >>>+#define CAPAB_INIT_REV (1 << 19) > >>>+#define CAPAB_INIT_TYPE (3 << 16) > >>>+#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) > >>>+#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | > >>>CAPAB_FLAG_HTTUNNEL) > >>>+#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) > >>>+#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) > >>>+ > >>>+/* MMIO registers */ > >>>+#define MMIO_DEVICE_TABLE 0x0000 > >>>+#define MMIO_COMMAND_BASE 0x0008 > >>>+#define MMIO_EVENT_BASE 0x0010 > >>>+#define MMIO_CONTROL 0x0018 > >>>+#define MMIO_EXCL_BASE 0x0020 > >>>+#define MMIO_EXCL_LIMIT 0x0028 > >>>+#define MMIO_EXT_FEATURES 0x0030 > >>>+#define MMIO_COMMAND_HEAD 0x2000 > >>>+#define MMIO_COMMAND_TAIL 0x2008 > >>>+#define MMIO_EVENT_HEAD 0x2010 > >>>+#define MMIO_EVENT_TAIL 0x2018 > >>>+#define MMIO_STATUS 0x2020 > >>>+#define MMIO_PPR_BASE 0x0038 > >>>+#define MMIO_PPR_HEAD 0x2030 > >>>+#define MMIO_PPR_TAIL 0x2038 > >>>+ > >>>+#define MMIO_SIZE 0x4000 > >>>+ > >>>+#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) > >>>+#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & > >>>~MMIO_DEVTAB_SIZE_MASK) > >>>+#define MMIO_DEVTAB_ENTRY_SIZE 32 > >>>+#define MMIO_DEVTAB_SIZE_UNIT 4096 > >>>+ > >>>+#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) > >>>+#define MMIO_CMDBUF_SIZE_MASK 0x0F > >>>+#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK > >>>+#define MMIO_CMDBUF_DEFAULT_SIZE 8 > >>>+#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) > >>>+#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK > >>>+ > >>>+#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) > >>>+#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK > >>>+#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK > >>>+#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE > >>>+#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) > >>>+#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK > >>>+ > >>>+#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK > >>>+#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) > >>>+#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) > >>>+#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK > >>>+#define MMIO_EXCL_LIMIT_LOW 0xFFF > >>>+ > >>>+#define MMIO_CONTROL_IOMMUEN (1ULL << 0) > >>>+#define MMIO_CONTROL_HTTUNEN (1ULL << 1) > >>>+#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) > >>>+#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) > >>>+#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) > >>>+#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) > >>>+ > >>>+#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) > >>>+#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) > >>>+#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) > >>>+#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) > >>>+#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) > >>>+ > >>>+#define CMDBUF_ID_BYTE 0x07 > >>>+#define CMDBUF_ID_RSHIFT 4 > >>>+#define CMDBUF_ENTRY_SIZE 0x10 > >>>+ > >>>+#define CMD_COMPLETION_WAIT 0x01 > >>>+#define CMD_INVAL_DEVTAB_ENTRY 0x02 > >>>+#define CMD_INVAL_IOMMU_PAGES 0x03 > >>>+#define CMD_INVAL_IOTLB_PAGES 0x04 > >>>+#define CMD_INVAL_INTR_TABLE 0x05 > >>>+ > >>>+#define DEVTAB_ENTRY_SIZE 32 > >>>+ > >>>+/* Device table entry bits 0:63 */ > >>>+#define DEV_VALID (1ULL << 0) > >>>+#define DEV_TRANSLATION_VALID (1ULL << 1) > >>>+#define DEV_MODE_MASK 0x7 > >>>+#define DEV_MODE_RSHIFT 9 > >>>+#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 > >>>+#define DEV_PT_ROOT_RSHIFT 12 > >>>+#define DEV_PERM_SHIFT 61 > >>>+#define DEV_PERM_READ (1ULL << 61) > >>>+#define DEV_PERM_WRITE (1ULL << 62) > >>>+ > >>>+/* Device table entry bits 64:127 */ > >>>+#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) > >>>+#define DEV_IOTLB_SUPPORT (1ULL << 17) > >>>+#define DEV_SUPPRESS_PF (1ULL << 18) > >>>+#define DEV_SUPPRESS_ALL_PF (1ULL << 19) > >>>+#define DEV_IOCTL_MASK (~3) > >>>+#define DEV_IOCTL_RSHIFT 20 > >>>+#define DEV_IOCTL_DENY 0 > >>>+#define DEV_IOCTL_PASSTHROUGH 1 > >>>+#define DEV_IOCTL_TRANSLATE 2 > >>>+#define DEV_CACHE (1ULL << 37) > >>>+#define DEV_SNOOP_DISABLE (1ULL << 38) > >>>+#define DEV_EXCL (1ULL << 39) > >>>+ > >>>+/* Event codes and flags, as stored in the info field */ > >>>+#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) > >>>+#define EVENT_IOPF (0x2U << 24) > >>>+#define EVENT_IOPF_I (1U << 3) > >>>+#define EVENT_IOPF_PR (1U << 4) > >>>+#define EVENT_IOPF_RW (1U << 5) > >>>+#define EVENT_IOPF_PE (1U << 6) > >>>+#define EVENT_IOPF_RZ (1U << 7) > >>>+#define EVENT_IOPF_TR (1U << 8) > >>>+#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) > >>>+#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) > >>>+#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) > >>>+#define EVENT_COMMAND_HW_ERROR (0x6U << 24) > >>>+#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) > >>>+#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) > >>>+ > >>>+#define EVENT_LEN 16 > >>>+ > >>>+#define IOMMU_PERM_READ (1 << 0) > >>>+#define IOMMU_PERM_WRITE (1 << 1) > >>>+#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) > >>>+ > >>>+/* AMD RD890 Chipset */ > >>>+#define PCI_DEVICE_ID_RD890_IOMMU 0x20 > >>>+ > >>>+#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header > >>>register */ > >>>+#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low > >>>register */ > >>>+#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high > >>>register */ > >>>+#define PCI_CAP_ID_RANGE 0x0 /* Device range register > >>>*/ > >>>+#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information > >>>register 0 */ > >>>+#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information > >>>register 1 */ > >>>+ > >>>+#define FEATURE_PREFETCH (1ULL<<0) > >>>+#define FEATURE_PPR (1ULL<<1) > >>>+#define FEATURE_NX (1ULL<<3) > >>>+#define FEATURE_GT (1ULL<<4) > >>>+#define FEATURE_IA (1ULL<<6) > >>>+#define FEATURE_GA (1ULL<<7) > >>>+#define FEATURE_HE (1ULL<<8) > >>>+#define FEATURE_PC (1ULL<<9) > >>>+ > >>>+/* IOMMU paging mode */ > >>>+#define GATS_MODE (6ULL << 12) > >>>+#define HATS_MODE (6ULL << 10) > >>>+/* PCI SIG constants */ > >>>+#define PCI_BUS_MAX 256 > >>>+#define PCI_SLOT_MAX 32 > >>>+#define PCI_FUNC_MAX 8 > >>>+#define PCI_DEVFN_MAX 256 > >>>+ > >>>+/* extended feature support */ > >>>+#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | > >>>FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) > >>>+ > >>>+/* capabilities header */ > >>>+#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | > >>>CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL > >>>| CAPAB_EFR_SUP) > >>>+ > >>>+/* command constants */ > >>>+#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 > >>>+#define COM_COMPLETION_STORE_MASK 0x1 > >>>+#define COM_COMPLETION_INTR 0x2 > >>>+#define COM_COMPLETION_DATA_OFF 0x8 > >>>+#define IOMMU_COMMAND_SIZE 0x10 > >>>+ > >>>+/* IOMMU default address */ > >>>+#define BUS_AMD_IOMMU_ADDR 0xfeb00000 > >>>+ > >>>+/* page management constants */ > >>>+#define IOMMU_PAGE_SHIFT 12 > >>>+#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) > >>>+ > >>>+#define IOMMU_PAGE_SHIFT_4K 12 > >>>+#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) > >>>+#define IOMMU_PAGE_SHIFT_2M 21 > >>>+#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) > >>>+#define IOMMU_PAGE_SHIFT_1G 30 > >>>+#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) > >>>+ > >>>+#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" > >>>+#define AMD_IOMMU_DEVICE(obj)\ > >>>+ OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) > >>>+ > >>>+typedef struct AMDIOMMUState AMDIOMMUState; > >>>+ > >>>+typedef struct AMDIOMMUAddressSpace{ > >>>+ uint8_t bus_num; /* bus number > >>>*/ > >>>+ uint8_t devfn; /* device function > >>>*/ > >>>+ AMDIOMMUState *iommu_state; /* IOMMU - one per machine > >>>*/ > >>>+ MemoryRegion iommu; /* Device's iommu region > >>>*/ > >>>+ AddressSpace as; /* device's corresponding address space > >>>*/ > >>>+}AMDIOMMUAddressSpace; > >>>+ > >>>+struct AMDIOMMUState { > >>>+ PCIDevice dev; /* The PCI device itself */ > >>>+ > >>>+ uint32_t version; > >>>+ > >>>+ int capab_offset; /* capability offset pointer */ > >>>+ unsigned char *capab; /* capabilities registers */ > >>>+ > >>>+ bool enabled; /* IOMMU enabled */ > >>>+ bool ats_enabled; /* address translation enabled */ > >>>+ bool cmdbuf_enabled; /* command buffer enabled */ > >>>+ bool evtlog_enabled; /* event log enabled */ > >>>+ bool excl_enabled; > >>>+ > >>>+ dma_addr_t devtab; /* base address device table */ > >>>+ size_t devtab_len; /* device table length */ > >>>+ > >>>+ dma_addr_t cmdbuf; /* command buffer base address */ > >>>+ uint64_t cmdbuf_len; /* command buffer length */ > >>>+ unsigned cmdbuf_head; /* current IOMMU read position */ > >>>+ unsigned cmdbuf_tail; /* next Software write position */ > >>>+ int completion_wait_intr; > >>>+ > >>>+ dma_addr_t evtlog; /* base address event log */ > >>>+ size_t evtlog_intr; > >>>+ size_t evtlog_len; /* event log length */ > >>>+ size_t evtlog_head; /* event log head */ > >>>+ size_t evtlog_tail; /* event log tail */ > >>>+ > >>>+ /* unused for now */ > >>>+ dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ > >>>+ dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ > >>>+ bool excl_allow; /* translate accesses to the exclusion > >>>range */ > >>>+ bool excl_enable; /* exclusion range enabled */ > >>>+ > >>>+ MemoryRegion mmio; /* MMIO region */ > >>>+ unsigned char mmior[MMIO_SIZE]; > >>>+ bool mmio_enabled; > >>>+ > >>>+ /* IOMMU function */ > >>>+ MemoryRegionIOMMUOps iommu_ops; > >>>+ > >>>+ /* for each served device */ > >>>+ AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; > >>>+}; > >>>+ > >>>+typedef struct AMDIOMMUEvent { > >>>+ uint16_t devfn; > >>>+ uint16_t reserved; > >>>+ uint16_t domid; > >>>+ uint16_t info; > >>>+ uint16_t addr; > >>>+} __attribute__((packed)) AMDIOMMUEvent; > >>>+ > >>>+AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int > >>>devfn); > >>>+ > >>>+#endif > >>> > >> > >>Regards, > >>Valentine > > -- > С уважением, > Синицын Валентин ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-09 7:59 ` Michael S. Tsirkin @ 2015-09-09 8:04 ` Valentine Sinitsyn 0 siblings, 0 replies; 22+ messages in thread From: Valentine Sinitsyn @ 2015-09-09 8:04 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: David kiarie, Jan Kiszka, QEMU Developers On 09.09.2015 12:59, Michael S. Tsirkin wrote: > On Wed, Sep 09, 2015 at 12:45:10PM +0500, Valentine Sinitsyn wrote: >> On 09.09.2015 12:30, David kiarie wrote: >> ...snip... >> >>>>> +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) >>>>> +{ >>>>> + unsigned type; >>>>> + uint8_t cmd[IOMMU_COMMAND_SIZE]; >>>>> + >>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>> + memset(cmd, 0, IOMMU_COMMAND_SIZE); >>>>> + >>>>> + if(dma_memory_read(&address_space_memory, s->cmdbuf + s->cmdbuf_head, >>>>> cmd, IOMMU_COMMAND_SIZE)){ >>>>> + IOMMU_DPRINTF(COMMAND, "error: fail to access memory at >>>>> 0x%"PRIx64 >>>>> + " + %"PRIu8, s->cmdbuf, s->cmdbuf_head); >>>>> + } >>>>> + >>>>> + type = cmd[CMDBUF_ID_BYTE] >> CMDBUF_ID_RSHIFT; >>>>> + >>>>> + switch(type){ >>>>> + case CMD_COMPLETION_WAIT: >>>>> + /* pretend to wait for command execution to complete */ >>>>> + IOMMU_DPRINTF(COMMAND, "completion wait requested"); >>>>> + amd_iommu_completion_wait(s, cmd); >>>>> + break; >>>>> + case CMD_INVAL_DEVTAB_ENTRY: >>>>> + /* Not implemented yet - should just clear device table >>>>> contents */ >>>>> + IOMMU_DPRINTF(COMMAND, "device table entries invalidated"); >>>> >>>> Better make it clear that these commands are not implemented yet. An IOMMU >>>> is hardly usable without invalidators. >>> >>> I think the "debug prinft" here is misleading. AFAIK, the commands >>> listed here(there are others which I haven't listed) relate to 'cache' >>> which means this commands do nothing in the absence of cache. >>> >>> The reason why I advertise 'cache' is because the linux driver checks >>> for cache and other optional features to determine the IOMMU version >>> whereby versions 2 of IOMMU are assummed to support this features. >> Did you check how address translation is emulated in QEMU. I didn't :) But >> you return IOMMTLBEntry from your translation routine, and I'd rather ensure >> it is not cached in some other layer. >> >> Besides, omitting invalidation commands will be a problem on real hardware. >> As IOMMU emulation is mainly useful for debugging, I'd reproduce this >> behaviour in the emulator. I mean, if I forget to do CMD_INVAL_DEVTAB_ENTRY >> in my guest code, things shouldn't work properly. > > That's hardly a priority. IOMMU is useful for other things besides > debugging. OK, let it be my own personal favorite. :) >> You can just copy all data structures to AMDIOMMUState and use this "cahced" >> copies, updated when you run invalidation commands. But this isn't a #1 >> priority, you are right. >> >> Can you share some tests results for this code? >>> >>>> >>>>> + break; >>>>> + case CMD_INVAL_IOMMU_PAGES: >>>>> + /* invalidate IOMMU cache for a particular domain */ >>>>> + IOMMU_DPRINTF(COMMAND, "IOMMU pages invalidated"); >>>>> + break; >>>>> + case CMD_INVAL_IOTLB_PAGES: >>>>> + /* Only present if remote IOTLB present */ >>>>> + IOMMU_DPRINTF(COMMAND, "IOTLB pages invalidated"); >>>>> + break; >>>>> + case CMD_INVAL_INTR_TABLE: >>>>> + /* no support for interrupt remapping yet */ >>>>> + IOMMU_DPRINTF(COMMAND, "interrupt table invalidated"); >>>>> + break; >>>>> + default: >>>>> + IOMMU_DPRINTF(COMMAND, "unhandled command %d", type); >>>>> + break; >>>>> + } >>>>> + >>>>> +} >>>>> + >>>>> +static void amd_iommu_cmdbuf_run(AMDIOMMUState *s) >>>>> +{ >>>>> + IOMMU_DPRINTF(COMMAND, ""); >>>>> + >>>>> + uint64_t *mmio_cmdbuf_head = (uint64_t*)s->mmior + MMIO_COMMAND_HEAD; >>>>> + >>>>> + if(!s->cmdbuf_enabled){ >>>>> + IOMMU_DPRINTF(COMMAND, "Command buffer not enabled"); >>>>> + return; >>>>> + } >>>>> + >>>>> + while(s->cmdbuf_head != s->cmdbuf_tail) { >>>>> + /* check if there is work to do. */ >>>>> + IOMMU_DPRINTF(COMMAND, "COMMAND BUFFER head at %x COMMAND BUFFER >>>>> tail at %x", >>>>> + s->cmdbuf_head, s->cmdbuf_tail); >>>>> + amd_iommu_cmdbuf_exec(s); >>>>> + s->cmdbuf_head += CMDBUF_ENTRY_SIZE; >>>>> + >>>>> + /* wrap head pointer */ >>>>> + if (s->cmdbuf_head >= s->cmdbuf_len * CMDBUF_ENTRY_SIZE) { >>>>> + s->cmdbuf_head = 0; >>>>> + } >>>>> + } >>>>> + >>>>> + *mmio_cmdbuf_head = cpu_to_le64(s->cmdbuf_head); >>>>> +} >>>>> + >>>>> +/* System Software might never read from some of this fields but anyways >>>>> */ >>>>> +static uint64_t amd_iommu_mmio_read(void *opaque, hwaddr addr, unsigned >>>>> size) >>>>> +{ >>>>> + AMDIOMMUState *s = opaque; >>>>> + >>>>> + uint64_t val = -1; >>>>> + if(addr + size > MMIO_SIZE) { >>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIX64 >>>>> + ", got 0x%"PRIx64 " %d", >>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>> + return (uint64_t) - 1; >>>>> + } >>>>> + >>>>> + switch(addr & ~0x07){ >>>>> + case MMIO_DEVICE_TABLE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>> >>>> What makes these cases different, except debug printf()s? Maybe leave >>>> printf()s inside the switch, and factor out the rest. This applies to other >>>> similar cases as well. >>>> >>>> >>>>> + >>>>> + case MMIO_COMMAND_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_CONTROL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_BASE read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_LIMIT: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_STATUS: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EXT_FEATURES: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXT_FEATURES read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + if(size == 2){ >>>>> + val = amd_iommu_readw(s, addr); >>>>> + } else if(size == 4){ >>>>> + val = amd_iommu_readl(s, addr); >>>>> + } >>>>> + else if(size == 8){ >>>>> + val = amd_iommu_readq(s, addr); >>>>> + } >>>>> + break; >>>>> + >>>>> + default: >>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO read addr 0x%"PRIx64 >>>>> + ", size %d offset 0x%"PRIx64, addr, size, >>>>> offset); >>>>> + } >>>>> + >>>>> + return val; >>>>> +} >>>>> + >>>>> +static void iommu_handle_control_write(AMDIOMMUState *s) >>>>> +{ >>>>> + /* read whatever is already written incase software is writing in >>>>> chucks less than 8 bytes */ >>>>> + unsigned long control = amd_iommu_readq(s, MMIO_CONTROL); >>>>> + s->enabled = !!(control & MMIO_CONTROL_IOMMUEN); >>>>> + >>>>> + s->ats_enabled = !!(control & MMIO_CONTROL_HTTUNEN); >>>>> + s->evtlog_enabled = s->enabled && !!(control & >>>>> MMIO_CONTROL_EVENTLOGEN); >>>>> + >>>>> + s->evtlog_intr = !!(control & MMIO_CONTROL_EVENTINTEN); >>>>> + s->completion_wait_intr = !!(control & MMIO_CONTROL_COMWAITINTEN); >>>>> + s->cmdbuf_enabled = s->enabled && !!(control & >>>>> MMIO_CONTROL_CMDBUFLEN); >>>>> + >>>>> + /* update the flags depending on the control register */ >>>>> + if(s->cmdbuf_enabled) { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_CMDBUF_RUN; >>>>> + } else { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_CMDBUF_RUN; >>>>> + } >>>>> + if (s->evtlog_enabled) { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) |= MMIO_STATUS_EVTLOG_RUN; >>>>> + } else { >>>>> + (*(uint64_t*)&s->mmior[MMIO_STATUS]) &= ~MMIO_STATUS_EVTLOG_RUN; >>>>> + } >>>>> + >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_STATUS state 0x%"PRIx64, control); >>>>> + >>>>> + amd_iommu_cmdbuf_run(s); >>>> >>>> Does any write to control register result in draining command buffer? To me, >>>> it looks strange, and I'd expect IOMMU to execute commands only if I change >>>> tail pointer. >>>> >>>> >>>>> +} >>>>> + >>>>> +/* FIXME: something might go wrong if System Software writes in chunks >>>>> + * of one byte but linux writes in chunks of 4 bytes so currently it >>>>> + * works correctly with linux but will definitely be busted if software >>>>> + * reads/writes 8 bytes >>>>> + */ >>>>> +static void amd_iommu_mmio_write(void *opaque, hwaddr addr, uint64_t val, >>>>> unsigned size) >>>>> +{ >>>>> + >>>>> + AMDIOMMUState *s = opaque; >>>>> + unsigned long offset = addr & 0x07; >>>>> + >>>>> + if(addr + size > MMIO_SIZE) { >>>>> + IOMMU_DPRINTF(MMIO, "error: addr outside region: max 0x%"PRIx64 >>>>> + ", got 0x%"PRIx64 " %d", >>>>> + (uint64_t)MMIO_SIZE, addr, size); >>>>> + return; >>>>> + } >>>>> + >>>>> + switch(addr & ~0x07){ >>>>> + case MMIO_CONTROL: >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_CONTROL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset 0x%"PRIx64 >>>>> , addr, size, val, offset); >>>>> + iommu_handle_control_write(s); >>>>> + break; >>>>> + >>>>> + case MMIO_DEVICE_TABLE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_DEVICE_TABLE write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + /* set device table address >>>>> + * This also suffers from inability to tell whether software >>>>> is done writing >>>>> + */ >>>>> + if(offset || (size == 8)){ >>>>> + unsigned long device_base = amd_iommu_readq(s, >>>>> MMIO_DEVICE_TABLE); >>>>> + s->devtab = (dma_addr_t)(device_base & >>>>> MMIO_CMDBUF_BASE_MASK); >>>>> + /* set device table length */ >>>>> + s->devtab_len = ((device_base & MMIO_DEVTAB_SIZE_MASK) + >>>>> 1) * (MMIO_DEVTAB_SIZE_UNIT / >>>>> + MMIO_DEVTAB_ENTRY_SIZE); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_HEAD write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->cmdbuf_head = val & MMIO_CMDBUF_HEAD_MASK; >>>>> + amd_iommu_cmdbuf_run(s); >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_BASE write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + /* FIXME - make sure System Software has finished writing >>>>> incase it writes >>>>> + * in chucks less than 8 bytes in a robust way.As for now, >>>>> this hacks works >>>>> + * for the linux driver >>>>> + */ >>>>> + if(offset || (size == 8)){ >>>>> + unsigned long command_base = amd_iommu_readq(s, >>>>> MMIO_COMMAND_BASE); >>>>> + s->cmdbuf = (dma_addr_t)(command_base & >>>>> MMIO_CMDBUF_BASE_MASK); >>>>> + s->cmdbuf_len = 1UL << (s->mmior[MMIO_CMDBUF_SIZE_BYTE] & >>>>> MMIO_CMDBUF_SIZE_MASK); >>>>> + s->cmdbuf_head = s->cmdbuf_tail = 0; >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_COMMAND_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_COMMAND_TAIL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + >>>>> + s->cmdbuf_tail = val & MMIO_CMDBUF_TAIL_MASK; >>>>> + amd_iommu_cmdbuf_run(s); >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_BASE write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->evtlog = (val & MMIO_EVTLOG_BASE_MASK); >>>>> + s->evtlog_len = 1UL << >>>>> (*(uint64_t*)&s->mmior[MMIO_EVTLOG_SIZE_BYTE] & MMIO_EVTLOG_SIZE_MASK); >>>>> + break; >>>>> + >>>>> + case MMIO_EXCL_LIMIT: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EXCL_LIMIT write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + s->excl_limit = (val & MMIO_EXCL_LIMIT_MASK) | >>>>> MMIO_EXCL_LIMIT_LOW; >>>>> + break; >>>>> + //TODO : Event handling fixes >>>>> + >>>>> + case MMIO_EVENT_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_HEAD write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + >>>>> + case MMIO_EVENT_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_EVENT_TAIL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log base - unused for now */ >>>>> + case MMIO_PPR_BASE: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_BASE write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log head - also unused for now */ >>>>> + case MMIO_PPR_HEAD: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_HEAD write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + /* PPR log tail - unused for now */ >>>>> + case MMIO_PPR_TAIL: >>>>> + IOMMU_DPRINTF(MMIO, "MMIO_PPR_TAIL write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + if(size == 2){ >>>>> + amd_iommu_writew(s, addr, val); >>>>> + } else if(size == 4){ >>>>> + amd_iommu_writel(s, addr, val); >>>>> + } else if(size == 8){ >>>>> + amd_iommu_writeq(s, addr, val); >>>>> + } >>>>> + break; >>>>> + >>>>> + default: >>>>> + IOMMU_DPRINTF(MMIO, "UNHANDLED MMIO write addr 0x%"PRIx64 >>>>> + ", size %d, val 0x%"PRIx64 ", offset >>>>> 0x%"PRIx64, addr, size, val, offset); >>>>> + ; >>>>> + } >>>>> + >>>>> +} >>>>> + >>>>> +static void amd_iommu_log_event(AMDIOMMUState *s, AMDIOMMUEvent *evt) >>>>> +{ >>>>> + /* event logging not enabled */ >>>>> + if(!s->evtlog_enabled || *(uint64_t*)&s->mmior[MMIO_STATUS] | >>>>> MMIO_STATUS_EVTLOG_OF){ >>>>> + return; >>>>> + } >>>>> + >>>>> + /* event log buffer full */ >>>>> + if(s->evtlog_tail >= s->evtlog_len) { >>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_OF; >>>>> + } >>>>> + >>>>> + if(dma_memory_write(&address_space_memory, s->evtlog_len + >>>>> s->evtlog_tail, &evt, EVENT_LEN)){ >>>>> + //IOMMU_DPRINTF(ELOG, "error: fail to write at address 0%x"PRIu8, >>>>> s->evtlog + s->evtlog_tail); >>>>> + } >>>>> + >>>>> + s->evtlog_tail += EVENT_LEN; >>>>> + *(uint64_t*)&s->mmior[MMIO_STATUS] |= MMIO_STATUS_EVTLOG_INTR; >>>>> + /* Disable logging if Overflow ? */ >>>> >>>> No, the spec details event logging restart procedure. Make sure emulated >>>> IOMMU behaves as described there. >>>> >>>> >>>>> +} >>>>> + >>>>> +static void amd_iommu_page_fault(AMDIOMMUState *s, int devfn, unsigned >>>>> domid, dma_addr_t addr, int present, >>>>> + int is_write) >>>>> +{ >>>>> + IOMMU_DPRINTF(ELOG, ""); >>>>> + >>>>> + AMDIOMMUEvent evt; >>>>> + unsigned info; >>>>> + uint16_t status; >>>>> + >>>>> + evt.devfn = cpu_to_le16(devfn); >>>>> + evt.reserved = 0; >>>>> + evt.domid = cpu_to_le16(domid); >>>>> + evt.addr = cpu_to_le16(addr); >>>>> + >>>>> + info = EVENT_IOPF; >>>>> + >>>>> + if(present) { >>>>> + info |= EVENT_IOPF_PR; >>>>> + } >>>>> + >>>>> + if (is_write) { >>>>> + info |= EVENT_IOPF_RW; >>>>> + } >>>>> + >>>>> + /* log a page fault */ >>>>> + amd_iommu_log_event(s, &evt); >>>>> + >>>>> + /* Abort the translation */ >>>>> + status = pci_get_word(s->dev.config + PCI_STATUS); >>>>> + pci_set_word(s->dev.config + PCI_STATUS, status | >>>>> PCI_STATUS_SIG_TARGET_ABORT); >>>>> +} >>>>> + >>>>> +static inline uint64_t amd_iommu_get_perms(uint64_t entry) >>>>> +{ >>>>> + return (entry &(DEV_PERM_READ | DEV_PERM_WRITE)) >> DEV_PERM_SHIFT; >>>>> +} >>>>> + >>>>> +/* FIXME deduplication */ >>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int devfn) >>>>> +{ >>>>> + AMDIOMMUState *s = opaque; >>>>> + AMDIOMMUAddressSpace **iommu_as; >>>>> + int bus_num = pci_bus_num(bus); >>>>> + >>>>> + /* just in case */ >>>>> + assert(0 <= bus_num && bus_num <= PCI_BUS_MAX); >>>>> + assert(0 <= devfn && devfn <= PCI_DEVFN_MAX); >>>>> + >>>>> + iommu_as = s->address_spaces[bus_num]; >>>>> + >>>>> + /* allocate memory during the first run */ >>>>> + if(!iommu_as) { >>>>> + iommu_as = >>>>> g_malloc0(sizeof(AMDIOMMUAddressSpace*)*PCI_DEVFN_MAX); >>>>> + s->address_spaces[bus_num] = iommu_as; >>>>> + } >>>>> + >>>>> + /* set up IOMMU region */ >>>>> + if(!iommu_as[devfn]){ >>>>> + iommu_as[devfn] = g_malloc0(sizeof(AMDIOMMUAddressSpace)); >>>>> + iommu_as[devfn]->bus_num = (uint8_t)bus_num; >>>>> + iommu_as[devfn]->devfn = (uint8_t)devfn; >>>>> + iommu_as[devfn]->iommu_state = s; >>>>> + >>>>> + memory_region_init_iommu(&iommu_as[devfn]->iommu, OBJECT(s), >>>>> &s->iommu_ops, "amd-iommu", UINT64_MAX); >>>>> + address_space_init(&iommu_as[devfn]->as, &iommu_as[devfn]->iommu, >>>>> "amd-iommu"); >>>>> + } >>>>> + return &iommu_as[devfn]->as; >>>>> +} >>>>> + >>>>> +/* validate a page table entry */ >>>>> +static bool amd_iommu_validate_pte(uint64_t pte) >>>>> +{ >>>>> + return pte & DEV_VALID && pte & DEV_TRANSLATION_VALID; >>>> >>>> I'd suggest parenthesis here. >>>> >>>> >>>>> +} >>>>> + >>>>> +/* get a device table entry given the device function */ >>>>> +static bool amd_iommu_get_dte(AMDIOMMUState *s, int devfn, uint64_t >>>>> *entry) >>>>> +{ >>>>> + /* Could lead to out of range accesses */ >>>>> + assert(0 < devfn && devfn < PCI_DEVFN_MAX); >>>>> + >>>>> + uint32_t offset = devfn * DEVTAB_ENTRY_SIZE; >>>>> + if(dma_memory_read(&address_space_memory, s->devtab + offset, entry, >>>>> 32)){ >>>>> + IOMMU_DPRINTF(MMU, "error: fail to access Device Entry devtab >>>>> 0x%"PRIx64 >>>>> + "offset 0x%"PRIx32, s->devtab, offset); >>>>> + return false; >>>>> + } >>>>> + >>>>> + if(!amd_iommu_validate_pte(entry[0])){ >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "Pte entry at 0x%"PRIx64" is invalid", entry[0]); >>>>> + return false; >>>>> + } >>>>> + >>>>> + return true; >>>>> +} >>>>> + >>>>> +static uint64_t get_pte_translation_mode(uint64_t pte) >>>>> +{ >>>>> + uint64_t level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>> + >>>>> + if(level == 7){ >>>>> + /* reserved level - abort ? */ >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "Reserved translation level (7) detected"); >>>>> + return 0; >>>>> + } >>>>> + >>>>> + return level; >>>>> +} >>>>> + >>>>> +/* TODO : Mark addresses as Accessed and Dirty */ >>>>> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr addr, >>>>> bool is_write, IOMMUTLBEntry *ret) >>>>> +{ >>>>> + AMDIOMMUState *s = as->iommu_state; >>>>> + >>>>> + int present; >>>>> + dma_addr_t pte_addr; >>>>> + uint64_t entry[4], pte, pte_perms; >>>>> + unsigned level; >>>>> + unsigned perms; >>>>> + >>>>> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >>>>> + goto no_translation; >>>>> + } >>>>> + >>>>> + pte = entry[0]; >>>>> + >>>>> + /* >>>>> + * It's okay to check for either read or write permissions >>>>> + * even for memory maps, since we don't support R/W maps. >>>>> + */ >>>>> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >>>>> + >>>>> + if(!(level = get_pte_translation_mode(pte))){ >>>>> + goto no_translation; >>>>> + } >>>>> + >>>>> + while(level > 0){ >>>>> + /* >>>>> + * check permissions: the bitwise >>>>> + * implication perms -> entry_perms must be true. Pages must be >>>>> present >>>>> + * and permissions on all levels must be similar >>>>> + */ >>>>> + pte_perms = amd_iommu_get_perms(pte); >>>>> + present = pte & 1; >>>>> + if(!present || perms != (perms & pte_perms)){ >>>>> + amd_iommu_page_fault(s, as->devfn, entry[1] & >>>>> DEV_DOMID_ID_MASK, addr, present, >>>>> + !!(perms & IOMMU_PERM_WRITE)); >>>>> + return; >>>>> + } >>>>> + >>>>> + /* go to the next lower level */ >>>>> + pte_addr = pte & DEV_PT_ROOT_MASK; >>>>> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); >>>> >>>> Does this work for six level page tables? The highest level has different >>>> bit size there IIRC. >>>> >>>>> + pte = ldq_phys(&address_space_memory, pte_addr); >>>>> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >>>>> + } >>>>> + >>>>> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & IOMMU_PAGE_MASK_4K; >>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret->perm = IOMMU_RW; >>>>> + return; >>>>> + >>>>> +no_translation: >>>>> + ret->iova = addr; >>>>> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret->perm = IOMMU_RW; >>>>> + return; >>>> >>>> Are you sure these transactions needs to be passed through rather than >>>> target-aborted? >>>> >>>>> +} >>>>> + >>>>> +static IOMMUTLBEntry amd_iommu_translate(MemoryRegion *iommu, hwaddr >>>>> addr, bool is_write) >>>>> +{ >>>>> + >>>>> + IOMMU_DPRINTF(GENERAL, ""); >>>>> + >>>>> + AMDIOMMUAddressSpace *as = container_of(iommu, AMDIOMMUAddressSpace, >>>>> iommu); >>>>> + AMDIOMMUState *s = as->iommu_state; >>>>> + >>>>> + IOMMUTLBEntry ret = { >>>>> + .target_as = &address_space_memory, >>>>> + .iova = addr, >>>>> + .translated_addr = 0, >>>>> + .addr_mask = ~(hwaddr)0, >>>>> + .perm = IOMMU_NONE, >>>>> + }; >>>>> + >>>>> + if(!s->enabled){ >>>>> + /* IOMMU disabled - corresponds to iommu=off not failure to >>>>> provide any parameter */ >>>>> + ret.iova = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret.translated_addr = addr & IOMMU_PAGE_MASK_4K; >>>>> + ret.addr_mask = ~IOMMU_PAGE_MASK_4K; >>>>> + ret.perm = IOMMU_RW; >>>>> + return ret; >>>>> + } >>>>> + >>>>> + amd_iommu_do_translate(as, addr, is_write, &ret); >>>>> + >>>>> + IOMMU_DPRINTF(MMU, >>>>> + "devid: %02x:%02x.%x gpa 0x%"PRIx64 " hpa 0x%"PRIx64, >>>>> as->bus_num, >>>>> + PCI_SLOT(as->devfn), PCI_FUNC(as->devfn), addr, >>>>> ret.translated_addr); >>>>> + >>>>> + return ret; >>>>> +} >>>>> + >>>>> +static const MemoryRegionOps mmio_mem_ops = { >>>>> + .read = amd_iommu_mmio_read, >>>>> + .write = amd_iommu_mmio_write, >>>>> + .endianness = DEVICE_LITTLE_ENDIAN, >>>>> + .valid = { >>>>> + .min_access_size = 1, >>>>> + .max_access_size = 8, >>>>> + .unaligned = false, >>>>> + }, >>>>> + >>>>> + .valid = { >>>>> + .min_access_size = 8, >>>>> + .max_access_size = 8, >>>>> + }, >>>>> +}; >>>>> + >>>>> +static void amd_iommu_set_misc_capab(uint32_t host_va, uint32_t host_pa, >>>>> uint32_t guest_va, uint32_t *reg) >>>>> +{ >>>>> + *reg = 0; >>>> >>>> Redundant line. >>>> >>>> >>>>> + >>>>> + *reg |= MAX_VA_ADDR | MAX_PH_ADDR | MAX_GVA_ADDR; >>>>> +} >>>>> + >>>>> +/* FIXME: The similar code in reset and init could be combined into a >>>>> function */ >>>>> +static void amd_iommu_reset(DeviceState *dev) >>>>> +{ >>>>> + AMDIOMMUState *s = AMD_IOMMU_DEVICE(dev); >>>>> + >>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>> + uint32_t capab_base_addr_low = s->mmio.addr & ~(0xffff0000); >>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0xffff)) >> 16; >>>>> + uint32_t capab_range = 0xff000000; >>>>> + uint32_t capab_misc = 0x0; >>>>> + >>>>> + /* reset MMIO */ >>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>> + amd_iommu_writeq(s, MMIO_EXT_FEATURES, EXT_FEATURES); >>>>> + /* TODO :Disable event logging and reset all buffers */ >>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>> &capab_misc); >>>>> + >>>>> + /* reset IOMMU specific capabilities */ >>>>> + pci_set_long(s->dev.config + s->capab_offset, capab_header); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_LOW, >>>>> capab_base_addr_low); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_BAR_HIGH, >>>>> capab_base_addr_high); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_RANGE, >>>>> capab_range); >>>>> + pci_set_long(s->dev.config + s->capab_offset + CAPAB_MISC, >>>>> capab_misc); >>>> >>>> >>>> Do we also need to reset MSI capability block? >>>> >>>> >>>>> + >>>>> + /* reset device ident */ >>>>> + pci_config_set_vendor_id(s->dev.config, PCI_VENDOR_ID_AMD); >>>>> + pci_config_set_device_id(s->dev.config, PCI_DEVICE_ID_RD890_IOMMU); >>>>> + pci_config_set_class(s->dev.config, 0x0806); >>>>> + pci_config_set_prog_interface(s->dev.config, 00); >>>>> +} >>>>> + >>>>> +static void amd_iommu_write_capab(PCIDevice *dev, uint32_t addr, uint32_t >>>>> val, int len) >>>>> +{ >>>>> + pci_default_write_config(dev, addr, val, len); >>>>> +} >>>>> + >>>>> +/* I honestly don't know how to reserve MMIO */ >>>>> +static void amd_iommu_mmio_map(AMDIOMMUState *s, hwaddr addr) >>>>> +{ >>>>> + if(s->mmio.addr == addr){ >>>>> + return; >>>>> + } >>>>> + >>>>> +// if(s->mmio.addr != (hwaddr)-1) { >>>>> +// memory_region_del_subregion(get_system_memory(), &s->mmio); >>>>> +// } >>>>> + >>>>> + s->mmio.addr = addr; >>>>> + memory_region_add_subregion(get_system_memory(), addr, &s->mmio); >>>>> + >>>>> +} >>>>> + >>>>> +static int amd_iommu_pci_initfn(PCIDevice *dev) >>>>> +{ >>>>> + AMDIOMMUState *s = container_of(dev, AMDIOMMUState, dev); >>>>> + uint32_t capab_header = CAPAB_FEATURES; >>>>> + uint32_t capab_base_addr_low = (s->mmio.addr & ~(0xffff0000)); >>>>> + uint32_t capab_base_addr_high = (s->mmio.addr & ~(0x0000ffff) >> 16); >>>>> + uint32_t capab_range = 0xff000000; >>>>> + uint32_t capab_misc = 0x0; >>>>> + >>>>> + memset(s->mmior, 0, MMIO_SIZE); >>>>> + amd_iommu_set_misc_capab(MAX_PH_ADDR, MAX_VA_ADDR, MAX_GVA_ADDR, >>>>> &capab_misc); >>>>> + >>>>> + s->iommu_ops.translate = amd_iommu_translate; >>>>> + s->enabled = false; >>>>> + s->ats_enabled = false; >>>>> + s->cmdbuf_enabled = false; >>>>> + s->devtab_len = 0; >>>>> + s->cmdbuf_len = 0; >>>>> + s->cmdbuf_head = 0; >>>>> + s->cmdbuf_tail = 0; >>>>> + s->evtlog_head = 0; >>>>> + s->evtlog_tail = 0; >>>>> + s->excl_enabled = false; >>>>> + s->excl_allow = false; >>>>> + s->mmio_enabled = false; >>>>> + dev->config_write = amd_iommu_write_capab; >>>>> + >>>>> + size_t offset; >>>>> + /* Save offset for IVRS */ >>>>> + s->capab_offset = offset = pci_add_capability(dev, PCI_CAP_ID_SEC, 0, >>>>> CAPAB_SIZE); >>>>> + pci_set_long(s->dev.config + offset, capab_header); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_LOW, >>>>> capab_base_addr_low); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_BAR_HIGH, >>>>> capab_base_addr_high); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_RANGE, capab_range); >>>>> + pci_set_long(s->dev.config + offset + CAPAB_MISC, capab_misc); >>>>> + >>>>> + /* add msi and hypertransport capabilities */ >>>>> + pci_add_capability(dev, PCI_CAP_ID_MSI, 0, CAPAB_REG_SIZE); >>>>> + pci_add_capability(dev, PCI_CAP_ID_HT, 0, CAPAB_REG_SIZE); >>>>> + >>>>> + /* set up MMIO */ >>>>> + memory_region_init_io(&s->mmio, OBJECT(s), &mmio_mem_ops, s, >>>>> "amd-iommu", MMIO_SIZE); >>>>> + amd_iommu_mmio_map(s, BUS_AMD_IOMMU_ADDR); >>>>> + >>>>> + /* reset device ident */ >>>>> + pci_config_set_vendor_id(dev->config, PCI_VENDOR_ID_AMD); >>>>> + pci_config_set_device_id(dev->config, PCI_DEVICE_ID_RD890_IOMMU); >>>>> + >>>>> + /* may not be necessary */ >>>>> + pci_config_set_interrupt_pin(dev->config, 0x1a); >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> +static void amd_iommu_realize(PCIDevice *dev, Error **error) >>>>> +{ >>>>> + amd_iommu_pci_initfn(dev); >>>>> +} >>>>> + >>>>> +static const VMStateDescription vmstate_amd_iommu = { >>>>> + .name = "amd-iommu", >>>>> + .fields = (VMStateField[]) { >>>>> + VMSTATE_PCI_DEVICE(dev, AMDIOMMUState), >>>>> + VMSTATE_END_OF_LIST() >>>>> + } >>>>> +}; >>>>> + >>>>> +static Property amd_iommu_properties[] = { >>>>> + DEFINE_PROP_UINT32("version", AMDIOMMUState, version, 2), >>>>> + DEFINE_PROP_END_OF_LIST(), >>>>> +}; >>>>> + >>>>> +/* not used for now but will be when cache is added */ >>>>> +static void amd_iommu_uninit(PCIDevice *dev) >>>>> +{ >>>>> + return; >>>>> +} >>>>> + >>>>> +static void amd_iommu_class_init(ObjectClass *klass, void* data) >>>>> +{ >>>>> + DeviceClass *dc = DEVICE_CLASS(klass); >>>>> + PCIDeviceClass *pci = PCI_DEVICE_CLASS(klass); >>>>> + >>>>> + pci->realize = amd_iommu_realize; >>>>> + pci->exit = amd_iommu_uninit; >>>>> + >>>>> + dc->reset = amd_iommu_reset; >>>>> + dc->vmsd = &vmstate_amd_iommu; >>>>> + dc->props = amd_iommu_properties; >>>>> +} >>>>> + >>>>> +static const TypeInfo amd_iommu = { >>>>> + .name = TYPE_AMD_IOMMU_DEVICE, >>>>> + .parent = TYPE_PCI_DEVICE, >>>>> + .instance_size = sizeof(AMDIOMMUState), >>>>> + .class_init = amd_iommu_class_init >>>>> +}; >>>>> + >>>>> +static void amd_iommu_register_types(void) >>>>> +{ >>>>> + type_register_static(&amd_iommu); >>>>> +} >>>>> + >>>>> +type_init(amd_iommu_register_types); >>>>> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h >>>>> new file mode 100644 >>>>> index 0000000..90309eb >>>>> --- /dev/null >>>>> +++ b/hw/i386/amd_iommu.h >>>>> @@ -0,0 +1,298 @@ >>>>> +/* >>>>> + * QEMU emulation of an AMD IOMMU (AMD-Vi) >>>>> + * >>>>> + * Copyright (C) 2011 Eduard-Gabriel Mateanu >>>>> + * Copyright (C) 2015 David Kiarie, <david.kiarie@hotmail.com> >>>>> + * >>>>> + * This program is free software; you can redistribute it and/or modify >>>>> + * it under the terms of the GNU General Public License as published by >>>>> + * the Free Software Foundation; either version 2 of the License, or >>>>> + * (at your option) any later version. >>>>> + >>>>> + * This program is distributed in the hope that it will be useful, >>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>>> + * GNU General Public License for more details. >>>>> + >>>>> + * You should have received a copy of the GNU General Public License >>>>> along >>>>> + * with this program; if not, see <http://www.gnu.org/licenses/>. >>>>> + */ >>>>> + >>>>> +#ifndef AMD_IOMMU_H_ >>>>> +#define AMD_IOMMU_H_ >>>>> + >>>>> +#include "hw/hw.h" >>>>> +#include "hw/pci/pci.h" >>>>> +#include "hw/sysbus.h" >>>>> +#include "sysemu/dma.h" >>>>> +#include "qemu/osdep.h" >>>>> +#include "qemu/event_notifier.h" >>>>> + >>>>> +/* Capability registers */ >>>>> +#define CAPAB_HEADER 0x00 >>>>> +#define CAPAB_REV_TYPE 0x02 >>>>> +#define CAPAB_FLAGS 0x03 >>>>> +#define CAPAB_BAR_LOW 0x04 >>>>> +#define CAPAB_BAR_HIGH 0x08 >>>>> +#define CAPAB_RANGE 0x0C >>>>> +#define CAPAB_MISC 0x10 >>>>> +#define CAPAB_MISC1 0x14 >>>>> + >>>>> +#define CAPAB_SIZE 0x18 >>>>> +#define CAPAB_REG_SIZE 0x04 >>>>> + >>>>> +/* Capability header data */ >>>>> +#define CAPAB_FLAT_EXT (1 << 28) >>>>> +#define CAPAB_EFR_SUP (1 << 27) >>>>> +#define CAPAB_FLAG_NPCACHE (1 << 26) >>>>> +#define CAPAB_FLAG_HTTUNNEL (1 << 25) >>>>> +#define CAPAB_FLAG_IOTLBSUP (1 << 24) >>>>> +#define CAPAB_INIT_REV (1 << 19) >>>>> +#define CAPAB_INIT_TYPE (3 << 16) >>>>> +#define CAPAB_INIT_REV_TYPE (CAPAB_REV | CAPAB_TYPE) >>>>> +#define CAPAB_INIT_FLAGS (CAPAB_FLAG_NPCACHE | >>>>> CAPAB_FLAG_HTTUNNEL) >>>>> +#define CAPAB_INIT_MISC ((64 << 15) | (48 << 8)) >>>>> +#define CAPAB_BAR_MASK (~((1UL << 14) - 1)) >>>>> + >>>>> +/* MMIO registers */ >>>>> +#define MMIO_DEVICE_TABLE 0x0000 >>>>> +#define MMIO_COMMAND_BASE 0x0008 >>>>> +#define MMIO_EVENT_BASE 0x0010 >>>>> +#define MMIO_CONTROL 0x0018 >>>>> +#define MMIO_EXCL_BASE 0x0020 >>>>> +#define MMIO_EXCL_LIMIT 0x0028 >>>>> +#define MMIO_EXT_FEATURES 0x0030 >>>>> +#define MMIO_COMMAND_HEAD 0x2000 >>>>> +#define MMIO_COMMAND_TAIL 0x2008 >>>>> +#define MMIO_EVENT_HEAD 0x2010 >>>>> +#define MMIO_EVENT_TAIL 0x2018 >>>>> +#define MMIO_STATUS 0x2020 >>>>> +#define MMIO_PPR_BASE 0x0038 >>>>> +#define MMIO_PPR_HEAD 0x2030 >>>>> +#define MMIO_PPR_TAIL 0x2038 >>>>> + >>>>> +#define MMIO_SIZE 0x4000 >>>>> + >>>>> +#define MMIO_DEVTAB_SIZE_MASK ((1ULL << 12) - 1) >>>>> +#define MMIO_DEVTAB_BASE_MASK (((1ULL << 52) - 1) & >>>>> ~MMIO_DEVTAB_SIZE_MASK) >>>>> +#define MMIO_DEVTAB_ENTRY_SIZE 32 >>>>> +#define MMIO_DEVTAB_SIZE_UNIT 4096 >>>>> + >>>>> +#define MMIO_CMDBUF_SIZE_BYTE (MMIO_COMMAND_BASE + 7) >>>>> +#define MMIO_CMDBUF_SIZE_MASK 0x0F >>>>> +#define MMIO_CMDBUF_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_CMDBUF_DEFAULT_SIZE 8 >>>>> +#define MMIO_CMDBUF_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>> +#define MMIO_CMDBUF_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>> + >>>>> +#define MMIO_EVTLOG_SIZE_BYTE (MMIO_EVENT_BASE + 7) >>>>> +#define MMIO_EVTLOG_SIZE_MASK MMIO_CMDBUF_SIZE_MASK >>>>> +#define MMIO_EVTLOG_BASE_MASK MMIO_CMDBUF_BASE_MASK >>>>> +#define MMIO_EVTLOG_DEFAULT_SIZE MMIO_CMDBUF_DEFAULT_SIZE >>>>> +#define MMIO_EVTLOG_HEAD_MASK (((1ULL << 19) - 1) & ~0x0F) >>>>> +#define MMIO_EVTLOG_TAIL_MASK MMIO_EVTLOG_HEAD_MASK >>>>> + >>>>> +#define MMIO_EXCL_BASE_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_EXCL_ENABLED_MASK (1ULL << 0) >>>>> +#define MMIO_EXCL_ALLOW_MASK (1ULL << 1) >>>>> +#define MMIO_EXCL_LIMIT_MASK MMIO_DEVTAB_BASE_MASK >>>>> +#define MMIO_EXCL_LIMIT_LOW 0xFFF >>>>> + >>>>> +#define MMIO_CONTROL_IOMMUEN (1ULL << 0) >>>>> +#define MMIO_CONTROL_HTTUNEN (1ULL << 1) >>>>> +#define MMIO_CONTROL_EVENTLOGEN (1ULL << 2) >>>>> +#define MMIO_CONTROL_EVENTINTEN (1ULL << 3) >>>>> +#define MMIO_CONTROL_COMWAITINTEN (1ULL << 4) >>>>> +#define MMIO_CONTROL_CMDBUFLEN (1ULL << 12) >>>>> + >>>>> +#define MMIO_STATUS_EVTLOG_OF (1ULL << 0) >>>>> +#define MMIO_STATUS_EVTLOG_INTR (1ULL << 1) >>>>> +#define MMIO_STATUS_COMWAIT_INTR (1ULL << 2) >>>>> +#define MMIO_STATUS_EVTLOG_RUN (1ULL << 3) >>>>> +#define MMIO_STATUS_CMDBUF_RUN (1ULL << 4) >>>>> + >>>>> +#define CMDBUF_ID_BYTE 0x07 >>>>> +#define CMDBUF_ID_RSHIFT 4 >>>>> +#define CMDBUF_ENTRY_SIZE 0x10 >>>>> + >>>>> +#define CMD_COMPLETION_WAIT 0x01 >>>>> +#define CMD_INVAL_DEVTAB_ENTRY 0x02 >>>>> +#define CMD_INVAL_IOMMU_PAGES 0x03 >>>>> +#define CMD_INVAL_IOTLB_PAGES 0x04 >>>>> +#define CMD_INVAL_INTR_TABLE 0x05 >>>>> + >>>>> +#define DEVTAB_ENTRY_SIZE 32 >>>>> + >>>>> +/* Device table entry bits 0:63 */ >>>>> +#define DEV_VALID (1ULL << 0) >>>>> +#define DEV_TRANSLATION_VALID (1ULL << 1) >>>>> +#define DEV_MODE_MASK 0x7 >>>>> +#define DEV_MODE_RSHIFT 9 >>>>> +#define DEV_PT_ROOT_MASK 0xFFFFFFFFFF000 >>>>> +#define DEV_PT_ROOT_RSHIFT 12 >>>>> +#define DEV_PERM_SHIFT 61 >>>>> +#define DEV_PERM_READ (1ULL << 61) >>>>> +#define DEV_PERM_WRITE (1ULL << 62) >>>>> + >>>>> +/* Device table entry bits 64:127 */ >>>>> +#define DEV_DOMID_ID_MASK ((1ULL << 16) - 1) >>>>> +#define DEV_IOTLB_SUPPORT (1ULL << 17) >>>>> +#define DEV_SUPPRESS_PF (1ULL << 18) >>>>> +#define DEV_SUPPRESS_ALL_PF (1ULL << 19) >>>>> +#define DEV_IOCTL_MASK (~3) >>>>> +#define DEV_IOCTL_RSHIFT 20 >>>>> +#define DEV_IOCTL_DENY 0 >>>>> +#define DEV_IOCTL_PASSTHROUGH 1 >>>>> +#define DEV_IOCTL_TRANSLATE 2 >>>>> +#define DEV_CACHE (1ULL << 37) >>>>> +#define DEV_SNOOP_DISABLE (1ULL << 38) >>>>> +#define DEV_EXCL (1ULL << 39) >>>>> + >>>>> +/* Event codes and flags, as stored in the info field */ >>>>> +#define EVENT_ILLEGAL_DEVTAB_ENTRY (0x1U << 24) >>>>> +#define EVENT_IOPF (0x2U << 24) >>>>> +#define EVENT_IOPF_I (1U << 3) >>>>> +#define EVENT_IOPF_PR (1U << 4) >>>>> +#define EVENT_IOPF_RW (1U << 5) >>>>> +#define EVENT_IOPF_PE (1U << 6) >>>>> +#define EVENT_IOPF_RZ (1U << 7) >>>>> +#define EVENT_IOPF_TR (1U << 8) >>>>> +#define EVENT_DEV_TAB_HW_ERROR (0x3U << 24) >>>>> +#define EVENT_PAGE_TAB_HW_ERROR (0x4U << 24) >>>>> +#define EVENT_ILLEGAL_COMMAND_ERROR (0x5U << 24) >>>>> +#define EVENT_COMMAND_HW_ERROR (0x6U << 24) >>>>> +#define EVENT_IOTLB_INV_TIMEOUT (0x7U << 24) >>>>> +#define EVENT_INVALID_DEV_REQUEST (0x8U << 24) >>>>> + >>>>> +#define EVENT_LEN 16 >>>>> + >>>>> +#define IOMMU_PERM_READ (1 << 0) >>>>> +#define IOMMU_PERM_WRITE (1 << 1) >>>>> +#define IOMMU_PERM_RW (IOMMU_PERM_READ | IOMMU_PERM_WRITE) >>>>> + >>>>> +/* AMD RD890 Chipset */ >>>>> +#define PCI_DEVICE_ID_RD890_IOMMU 0x20 >>>>> + >>>>> +#define PCI_CAP_ID_SEC 0xf /* IOMMU capability header >>>>> register */ >>>>> +#define PCI_CAP_ID_MMIO_LOW 0x0 /* MMIO base address low >>>>> register */ >>>>> +#define PCI_CAP_ID_MMIO_HIGH 0x0 /* MMIO base address high >>>>> register */ >>>>> +#define PCI_CAP_ID_RANGE 0x0 /* Device range register >>>>> */ >>>>> +#define PCI_CAP_ID_MISC 0x0 /* miscellaneous Information >>>>> register 0 */ >>>>> +#define PCI_CAP_ID_MISC1 0x0 /* miscellaneous Information >>>>> register 1 */ >>>>> + >>>>> +#define FEATURE_PREFETCH (1ULL<<0) >>>>> +#define FEATURE_PPR (1ULL<<1) >>>>> +#define FEATURE_NX (1ULL<<3) >>>>> +#define FEATURE_GT (1ULL<<4) >>>>> +#define FEATURE_IA (1ULL<<6) >>>>> +#define FEATURE_GA (1ULL<<7) >>>>> +#define FEATURE_HE (1ULL<<8) >>>>> +#define FEATURE_PC (1ULL<<9) >>>>> + >>>>> +/* IOMMU paging mode */ >>>>> +#define GATS_MODE (6ULL << 12) >>>>> +#define HATS_MODE (6ULL << 10) >>>>> +/* PCI SIG constants */ >>>>> +#define PCI_BUS_MAX 256 >>>>> +#define PCI_SLOT_MAX 32 >>>>> +#define PCI_FUNC_MAX 8 >>>>> +#define PCI_DEVFN_MAX 256 >>>>> + >>>>> +/* extended feature support */ >>>>> +#define EXT_FEATURES (FEATURE_PREFETCH | FEATURE_PPR | FEATURE_NX | >>>>> FEATURE_GT | FEATURE_IA | FEATURE_GA | FEATURE_HE | GATS_MODE | HATS_MODE ) >>>>> + >>>>> +/* capabilities header */ >>>>> +#define CAPAB_FEATURES (CAPAB_FLAT_EXT | CAPAB_FLAG_NPCACHE | >>>>> CAPAB_FLAG_IOTLBSUP | PCI_CAP_ID_SEC | CAPAB_INIT_TYPE | CAPAB_FLAG_HTTUNNEL >>>>> | CAPAB_EFR_SUP) >>>>> + >>>>> +/* command constants */ >>>>> +#define COM_STORE_ADDRESS_MASK 0xffffffffffff8 >>>>> +#define COM_COMPLETION_STORE_MASK 0x1 >>>>> +#define COM_COMPLETION_INTR 0x2 >>>>> +#define COM_COMPLETION_DATA_OFF 0x8 >>>>> +#define IOMMU_COMMAND_SIZE 0x10 >>>>> + >>>>> +/* IOMMU default address */ >>>>> +#define BUS_AMD_IOMMU_ADDR 0xfeb00000 >>>>> + >>>>> +/* page management constants */ >>>>> +#define IOMMU_PAGE_SHIFT 12 >>>>> +#define IOMMU_PAGE_SIZE (1ULL << IOMMU_PAGE_SHIFT) >>>>> + >>>>> +#define IOMMU_PAGE_SHIFT_4K 12 >>>>> +#define IOMMU_PAGE_MASK_4K (~((1ULL << IOMMU_PAGE_SHIFT_4K) - 1)) >>>>> +#define IOMMU_PAGE_SHIFT_2M 21 >>>>> +#define IOMMU_PAGE_MASK_2M (~((1ULL << IOMMU_PAGE_SHIFT_2M) -1)) >>>>> +#define IOMMU_PAGE_SHIFT_1G 30 >>>>> +#define IOMMU_PAGE_MASK_1G (~((1ULL << IOMMU_PAGE_SHIFT_1G) - 1)) >>>>> + >>>>> +#define TYPE_AMD_IOMMU_DEVICE "amd-iommu" >>>>> +#define AMD_IOMMU_DEVICE(obj)\ >>>>> + OBJECT_CHECK(AMDIOMMUState, (obj), TYPE_AMD_IOMMU_DEVICE) >>>>> + >>>>> +typedef struct AMDIOMMUState AMDIOMMUState; >>>>> + >>>>> +typedef struct AMDIOMMUAddressSpace{ >>>>> + uint8_t bus_num; /* bus number >>>>> */ >>>>> + uint8_t devfn; /* device function >>>>> */ >>>>> + AMDIOMMUState *iommu_state; /* IOMMU - one per machine >>>>> */ >>>>> + MemoryRegion iommu; /* Device's iommu region >>>>> */ >>>>> + AddressSpace as; /* device's corresponding address space >>>>> */ >>>>> +}AMDIOMMUAddressSpace; >>>>> + >>>>> +struct AMDIOMMUState { >>>>> + PCIDevice dev; /* The PCI device itself */ >>>>> + >>>>> + uint32_t version; >>>>> + >>>>> + int capab_offset; /* capability offset pointer */ >>>>> + unsigned char *capab; /* capabilities registers */ >>>>> + >>>>> + bool enabled; /* IOMMU enabled */ >>>>> + bool ats_enabled; /* address translation enabled */ >>>>> + bool cmdbuf_enabled; /* command buffer enabled */ >>>>> + bool evtlog_enabled; /* event log enabled */ >>>>> + bool excl_enabled; >>>>> + >>>>> + dma_addr_t devtab; /* base address device table */ >>>>> + size_t devtab_len; /* device table length */ >>>>> + >>>>> + dma_addr_t cmdbuf; /* command buffer base address */ >>>>> + uint64_t cmdbuf_len; /* command buffer length */ >>>>> + unsigned cmdbuf_head; /* current IOMMU read position */ >>>>> + unsigned cmdbuf_tail; /* next Software write position */ >>>>> + int completion_wait_intr; >>>>> + >>>>> + dma_addr_t evtlog; /* base address event log */ >>>>> + size_t evtlog_intr; >>>>> + size_t evtlog_len; /* event log length */ >>>>> + size_t evtlog_head; /* event log head */ >>>>> + size_t evtlog_tail; /* event log tail */ >>>>> + >>>>> + /* unused for now */ >>>>> + dma_addr_t excl_base; /* base DVA - IOMMU exclusion range */ >>>>> + dma_addr_t excl_limit; /* limit of IOMMU exclusion range */ >>>>> + bool excl_allow; /* translate accesses to the exclusion >>>>> range */ >>>>> + bool excl_enable; /* exclusion range enabled */ >>>>> + >>>>> + MemoryRegion mmio; /* MMIO region */ >>>>> + unsigned char mmior[MMIO_SIZE]; >>>>> + bool mmio_enabled; >>>>> + >>>>> + /* IOMMU function */ >>>>> + MemoryRegionIOMMUOps iommu_ops; >>>>> + >>>>> + /* for each served device */ >>>>> + AMDIOMMUAddressSpace **address_spaces[PCI_BUS_MAX]; >>>>> +}; >>>>> + >>>>> +typedef struct AMDIOMMUEvent { >>>>> + uint16_t devfn; >>>>> + uint16_t reserved; >>>>> + uint16_t domid; >>>>> + uint16_t info; >>>>> + uint16_t addr; >>>>> +} __attribute__((packed)) AMDIOMMUEvent; >>>>> + >>>>> +AddressSpace *bridge_host_amd_iommu(PCIBus *bus, void *opaque, int >>>>> devfn); >>>>> + >>>>> +#endif >>>>> >>>> >>>> Regards, >>>> Valentine >> >> -- >> С уважением, >> Синицын Валентин -- С уважением, Синицын Валентин ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU 2015-09-07 12:46 ` Valentine Sinitsyn 2015-09-09 7:30 ` David kiarie @ 2015-09-12 10:55 ` Valentine Sinitsyn 1 sibling, 0 replies; 22+ messages in thread From: Valentine Sinitsyn @ 2015-09-12 10:55 UTC (permalink / raw) To: David Kiarie, qemu-devel; +Cc: jan.kiszka, mst Hi David, On 07.09.2015 17:46, Valentine Sinitsyn wrote: ...snip... >> +/* TODO : Mark addresses as Accessed and Dirty */ >> +static void amd_iommu_do_translate(AMDIOMMUAddressSpace *as, hwaddr >> addr, bool is_write, IOMMUTLBEntry *ret) >> +{ >> + AMDIOMMUState *s = as->iommu_state; >> + >> + int present; >> + dma_addr_t pte_addr; >> + uint64_t entry[4], pte, pte_perms; >> + unsigned level; >> + unsigned perms; >> + >> + if(!amd_iommu_get_dte(s, as->devfn, entry)){ >> + goto no_translation; >> + } >> + >> + pte = entry[0]; >> + >> + /* >> + * It's okay to check for either read or write permissions >> + * even for memory maps, since we don't support R/W maps. >> + */ >> + perms = is_write ? IOMMU_PERM_WRITE : IOMMU_PERM_READ; >> + >> + if(!(level = get_pte_translation_mode(pte))){ >> + goto no_translation; >> + } >> + >> + while(level > 0){ >> + /* >> + * check permissions: the bitwise >> + * implication perms -> entry_perms must be true. Pages must >> be present >> + * and permissions on all levels must be similar >> + */ >> + pte_perms = amd_iommu_get_perms(pte); >> + present = pte & 1; >> + if(!present || perms != (perms & pte_perms)){ >> + amd_iommu_page_fault(s, as->devfn, entry[1] & >> DEV_DOMID_ID_MASK, addr, present, >> + !!(perms & IOMMU_PERM_WRITE)); >> + return; >> + } >> + >> + /* go to the next lower level */ >> + pte_addr = pte & DEV_PT_ROOT_MASK; >> + pte_addr += ((addr >> ( 9 * level)) & 0xff8); > Does this work for six level page tables? The highest level has > different bit size there IIRC. > >> + pte = ldq_phys(&address_space_memory, pte_addr); >> + level = (pte >> DEV_MODE_RSHIFT) & DEV_MODE_MASK; >> + } >> + >> + ret->iova = addr & IOMMU_PAGE_MASK_4K; >> + ret->translated_addr = (pte & DEV_PT_ROOT_MASK) & >> IOMMU_PAGE_MASK_4K; >> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >> + ret->perm = IOMMU_RW; >> + return; >> + >> +no_translation: >> + ret->iova = addr; >> + ret->translated_addr = addr & IOMMU_PAGE_MASK_4K; >> + ret->addr_mask = ~IOMMU_PAGE_MASK_4K; >> + ret->perm = IOMMU_RW; >> + return; > Are you sure these transactions needs to be passed through rather than > target-aborted? FYI: They are indeed passed-through; see Table 9 in the spec. Valentine ^ permalink raw reply [flat|nested] 22+ messages in thread
* [Qemu-devel] [RFC 3/4] hw/i386: Introduce IVRS for AMD IOMMU 2015-08-24 23:19 [Qemu-devel] [RFC 0/4] AMD IOMMU David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 1/4] hw/core: Prepare for introducing " David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 2/4] hw/i386: Introduce " David Kiarie @ 2015-08-24 23:19 ` David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 4/4] hw/pci-host: Add AMD IOMMU emulation to q35 and PIIX David Kiarie 3 siblings, 0 replies; 22+ messages in thread From: David Kiarie @ 2015-08-24 23:19 UTC (permalink / raw) To: qemu-devel; +Cc: valentine.sinitsyn, jan.kiszka, David, mst From: David <davidkiarie4@gmail.com> Add IVRS table for AMD IOMMU. Table indicates that all devices will be translated by the IOMMU, features common to all IOMMUs and IVDB for the IOMMU to be emulated Signed-off-by: David Kiarie <davidkiarie4@gmail.com> --- hw/i386/acpi-build.c | 85 +++++++++++++++++++++++++++++++++++++++++++++ include/hw/acpi/acpi-defs.h | 55 +++++++++++++++++++++++++++++ 2 files changed, 140 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 95e0c65..1016ed9 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -50,6 +50,7 @@ #include "hw/pci/pci_bus.h" #include "hw/pci-host/q35.h" #include "hw/i386/intel_iommu.h" +#include "hw/i386/amd_iommu.h" #include "hw/i386/q35-acpi-dsdt.hex" #include "hw/i386/acpi-dsdt.hex" @@ -1576,10 +1577,80 @@ build_dmar_q35(GArray *table_data, GArray *linker) } static void +amd_iommu_acpi_set_flag(uint8_t *value, uint64_t flag) +{ + uint64_t newvalue = *value | flag; + *(uint64_t*)value = newvalue; +} + +static void +amd_iommu_acpi_set_feature(uint64_t *value, uint64_t feature) +{ + uint64_t newvalue = *value | feature; + *value = newvalue; +} + +static void +build_amd_iommu(GArray *table_data, GArray *linker) +{ + int iommu_start = table_data->len; + bool iommu_ambig; + uint64_t host_width = (AMD_IOMMU_HOST_ADDRESS_WIDTH << 8); + + AcpiAMDIOMMUIVRS *ivrs; + AcpiAMDIOMMUHardwareUnit *iommu; + + /* IVRS definition */ + ivrs = acpi_data_push(table_data, sizeof(*ivrs)); + ivrs->revision = ACPI_IOMMU_IVRS_TYPE; + ivrs->length = (sizeof(*ivrs) + sizeof(*iommu)); + ivrs->v_common_info = host_width; + + AMDIOMMUState *s = (AMDIOMMUState*)object_resolve_path_type("", TYPE_AMD_IOMMU_DEVICE, &iommu_ambig); + + /* IVDB definition */ + iommu = acpi_data_push(table_data, sizeof(*iommu)); + if(!iommu_ambig){ + iommu->type = 0x10; + /* IVHD flags */ + amd_iommu_acpi_set_flag(&iommu->flags, IVHD_HT_TUNEN); + amd_iommu_acpi_set_flag(&iommu->flags, IVHD_PPRSUP); + amd_iommu_acpi_set_flag(&iommu->flags, IVHD_IOTLBSUP); + amd_iommu_acpi_set_flag(&iommu->flags, IVHD_ISOC); + amd_iommu_acpi_set_flag(&iommu->flags, IVHD_PREFSUP); + + iommu->length = sizeof(*iommu); + iommu->device_id = PCI_DEVICE_ID_RD890_IOMMU; + iommu->capability_offset = s->capab_offset; + iommu->mmio_base = s->mmio.addr; + iommu->pci_segment = cpu_to_le16(0); + iommu->interrupt_info = cpu_to_le16(0); + + /* EFR features */ + amd_iommu_acpi_set_feature(&iommu->efr_register, IVHD_EFR_GTSUP); + amd_iommu_acpi_set_feature(&iommu->efr_register, IVHD_EFR_HATS); + amd_iommu_acpi_set_feature(&iommu->efr_register, IVHD_EFR_GATS); + + /* device entries */ + memset(iommu->dev_entries, 0, 20); + + /* Add device flags here */ + iommu->dev_entries[12] = 3; + iommu->dev_entries[16] = 4; + iommu->dev_entries[17] = 0xff; + iommu->dev_entries[18] = 0xff; + } + + build_header(linker, table_data, (void*)(table_data->data + iommu_start), + "IVRS", table_data->len - iommu_start, 1); +} + +static void build_dsdt(GArray *table_data, GArray *linker, AcpiMiscInfo *misc) { AcpiTableHeader *dsdt; + assert(misc->dsdt_code && misc->dsdt_size); dsdt = acpi_data_push(table_data, misc->dsdt_size); @@ -1658,6 +1729,16 @@ static bool acpi_has_iommu(void) return intel_iommu && !ambiguous; } +static bool acpi_has_amd_iommu(void) +{ + bool ambiguous; + Object *amd_iommu; + + amd_iommu = object_resolve_path_type("", TYPE_AMD_IOMMU_DEVICE, + &ambiguous); + return amd_iommu && !ambiguous; +} + static void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables) { @@ -1741,6 +1822,10 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables) acpi_add_table(table_offsets, tables_blob); build_dmar_q35(tables_blob, tables->linker); } + if(acpi_has_amd_iommu() && !acpi_has_iommu()){ + acpi_add_table(table_offsets, tables_blob); + build_amd_iommu(tables_blob, tables->linker); + } /* Add tables supplied by user (if any) */ for (u = acpi_table_first(); u; u = acpi_table_next(u)) { diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h index 2b431e6..4fc1f79 100644 --- a/include/hw/acpi/acpi-defs.h +++ b/include/hw/acpi/acpi-defs.h @@ -561,4 +561,59 @@ typedef struct AcpiDmarHardwareUnit AcpiDmarHardwareUnit; /* Masks for Flags field above */ #define ACPI_DMAR_INCLUDE_PCI_ALL 1 +/* IVRS constants */ +#define ACPI_IOMMU_HARDWAREUNIT_TYPE 0x10 +#define ACPI_IOMMU_IVRS_TYPE 0x1 +#define AMD_IOMMU_HOST_ADDRESS_WIDTH 39UL + +/* AMD IOMMU IVRS table */ +struct AcpiAMDIOMMUIVRS{ + ACPI_TABLE_HEADER_DEF + uint32_t v_common_info; /* common virtualization information */ + uint64_t reserved; /* reserved */ +} QEMU_PACKED; +typedef struct AcpiAMDIOMMUIVRS AcpiAMDIOMMUIVRS; + +/* flags in the IVHD headers */ +#define IVHD_HT_TUNEN (1UL << 0) +#define IVHD_PASS_PW (1UL << 1) +#define IVHD_RESPASS_PW (1UL << 2) +#define IVHD_ISOC (1UL << 3) +#define IVHD_IOTLBSUP (1UL << 4) +#define IVHD_COHERENT (1UL << 5) +#define IVHD_PREFSUP (1UL << 6) +#define IVHD_PPRSUP (1UL << 7) + +/* features in the IVHD headers */ +#define IVHD_EFR_HATS 48 +#define IVHD_EFR_GATS 48 +#define IVHD_EFR_MSI_NUM +#define IVHD_EFR_PNBANKS +#define IVHD_EFR_PNCOUNTERS +#define IVHD_EFR_PASMAX +#define IVHD_EFR_HESUP (1UL << 7) +#define IVHD_EFR_GASUP (1UL << 6) +#define IVHD_EFR_IASUP (1UL << 5) +#define IVHD_EFR_GLXSUP (3UL << 3) +#define IVHD_EFR_GTSUP (1UL << 2) +#define IVHD_EFR_NXSUP (1UL << 1) +#define IVHD_EFR_XTSUP (1UL << 0) + +/* IVDB type 10h */ +struct AcpiAMDIOMMUHardwareUnit{ + uint8_t type; + uint8_t flags; + uint16_t length; + uint16_t device_id; + uint16_t capability_offset; + uint64_t mmio_base; + uint16_t pci_segment; + uint16_t interrupt_info; + uint32_t features; + uint64_t efr_register; + uint64_t reserved; + uint8_t dev_entries[20]; +}QEMU_PACKED; +typedef struct AcpiAMDIOMMUHardwareUnit AcpiAMDIOMMUHardwareUnit; + #endif -- 2.1.4 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* [Qemu-devel] [RFC 4/4] hw/pci-host: Add AMD IOMMU emulation to q35 and PIIX 2015-08-24 23:19 [Qemu-devel] [RFC 0/4] AMD IOMMU David Kiarie ` (2 preceding siblings ...) 2015-08-24 23:19 ` [Qemu-devel] [RFC 3/4] hw/i386: Introduce IVRS for " David Kiarie @ 2015-08-24 23:19 ` David Kiarie 3 siblings, 0 replies; 22+ messages in thread From: David Kiarie @ 2015-08-24 23:19 UTC (permalink / raw) To: qemu-devel; +Cc: valentine.sinitsyn, jan.kiszka, David, mst From: David <davidkiarie4@gmail.com> Add AMD IOMMU emulation to q35 and PIIX chipsets. Signed-off-by: David Kiarie <davidkiarie4@gmail.com> --- hw/pci-host/piix.c | 11 +++++++++++ hw/pci-host/q35.c | 11 +++++++++++ 2 files changed, 22 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 1cb25f3..348cff0 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -31,6 +31,7 @@ #include "qemu/range.h" #include "hw/xen/xen.h" #include "hw/pci-host/pam.h" +#include "hw/i386/amd_iommu.h" #include "sysemu/sysemu.h" #include "hw/i386/ioapic.h" #include "qapi/visitor.h" @@ -292,12 +293,21 @@ static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) { PCIHostState *s = PCI_HOST_BRIDGE(dev); SysBusDevice *sbd = SYS_BUS_DEVICE(dev); + AMDIOMMUState *iommu_state; + PCIDevice *iommu; sysbus_add_io(sbd, 0xcf8, &s->conf_mem); sysbus_init_ioports(sbd, 0xcf8, 4); sysbus_add_io(sbd, 0xcfc, &s->data_mem); sysbus_init_ioports(sbd, 0xcfc, 4); + + /* AMD IOMMU (AMD-Vi) */ + if(machine_amd_iommu(current_machine)){ + iommu = pci_create_simple(s->bus, 0x20, TYPE_AMD_IOMMU_DEVICE); + iommu_state = AMD_IOMMU_DEVICE(iommu); + pci_setup_iommu(s->bus, bridge_host_amd_iommu, iommu_state); + } } static void i440fx_realize(PCIDevice *dev, Error **errp) @@ -333,6 +343,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, object_property_add_child(qdev_get_machine(), "i440fx", OBJECT(dev), NULL); qdev_init_nofail(dev); + d = pci_create_simple(b, 0, TYPE_I440FX_PCI_DEVICE); *pi440fx_state = I440FX_PCI_DEVICE(d); f = *pi440fx_state; diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index bd74094..4bb7e3f 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -30,6 +30,7 @@ #include "hw/hw.h" #include "hw/pci-host/q35.h" #include "qapi/visitor.h" +#include "hw/i386/amd_iommu.h" /**************************************************************************** * Q35 host @@ -470,6 +471,8 @@ static void mch_realize(PCIDevice *d, Error **errp) { int i; MCHPCIState *mch = MCH_PCI_DEVICE(d); + AMDIOMMUState *iommu_state; + PCIDevice *iommu; /* setup pci memory mapping */ pc_pci_as_mapping_init(OBJECT(mch), mch->system_memory, @@ -528,6 +531,14 @@ static void mch_realize(PCIDevice *d, Error **errp) if (machine_iommu(current_machine)) { mch_init_dmar(mch); } + + /* AMD IOMMU (AMD-Vi) */ + if (machine_amd_iommu(current_machine)){ + PCIBus *bus = PCI_BUS(qdev_get_parent_bus(DEVICE(mch))); + iommu = pci_create_simple(bus, 0x20, TYPE_AMD_IOMMU_DEVICE); + iommu_state = AMD_IOMMU_DEVICE(iommu); + pci_setup_iommu(bus, bridge_host_amd_iommu, iommu_state); + } } uint64_t mch_mcfg_base(void) -- 2.1.4 ^ permalink raw reply related [flat|nested] 22+ messages in thread
end of thread, other threads:[~2015-09-12 10:56 UTC | newest] Thread overview: 22+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-08-24 23:19 [Qemu-devel] [RFC 0/4] AMD IOMMU David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 1/4] hw/core: Prepare for introducing " David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 2/4] hw/i386: Introduce " David Kiarie 2015-08-25 6:39 ` Valentine Sinitsyn 2015-08-25 7:25 ` David kiarie 2015-08-25 7:31 ` Valentine Sinitsyn 2015-08-25 7:41 ` David kiarie 2015-08-25 7:43 ` Valentine Sinitsyn 2015-08-25 7:44 ` David kiarie 2015-09-07 12:46 ` Valentine Sinitsyn 2015-09-09 7:30 ` David kiarie 2015-09-09 7:45 ` Valentine Sinitsyn 2015-09-09 7:59 ` David kiarie 2015-09-09 8:07 ` Valentine Sinitsyn 2015-09-09 8:12 ` David kiarie 2015-09-09 8:14 ` Valentine Sinitsyn 2015-09-09 8:31 ` David kiarie 2015-09-09 7:59 ` Michael S. Tsirkin 2015-09-09 8:04 ` Valentine Sinitsyn 2015-09-12 10:55 ` Valentine Sinitsyn 2015-08-24 23:19 ` [Qemu-devel] [RFC 3/4] hw/i386: Introduce IVRS for " David Kiarie 2015-08-24 23:19 ` [Qemu-devel] [RFC 4/4] hw/pci-host: Add AMD IOMMU emulation to q35 and PIIX David Kiarie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).