From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 6/7] bt: remove muldiv64()
Date: Tue, 25 Aug 2015 22:44:50 +0200 [thread overview]
Message-ID: <1440535491-4511-7-git-send-email-lvivier@redhat.com> (raw)
In-Reply-To: <1440535491-4511-1-git-send-email-lvivier@redhat.com>
Originally, timers were ticks based, and it made sense to
add ticks to current time to know when to trigger an alarm.
But since commit:
7447545 change all other clock references to use nanosecond resolution accessors
All timers use nanoseconds and we need to convert ticks to nanoseconds.
As get_ticks_per_sec() is 10^9,
a = muldiv64(b, get_ticks_per_sec(), 100);
y = muldiv64(x, get_ticks_per_sec(), 1000000);
can be converted to
a = b * 10000000;
y = x * 1000;
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
hw/bt/hci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/bt/hci.c b/hw/bt/hci.c
index 7ea3dc6..585ee2e 100644
--- a/hw/bt/hci.c
+++ b/hw/bt/hci.c
@@ -595,7 +595,7 @@ static void bt_hci_inquiry_result(struct bt_hci_s *hci,
static void bt_hci_mod_timer_1280ms(QEMUTimer *timer, int period)
{
timer_mod(timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
- muldiv64(period << 7, get_ticks_per_sec(), 100));
+ (uint64_t)(period << 7) * 10000000);
}
static void bt_hci_inquiry_start(struct bt_hci_s *hci, int length)
@@ -1099,7 +1099,7 @@ static int bt_hci_mode_change(struct bt_hci_s *hci, uint16_t handle,
bt_hci_event_status(hci, HCI_SUCCESS);
timer_mod(link->acl_mode_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
- muldiv64(interval * 625, get_ticks_per_sec(), 1000000));
+ ((uint64_t)interval * 625) * 1000);
bt_hci_lmp_mode_change_master(hci, link->link, mode, interval);
return 0;
--
2.1.0
next prev parent reply other threads:[~2015-08-25 20:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 20:44 [Qemu-devel] [PATCH 0/7] remove useless muldiv64() Laurent Vivier
2015-08-25 20:44 ` [Qemu-devel] [PATCH 1/7] PCI: remove muldiv64() Laurent Vivier
2015-08-25 20:44 ` [Qemu-devel] [PATCH 2/7] mips: " Laurent Vivier
2015-08-25 20:44 ` [Qemu-devel] [PATCH 3/7] openrisc: " Laurent Vivier
2015-08-25 20:44 ` [Qemu-devel] [PATCH 4/7] arm: " Laurent Vivier
2015-08-25 21:11 ` Peter Crosthwaite
2015-08-25 21:36 ` Laurent Vivier
2015-08-25 20:44 ` [Qemu-devel] [PATCH 5/7] hpet: " Laurent Vivier
2015-08-25 20:44 ` Laurent Vivier [this message]
2015-08-25 20:44 ` [Qemu-devel] [PATCH 7/7] net: " Laurent Vivier
2015-08-25 22:51 ` [Qemu-devel] [PATCH 0/7] remove useless muldiv64() Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440535491-4511-7-git-send-email-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).