From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 02/12] qga: use exit() when parsing options
Date: Wed, 26 Aug 2015 00:10:14 +0200 [thread overview]
Message-ID: <1440540624-7998-3-git-send-email-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <1440540624-7998-1-git-send-email-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
The option parsing is going to be moved to a separate function,
use exit() consistently.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
qga/main.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 791982e..10bb2f7 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -992,14 +992,14 @@ int main(int argc, char **argv)
break;
case 'V':
printf("QEMU Guest Agent %s\n", QEMU_VERSION);
- return 0;
+ exit(EXIT_SUCCESS);
case 'd':
daemonize = 1;
break;
case 'b': {
if (is_help_option(optarg)) {
qmp_for_each_command(ga_print_cmd, NULL);
- return 0;
+ exit(EXIT_SUCCESS);
}
for (j = 0, i = 0, len = strlen(optarg); i < len; i++) {
if (optarg[i] == ',') {
@@ -1027,36 +1027,36 @@ int main(int argc, char **argv)
NULL :
state_dir;
if (ga_install_vss_provider()) {
- return EXIT_FAILURE;
+ exit(EXIT_FAILURE);
}
if (ga_install_service(path, log_filepath, fixed_state_dir)) {
- return EXIT_FAILURE;
+ exit(EXIT_FAILURE);
}
- return 0;
+ exit(EXIT_SUCCESS);
} else if (strcmp(service, "uninstall") == 0) {
ga_uninstall_vss_provider();
- return ga_uninstall_service();
+ exit(ga_uninstall_service());
} else if (strcmp(service, "vss-install") == 0) {
if (ga_install_vss_provider()) {
- return EXIT_FAILURE;
+ exit(EXIT_FAILURE);
}
- return EXIT_SUCCESS;
+ exit(EXIT_SUCCESS);
} else if (strcmp(service, "vss-uninstall") == 0) {
ga_uninstall_vss_provider();
- return EXIT_SUCCESS;
+ exit(EXIT_SUCCESS);
} else {
printf("Unknown service command.\n");
- return EXIT_FAILURE;
+ exit(EXIT_FAILURE);
}
break;
#endif
case 'h':
usage(argv[0]);
- return 0;
+ exit(EXIT_SUCCESS);
case '?':
g_print("Unknown option, try '%s --help' for more information.\n",
argv[0]);
- return EXIT_FAILURE;
+ exit(EXIT_FAILURE);
}
}
--
2.4.3
next prev parent reply other threads:[~2015-08-25 22:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 22:10 [Qemu-devel] [PATCH v2 00/12] qemu-ga: add a configuration file marcandre.lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 01/12] qga: misc spelling marcandre.lureau
2015-08-25 22:26 ` Michael Roth
2015-08-25 22:30 ` Eric Blake
2015-08-25 22:36 ` Marc-André Lureau
2015-08-25 22:10 ` marcandre.lureau [this message]
2015-08-25 22:27 ` [Qemu-devel] [PATCH v2 02/12] qga: use exit() when parsing options Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 03/12] qga: move string split in separate function marcandre.lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 04/12] qga: rename 'path' to 'channel_path' marcandre.lureau
2015-08-25 22:29 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 05/12] qga: copy argument strings marcandre.lureau
2015-08-25 22:31 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 06/12] qga: move option parsing to seperate function marcandre.lureau
2015-08-25 22:40 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 07/12] qga: fill default options in main() marcandre.lureau
2015-08-25 22:46 ` Michael Roth
2015-08-25 22:59 ` Marc-André Lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 08/12] qga: move agent run in a seperate function marcandre.lureau
2015-08-25 22:55 ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 09/12] qga: free a bit more marcandre.lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf system configuration marcandre.lureau
2015-08-25 23:09 ` Michael Roth
2015-08-25 23:18 ` Marc-André Lureau
2015-08-25 23:29 ` Michael Roth
2015-08-26 8:01 ` Markus Armbruster
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 11/12] qga: add --dump-conf option marcandre.lureau
2015-08-25 23:13 ` Michael Roth
2015-08-25 23:31 ` Marc-André Lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 12/12] qga: start a man page marcandre.lureau
2015-08-25 23:16 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440540624-7998-3-git-send-email-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).