qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 04/12] qga: rename 'path' to 'channel_path'
Date: Wed, 26 Aug 2015 00:10:16 +0200	[thread overview]
Message-ID: <1440540624-7998-5-git-send-email-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <1440540624-7998-1-git-send-email-marcandre.lureau@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

'path' is already a global function, rename the variable since it's
going to be in global scope in a later patch.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 qga/main.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/qga/main.c b/qga/main.c
index e75022c..ede5306 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -944,7 +944,7 @@ static GList *split_list(gchar *str, const gchar separator)
 int main(int argc, char **argv)
 {
     const char *sopt = "hVvdm:p:l:f:F::b:s:t:";
-    const char *method = NULL, *path = NULL;
+    const char *method = NULL, *channel_path = NULL;
     const char *log_filepath = NULL;
     const char *pid_filepath;
 #ifdef CONFIG_FSFREEZE
@@ -990,7 +990,7 @@ int main(int argc, char **argv)
             method = optarg;
             break;
         case 'p':
-            path = optarg;
+            channel_path = optarg;
             break;
         case 'l':
             log_filepath = optarg;
@@ -1040,7 +1040,8 @@ int main(int argc, char **argv)
                 if (ga_install_vss_provider()) {
                     exit(EXIT_FAILURE);
                 }
-                if (ga_install_service(path, log_filepath, fixed_state_dir)) {
+                if (ga_install_service(channel_path, log_filepath,
+                                       fixed_state_dir)) {
                     exit(EXIT_FAILURE);
                 }
                 exit(EXIT_SUCCESS);
@@ -1185,7 +1186,7 @@ int main(int argc, char **argv)
 #endif
 
     s->main_loop = g_main_loop_new(NULL, false);
-    if (!channel_init(ga_state, method, path)) {
+    if (!channel_init(ga_state, method, channel_path)) {
         g_critical("failed to initialize guest agent channel");
         goto out_bad;
     }
-- 
2.4.3

  parent reply	other threads:[~2015-08-25 22:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 22:10 [Qemu-devel] [PATCH v2 00/12] qemu-ga: add a configuration file marcandre.lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 01/12] qga: misc spelling marcandre.lureau
2015-08-25 22:26   ` Michael Roth
2015-08-25 22:30   ` Eric Blake
2015-08-25 22:36     ` Marc-André Lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 02/12] qga: use exit() when parsing options marcandre.lureau
2015-08-25 22:27   ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 03/12] qga: move string split in separate function marcandre.lureau
2015-08-25 22:10 ` marcandre.lureau [this message]
2015-08-25 22:29   ` [Qemu-devel] [PATCH v2 04/12] qga: rename 'path' to 'channel_path' Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 05/12] qga: copy argument strings marcandre.lureau
2015-08-25 22:31   ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 06/12] qga: move option parsing to seperate function marcandre.lureau
2015-08-25 22:40   ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 07/12] qga: fill default options in main() marcandre.lureau
2015-08-25 22:46   ` Michael Roth
2015-08-25 22:59     ` Marc-André Lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 08/12] qga: move agent run in a seperate function marcandre.lureau
2015-08-25 22:55   ` Michael Roth
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 09/12] qga: free a bit more marcandre.lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 10/12] qga: add an optionnal qemu-ga.conf system configuration marcandre.lureau
2015-08-25 23:09   ` Michael Roth
2015-08-25 23:18     ` Marc-André Lureau
2015-08-25 23:29       ` Michael Roth
2015-08-26  8:01   ` Markus Armbruster
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 11/12] qga: add --dump-conf option marcandre.lureau
2015-08-25 23:13   ` Michael Roth
2015-08-25 23:31     ` Marc-André Lureau
2015-08-25 22:10 ` [Qemu-devel] [PATCH v2 12/12] qga: start a man page marcandre.lureau
2015-08-25 23:16   ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440540624-7998-5-git-send-email-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).