From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Leon Alrae <leon.alrae@imgtec.com>, Jia Liu <proljc@gmail.com>,
Jason Wang <jasowang@redhat.com>,
crosthwaitepeter@gmail.com, qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0/7] remove useless muldiv64()
Date: Wed, 26 Aug 2015 20:05:31 +0200 [thread overview]
Message-ID: <1440612338-5912-1-git-send-email-lvivier@redhat.com> (raw)
Originally, timers were ticks based, and it made sense to
add ticks to current time to know when to trigger an alarm.
But since commit:
7447545 change all other clock references to use nanosecond resolution accessors
All timers use nanoseconds and we need to convert ticks to nanoseconds, by
doing something like:
y = muldiv64(x, get_ticks_per_sec(), TIMER_FREQ)
where x is the number of device ticks and y the number of system ticks.
y is used as nanoseconds in timer functions,
it works because 1 tick is 1 nanosecond.
(get_ticks_per_sec() is 10^9)
But if get_ticks_per_sec() / TIMER_FREQ is an integer, we can do:
y = x * TIMER_PERIOD;
v2:
4/4 For target-arm, don't remove muldiv64() but clarify
the use of the values.
7/7 Replace qemu_clock_get_ns()/1000 by qemu_clock_get_us()
Laurent Vivier (7):
PCI: remove muldiv64()
mips: remove muldiv64()
openrisc: remove muldiv64()
arm: clarify the use of muldiv64()
hpet: remove muldiv64()
bt: remove muldiv64()
net: remove muldiv64()
hw/bt/hci.c | 4 ++--
hw/mips/cputimer.c | 19 ++++++++-----------
hw/net/pcnet.c | 3 +--
hw/net/rtl8139.c | 14 ++++++--------
hw/openrisc/cputimer.c | 7 +++----
hw/timer/hpet.c | 6 +++---
hw/watchdog/wdt_i6300esb.c | 11 +++--------
include/hw/timer/hpet.h | 4 ++--
net/dump.c | 2 +-
target-arm/helper.c | 14 ++++++++------
tests/rtl8139-test.c | 2 +-
11 files changed, 38 insertions(+), 48 deletions(-)
--
2.1.0
next reply other threads:[~2015-08-26 18:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 18:05 Laurent Vivier [this message]
2015-08-26 18:05 ` [Qemu-devel] [PATCH v2 1/7] PCI: remove muldiv64() Laurent Vivier
2015-08-27 11:12 ` Michael S. Tsirkin
2015-08-26 18:05 ` [Qemu-devel] [PATCH v2 2/7] mips: " Laurent Vivier
2015-08-26 18:05 ` [Qemu-devel] [PATCH v2 3/7] openrisc: " Laurent Vivier
2015-08-26 18:05 ` [Qemu-devel] [PATCH v2 4/7] arm: clarify the use of muldiv64() Laurent Vivier
2015-08-26 18:05 ` [Qemu-devel] [PATCH v2 5/7] hpet: remove muldiv64() Laurent Vivier
2015-08-26 18:05 ` [Qemu-devel] [PATCH v2 6/7] bt: " Laurent Vivier
2015-08-26 18:05 ` [Qemu-devel] [PATCH v2 7/7] net: " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440612338-5912-1-git-send-email-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=aurelien@aurel32.net \
--cc=crosthwaitepeter@gmail.com \
--cc=jasowang@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).