From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: Peter Lieven <pl@kamp.de>, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 1/4] vnc: make the Buffer capacity increase in powers of two
Date: Thu, 27 Aug 2015 12:18:51 +0200 [thread overview]
Message-ID: <1440670734-5616-2-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1440670734-5616-1-git-send-email-pl@kamp.de>
This makes sure the number of reallocs is in O(log N).
Signed-off-by: Peter Lieven <pl@kamp.de>
---
ui/vnc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index caf82f5..8cfd2d8 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -653,10 +653,13 @@ void vnc_framebuffer_update(VncState *vs, int x, int y, int w, int h,
vnc_write_s32(vs, encoding);
}
+#define BUFFER_MIN_INIT_SIZE 4096
+
void buffer_reserve(Buffer *buffer, size_t len)
{
if ((buffer->capacity - buffer->offset) < len) {
- buffer->capacity += (len + 1024);
+ buffer->capacity = pow2ceil(buffer->capacity + len);
+ buffer->capacity = MAX(buffer->capacity, BUFFER_MIN_INIT_SIZE);
buffer->buffer = g_realloc(buffer->buffer, buffer->capacity);
}
}
--
1.9.1
next prev parent reply other threads:[~2015-08-27 10:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 10:18 [Qemu-devel] [PATCH 0/4] VNC server memory savings Peter Lieven
2015-08-27 10:18 ` Peter Lieven [this message]
2015-09-03 8:56 ` [Qemu-devel] [PATCH 1/4] vnc: make the Buffer capacity increase in powers of two Gerd Hoffmann
2015-09-03 10:29 ` Peter Lieven
2015-09-03 10:47 ` Gerd Hoffmann
2015-08-27 10:18 ` [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again Peter Lieven
2015-08-27 10:39 ` Daniel P. Berrange
2015-08-27 12:36 ` Peter Lieven
2015-09-03 9:52 ` Gerd Hoffmann
2015-09-03 10:07 ` Peter Lieven
2015-09-03 11:52 ` Gerd Hoffmann
2015-09-03 14:52 ` Peter Lieven
2015-09-03 10:36 ` Peter Lieven
2015-09-03 11:57 ` Gerd Hoffmann
2015-09-03 12:00 ` Peter Lieven
2015-08-27 10:18 ` [Qemu-devel] [PATCH 3/4] vnc-jobs: move buffer_reset to vnc_async_encoding_end Peter Lieven
2015-08-27 10:18 ` [Qemu-devel] [PATCH 4/4] vnc: destroy server surface if no client is connected Peter Lieven
2015-09-03 9:57 ` Gerd Hoffmann
2015-09-03 10:08 ` Peter Lieven
2015-09-03 10:54 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440670734-5616-2-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).