From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVMn7-00089G-11 for qemu-devel@nongnu.org; Fri, 28 Aug 2015 12:46:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVMn5-0000IS-If for qemu-devel@nongnu.org; Fri, 28 Aug 2015 12:46:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVMn5-0000IA-ES for qemu-devel@nongnu.org; Fri, 28 Aug 2015 12:46:11 -0400 From: Markus Armbruster Date: Fri, 28 Aug 2015 18:45:50 +0200 Message-Id: <1440780366-7177-11-git-send-email-armbru@redhat.com> In-Reply-To: <1440780366-7177-1-git-send-email-armbru@redhat.com> References: <1440780366-7177-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 10/26] qapi-visit: Replace list implicit_structs by set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com Use set because that's what it is. While there, rename to implicit_structs_seen. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-visit.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index b3a308f..9fc040e 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -16,14 +16,13 @@ from ordereddict import OrderedDict from qapi import * import re -implicit_structs = [] +implicit_structs_seen = set() struct_fields_seen = set() def generate_visit_implicit_struct(type): - global implicit_structs - if type in implicit_structs: + if type in implicit_structs_seen: return '' - implicit_structs.append(type) + implicit_structs_seen.add(type) ret = '' if type not in struct_fields_seen: # Need a forward declaration -- 2.4.3